[Bug 1507681] Re: killall with 65 arguments kills more than expected
This bug was fixed in the package psmisc - 22.15-2ubuntu1.2 --- psmisc (22.15-2ubuntu1.2) precise; urgency=low * Backport of upstream fix: - Fix killall with 65 arguments (LP: #1507681) -- Christian Ehrhardt Tue, 07 Jun 2016 11:36:17 -0700 ** Changed in: psmisc (Ubuntu Precise) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
Unfortunately no 3rd party verification yet - adding one of my own. Since I wasn't sure about the reproducibility I went a bit parallel: Using the test (very slightly) modified in 4 precise containers I got a reliable trigger: 2/4 directly 2/4 after one retry mkdir -p ~/tmp_tasks; ps xa | wc -l; for i in `seq 1 65`; do touch ~/tmp_tasks/test$i; done; for i in `seq 1 65`; do echo ~/tmp_tasks/test$i; done | xargs killall; ps xa | wc -l Upgrading to proposed got them all reliable to report: "Maximum number of names is 64" I played a bit with ps and couldn't find any other regressions that would be obvious. That said - setting verified. ** Tags removed: verification-needed ** Tags added: verification-done-precise -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
** Changed in: psmisc (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
Hello Gregory, or anyone else affected, Accepted psmisc into precise-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/psmisc/22.15-2ubuntu1.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: psmisc (Ubuntu Precise) Status: In Progress => Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
** Description changed: - killall in Precise is supposed to limit the number of arguments to 64, - but due to a fencepost error, 66 arguments will be blocked but 65 is - not. + [Impact] + + * killall with exactly 65 (33 in 32-bit environments) arguments can kill random processes + * this can be accidentially or even maliciously used to kill processes + * root casue is an off-by-one error + + [Test Case] + + * as seen in the bug description above, but please note that this triggers the bug only sometimes (1/3 of my tries) +ps xa | wc -l +for i in `seq 1 65`; do touch ~/tmp_tasks/test$i; done; +for i in `seq 1 65`; do echo ~/tmp_tasks/test$i; done | xargs killall +ps xa | wc -l + + [Regression Potential] + + * there should be no/minimal regression Potential +- the fix itself is minimal +- no solution (other than maybe exploits) should rely on this behaviour + + + [Original Report] + killall in Precise is supposed to limit the number of arguments to 64, but due to a fencepost error, 66 arguments will be blocked but 65 is not. With 65 arguments, the behavior varies, but in some cases will send a signal to random processes. # ps xa | wc -l 164 # mkdir ~/tmp_tasks/ # for i in `seq 1 65`; do touch ~/tmp_tasks/test$i; done; # for i in `seq 1 65`; do echo ~/tmp_tasks/test$i; done | xargs killall Connection to 198.18.88.176 closed by remote host. Connection to 198.18.88.176 closed. # ps xa | wc -l 126 This is fixed upstream and at the very least trusty works fine. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
I've uploaded this to the queue for review by the SRU team. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
SRU-Template: [Impact] * killall with exactly 65 (33 in 32-bit environments) arguments can kill random processes * this can be accidentially or even maliciously used to kill processes * root casue is an off-by-one error [Test Case] * as seen in the bug description above, but please note that this triggers the bug only sometimes (1/3 of my tries) ps xa | wc -l for i in `seq 1 65`; do touch ~/tmp_tasks/test$i; done; for i in `seq 1 65`; do echo ~/tmp_tasks/test$i; done | xargs killall ps xa | wc -l [Regression Potential] * there should be no/minimal regression Potential - the fix itself is minimal - no solution (other than maybe exploits) should rely on this behaviour ** Changed in: psmisc (Ubuntu Precise) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
** Patch added: "debdiff for SRU to fix this issue (based on upstream backport)" https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+attachment/4672918/+files/psmisc_22.15-2ubuntu1.2-precise-bug-1507681.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
** Changed in: psmisc (Ubuntu Precise) Assignee: (unassigned) => ChristianEhrhardt (paelzer) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
** Also affects: psmisc (Ubuntu Precise) Importance: Undecided Status: New ** Changed in: psmisc (Ubuntu Precise) Status: New => Triaged ** Changed in: psmisc (Ubuntu Precise) Importance: Undecided => Medium ** Changed in: psmisc (Ubuntu) Status: New => Fix Released ** Tags added: bitesize -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
The attachment "killall-with-65-arguments-kills-all-proce.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1507681] Re: killall with 65 arguments kills more than expected
attached is a proposed fix ** Patch added: "killall-with-65-arguments-kills-all-proce.patch" https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+attachment/4500472/+files/killall-with-65-arguments-kills-all-proce.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1507681 Title: killall with 65 arguments kills more than expected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1507681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
