[Bug 1508075] Re: ubiquity and others time out on polkit (killed by udisks2-inhibit)

2015-10-29 Thread Launchpad Bug Tracker
This bug was fixed in the package udisks2 - 2.1.6-2+git1

---
udisks2 (2.1.6-2+git1) xenial; urgency=medium

  * udisks2-inhibit: Stop fiddling with polkit rules; restarting it can break
existing clients/pending requests, and we can't use inotify as we don't
want to write anything on the actual file system and bind mounts don't
trigger inotify. Use a different approach of a temporary udev rule which
sets UDISKS_IGNORE on all block devices. This continues to avoid touching
the file system but does not need any daemon restarts, works with polkit
>= 106, and now also suppresses showing new block devices on the desktop.
(LP: #1508075)

 -- Martin Pitt   Thu, 29 Oct 2015 12:04:08
+0100

** Changed in: udisks2 (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1508075

Title:
  ubiquity and others time out on polkit (killed by udisks2-inhibit)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1508075] Re: ubiquity and others time out on polkit (killed by udisks2-inhibit)

2015-10-21 Thread Launchpad Bug Tracker
This bug was fixed in the package udisks2 - 2.1.6-2ubuntu1

---
udisks2 (2.1.6-2ubuntu1) wily; urgency=medium

  * udisks2-inhibit: Restart polkitd instead of just killing it, so that
existing connected clients continue having something to talk to instead of
timing out. Keep old pkill as a fallback for non-systemd.
(LP: #1508075)

 -- Martin Pitt   Wed, 21 Oct 2015 13:41:35
+0200

** Changed in: udisks2 (Ubuntu Wily)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1508075

Title:
  ubiquity and others time out on polkit (killed by udisks2-inhibit)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1508075] Re: ubiquity and others time out on polkit (killed by udisks2-inhibit)

2015-10-21 Thread Martin Pitt
For Debian and X-series I have committed http://anonscm.debian.org/cgit
/pkg-utopia/udisks2.git/commit/?id=b68ac3766c now, which implements the
udev rules approach.

** Changed in: udisks2 (Ubuntu X-series)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1508075

Title:
  ubiquity and others time out on polkit (killed by udisks2-inhibit)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1508075] Re: ubiquity and others time out on polkit (killed by udisks2-inhibit)

2015-10-21 Thread Martin Pitt
Neither of the above solutions are perfect, thus for x and beyond (and
for Debian), I'd actually like to change it like this: udisks2-inhibit
should create a temporary udev rule in /run/udev/rules.d/ with

  SUBSYSTEM=="block", ENV{UDISKS_IGNORE}="1" on all block devices.

and then "udevadm trigger -subsystem-match=block" to apply it to
existing devices.

Note that UDISKS_AUTO="0" won't suffice: We don't only want to avoid
auto-mounting external USB  storage (as we might install onto that), but
also avoid accidental manual mounts by clicking on newly appearing drive
icons.


** Also affects: udisks2 (Ubuntu X-series)
   Importance: Undecided
   Status: New

** Also affects: udisks2 (Ubuntu Wily)
   Importance: Critical
 Assignee: Martin Pitt (pitti)
   Status: In Progress

** Changed in: udisks2 (Ubuntu X-series)
   Status: New => In Progress

** Changed in: udisks2 (Ubuntu X-series)
   Importance: Undecided => Medium

** Changed in: udisks2 (Ubuntu X-series)
 Assignee: (unassigned) => Martin Pitt (pitti)

** Changed in: udisks2 (Ubuntu Wily)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1508075

Title:
  ubiquity and others time out on polkit (killed by udisks2-inhibit)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1508075] Re: ubiquity and others time out on polkit (killed by udisks2-inhibit)

2015-10-21 Thread Martin Pitt
This is a tested replacement for udisks2-inhibit which avoids
killing/restarting the daemon. It instead uses polkit's inotify by
merely placing a symlink into
/var/lib/polkit-1/localauthority/90-mandatory.d/ . Since we are only
adding a new file (or rm it on cleanup), overlayfs' restricted inotify
support actually seems good enough.

You can test quickly with

  pkcheck -a org.freedesktop.udisks2.filesystem-mount -p $$; echo $?

This should give 0 ("allowed") normally, and 1 and "Not authorized."
while you are running "sudo ./udisks2-inhibit sleep 5" or something
such.

** Attachment added: "fixed udisks2-inhibit (using inotify)"
   
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+attachment/4501723/+files/udisks2-inhibit

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1508075

Title:
  ubiquity and others time out on polkit (killed by udisks2-inhibit)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1508075] Re: ubiquity and others time out on polkit (killed by udisks2-inhibit)

2015-10-21 Thread Martin Pitt
Note that the above is less robust than the original one as it now could
happen to leave a dangling symlink behind if udisks2-inhibit is killed
while its running with a signal that doesn't run the cleanup trap.
However, this doesn't change actual policy, and as we only really use
that during the live system (where such leftover files don't matter at
all), it'd be acceptable.

The bind mount to /run didn't have this problem, but it doesn't trigger
inotify and thus requires a restart (which is problematic).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1508075

Title:
  ubiquity and others time out on polkit (killed by udisks2-inhibit)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1508075] Re: ubiquity and others time out on polkit (killed by udisks2-inhibit)

2015-10-21 Thread Martin Pitt
As indicated above, this is a variant which keeps the robust bind
mounting, but restarts polkit instead of just killing it. This should
deal much more gracefully with existing connected clients.

** Attachment added: "fixed udisks2-inhibit (using restart)"
   
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+attachment/4501725/+files/udisks2-inhibit

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1508075

Title:
  ubiquity and others time out on polkit (killed by udisks2-inhibit)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1508075] Re: ubiquity and others time out on polkit (killed by udisks2-inhibit)

2015-10-21 Thread Martin Pitt
** Changed in: udisks2 (Ubuntu)
   Status: Incomplete => In Progress

** Changed in: udisks2 (Ubuntu)
 Assignee: (unassigned) => Martin Pitt (pitti)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1508075

Title:
  ubiquity and others time out on polkit (killed by udisks2-inhibit)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1508075/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs