[Bug 1541902] Re: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
** Tags removed: targetmilestone-inin16041 ** Tags added: targetmilestone-inin1610 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
This bug was fixed in the package qemu - 1:2.6.1+dfsg-0ubuntu2 --- qemu (1:2.6.1+dfsg-0ubuntu2) yakkety; urgency=medium * Enable GPU Passthru for ppc64le (LP: #1541902) - 0001-spapr-ensure-device-trees-are-always-associated-with.patch - 0002-spapr_pci-Use-correct-DMA-LIOBN-when-composing-the-d.patch - 0003-spapr_iommu-Finish-renaming-vfio_accel-to-need_vfio.patch - 0004-spapr_iommu-Move-table-allocation-to-helpers.patch - 0005-vmstate-Define-VARRAY-with-VMS_ALLOC.patch - 0006-spapr_iommu-Introduce-enabled-state-for-TCE-table.patch - 0007-spapr_iommu-Migrate-full-state.patch - 0008-spapr_iommu-Add-root-memory-region.patch - 0009-spapr_pci-Reset-DMA-config-on-PHB-reset.patch - 0010-spapr_pci-Add-and-export-DMA-resetting-helper.patch - 0011-memory-Add-reporting-of-supported-page-sizes.patch - 0012-memory-Add-MemoryRegionIOMMUOps.notify_started-stopp.patch - 0013-intel_iommu-Throw-hw_error-on-notify_started.patch - 0014-spapr_iommu-Realloc-guest-visible-TCE-table-when-sta.patch - 0015-vfio-spapr-Add-DMA-memory-preregistering-SPAPR-IOMMU.patch - 0016-vfio-Add-host-side-DMA-window-capabilities.patch - 0017-vfio-spapr-Create-DMA-window-dynamically-SPAPR-IOMMU.patch - 0018-spapr_pci-spapr_pci_vfio-Support-Dynamic-DMA-Windows.patch - 0019-vfio-spapr-Remove-stale-ioctl-call.patch - 0020-spapr-Fix-undefined-behaviour-in-spapr_tce_reset.patch - 0021-memory-Fix-IOMMU-replay-base-address.patch -- Jon GrimmFri, 16 Sep 2016 14:14:47 -0500 ** Changed in: qemu (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Rebased on new 2.6.1. ** Patch added: "qemu_2.6.1+dfsg-0ubuntu2.debdiff" https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+attachment/4742202/+files/qemu_2.6.1+dfsg-0ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
On Hold. 2.6.1 seems to be having issues landing. Removed sponsors and will likely have to rebase again. ** Patch removed: "qemu_2.6.1+dfsg-0ubuntu2.debdiff" https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+attachment/4742034/+files/qemu_2.6.1+dfsg-0ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Rebase on 2.6.1. Re-ran qa-regression-testing libvirt/qemu. ** Patch added: "qemu_2.6.1+dfsg-0ubuntu2.debdiff" https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+attachment/4742034/+files/qemu_2.6.1+dfsg-0ubuntu2.debdiff ** Changed in: qemu (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
PPA rebased on 2.6.1. I'm running qa-regression-testing libvirt/qemu tests on it now. Will upload debdiff for sponsorship once testing complete. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Reviewing the diff, the changes are all well-isolated to hw/ppc + target-ppc, with the following exceptions: - trace-events - a few additions to generic headers - 98295803b5a7929232fd92ecf17137c991273678, fc8865d5c3e733c7b03070017778b31de22c329f, 94582d197efb7030f5d0dccab6165c28fb62d5b5 and 561e77f740999600449223c912126a575c7ec3ce, which make changes to hw/vfio/common.c and memory.c which appear to be reasonably self-contained changes - b6dc0429cb690572984e34aa6bfe557beed82282, which makes intel iommu handling more strict; this doesn't appear to be an actual prerequisite for the rest of the ppc64el patches, but it also appears to be harmless in the sense that it will cause earlier failure in the case of driver errors - changes to hw/vfio/common.c in 330619403e536e0e31671ae5bcd9f9921e73d9c9 which are spapr-specific (and therefore ppc-specific in practice) This looks like a reasonably safe change, given the testing that's been done in the ppa. As part of this FFe, these patches should be re-tested on top of 2.6.1 (LP: #1617055). ** Changed in: qemu (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Thank you. Awaiting FFe approval now. But looks like I may need to reapply on top of pending 2.6.1 that has an FFe in progress atm. ** Summary changed: - Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM + [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFe] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
No that seems to be the entirely wrong patchset. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Happy to. I'll take the patchset from May 11, Subject: [Qemu-devel] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR Please shout if that is not the best one to use. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Serge, we may want to pull them in and put in a PPA to see if IBM and others can give the patchset a try. And ideally they'd report to qemu-devel of their success/problems. On Fri, May 13, 2016 at 8:17 AM, Serge Hallyn <1541...@bugs.launchpad.net> wrote: > Thanks, Ryan. We'll hold off until the next round. > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1541902 > > Title: > [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu > KVM > > To manage notifications about this bug go to: > https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions > -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Thanks, Ryan. We'll hold off until the next round. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
** Tags removed: bot-comment bugnameltc-136627 severity-high -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
I'd say we should hold off: http://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg03092.html Includes this bit: >> Why 64-bit math here, but 128 bit math in the region_add path? > > Hm. Good question. It has been copied from the common VFIO code where it was since 7532d3cbf1, back those days I did not even think of VFIO devices hot(un)plugging so > region_del() was never executed so this seems to be a bug there and here. Yet another patch is coming then There are other things that aren't nearly as troublesome but it certainly feels like another round of patches are forthcoming. I didn't get a feeling from the patchset that this was functional, no Tested-by: or Acked-by: either. On Thu, May 12, 2016 at 1:11 PM, Serge Hallyn <1541...@bugs.launchpad.net> wrote: > (Make that @raharper ^ ) > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1541902 > > Title: > [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu > KVM > > To manage notifications about this bug go to: > https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions > -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Seems like the upstream discussion is still unresolved in some areas (and no patches are upstream in the git tree) and I don't understand why. I'm happy to pull these patches in now. Just as a sanity check, @rharper - any definite badness that you see? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
(Make that @raharper ^ ) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
** Changed in: qemu (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
Dear Canonical, A new patchset (version 15) was sent upstream, and already reviewed by David Gibson. http://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg00360.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
** Tags removed: targetmilestone-inin1604 ** Tags added: targetmilestone-inin16041 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to qemu in Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
** Tags removed: targetmilestone-inin1604 ** Tags added: targetmilestone-inin16041 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
I would like to justify this FFe as this is an important feature for Ubuntu 16.04/ppc64el [Technical Justification] This feature enables GPU pass through to work decently on Ubuntu KVM. Without this feature, GPU pass through works with a very bad performance, which is completely unusable in production. This feature enables a huge performance improvement, allowing Ubuntu KVM deployment in production environments. [ Customer justification] There are numerous partners interested in this feature, and a real set of customers that will be taking benefit directly if this feature makes Ubuntu 16.04 release. [Testing plan] This set of patch is being tested internally at IBM. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to qemu in Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1541902] Re: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM
I would like to justify this FFe as this is an important feature for Ubuntu 16.04/ppc64el [Technical Justification] This feature enables GPU pass through to work decently on Ubuntu KVM. Without this feature, GPU pass through works with a very bad performance, which is completely unusable in production. This feature enables a huge performance improvement, allowing Ubuntu KVM deployment in production environments. [ Customer justification] There are numerous partners interested in this feature, and a real set of customers that will be taking benefit directly if this feature makes Ubuntu 16.04 release. [Testing plan] This set of patch is being tested internally at IBM. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1541902 Title: [FFE] Enable DDW on qemu aiming GPU passthrough performance on Ubuntu KVM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1541902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs