[Bug 1582515] Re: strip phase name is not great

[Launchpad Bug Tracker]

This bug was fixed in the package snapcraft - 2.10.1

---
snapcraft (2.10.1) xenial; urgency=medium

  * Backwards compatible clean with strip (#556) (LP: #1590256)

 -- Sergio Schvezov   Wed, 08 Jun 2016 16:32:27
-0300

** Changed in: snapcraft (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Sergio Schvezov]

** Tags removed: verification-failed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Sergio Schvezov]

** Tags removed: verification-done
** Tags added: verification-failed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Leo Arias]

IMO, it's important but not critical. It was a mistake, not that we are
renaming a feature without deprecation. We'll get it fixed with a
regression test next week, and the impact I think is not enough to delay
the release.

We'll make more mistakes. The cool thing is that our dev. process
minimizes them and our short release cycle lets us find them quickly and
make a decision about when to fix them.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Kyle Fazzari]

> Got an error message because the step is not valid.

Good testing Leo! That's kind of a big deal-- the CLI is breaking
without a major version jump. What's the point of introducing
deprecation after you make a release where it's removed all together?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Leo Arias]

Tested in an up-to-date xenial system:
- Enabled the proposed archive
- Updated snapcraft to 2.10
- Made a snapcraft dir.
- snapcraft strip
- The step is executed and a deprecated message is printed.
- snapcraft clean
- snapcraft prime
- The step is executed and no deprecated message is printed.
- snapcraft strip
- The step is not executed again.
- snapcraft prime
- The step is not executed again.
- snapcraft clean -s prime
- The step is cleaned.
- snapcraft clean -s strip.
- Got an error message because the step is not valid. This is a bug, because 
the deprecation message should be printed here too. Reported in 
https://bugs.launchpad.net/snapcraft/+bug/1590256

We can fix this in the next release, so I'm marking the verification as
done.

Thanks Chris!


** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Sergio Schvezov]

** Changed in: snapcraft
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Chris J Arges]

Hello Gustavo, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/snapcraft/2.10 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: snapcraft (Ubuntu Xenial)
   Status: New => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Launchpad Bug Tracker]

This bug was fixed in the package snapcraft - 2.10+16.10

---
snapcraft (2.10+16.10) yakkety; urgency=medium

  [ Martin Wimpress ]
  * Correct autotools tests to use configflags (#521)

  [ Leo Arias ]
  * Run the integration tests against a local fake server when the user
password is not in the environment. (#511) (LP: #1585023)
  * Move the login and logout methods to a client. (#518) (LP: #1586504)
  * Improve the config handling. (#519) (LP: #1586511)
  * Fix the one-time password login. (#529) (LP: #1586832)
  * Moved the download to the store client. (#530) (LP: #1586836)
  * Moved the upload to the store client. (#531) (LP: #1586836)
  * Updated the documentation about the icon. (#542) (LP: #1578231)
  * Improve the error message when a part binary is not found. (#541)
(LP: #1582367)
  * Reenable the ROS demo for autopackage testing. (#520) (LP: #1588098)
  * Add macaroon support to login, upload and download. (#532) (LP: #1586910)
  * Set the no_proxy environment variable to access the local fake servers.
(#546) (LP: #1588631)

  [ Stephen Stewart ]
  * nodejs plugin: Support configurable node version (#509) (LP: #1586104)

  [ Kyle Fazzari ]
  * Use correct cross-build packages for ppc64le. (#539) (LP: #1570944)

  [ Sergio Schvezov ]
  * Support zip files as source (#523) (LP: #1577062)
  * A nicer error message for incorrect stage-packages (#524) (LP: #1568131)
  * Support the assumes keyword (#525) (LP: #1586429)
  * Improve the template for snapcraft init (#528) (LP: #1575581)
  * Filter out *.snap from sourcedir (#535) (LP: #1575628)
  * Support setting a gopath for a go project from vcs (#538) (LP: #1583426)
  * Add a ticker for snapping (#540) (LP: #1582955)
  * Rename strip to prime (#543) (LP: #1582515)

  [ Didier Roche ]
  * Wrap plugin list output content (#534) (LP: #1587057)
  * Add snapcraft examples to scaffold getting started tour (#513)
(LP: #1586137)

  [ Joe Talbott ]
  * Add support for parsing the parts wiki (#545) (LP: #1587583)

 -- Sergio Schvezov   Fri, 03 Jun 2016
13:37:58 -0300

** Changed in: snapcraft (Ubuntu Yakkety)
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Sergio Schvezov]

** Also affects: snapcraft (Ubuntu Yakkety)
   Importance: Undecided
   Status: New

** Also affects: snapcraft (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Changed in: snapcraft (Ubuntu Xenial)
Milestone: None => xenial-updates

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Sergio Schvezov]

** Changed in: snapcraft
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Leo Arias]

** Description changed:

  The "strip" phase name is not great. It's not actually stripping.. it's
  the phase that copies the content into the snap directory, as I
  understand it. So it's the opposite of stripping (although I understand
  where the motivation comes from). See how this command makes little
  sense, for example:
  
- snapcraft clean --step=strip
+ snapcraft clean --step=strip
  
  So it might be better named as something like "cast", or "shape", or
  "form". I'd check with Mark for the best word here.
+ 
+ [Impact]
+ 
+  * One of the snapcraft commands is confusing.
+ 
+  * The change is backwards compatible, so anything that's relying on
+ strip will still work.
+ 
+ [Test Case]
+ 
+  * Run snapcraft strip
+  * Check that you get a deprecation message.
+  * Clean
+  * Run snapcraft prime
+  * Check that the results are the same, without deprecation message.
+ 
+ [Regression Potential]
+ 
+  * This could affect the strip command.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582515] Re: strip phase name is not great

[Leo Arias]

** Also affects: snapcraft (Ubuntu)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582515

Title:
  strip phase name is not great

To manage notifications about this bug go to:
https://bugs.launchpad.net/snapcraft/+bug/1582515/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs