[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
This bug was fixed in the package qemu - 1:2.5+dfsg-5ubuntu10.31 --- qemu (1:2.5+dfsg-5ubuntu10.31) xenial; urgency=medium * d/p/ubuntu/lp-1587065-qga-ignore-EBUSY-when-freezing-a-filesystem.patch: Fix qemu-guest-agent failing to freeze filesystems that were mounted multiple times like bind mounts. (LP: #1587065). -- Christian Ehrhardt Thu, 28 Jun 2018 11:35:05 +0200 ** Changed in: qemu (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
Prior to the update: $ virsh domfsfreeze x-freeze; virsh domfsthaw x-freeze error: Unable to freeze filesystems error: internal error: unable to execute QEMU agent command 'guest-fsfreeze-freeze': failed to freeze /: Device or resource busy Thawed 0 filesystem(s) $ sudo apt install qemu-guest-agent Reading package lists... Done Building dependency tree Reading state information... Done The following packages will be upgraded: qemu-guest-agent 1 upgraded, 0 newly installed, 0 to remove and 27 not upgraded. Need to get 132 kB of archives. After this operation, 0 B of additional disk space will be used. Get:1 http://archive.ubuntu.com/ubuntu xenial-proposed/universe amd64 qemu-guest-agent amd64 1:2.5+dfsg-5ubuntu10.31 [132 kB] Fetched 132 kB in 0s (1.161 kB/s) (Reading database ... 54125 files and directories currently installed.) Preparing to unpack .../qemu-guest-agent_1%3a2.5+dfsg-5ubuntu10.31_amd64.deb ... Unpacking qemu-guest-agent (1:2.5+dfsg-5ubuntu10.31) over (1:2.5+dfsg-5ubuntu10.30) ... Processing triggers for man-db (2.7.5-1) ... Processing triggers for systemd (229-4ubuntu21.2) ... Processing triggers for ureadahead (0.100.0-19) ... Setting up qemu-guest-agent (1:2.5+dfsg-5ubuntu10.31) ... Retesting the above: $ virsh domfsfreeze x-freeze; virsh domfsthaw x-freeze Froze 1 filesystem(s) Thawed 1 filesystem(s) Found no other hickups due to the update, setting verified. ** Tags removed: verification-needed verification-needed-xenial ** Tags added: verification-done verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
Hello Dominique, or anyone else affected, Accepted qemu into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:2.5+dfsg- 5ubuntu10.31 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: qemu (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
Tests are all ok, MP review was acked and case confirmed. No Security Update since then in between, so sponsoring into SRU queue now ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
** Description changed:
[Impact]
- * backport upstream fix to avoid double unmounts (e.g. bind mounts)
-hanging the freeze action.
+ * backport upstream fix to avoid double unmounts (e.g. bind mounts)
+ hanging the freeze action.
[Test Case]
* Prepare a guest
$ uvt-simplestreams-libvirt --verbose sync --source
http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily
uvt-kvm create --password ubuntu x-freeze arch=amd64 release=xenial
label=daily
* Shut it down and use virsh edit to add a channel for the agent. Add this
somewhere under :
* Start the guest again, in it install qemu-guest-agent
*
* On the Host then freeze and thaw the guest
$ virsh domfsfreeze x-freeze
$ virsh domfsthaw x-freeze
# The above works, then trigger the issue, in the guest do
$ sudo mkdir /mnt/test
$ sudo mount -o bind / /mnt/test/
- * Now the freeze/thaw will fail unless the fix is applied.
+ * Now the freeze/thaw will fail unless the fix is applied to the
+ guest.
[Regression Potential]
* From looking at the code alone I could think of a different cause that
makes it return EBUSY.
The biggest risk I could see due to that is the agent reporting a
successful freeze due to accepting EBUSY which is not actually true.
But we have that in Ubuntu since Artful and
upstream since January 2017 and there are no such reports.
[Other Info]
* n/a
---
Having two mounts of the same device makes fsfreeze through qemu-ga
impossible.
root@CmsrvMTA:/# mount -l | grep /dev/vda2
/dev/vda2 on / type btrfs (rw,relatime,space_cache,subvolid=257,subvol=/@)
/dev/vda2 on /home type btrfs
(rw,relatime,space_cache,subvolid=258,subvol=/@home)
Having two mounts is rather common with btrfs, so the feature fsfreeze
is unusable on these systems.
Below more information about how we encountered this issue...
Message send to qemu-disc...@nongnu.org:
Message 1:
--
I use external snapshots to backup my guests. I use the 'quiesce' option to
flush and frees the guest file system with the qemu guest agent.
With the exeption of one guest, this procedure works fine. On the 'unwilling'
guest, I get this error message:
"ERROR 2016-05-25 00:51:19 | T25-bakVMSCmsrvVH2 | fout: internal error:
unable to execute QEMU agent command 'guest-fsfreeze-freeze': failed to freeze
/: Device or resource busy"
I don't think this is not some sort of time-out error, because
activation of the fsfreeze and the error message happen immediately
after each other:
$ grep qemu-ga syslog.1
May 25 00:51:19 CmsrvMTA qemu-ga: info: guest-fsfreeze called
This is the only entry of the qemu guest agent in syslog.
$ sudo virsh version
Compiled against library: libvirt 1.3.1
Using library: libvirt 1.3.1
Gebruikte API: QEMU 1.3.1
Draaiende hypervisor: QEMU 2.5.0
$ virsh qemu-agent-command CmsrvMTA '{"execute": "guest-info"}'
{"return":{"version":"2.5.0", ...
,{"enabled":true,"name":"guest-fstrim","success-response":true},{"enabled":true,"name":"guest-fsfreeze-thaw","success-response":true},{"enabled":true,"name":"guest-fsfreeze-status","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze-list","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze","success-response":true},
... }
For making an external snapshot, I use this command:
$ virsh snapshot-create-as --domain CmsrvMTA sn1 --disk-only --atomic
--quiesce --no-metadata --diskspec vda,file=/srv/poolVMS/CmsrvMTA.sn1
Piece of reply 1:
-
I have encountered this before. Some operating systems
may have bind-mounts that let a device appear multiple times in the mount
list. Unfortunately the guest agent is not smart enough to consider a device
that has been frozen as succesfull and keep going. This causes this specific
error.
Piece of reply 2:
-
Ok, that seems to be it.
I’ve got the ‘/’ and ‘/home’ on the same device formatted as btrfs on
two separate sub volumes.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1587065
Title:
btrfs qemu-ga - multiple mounts block fsfreeze
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
** Description changed:
[Impact]
- * backport upstream fix to avoid double unmounts (e.g. bind mounts)
-hanging the freeze action.
+ * backport upstream fix to avoid double unmounts (e.g. bind mounts)
+ hanging the freeze action.
[Test Case]
* Prepare a guest
$ uvt-simplestreams-libvirt --verbose sync --source
http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily
uvt-kvm create --password ubuntu x-freeze arch=amd64 release=xenial
label=daily
* Shut it down and use virsh edit to add a channel for the agent. Add this
somewhere under :
* Start the guest again, in it install qemu-guest-agent
*
* On the Host then freeze and thaw the guest
$ virsh domfsfreeze x-freeze
$ virsh domfsthaw x-freeze
# The above works, then trigger the issue, in the guest do
$ sudo mkdir /mnt/test
$ sudo mount -o bind / /mnt/test/
- * Now the freeze/thaw will fail unless the fix is applied.
+ * Now the freeze/thaw will fail unless the fix is applied to the
+ guest.
[Regression Potential]
* From looking at the code alone I could think of a different cause that
makes it return EBUSY.
The biggest risk I could see due to that is the agent reporting a
successful freeze due to accepting EBUSY which is not actually true.
But we have that in Ubuntu since Artful and
upstream since January 2017 and there are no such reports.
[Other Info]
* n/a
---
Having two mounts of the same device makes fsfreeze through qemu-ga
impossible.
root@CmsrvMTA:/# mount -l | grep /dev/vda2
/dev/vda2 on / type btrfs (rw,relatime,space_cache,subvolid=257,subvol=/@)
/dev/vda2 on /home type btrfs
(rw,relatime,space_cache,subvolid=258,subvol=/@home)
Having two mounts is rather common with btrfs, so the feature fsfreeze
is unusable on these systems.
Below more information about how we encountered this issue...
Message send to qemu-disc...@nongnu.org:
Message 1:
--
I use external snapshots to backup my guests. I use the 'quiesce' option to
flush and frees the guest file system with the qemu guest agent.
With the exeption of one guest, this procedure works fine. On the 'unwilling'
guest, I get this error message:
"ERROR 2016-05-25 00:51:19 | T25-bakVMSCmsrvVH2 | fout: internal error:
unable to execute QEMU agent command 'guest-fsfreeze-freeze': failed to freeze
/: Device or resource busy"
I don't think this is not some sort of time-out error, because
activation of the fsfreeze and the error message happen immediately
after each other:
$ grep qemu-ga syslog.1
May 25 00:51:19 CmsrvMTA qemu-ga: info: guest-fsfreeze called
This is the only entry of the qemu guest agent in syslog.
$ sudo virsh version
Compiled against library: libvirt 1.3.1
Using library: libvirt 1.3.1
Gebruikte API: QEMU 1.3.1
Draaiende hypervisor: QEMU 2.5.0
$ virsh qemu-agent-command CmsrvMTA '{"execute": "guest-info"}'
{"return":{"version":"2.5.0", ...
,{"enabled":true,"name":"guest-fstrim","success-response":true},{"enabled":true,"name":"guest-fsfreeze-thaw","success-response":true},{"enabled":true,"name":"guest-fsfreeze-status","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze-list","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze","success-response":true},
... }
For making an external snapshot, I use this command:
$ virsh snapshot-create-as --domain CmsrvMTA sn1 --disk-only --atomic
--quiesce --no-metadata --diskspec vda,file=/srv/poolVMS/CmsrvMTA.sn1
Piece of reply 1:
-
I have encountered this before. Some operating systems
may have bind-mounts that let a device appear multiple times in the mount
list. Unfortunately the guest agent is not smart enough to consider a device
that has been frozen as succesfull and keep going. This causes this specific
error.
Piece of reply 2:
-
Ok, that seems to be it.
I’ve got the ‘/’ and ‘/home’ on the same device formatted as btrfs on
two separate sub volumes.
--
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1587065
Title:
btrfs qemu-ga - multiple mounts block fsfreeze
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
** Description changed:
[Impact]
- * An explanation of the effects of the bug on users and
-
- * justification for backporting the fix to the stable release.
-
- * In addition, it is helpful, but not required, to include an
- explanation of how the upload fixes this bug.
+ * backport upstream fix to avoid double unmounts (e.g. bind mounts)
+hanging the freeze action.
[Test Case]
* Prepare a guest
$ uvt-simplestreams-libvirt --verbose sync --source
http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily
uvt-kvm create --password ubuntu x-freeze arch=amd64 release=xenial
label=daily
* Shut it down and use virsh edit to add a channel for the agent. Add this
somewhere under :
* Start the guest again, in it install qemu-guest-agent
*
* On the Host then freeze and thaw the guest
$ virsh domfsfreeze x-freeze
$ virsh domfsthaw x-freeze
# The above works, then trigger the issue, in the guest do
$ sudo mkdir /mnt/test
$ sudo mount -o bind / /mnt/test/
* Now the freeze/thaw will fail unless the fix is applied.
[Regression Potential]
* From looking at the code alone I could think of a different cause that
makes it return EBUSY.
The biggest risk I could see due to that is the agent reporting a
successful freeze due to accepting EBUSY which is not actually true.
But we have that in Ubuntu since Artful and
upstream since January 2017 and there are no such reports.
[Other Info]
* n/a
---
Having two mounts of the same device makes fsfreeze through qemu-ga
impossible.
root@CmsrvMTA:/# mount -l | grep /dev/vda2
/dev/vda2 on / type btrfs (rw,relatime,space_cache,subvolid=257,subvol=/@)
/dev/vda2 on /home type btrfs
(rw,relatime,space_cache,subvolid=258,subvol=/@home)
Having two mounts is rather common with btrfs, so the feature fsfreeze
is unusable on these systems.
Below more information about how we encountered this issue...
Message send to qemu-disc...@nongnu.org:
Message 1:
--
I use external snapshots to backup my guests. I use the 'quiesce' option to
flush and frees the guest file system with the qemu guest agent.
With the exeption of one guest, this procedure works fine. On the 'unwilling'
guest, I get this error message:
"ERROR 2016-05-25 00:51:19 | T25-bakVMSCmsrvVH2 | fout: internal error:
unable to execute QEMU agent command 'guest-fsfreeze-freeze': failed to freeze
/: Device or resource busy"
I don't think this is not some sort of time-out error, because
activation of the fsfreeze and the error message happen immediately
after each other:
$ grep qemu-ga syslog.1
May 25 00:51:19 CmsrvMTA qemu-ga: info: guest-fsfreeze called
This is the only entry of the qemu guest agent in syslog.
$ sudo virsh version
Compiled against library: libvirt 1.3.1
Using library: libvirt 1.3.1
Gebruikte API: QEMU 1.3.1
Draaiende hypervisor: QEMU 2.5.0
$ virsh qemu-agent-command CmsrvMTA '{"execute": "guest-info"}'
{"return":{"version":"2.5.0", ...
,{"enabled":true,"name":"guest-fstrim","success-response":true},{"enabled":true,"name":"guest-fsfreeze-thaw","success-response":true},{"enabled":true,"name":"guest-fsfreeze-status","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze-list","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze","success-response":true},
... }
For making an external snapshot, I use this command:
$ virsh snapshot-create-as --domain CmsrvMTA sn1 --disk-only --atomic
--quiesce --no-metadata --diskspec vda,file=/srv/poolVMS/CmsrvMTA.sn1
Piece of reply 1:
-
I have encountered this before. Some operating systems
may have bind-mounts that let a device appear multiple times in the mount
list. Unfortunately the guest agent is not smart enough to consider a device
that has been frozen as succesfull and keep going. This causes this specific
error.
Piece of reply 2:
-
Ok, that seems to be it.
I’ve got the ‘/’ and ‘/home’ on the same device formatted as btrfs on
two separate sub volumes.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1587065
Title:
btrfs qemu-ga - multiple mounts block fsfreeze
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
** Description changed:
[Impact]
- * An explanation of the effects of the bug on users and
+ * An explanation of the effects of the bug on users and
- * justification for backporting the fix to the stable release.
+ * justification for backporting the fix to the stable release.
- * In addition, it is helpful, but not required, to include an
-explanation of how the upload fixes this bug.
+ * In addition, it is helpful, but not required, to include an
+ explanation of how the upload fixes this bug.
[Test Case]
- * Prepare a guest
-$ uvt-simplestreams-libvirt --verbose sync --source
http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily
+ * Prepare a guest
+ $ uvt-simplestreams-libvirt --verbose sync --source
http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily
uvt-kvm create --password ubuntu x-freeze arch=amd64 release=xenial
label=daily
- * Shut it down and use virsh edit to add a channel for the agent
+ * Shut it down and use virsh edit to add a channel for the agent. Add this
somewhere under :
-
-
+
+
- * Start the guest again, in it install qemu-guest-agent
+ * Start the guest again, in it install qemu-guest-agent
- *
+ *
- * On the Host then freeze and thaw the guest
- $ virsh domfsfreeze x-freeze
- $ virsh domfsthaw x-freeze
+ * On the Host then freeze and thaw the guest
+ $ virsh domfsfreeze x-freeze
+ $ virsh domfsthaw x-freeze
- # The above works, then trigger the issue, in the guest do
- $ sudo mkdir /mnt/test
- $ sudo mount -o bind / /mnt/test/
+ # The above works, then trigger the issue, in the guest do
+ $ sudo mkdir /mnt/test
+ $ sudo mount -o bind / /mnt/test/
- * Now the freeze/thaw will fail unless the fix is applied.
+ * Now the freeze/thaw will fail unless the fix is applied.
[Regression Potential]
- * From looking at the code alone I could think of a different cause that
-makes it return EBUSY.
-The biggest risk I could see due to that is the agent reporting a
-successful freeze due to accepting EBUSY which is not actually true.
-But we have that in Ubuntu since Artful and
-upstream since January 2017 and there are no such reports.
+ * From looking at the code alone I could think of a different cause that
+ makes it return EBUSY.
+ The biggest risk I could see due to that is the agent reporting a
+ successful freeze due to accepting EBUSY which is not actually true.
+ But we have that in Ubuntu since Artful and
+ upstream since January 2017 and there are no such reports.
[Other Info]
-
- * n/a
+ * n/a
---
Having two mounts of the same device makes fsfreeze through qemu-ga
impossible.
root@CmsrvMTA:/# mount -l | grep /dev/vda2
/dev/vda2 on / type btrfs (rw,relatime,space_cache,subvolid=257,subvol=/@)
/dev/vda2 on /home type btrfs
(rw,relatime,space_cache,subvolid=258,subvol=/@home)
Having two mounts is rather common with btrfs, so the feature fsfreeze
is unusable on these systems.
Below more information about how we encountered this issue...
Message send to qemu-disc...@nongnu.org:
Message 1:
--
I use external snapshots to backup my guests. I use the 'quiesce' option to
flush and frees the guest file system with the qemu guest agent.
With the exeption of one guest, this procedure works fine. On the 'unwilling'
guest, I get this error message:
"ERROR 2016-05-25 00:51:19 | T25-bakVMSCmsrvVH2 | fout: internal error:
unable to execute QEMU agent command 'guest-fsfreeze-freeze': failed to freeze
/: Device or resource busy"
I don't think this is not some sort of time-out error, because
activation of the fsfreeze and the error message happen immediately
after each other:
$ grep qemu-ga syslog.1
May 25 00:51:19 CmsrvMTA qemu-ga: info: guest-fsfreeze called
This is the only entry of the qemu guest agent in syslog.
$ sudo virsh version
Compiled against library: libvirt 1.3.1
Using library: libvirt 1.3.1
Gebruikte API: QEMU 1.3.1
Draaiende hypervisor: QEMU 2.5.0
$ virsh qemu-agent-command CmsrvMTA '{"execute": "guest-info"}'
{"return":{"version":"2.5.0", ...
,{"enabled":true,"name":"guest-fstrim","success-response":true},{"enabled":true,"name":"guest-fsfreeze-thaw","success-response":true},{"enabled":true,"name":"guest-fsfreeze-status","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze-list","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze","success-response":true},
... }
For making an external snapshot, I use this command:
$ virsh snapshot-create-as --domain CmsrvMTA sn1 --disk-only --atomic
--quiesce --no-metadata --diskspec vda,file=/srv/poolVMS/CmsrvMTA.sn1
Piece of reply 1:
-
I have encountered this before. Some operating systems
may have bind-mounts that let a device
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
** Description changed:
[Impact]
- * An explanation of the effects of the bug on users and
+ * An explanation of the effects of the bug on users and
- * justification for backporting the fix to the stable release.
+ * justification for backporting the fix to the stable release.
- * In addition, it is helpful, but not required, to include an
-explanation of how the upload fixes this bug.
+ * In addition, it is helpful, but not required, to include an
+ explanation of how the upload fixes this bug.
[Test Case]
- * Prepare a guest
-$ uvt-simplestreams-libvirt --verbose sync --source
http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily
+ * Prepare a guest
+ $ uvt-simplestreams-libvirt --verbose sync --source
http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily
uvt-kvm create --password ubuntu x-freeze arch=amd64 release=xenial
label=daily
- * Shut it down and use virsh edit to add a channel for the agent
+ * Shut it down and use virsh edit to add a channel for the agent. Add this
somewhere under :
-
-
+
+
- * Start the guest again, in it install qemu-guest-agent
+ * Start the guest again, in it install qemu-guest-agent
- *
+ *
- * On the Host then freeze and thaw the guest
- $ virsh domfsfreeze x-freeze
- $ virsh domfsthaw x-freeze
+ * On the Host then freeze and thaw the guest
+ $ virsh domfsfreeze x-freeze
+ $ virsh domfsthaw x-freeze
- # The above works, then trigger the issue, in the guest do
- $ sudo mkdir /mnt/test
- $ sudo mount -o bind / /mnt/test/
+ # The above works, then trigger the issue, in the guest do
+ $ sudo mkdir /mnt/test
+ $ sudo mount -o bind / /mnt/test/
- * Now the freeze/thaw will fail unless the fix is applied.
+ * Now the freeze/thaw will fail unless the fix is applied.
[Regression Potential]
- * From looking at the code alone I could think of a different cause that
-makes it return EBUSY.
-The biggest risk I could see due to that is the agent reporting a
-successful freeze due to accepting EBUSY which is not actually true.
-But we have that in Ubuntu since Artful and
-upstream since January 2017 and there are no such reports.
+ * From looking at the code alone I could think of a different cause that
+ makes it return EBUSY.
+ The biggest risk I could see due to that is the agent reporting a
+ successful freeze due to accepting EBUSY which is not actually true.
+ But we have that in Ubuntu since Artful and
+ upstream since January 2017 and there are no such reports.
[Other Info]
-
- * n/a
+ * n/a
---
Having two mounts of the same device makes fsfreeze through qemu-ga
impossible.
root@CmsrvMTA:/# mount -l | grep /dev/vda2
/dev/vda2 on / type btrfs (rw,relatime,space_cache,subvolid=257,subvol=/@)
/dev/vda2 on /home type btrfs
(rw,relatime,space_cache,subvolid=258,subvol=/@home)
Having two mounts is rather common with btrfs, so the feature fsfreeze
is unusable on these systems.
Below more information about how we encountered this issue...
Message send to qemu-disc...@nongnu.org:
Message 1:
--
I use external snapshots to backup my guests. I use the 'quiesce' option to
flush and frees the guest file system with the qemu guest agent.
With the exeption of one guest, this procedure works fine. On the 'unwilling'
guest, I get this error message:
"ERROR 2016-05-25 00:51:19 | T25-bakVMSCmsrvVH2 | fout: internal error:
unable to execute QEMU agent command 'guest-fsfreeze-freeze': failed to freeze
/: Device or resource busy"
I don't think this is not some sort of time-out error, because
activation of the fsfreeze and the error message happen immediately
after each other:
$ grep qemu-ga syslog.1
May 25 00:51:19 CmsrvMTA qemu-ga: info: guest-fsfreeze called
This is the only entry of the qemu guest agent in syslog.
$ sudo virsh version
Compiled against library: libvirt 1.3.1
Using library: libvirt 1.3.1
Gebruikte API: QEMU 1.3.1
Draaiende hypervisor: QEMU 2.5.0
$ virsh qemu-agent-command CmsrvMTA '{"execute": "guest-info"}'
{"return":{"version":"2.5.0", ...
,{"enabled":true,"name":"guest-fstrim","success-response":true},{"enabled":true,"name":"guest-fsfreeze-thaw","success-response":true},{"enabled":true,"name":"guest-fsfreeze-status","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze-list","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze","success-response":true},
... }
For making an external snapshot, I use this command:
$ virsh snapshot-create-as --domain CmsrvMTA sn1 --disk-only --atomic
--quiesce --no-metadata --diskspec vda,file=/srv/poolVMS/CmsrvMTA.sn1
Piece of reply 1:
-
I have encountered this before. Some operating systems
may have bind-mounts that let a device
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/348672 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
** Changed in: qemu (Ubuntu Xenial) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
** Description changed:
+ [Impact]
+
+ * An explanation of the effects of the bug on users and
+
+ * justification for backporting the fix to the stable release.
+
+ * In addition, it is helpful, but not required, to include an
+explanation of how the upload fixes this bug.
+
+ [Test Case]
+
+ * Prepare a guest
+$ uvt-simplestreams-libvirt --verbose sync --source
http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily
+ uvt-kvm create --password ubuntu x-freeze arch=amd64 release=xenial
label=daily
+
+ * Shut it down and use virsh edit to add a channel for the agent
+
+
+
+
+
+ * Start the guest again, in it install qemu-guest-agent
+
+ *
+
+ * On the Host then freeze and thaw the guest
+ $ virsh domfsfreeze x-freeze
+ $ virsh domfsthaw x-freeze
+
+ # The above works, then trigger the issue, in the guest do
+ $ sudo mkdir /mnt/test
+ $ sudo mount -o bind / /mnt/test/
+
+ * Now the freeze/thaw will fail unless the fix is applied.
+
+ [Regression Potential]
+
+ * From looking at the code alone I could think of a different cause that
+makes it return EBUSY.
+The biggest risk I could see due to that is the agent reporting a
+successful freeze due to accepting EBUSY which is not actually true.
+But we have that in Ubuntu since Artful and
+upstream since January 2017 and there are no such reports.
+
+ [Other Info]
+
+ * n/a
+
+
+ ---
+
Having two mounts of the same device makes fsfreeze through qemu-ga
impossible.
root@CmsrvMTA:/# mount -l | grep /dev/vda2
/dev/vda2 on / type btrfs (rw,relatime,space_cache,subvolid=257,subvol=/@)
/dev/vda2 on /home type btrfs
(rw,relatime,space_cache,subvolid=258,subvol=/@home)
Having two mounts is rather common with btrfs, so the feature fsfreeze
is unusable on these systems.
-
Below more information about how we encountered this issue...
Message send to qemu-disc...@nongnu.org:
Message 1:
--
I use external snapshots to backup my guests. I use the 'quiesce' option to
flush and frees the guest file system with the qemu guest agent.
With the exeption of one guest, this procedure works fine. On the 'unwilling'
guest, I get this error message:
"ERROR 2016-05-25 00:51:19 | T25-bakVMSCmsrvVH2 | fout: internal error:
unable to execute QEMU agent command 'guest-fsfreeze-freeze': failed to freeze
/: Device or resource busy"
I don't think this is not some sort of time-out error, because
activation of the fsfreeze and the error message happen immediately
after each other:
$ grep qemu-ga syslog.1
May 25 00:51:19 CmsrvMTA qemu-ga: info: guest-fsfreeze called
This is the only entry of the qemu guest agent in syslog.
$ sudo virsh version
Compiled against library: libvirt 1.3.1
Using library: libvirt 1.3.1
Gebruikte API: QEMU 1.3.1
Draaiende hypervisor: QEMU 2.5.0
$ virsh qemu-agent-command CmsrvMTA '{"execute": "guest-info"}'
{"return":{"version":"2.5.0", ...
,{"enabled":true,"name":"guest-fstrim","success-response":true},{"enabled":true,"name":"guest-fsfreeze-thaw","success-response":true},{"enabled":true,"name":"guest-fsfreeze-status","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze-list","success-response":true},{"enabled":true,"name":"guest-fsfreeze-freeze","success-response":true},
... }
For making an external snapshot, I use this command:
$ virsh snapshot-create-as --domain CmsrvMTA sn1 --disk-only --atomic
--quiesce --no-metadata --diskspec vda,file=/srv/poolVMS/CmsrvMTA.sn1
Piece of reply 1:
-
I have encountered this before. Some operating systems
- may have bind-mounts that let a device appear multiple times in the mount
list. Unfortunately the guest agent is not smart enough to consider a device
that has been frozen as succesfull and keep going. This causes this specific
error.
+ may have bind-mounts that let a device appear multiple times in the mount
list. Unfortunately the guest agent is not smart enough to consider a device
that has been frozen as succesfull and keep going. This causes this specific
error.
Piece of reply 2:
-
Ok, that seems to be it.
I’ve got the ‘/’ and ‘/home’ on the same device formatted as btrfs on
two separate sub volumes.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1587065
Title:
btrfs qemu-ga - multiple mounts block fsfreeze
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
Steps to reproduce uvt-simplestreams-libvirt --verbose sync --source http://cloud-images.ubuntu.com/daily arch=amd64 release=xenial label=daily uvt-kvm create --password ubuntu x-freeze arch=amd64 release=xenial label=daily Add this to the guest definition and restart it >From the host freeze and thaw it: $ virsh domfsfreeze x-freeze $ virsh domfsthaw x-freeze # The above works In the Guest then add a bind mount to trigger the issue $ sudo mkdir /mnt/test $ sudo mount -o bind / /mnt/test/ Then again try to freeze/unfreeze $ virsh domfsfreeze x-freeze error: Unable to freeze filesystems error: internal error: unable to execute QEMU agent command 'guest-fsfreeze-freeze': failed to freeze /: Device or resource busy I installed a fix from my PPA [1] and with that it works just fine now. Proposing an MP for review by the team, to afterwards move on into SRU processing. [1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3310 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
Fix is known and seems backportable, marking as server-next and subscribing for somebody to take a look. Also as mentioned it is in 2.9, so newer releases are already fixed. ** Also affects: qemu (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Fix Released ** Changed in: qemu (Ubuntu Xenial) Status: New => Confirmed ** Tags added: server-next -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze
This affects Ubuntu 16.04 as in #4 ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multiple mounts block fsfreeze To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1587065/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
