[Bug 159258] Re: Helper applications launched by Firefox inherit ALL file descriptors
** Changed in: firefox Status: Confirmed => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Something else: mailcap support uses nsIProcess to start commands. These wouldn't be covered either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Ah, I answered my own question - the minimum gtk requirement is 2.10 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Actually, I was thinking about this last week, but why do we have the gio support in the mozgnome component? gio exists on any system with a gtk version of 2.14 or newer (the version there is just plucked from a brief look through the git history of gtk) And if we modified the mozgnome component to dynamically check for gconf/gnomevfs, then is there any point to having the separate component for them anyway? (perhaps I'm missing the point of putting them in libmozgnome in the first place though?) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Mozilla builds depend on libnotify.so.1. The ABI and soname has since changed, so that may be a problem on newer distros. If there's no stable notification library we can use instead, then we could dynamically detect. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Also note that mozgnome also may depend on libnotify. (mozilla builds don't but distros' do) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
(In reply to Mike Hommey [:glandium] from comment #75) > Actually, Non-GNOME systems won't be covered with --enable-gio, because the > gio service is in the mozgnome component, which depends on GNOME libs, which > will most likely fail to load on non-GNOME systems. We'd have to either --disable-gconf --disable-gnomevfs (as I expect GIO distributions will do), or make mozgnome dynamically check for gconf and gnomevfs if still useful. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
(In reply to Karl Tomlinson (:karlt) from comment #73) > Helper apps should be fine in --enable-gio builds because > g_desktop_app_info_launch_uris also calls g_spawn_async without > G_SPAWN_LEAVE_DESCRIPTORS_OPEN. Actually, Non-GNOME systems won't be covered with --enable-gio, because the gio service is in the mozgnome component, which depends on GNOME libs, which will most likely fail to load on non-GNOME systems. And if mozgnome loads anyway, it contains the GnomeVFSService, which would already use gnome_vfs_mime_application_launch. So --enable-gio would change nothing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Ideally at the same time we can install GTK3 on our build systems and migrate to that asap. -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
gnome_vfs_mime_application_launch_with_env calls g_spawn_async without G_SPAWN_LEAVE_DESCRIPTORS_OPEN so helper apps should be fine with GnomeVFS. Non-GNOME (and newer GNOME) systems without --enable-gio will use nsIProcess which uses PR_CreateProcess, thus hitting this bug. Helper apps should be fine in --enable-gio builds because g_desktop_app_info_launch_uris also calls g_spawn_async without G_SPAWN_LEAVE_DESCRIPTORS_OPEN. For plugin/content processes this is addressed by CloseSuperfluousFds. Most systems should have GIO these days, so it looks like the appropriate fix here is to update glib on our build systems so we can --enable-gio. (I haven't done an audit of other nsIProcess consumers.) -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Doing some more code searching, the most important place to put this call might be nsLocalFile::OpenNSPRFileDesc (and possibly OpenANSIFileDesc). Writing that here for my own records. -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
wtc doesn't want the proposed approach as he mentioned in bug 372734. We need to find a way to do this without touching NSPR. This might possibly mean auditing all PRFileDesc* in mozilla-central and calling PR_SetFDInheritable(..., PR_FALSE) on them -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
(In reply to comment #67) > So this is the culprit? > http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/src/md/unix/ > uxproces.c#263 > > How exactly do you trigger this? I thought download code used GIO or > GnomeVFS now to spawn processes. > > Is there any valid case for wanting to keep the file descriptors open after > a fork? I was thinking that, in that function ForkAndExec(), if attr is null > then I close the fds. karl, thoughts? My 2 cents: - The problem is not keeping the file descriptors open after a fork, but after an exec. - There are a lot of valid reasons to keep file descriptors open after a fork - There are a few valid reasons to keep file descriptors open after an exec, but I don't think any of these reasons are in the scope of a browser - Modifying ForkAndExec() behaviour in nspr means a change in behaviour in all applications using NSPR, which may or may not expect file descriptors not to be closed. - As you pointed out, nowadays GIO and GnomeVFS is used (except for mailcap entries), but I don't think they close file descriptors either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Michael, I'd love it if you could take this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Some relevant reference and code over at stackoverflow: http://stackoverflow.com/questions/5713242/linux-fork-file-descriptors- inheritance -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
So this is the culprit? http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/src/md/unix/uxproces.c#263 How exactly do you trigger this? I thought download code used GIO or GnomeVFS now to spawn processes. Is there any valid case for wanting to keep the file descriptors open after a fork? I was thinking that, in that function ForkAndExec(), if attr is null then I close the fds. karl, thoughts? -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Hey, we only have 13 months before the 10-year anniversary of this bug! Here's a doodle for scheduling the party: http://www.doodle.com/9uav5v7igabaxndv *Maybe* we could get the ticket status updated to a status that actually exists for the occasion :) "NEW" doesn't seem to be on the list anymore: https://bugzilla.mozilla.org/page.cgi?id=fields.html#status I won't go so far as to suggest RESOLVED, but IN_PROGRESS would be *awesome*. -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
*** Bug 460936 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
yeah let's not fix this before it's a decade old. not much longer to wait! -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
We do need to fix this, but we're not going to hold Gecko 2 for it. Moving to the 2.x list, pending Karl actually having time... -- You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258] Re: Helper applications launched by Firefox inherit ALL file descriptors
** Changed in: firefox Importance: Unknown => High -- Helper applications launched by Firefox inherit ALL file descriptors https://bugs.launchpad.net/bugs/159258 You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258] Re: Helper applications launched by Firefox inherit ALL file descriptors
** Bug watch added: Mozilla Bugzilla #147659 https://bugzilla.mozilla.org/show_bug.cgi?id=147659 ** Also affects: firefox via https://bugzilla.mozilla.org/show_bug.cgi?id=147659 Importance: Unknown Status: Unknown ** Changed in: firefox (Ubuntu) Importance: Undecided => Low Status: New => Confirmed -- Helper applications launched by Firefox inherit ALL file descriptors https://bugs.launchpad.net/bugs/159258 You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258] Re: Helper applications launched by Firefox inherit ALL file descriptors
** Visibility changed to: Public -- Helper applications launched by Firefox inherit ALL file descriptors https://bugs.launchpad.net/bugs/159258 You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
