[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-28 Thread Daniel van Vugt
I've moved the general accuracy problem that's specific to Unity8 into
bug 1607223.

This bug is all about certain apps only, and is reproducible in Untiy7.

** Package changed: qtmir (Ubuntu) => qtdeclarative-opensource-src
(Ubuntu)

** No longer affects: qtmir

** Summary changed:

- Touchpad scrolling is disproportionately faster than mouse wheel scrolling
+ Touchpad scrolling in dash and system settings is disproportionately faster 
than mouse wheel scrolling

** Description changed:

- Touchpad scrolling is disproportionately faster than mouse wheel
- scrolling in Unity8 (web browser and system settings).
+ Touchpad scrolling in dash and system settings is disproportionately
+ faster than mouse wheel scrolling
  
  I can only say this with confidence today because I implemented accurate
  smooth scrolling in Xmir yesterday, so I know how it should behave.
  
  It's possible QtMir is overreacting to the large number of events that
  touchpads generate compared to a mouse wheel, without taking into
  account the scroll magnitude of each one is smaller.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling in dash and system settings is disproportionately
  faster than mouse wheel scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-28 Thread Daniel van Vugt
That's weird. The problem persists even in System Settings under Unity7.
So not a bug in QtMir but more a bug in the toolkit layer (!?)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-28 Thread Daniel van Vugt
Interestingly webbrowser-app under Unity7 behaves much better (same
findings as bug 1523823).

So whatever the problem is in our QML app scrolling is not a problem in
webbrowser-app.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-26 Thread Daniel van Vugt
Come to think of it, the core of this bug might be outside of QtMir.
That is whatever eventually receives handleWheelEvent is failing to
scroll proportionately to the magnitude of angleDelta, and instead is
scrolling just proportionately to the number of calls to
handleWheelEvent.

** Changed in: qtmir (Ubuntu)
 Assignee: Daniel van Vugt (vanvugt) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-25 Thread Daniel van Vugt
Actually I think this bug might be tangential to the precision problem
in QtMir.

QtMir appears to maintain a little smooth scrolling to a precision of
roughly 0.067 mouse wheel ticks. But touchpads commonly have a precision
of more like 0.00025 equivalent mouse wheel ticks.

So both problems are real. It's possible I have tied them together here
in a single bug erroneously though.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-25 Thread Daniel van Vugt
To solve _this_bug_ as the description states it is probably much simpler:
We should scale the number of integer wheel events sent to Qt according to the 
float magnitude of the Mir vscroll axis. So QtMir should accumulate vscroll 
values as a float and only emit them to Qt each time that value ticks over an 
integer value.

That will correct the relative scrolling distances being
disproportionate between mice and touchpads.

** Changed in: qtmir (Ubuntu)
 Assignee: (unassigned) => Daniel van Vugt (vanvugt)

** Also affects: qtmir
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-25 Thread Daniel van Vugt
That's an idea but we have a problem with libinput/Mir I think... It
hides two-finger events from the client during a scroll, and only
delivers vscroll events instead.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-25 Thread Gerry Boland
Ah no, I'm reading the API wrong (kudos to faenil for correcting me):
QPoint pixelDelta
is in integers, as are all QWheelEvent calculations. So that's not going to 
work without breaking Qt APIs, which is unlikely.

An alternative option might be to us Qt's support for native gesture
events - this is used on OS X. These do let Qt do Pan/Swipe gestures
with float precision.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-25 Thread Gerry Boland
Are you looking at the right code? I see this from Qt5.4 source
(qtbase/src/gui/kernel/qwindowsysteminterface.h)

static void handleWheelEvent(QWindow *w, const QPointF & local, const 
QPointF & global, QPoint pixelDelta, QPoint angleDelta, Qt::KeyboardModifiers 
mods = Qt::NoModifier, Qt::ScrollPhase phase = Qt::ScrollUpdate);
static void handleWheelEvent(QWindow *w, ulong timestamp, const QPointF & 
local, const QPointF & global, QPoint pixelDelta, QPoint angleDelta, 
Qt::KeyboardModifiers mods = Qt::NoModifier, Qt::ScrollPhase phase = 
Qt::ScrollUpdate);

Scroll units are floats. The line you're quoting is a QtMir internal
thing, which we mistakenly used ints for.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-25 Thread Daniel van Vugt
Bad news: The broken handleWheelEvent syntax is one we have inherited
from QWindowSystemInterface so we can't just fix it in QtMir to use
QPointF and libinput-style smooth scrolling :(

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1605513] Re: Touchpad scrolling is disproportionately faster than mouse wheel scrolling

2016-07-22 Thread Daniel van Vugt
Found the problem:

void handleWheelEvent(ulong timestamp, QPoint angleDelta,
Qt::KeyboardModifiers mods) override

QPoint is a pair of integers, but touchpad scroll values are floats.

** Changed in: unity8 (Ubuntu)
   Status: New => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1605513

Title:
  Touchpad scrolling is disproportionately faster than mouse wheel
  scrolling

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1605513/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs