[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
\o/ Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
unsubscribing 'xnox' big-bow guys - this was pretty fast forward. Sometimes THE internet and it's opportunties still impress me. TKS! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
This bug was fixed in the package cmake - 3.5.1-1ubuntu3 --- cmake (3.5.1-1ubuntu3) xenial; urgency=medium * cherry-pick from upstream to fix Ninja builds (LP: #1624832): - debian/patches/f6c5958047ee8a9084bf230a6c1acb4801cb2b93.patch: * cherry-pick Debian patch to fix build with libarchive from backports: - Make FindLibArchive compatible with libarchive 3.2. (Closes: #828092) - Add FindLibArchive_Support_libarchive_3.2.patch -- Gianfranco CostamagnaMon, 26 Sep 2016 19:38:26 +0200 ** Changed in: cmake (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
I can confirm this fixes the reported issue. I can also confirm that LibArchive is found properly with xenial- backports enabled: estan@newton:~/tmp$ cat CMakeLists.txt find_package(LibArchive) estan@newton:~/tmp$ cmake . . . . -- Found LibArchive: /usr/lib/x86_64-linux-gnu/libarchive.so (found version "3.1.2") . . . estan@newton:~/tmp$ Thanks a lot for fixing this so fast! No-op builds are now next to instantaneous, even with AUTORCC-generated sources, as they should be :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
Excellent, thanks a lot. Will verify as soon as I'm back at work tomorrow (missed this email before I left today). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
@elvis please confirm it too, this works: cat CMakeLists.txt find_package(LibArchive) cmake . -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
-- Found LibArchive: /usr/lib/x86_64-linux-gnu/libarchive.so (found version "3.2.1") so far so good. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
Hello Elvis, or anyone else affected, Accepted cmake into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cmake/3.5.1-1ubuntu3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: cmake (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
** Changed in: cmake (Ubuntu) Status: New => In Progress ** Also affects: cmake (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: cmake (Ubuntu Xenial) Status: New => In Progress ** Changed in: cmake (Ubuntu Xenial) Assignee: (unassigned) => Graham Inggs (ginggs) ** Changed in: cmake (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to cmake in Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
the debdiff above works with libarchive from updates. With libarchive from backports an additional patch (Coming from Debian and later releases) is needed. this debdiff (uploaded on ppa:costamagnagianfranco/boinc) should work ** Attachment added: "debdiff-v2" https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+attachment/4748911/+files/debdiff-v2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja
patch fixing the issue build ongoing at ppa:costamagnagianfranco/costamagnagianfranco-ppa https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/costamagnagianfranco-ppa ** Summary changed: - AUTORCC-generated resources always out-of-date with Ninja + [SRU] AUTORCC-generated resources always out-of-date with Ninja ** Description changed: - When using AUTORCC with the Ninja generator, the generated qrc_*.cpp.o - target is always considered out-of-date, leading to an unnecessary (and - possibly lengthy) re-link on each build. This defeats one of the main - strengths of Ninja, which is its fast no-op build time. + [Impact] + + * people using Ninja to speed up the build, with AUTORCC-generated + resources + + [Test Case] + + * stuff is not regenerated due to a bug in cmake + + [Regression Potential] + + * None + + [Other Info] The upstream bug report is here: https://cmake.org/Bug/view.php?id=16049 and was later moved to here: https://gitlab.kitware.com/cmake/cmake/issues/16049 It was fixed by Brad King in https://gitlab.kitware.com/ben.boeckel/cmake/commit/f6c5958047ee8a9084bf230a6c1acb4801cb2b93 and the fix is in CMake 3.5.2. I would like to ask what is best: Should I should prepare a debdiff adding this patch to the 3.5.1 package in Xenial and request an SRU? Or is it reasonable to update the Xenial package to 3.5.2 (which is in Yakkety) outright? ** Attachment added: "debdiff" https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+attachment/4748881/+files/debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1624832 Title: [SRU] AUTORCC-generated resources always out-of-date with Ninja To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs