[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Launchpad Bug Tracker]

This bug was fixed in the package apt-xapian-index - 0.47ubuntu8.4

---
apt-xapian-index (0.47ubuntu8.4) xenial; urgency=medium

  * debian/patches/08_race_no_attribute_unlink.patch: use a finalizer
instead of __del__ to close and remove the socket.
When ServerProgress.__del__() is called the global os module might
already have been set to None by the Python shutdown, causing an
exception. (LP: #1652641)

 -- Carlo Vanini   Fri, 23 Feb 2018 08:44:53 -0800

** Changed in: apt-xapian-index (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Jorma Hytonen]

Hi Carlo
Thank you for the information.
I look forward to a regular update.

Thanks for your activity in solving the problem.

Regards,
Jorma

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

Hi Jorma,
now that the verification is done it will be moved to xenial-updates and it 
will be part of the regular updates (and then the status will become "Fix 
Released").

If, instead, you want to have the fix before that, or you want to
confirm that the problem is indeed fixed for you too (that's the goal of
verification) you can download and install the new version by hand.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Jorma Hytonen]

Ref to #20
Does this mean that I need to update my Ubuntu 16.04 system? 
Download and install apt-xapian-index_0.47ubuntu8.4.tar.gz
Or can I wait for a regular update?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Mathew Hodson]

** Tags removed: verification-needed yakkety

** Tags added: yakkety

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

Works for me on Xenial with apt-xapian-index version 0.47ubuntu8.4

** Tags removed: verification-needed-xenial
** Tags added: verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Brian Murray]

Hello Carlo, or anyone else affected,

Accepted apt-xapian-index into xenial-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/apt-xapian-
index/0.47ubuntu8.4 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-xenial to verification-done-xenial. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-xenial. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: apt-xapian-index (Ubuntu Xenial)
   Status: In Progress => Fix Committed

** Tags added: verification-needed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Brian Murray]

** Changed in: apt-xapian-index (Ubuntu Xenial)
   Status: Triaged => In Progress

** Changed in: apt-xapian-index (Ubuntu Xenial)
 Assignee: (unassigned) => Brian Murray (brian-murray)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

** Description changed:

  [Impact]
  
  When the apt-xapian-index is already up to date, and under certain
  conditions, update-apt-xapian-index throws an exception.
  
  The index /var/lib/apt-xapian-index is up to date
  Exception ignored in: >
  Traceback (most recent call last):
-   File "/usr/lib/python3/dist-packages/axi/indexer.py", line 306, in __del__
+   File "/usr/lib/python3/dist-packages/axi/indexer.py", line 306, in __del__
  AttributeError: 'NoneType' object has no attribute 'unlink'
  
  This happens more frequently when it is run with nice and ionice, which
  is the case in the cron.weekly/apt-xapian-index cron job.
  
  This is not severe, since the exception is thrown on exit, and depends
  on the way python3 cleans up the environment. Anyway, this leaves a
  socket file behind, and creates noise in cron logs (see comment #2).
  
- The patch keeps a reference to the os.unlink function in the
- ServerProgress instance, such that it has the same lifespan.
+ The patch uses a weakref finalizer in order to remove the socket file.
  
  [Test Case]
  
  * `sudo nice -n 19 ionice -c 3 update-apt-xapian-index --quiet`
  * may need to run 4 times or more
  * no exception is thrown
  
  [Regression Potential]
  
- * If the os module is unloaded anyway and self.os_unlink becomes
- unreachable, we get the same exception again.
+ * If the os module is unloaded anyway and os.unlink becomes unreachable, we 
get the same exception again.
+ * We import the `weakref` module, which was not used before.
  
  [Other Info]
  
- * There is probably a more "pythonic" way to fix this. For instance,
- avoiding __del__. That requires a larger change.
+ * This description was updated to reflect the changes in the behavior of
+ the patch that was released in Zesty. It still needs sponsoring for
+ Xenial.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Launchpad Bug Tracker]

This bug was fixed in the package apt-xapian-index - 0.47ubuntu13.1

---
apt-xapian-index (0.47ubuntu13.1) zesty; urgency=medium

  * debian/patches/08_race_no_attribute_unlink.patch: use a finalizer
instead of __del__ to close and remove the socket.
When ServerProgress.__del__() is called the global os module might
already have been set to None by the Python shutdown, causing an
exception. (LP: #1652641)

 -- Carlo Vanini   Fri, 24 Nov 2017 21:23:12 -0600

** Changed in: apt-xapian-index (Ubuntu Zesty)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

It works for me on zesty with apt-xapian-index version 0.47ubuntu13.1
(python3 3.5.3-1)

** Tags removed: verification-needed-zesty
** Tags added: verification-done-zesty

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Mathew Hodson]

** Changed in: apt-xapian-index (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: apt-xapian-index (Ubuntu Zesty)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Brian Murray]

Hello Carlo, or anyone else affected,

Accepted apt-xapian-index into zesty-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/apt-xapian-
index/0.47ubuntu13.1 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-zesty to verification-done-zesty. If it does not fix
the bug for you, please add a comment stating that, and change the tag
to verification-failed-zesty. In either case, details of your testing
will help us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: apt-xapian-index (Ubuntu Zesty)
   Status: Triaged => Fix Committed

** Tags added: verification-needed verification-needed-zesty

** Changed in: apt-xapian-index (Ubuntu)
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

This is the patch for Xenial. Tested in a 16.04.2 VM.

** Patch added: "patch for Xenial"
   
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+attachment/5014886/+files/apt-xapian-index_0.47ubuntu8.4.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Simon Quigley]

Apologies for the delay, sponsored to Zesty. Unsubscribing ~ubuntu-
sponsors for now, but it would be great if you could create a patch for
Xenial and resubscribe when you're ready. ;)

Thanks!

** Also affects: apt-xapian-index (Ubuntu Zesty)
   Importance: Undecided
   Status: New

** Also affects: apt-xapian-index (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Changed in: apt-xapian-index (Ubuntu Xenial)
   Status: New => Triaged

** Changed in: apt-xapian-index (Ubuntu Zesty)
   Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Amr Ibrahim]

Carlo, I subscribed ~ubuntu-sponsors for you to review the debdiff.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

Sorry for the noise, patch updated again. This time it uses a
weakref.finalizer instead of __del__. This is a little a cleaner
solution. Moreover the finalizer is guaranteed to be called (at the
latest at exit), whereas __del__ is not.

** Patch added: "apt-xapian-index_0.47ubuntu13.1.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+attachment/4943263/+files/apt-xapian-index_0.47ubuntu13.1.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

Hello Simon,

version 0.47ubuntu13 in zesty-updates is still affected.
version 0.47ubuntu8.3 in xenial-updates is affected too.

Artful beta1 has 0.47ubuntu13 like Zesty does, but I could not reproduce
the bug. The reason could be that Python changed from 3.5.3 (in Zesty)
to 3.6.2 (in Artful). The way Python unloads modules might have changed,
but I couldn't tell for sure from the docs
https://docs.python.org/3/whatsnew/3.6.html

Patch updated, as you suggested.

** Patch added: "apt-xapian-index_0.47ubuntu13.1.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+attachment/4943253/+files/apt-xapian-index_0.47ubuntu13.1.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Simon Quigley]

Hello Carlo,

Could you please clarify which release this should go to? Yakkety is EOL
now.

Also, irt to your patch, DEP-3 headers don't need "##" in front of them,
please remove that.

Thank you for your interest in fixing this bug!

(unsubscribing ~ubuntu-sponsors as there's nothing to sponsor)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

** Description changed:

- While installing Muon the following exception was raised.
+ [Impact]
  
- Ophalen:1 http://nl.archive.ubuntu.com/ubuntu zesty/universe amd64 muon amd64
- 4:5.6.0-0ubuntu2 [332 kB]
- Ophalen:2 http://nl.archive.ubuntu.com/ubuntu zesty/universe amd64 
muon-updater
- all 4:5.8.4-0ubuntu1 [3268 B]
- 335 kB opgehaald in 0s (861 kB/s)
- Voorheen niet geselecteerd pakket muon wordt geselecteerd.
- (Database wordt ingelezen ... 238429 bestanden en mappen momenteel
- geïnstalleerd.)
- Uitpakken van .../0-muon_4%3a5.6.0-0ubuntu2_amd64.deb wordt voorbereid...
- Bezig met uitpakken van muon (4:5.6.0-0ubuntu2) ...
- Voorheen niet geselecteerd pakket muon-updater wordt geselecteerd.
- Uitpakken van .../1-muon-updater_4%3a5.8.4-0ubuntu1_all.deb wordt 
voorbereid...
- Bezig met uitpakken van muon-updater (4:5.8.4-0ubuntu1) ...
- Bezig met afhandelen van triggers voor mime-support (3.60ubuntu1) ...
- Instellen van muon-updater (4:5.8.4-0ubuntu1) ...
- Instellen van muon (4:5.6.0-0ubuntu2) ...
+ When the apt-xapian-index is already up to date, and under certain
+ conditions, update-apt-xapian-index throws an exception.
  
  The index /var/lib/apt-xapian-index is up to date
  Exception ignored in: >
  Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/axi/indexer.py", line 306, in __del__
  AttributeError: 'NoneType' object has no attribute 'unlink'
  
+ This happens more frequently when it is run with nice and ionice, which
+ is the case in the cron.weekly/apt-xapian-index cron job.
  
- Bezig met afhandelen van triggers voor hicolor-icon-theme (0.15-1) ...
- done..
+ This is not severe, since the exception is thrown on exit, and depends
+ on the way python3 cleans up the environment. Anyway, this leaves a
+ socket file behind, and creates noise in cron logs (see comment #2).
  
+ The patch keeps a reference to the os.unlink function in the
+ ServerProgress instance, such that it has the same lifespan.
  
- This bug was originally reported against Muon as 
https://bugs.kde.org/show_bug.cgi?id=374084 but the crash actually happens in 
a-x-i.
+ [Test Case]
+ 
+ * `sudo nice -n 19 ionice -c 3 update-apt-xapian-index --quiet`
+ * may need to run 4 times or more
+ * no exception is thrown
+ 
+ [Regression Potential]
+ 
+ * If the os module is unloaded anyway and self.os_unlink becomes
+ unreachable, we get the same exception again.
+ 
+ [Other Info]
+ 
+ * There is probably a more "pythonic" way to fix this. For instance,
+ avoiding __del__. That requires a larger change.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Brian Murray]

** Tags added: zesty

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Mathew Hodson]

** Changed in: apt-xapian-index (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Ubuntu Foundations Team Bug Bot]

The attachment "keep a reference to os.unlink" seems to be a debdiff.
The ubuntu-sponsors team has been subscribed to the bug report so that
they can review and hopefully sponsor the debdiff.  If the attachment
isn't a patch, please remove the "patch" flag from the attachment,
remove the "patch" tag, and if you are member of the ~ubuntu-sponsors,
unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issue please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Carlo Vanini]

It looks like the same bug reappearing
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-
index/+bug/1530518/comments/2

Running a-x-i directly doesn't trigger this bug, but the combination of
nice and ionice makes it show up much more often. (When the index is
already up to date)

Steps to reproduce:
 * `sudo update-apt-xapian-index`
 * Now that the index is updated we trigger the bug by running the following 
command (which is the same used in the cron job)
 * `sudo nice -n 19 ionice -c 3 update-apt-xapian-index --quiet`
 * may need to run 4 times or more

The intention of the proposed patch is to work around the problem by keeping a 
reference to the os.unlink function in the ServerProgress instance.
See 
http://stackoverflow.com/questions/17084260/imported-modules-become-none-when-running-a-function
 for an explanation of the issue in python.
Also see http://pydev.blogspot.ch/2015/01/creating-safe-cyclic-reference.html 
for a possible implementation using weakrefs.

** Patch added: "keep a reference to os.unlink"
   
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+attachment/4861539/+files/apt-xapian-index_0.47ubuntu12.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Brian Murray]

I didn't see any instances of this Traceback at errors.ubuntu.com.  It's
worth noting that apt-xapian-index is only included in Task: kubuntu-
desktop, kubuntu-full, lubuntu-qt-desktop, ubuntukylin-desktop.

** Tags added: yakkety

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Andreas Roth]

Sorry, but forgot to mention that i'm running Ubuntu yakkety on my
machine.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Andreas Roth]

This morning i received this mail from the cron.weekly run:

/etc/cron.weekly/apt-xapian-index:
Exception ignored in: >
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/axi/indexer.py", line 306, in __del__
AttributeError: 'NoneType' object has no attribute 'unlink'

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: apt-xapian-index (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1652641] Re: crash in indexer.py, AttributeError: 'NoneType' object has no attribute 'unlink'

[André Verwijs]

(k)ubuntu version 17.04
kernel version: 4.9.0-11.12
apt-xapian-index version: 0.47ubuntu11

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1652641

Title:
  crash in indexer.py, AttributeError: 'NoneType' object has no
  attribute 'unlink'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-xapian-index/+bug/1652641/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs