[Bug 1679392] Re: Missing dep8 tests
** Changed in: sg3-utils (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1679392 Title: Missing dep8 tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sg3-utils/+bug/1679392/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1679392] Re: Missing dep8 tests
** Merge proposal linked: https://code.launchpad.net/~bryce/ubuntu/+source/sg3-utils/+git/sg3-utils/+merge/472834 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1679392 Title: Missing dep8 tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sg3-utils/+bug/1679392/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1679392] Re: Missing dep8 tests
We have made other tests work using scsi_debug module [1] which usually is available and would work at least in "isolation-machine" environments. One could check if/what sg tools can query from that. Another case that could be used to learn from are the tests of packages tgt and multipath-tools. There we set up iscsi using TGT, if sg_tools can query something that we can construct we could check if the data is as expected. [1]: http://sg.danny.cz/sg/sdebug26.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1679392 Title: Missing dep8 tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sg3-utils/+bug/1679392/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1679392] Re: Missing dep8 tests
This is a collection of binary cli tools and bash scripts that do hardware-specific operations. There have only ever been 10 bugs filed against this package, and nearly all are packaging-related (e.g. sync requests.) Thus, this package may see limited benefit of having dep8 tests. I think the extent of tests should just check installation of a handful of the most commonly used commands That said, some simple smoke tests for common commands might be of some usefulness, and could be sufficient to close this bug. From looking at https://www.tldp.org/HOWTO/SCSI-Generic-HOWTO/sg3_utils.html I might suggest something like: ``` test -e /usr/bin/sg_dd test -e /usr/bin/sg_map test -e /usr/bin/sg_inq test -e /usr/bin/sg_read ``` Probably safe to assume that these are representative enough that if they're installed, all the other utilities would be as well. It's probably unreasonable to assume that the testing environments this runs in will be assured to have any SCSI devices available for the test. But, if that can be guaranteed, then it might be of use to run sg_inq as a basic smoke test. ** Changed in: sg3-utils (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1679392 Title: Missing dep8 tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sg3-utils/+bug/1679392/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
