Initially looks good except a few things
1. Can you update the version number to a -0ubuntu1 style for
consistency
2. check-all-the-things stuff
$ check-all-the-things
$ find . -type f \( -iname '*.metainfo.xml' -o -iname '*.appdata.xml' \) -exec
appstreamcli validate --pedantic {} +
Validation was successful.
# Check with upstream where the Inkscape SVG source files are.
$ find . -type f \( -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg' -o
-iname '*.jpeg' \) -exec grep -nHiF inkscape {} +
Binary file ./data/banner.png matches
Binary file ./data/babe_128.png matches
Binary file ./data/playBtn.svg.png matches
Binary file ./BabeExtension/icon_1.png matches
Binary file ./BabeExtension/icon_done.png matches
Binary file ./BabeExtension/icon_2.png matches
$ grep -nHEr '/(home|srv|opt)(\W|$)' .
./CMakeLists.txt.user:70:/home/camilo/Desktop/build-babe-Desktop-Default
./CMakeLists.txt.user:114:/home/camilo/Desktop/build-babe-Desktop-Debug
./CMakeLists.txt.user:158:/home/camilo/Desktop/build-babe-Desktop-Release
./CMakeLists.txt.user:202:/home/camilo/Desktop/build-babe-Desktop-Release
with Debug Information
./CMakeLists.txt.user:246:/home/camilo/Desktop/build-babe-Desktop-Minimum
Size Release
./CMakeLists.txt.user:344:/home/camilo/Desktop/build-babe-Desktop-Default
./style_examples/style.qss:10:
background-image:url("/home/camilo/.config/babe/pattern.png") repeat;
./BabeExtension/icon_push.svg:21:
inkscape:export-filename="/home/camilo/Coding/qt5/Babe/chrome_extension/icon_1.png"
./Babe.pro.user.972235b:69:/home/camilo/Desktop/build-Babe-Desktop-Debug
./Babe.pro.user.972235b:129:/home/camilo/Desktop/build-Babe-Desktop-Release
...
$ find . -type f \( -iname '*.ttf' -o -iname '*.otf' -o -iname '*.sfd' -o
-iname '*.pfa' -o -iname '*.pfb' -o -iname '*.bdf' -o -iname '*.pk' -o -iname
'*.ttc' -o -iname '*.pcf' \) -exec check-font-embedding-restrictions {} +
Traceback (most recent call last):
File "/usr/bin/check-font-embedding-restrictions", line 3, in
import fontforge
ImportError: No module named fontforge
# check if these can be switched to https://
$ grep -nHrF http: .
./debian/copyright:45: this program. If not, see .
./data/media-playback-start.svg:3: xmlns:dc="http://purl.org/dc/elements/1.1/";
./data/media-playback-start.svg:4: xmlns:cc="http://creativecommons.org/ns#";
./data/media-playback-start.svg:5:
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#";
./data/media-playback-start.svg:6: xmlns:svg="http://www.w3.org/2000/svg";
./data/media-playback-start.svg:7: xmlns="http://www.w3.org/2000/svg";
./data/media-playback-start.svg:8:
xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd";
./data/media-playback-start.svg:9:
xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape";
./data/media-playback-start.svg:22:
rdf:resource="http://purl.org/dc/dcmitype/StillImage"; />
./data/cover_hover.svg:3: xmlns:dc="http://purl.org/dc/elements/1.1/";
...
$ licensecheck --check=. --recursive --copyright .
./collectionDB.cpp: GPL (v3 or later)
[Copyright: 2017 Camilo Higuita]
./CMakeLists.txt.user: *No copyright* UNKNOWN
./settings.h: *No copyright* UNKNOWN
./pulpo.h: *No copyright* UNKNOWN
./org.kde.babe.appdata.xml: *No copyright* UNKNOWN
...
$ env PERL5OPT=-m-lib=. lintian --info --display-info --display-experimental
--pedantic --show-overrides --color auto
Cannot find changes file for babe/0.0.0.1+p17.10+git20170615.0110-0, tried:
babe_0.0.0.1+p17.10+git20170615.0110-0_amd64.changes
babe_0.0.0.1+p17.10+git20170615.0110-0_i386.changes
babe_0.0.0.1+p17.10+git20170615.0110-0_multi.changes
babe_0.0.0.1+p17.10+git20170615.0110-0_all.changes
babe_0.0.0.1+p17.10+git20170615.0110-0_source.changes
in the following dirs:
..
../build-area
/var/cache/pbuilder/result
$ find . -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname .svn -o
-iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o -iname _darcs -o
-iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o -iname .metadata -o
-iname CMakeFiles -o -iname _build -o -iname _sgbak -o -iname autom4te.cache -o
-iname blib -o -iname cover_db -o -iname node_modules -o -iname '~.dep' -o
-iname '~.dot' -o -iname '~.nib' -o -iname '~.plst' \) -prune -o -type f ! \(
-iname '*.bak' -o -iname '*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname
'core.*' -o -iname '*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg'
-o -iname '*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname
'*.js.min' -o -iname '*.min.css' -o -iname '*.css.map' -o -iname '*.css.min' -o
-iname '*.wav' \) -exec env PERL5OPT=-m-lib=. spellintian --picky {} +
./org.kde.babe.appdata.xml: let's you -> lets you
./org.kde.babe.appdata.xml: kde -> KDE
./settings.cpp: writting -> writing
./mainwindow.cpp.autosave: separte -> separate
./mpris2.cpp: dont -> don't
./README.md: let's you -> lets you
./README.md: kde -> KDE
./pulpo.cpp: do
