[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
Nothing from my POV, I expected Andres to propose or upload the same fix for X/Z now as he did for Artful last month. Btw I'll mark Artful correctly and add X/Z tasks. ** Also affects: ipxe (Ubuntu Artful) Importance: Undecided Status: New ** Also affects: ipxe (Ubuntu Zesty) Importance: Undecided Status: New ** Changed in: ipxe (Ubuntu Artful) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
Since the code is essentially the same it should likely apply as is. If one expected that I take over and do the uploads please tell me so. ** Changed in: ipxe (Ubuntu Zesty) Status: New => Triaged ** Changed in: ipxe (Ubuntu Xenial) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
Can someone summarize what is blocking the Xenial incarnation of this bug in moving ahead? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
** Changed in: ipxe (Ubuntu Bionic) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
This bug was fixed in the package ipxe - 1.0.0+git-20161027.b991c67+really20150424.a25a16d-1ubuntu2 --- ipxe (1.0.0+git-20161027.b991c67+really20150424.a25a16d-1ubuntu2) artful; urgency=medium * debian/patches/handle-dhcp-nack.patch: Handle DHCP NAK and send a re-discover. (LP: #1707999) -- Andres Rodriguez Thu, 12 Oct 2017 16:25:52 -0400 ** Changed in: ipxe (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
I have submitted the patch upstream: https://github.com/ipxe/ipxe/pull/66 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
Hi Andres, Blake and Jason, reading this long context trying to help avaluating the change. Summarizing (mostly for myself) c#34 and c#35 means that you think it is "ok" due to the out-of-band update to have time windows where primary and secondary will offer different IPs. Instead of (trying to) fix this part of the dhcp setup to onyl ever offer one (or at least offer the same from primary and secondary) the suggestion is to make iPXE aware of how to handle the NACK. The patch in c#41 and tests in c#40 suggest this works fine for your case now. Overall that was already a lot of work to debug it down, kudos to all of you. Taking a look on this from the qemu POV - probably especially since the last ipxe upload broke all migrations :-) (due to a size change). One thing I wondered, but think we are good are state loops. Since we add a state transition back (that didn't exist before at all) it might need some sort of infinite loop protection. I tried to read all that code but might be wrong. D: dhcp_state_discover; R: dhcp_state_request init: -> D -> R ^---/ (this is what we add) As I read it, this will continue as before, neiher _expiry function had a responsibiity to abort he overall discovery. Each state change resets it's timer, but that should be ok. Also a scenario where a guest repeatetly gets an offer but then Nacked should be invalid in general. So it should (IMHO) be ok to add this transition. In addition to the review I ran some tests (on Xenial as the ppa). On Artful sizes would now be checked on build, but the ppa is only xenial - so I checked manually and they are ok. Further some upgrade & migration test I ran were all without issues - ok. The open comments/requests to you that I'd have are: 1. Trivial: current patch has (only) whitespace damage in hunk #2 2. Upstreaming: While we can't wait (or could we) with the fix for an upstream accept it should be forwarded 3. Formalisms in the patch header: 3.1 After being submitted please add as usual add to the dep3 header a Forwarded statement with a link to where you sent it. 3.2 We all know how hard backtracing in a few years can be, please add like Bug-Ubuntu: https://bugs.launchpad.net/bugs/1707999 Other than that I like it and would consider it clearly good enough to go from on-bug-RFC to ipxe-upstream-RFC with the patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
As David said, and to clarify, I was planning on uploading this patch to the archive, but I wanted to double check with you guys to ensure that the implementation is sane from your perspective, as this will affect ipxe clients that receive DHCPNACKs. Also, it would be good to get a different perspective from the RFC standpoint. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
Christian -- Andres is planning on uploading this, but could use a review first to make sure it is sane from a qemu/kvm perspective. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
The patch is built in ppa:blake-rouse/ipxe -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
** Changed in: ipxe (Ubuntu) Assignee: Andres Rodriguez (andreserl) => ChristianEhrhardt (paelzer) ** Also affects: ipxe (Ubuntu Bb-series) Importance: Undecided Status: New ** Also affects: ipxe (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
** Patch added: "handle-dhcp-nack.patch" https://bugs.launchpad.net/maas/+bug/1707999/+attachment/4969236/+files/handle-dhcp-nack.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
** Changed in: maas Status: Incomplete => Invalid ** Changed in: maas/2.2 Status: Incomplete => Invalid ** Changed in: ipxe (Ubuntu) Assignee: (unassigned) => Andres Rodriguez (andreserl) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
Blake, nice work on the patch, it appears that it worked! Here's a snippet of my syslog where you can see the machine requesting an IP, getting NAK'd, then going back to discover state and successfully completing dhcp with a new ip. http://paste.ubuntu.com/25728345/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
** Changed in: maas Assignee: (unassigned) => Blake Rouse (blake-rouse) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1707999] Re: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server
** Also affects: ipxe (Ubuntu) Importance: Undecided Status: New ** Changed in: ipxe (Ubuntu) Importance: Undecided => Critical ** Changed in: maas Status: Triaged => Incomplete ** Changed in: maas/2.2 Status: Triaged => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1707999 Title: pod VM fails to PXE boot after receiving multiple DHCP offers, for different IPs, from the dhcp server To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1707999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
