[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
As far as I see, openjdk-8 (8u275-b01-1) contains this patch, so it was backported upstream. ** Changed in: openjdk-8 (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: openjdk-9 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Patch was applied upstream, http://hg.openjdk.java.net/jdk/jdk/rev/d4ed3b8d166c Requesting a backport to 8/9 please. Should apply without conflicts - file hasn't been otherwise modified in either version. Thanks Michael -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
The attachment "disabled.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
No upstream bug yet unfortunately (OpenJDK bugtracker is restricted access as I'm sure you know). I made a mailing list thread a few days ago here http://mail.openjdk.java.net/pipermail/swing-dev/2017-November/007904.html although haven't had any feedback aside from the patch not being attached! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Great, thanks. Do you have a link to the upstream bug? ** Changed in: openjdk-9 (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Patch I submitted upstream is attached, not through yet though. ** Patch added: "disabled.diff" https://bugs.launchpad.net/ubuntu/+source/openjdk-8/+bug/1729558/+attachment/5005613/+files/disabled.diff ** Also affects: openjdk-9 (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
** Changed in: ubuntu-themes Status: Confirmed => Invalid ** Changed in: ubuntu-themes (Ubuntu) Status: Confirmed => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Ok Turns out Java has some super funky code:
int componentState = context.getComponentState();
if ((componentState & SynthConstants.DISABLED) ==
SynthConstants.DISABLED){
if (!GTKLookAndFeel.is3()) {
Color orgColor = g.getColor();
g.setColor(context.getStyle().getColor(context,
GTKColorType.WHITE));
x += 1;
y += 1;
super.paintText(context, g, text, x, y, mnemonicIndex);
g.setColor(orgColor);
x -= 1;
y -= 1;
}
super.paintText(context, g, text, x, y, mnemonicIndex);
}
Removing this silly +1 white shadowing nonsense results in perfect looking
menus both when dark and light.
I will take this upstream and see if it can be patched into Ubuntu, not a
theming bug after all.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1729558
Title:
[regression] In Java apps like Netbeans, dark menu bars don't look
good for disabled elements
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Java looks to be using the disabled foreground colour correctly (to me,
the untrained observer):
gtk2_widget = gtk2_get_widget(widget_type);
GtkStyle* style = gtk2_widget->style;
switch (color_type)
{
case FOREGROUND:
color = &(style->fg[state_type]);
break;
Worth noting using GTK3 breaks other things, but actually fixes this bug (but
that could simply point to an issue with Java's GTK2 code).
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1729558
Title:
[regression] In Java apps like Netbeans, dark menu bars don't look
good for disabled elements
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
If you were testing your own install the font rendering is messed because of this bug in freetype https://bugs.launchpad.net/bugs/1722508 Downgrading to the Zesty version of freetype (as in my screenshots) fixes that issue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
I think it's more the Swing/other toolkit's unique way of rendering things than GTK. Testing a native GTK-2 app (geeqie) doesn't seem to exhibit the problem. Yes I agree with your terminology. Worth noting though even the font rendering style looks messed up in Netbeans. From what I recall in years gone by that's a Java-specific issue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Java isn’t hardcoding them, it’s pulling them from GTK. There is the possibility that it’s pulling the wrong type of element colour (sorry not sure about terminology). I guess the test is to find a GTK 2 app with disabled menu elements that previously had a white menu which is now black wih this patch. I did make a test Java Swing app and the disabled elements looked bad, so it’s not constrained to Netbeans at least. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
** Tags added: visual-quality -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: openjdk-8 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
** Changed in: ubuntu-themes Importance: Undecided => Low ** Changed in: openjdk-8 (Ubuntu) Importance: Undecided => Low ** Changed in: ubuntu-themes (Ubuntu) Importance: Undecided => Low ** Changed in: ubuntu-themes Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: ubuntu-themes (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
