Re: [Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Simon Lambourn]

Thankyou for putting the time into this Brian.
Much appreciated.

On Thu, 15 Feb 2018 at 21:35 Brian Murray  wrote:

> I did an audit of the release upgrader code and found a couple of spots
> where the upgrade may not have been rolled back to the previous release
> and fixed them here.
>
> https://bazaar.launchpad.net/~ubuntu-core-dev/ubuntu-release-
> upgrader/trunk/revision/3102
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1737445
>
> Title:
>   release upgrader doesn't re-enable updates after failure
>
> Status in ubuntu-release-upgrader package in Ubuntu:
>   Expired
> Status in ubuntu-release-upgrader source package in Bionic:
>   Expired
>
> Bug description:
>   If a release upgrade fails (my example is in a failure to calculate
>   the upgrade: https://bugs.launchpad.net/bugs/1726180) the software
>   sources are reset but updates are not re-enabled,   This has meant in
>   my case going a month without updates, which introduces a security
>   exposure to my system.
>
>   In my case, the first two updates on the "Updates" tab of software
>   sources should have been re-enabled (zesty-security and zesty-
>   updates), but were not.
>
>   Expected behaviour:  if the release upgrader cannot complete the
>   upgrade, it should reinstate the software sources as they were prior
>   to the upgrade.
>
>   ProblemType: Bug
>   DistroRelease: Ubuntu 17.04
>   Package: ubuntu-release-upgrader-core 1:17.04.10
>   ProcVersionSignature: Ubuntu 4.10.0-38.42-generic 4.10.17
>   Uname: Linux 4.10.0-38-generic x86_64
>   ApportVersion: 2.20.4-0ubuntu4.9
>   Architecture: amd64
>   CrashDB: ubuntu
>   CurrentDesktop: Unity:Unity7
>   Date: Sun Dec 10 23:00:41 2017
>   PackageArchitecture: all
>   SourcePackage: ubuntu-release-upgrader
>   Symptom: ubuntu-release-upgrader
>   UpgradeStatus: Upgraded to zesty on 2017-12-09 (1 days ago)
>   VarLogDistupgradeTermlog:
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions
>
-- 

Sent from my phone.  07952 932 823

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Brian Murray]

I did an audit of the release upgrader code and found a couple of spots
where the upgrade may not have been rolled back to the previous release
and fixed them here.

https://bazaar.launchpad.net/~ubuntu-core-dev/ubuntu-release-
upgrader/trunk/revision/3102

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Francis Ginther]

** Tags added: id-5a579272c94f7561416efca8

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Francis Ginther]

** Tags added: id-5a32a5447424d161c8ae4beb

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Launchpad Bug Tracker]

[Expired for ubuntu-release-upgrader (Ubuntu Bionic) because there has
been no activity for 60 days.]

** Changed in: ubuntu-release-upgrader (Ubuntu Bionic)
   Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Simon Lambourn]

I'm really sorry but I have failed to re-create the bug on my own
system.   As I didn't discover the problem for at least a month, I can't
remember exactly when it occurred or what I did to make it happen.   I
do remember that after the first attempt to upgrade, there was a problem
with using the "revert" button on the Software Sources application,
which re-enabled all the Artful sources even though I hadn't upgraded -
so I had to manually alter the /etc/apt/sources.list to go back to
Zesty.   I'm pretty sure that I would have enabled all the Zesty sources
including updates, as the sources.list is not that complicated.

However I can't tell you how this happened, so regrettably I think I
have to withdraw the bug report (or at least ask you to do so).   I
apologise for wasting your time on this one.

** Attachment added: "/etc/apt/sources.list"
   
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+attachment/5023303/+files/sources.list

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Brian Murray]

I've tried to recreate this by installing nvidia-libopencl1-304 and
virt-viewer on Ubuntu 17.04 to ensure my upgrade to 17.10 will fail and
the upgrade process failed in the same way that is show in the
Mainlog.txt file attached to this bug report and the bug which was
linked to in the description.

2017-12-14 10:29:06,946 DEBUG need_server_mode(): run in 'desktop' mode, 
(because of pkg 'ubuntu-desktop')
2017-12-14 10:29:07,299 ERROR Dist-upgrade failed: 'E:Error, 
pkgProblemResolver::Resolve generated breaks, this may be caused by held 
packages.'
2017-12-14 10:29:07,301 DEBUG abort called
2017-12-14 10:29:07,302 DEBUG openCache()
2017-12-14 10:29:07,302 DEBUG failed to SystemUnLock() (E:Not locked) 
2017-12-14 10:29:09,558 DEBUG /openCache(), new cache size 87326

However, my /etc/apt/sources.list file is properly restored whether I
use my mirror of the Ubuntu archive or an official mirror fo the
archive. Could you provide some more details as to how this situation
came about? Its quite serious and we'd like to sort it out.

** Changed in: ubuntu-release-upgrader (Ubuntu Bionic)
   Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Steve Langasek]

** Changed in: ubuntu-release-upgrader (Ubuntu)
   Importance: Undecided => High

** Also affects: ubuntu-release-upgrader (Ubuntu Bionic)
   Importance: High
   Status: New

** Tags removed: rls-bb-incoming

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Brian Murray]

** Tags added: rls-bb-incoming

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Ubuntu Foundations Team Bug Bot]

** Tags added: zesty2artful

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1737445] Re: release upgrader doesn't re-enable updates after failure

[Leonidas S. Barbosa]

** Information type changed from Private Security to Public

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1737445

Title:
  release upgrader doesn't re-enable updates after failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1737445/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs