[Bug 1746871] Re: Postgresql service unit name wrongly cutted
The attachment "needrestart-2.6-fix-erroneous-assignation-in-if- statements.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1746871 Title: Postgresql service unit name wrongly cutted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/1746871/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1746871] Re: Postgresql service unit name wrongly cutted
I gave a quick look at the `/usr/sbin/needrestart` and the problem seems to be with one (or two) erroneous `if()` statements that performs an affectation to the `$value` instead of doing a regexp match test. After applying the attached patch, the `postgresql@9.6-main.service` service is correctly detected : --8<-- # needrestart -r l Scanning processes... Scanning candidates... Scanning linux images... Running kernel seems to be up-to-date. Services to be restarted: systemctl restart postgresql@9.6-main.service No containers need to be restarted. -->8-- ** Patch added: "needrestart-2.6-fix-erroneous-assignation-in-if-statements.diff" https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/1746871/+attachment/5151208/+files/needrestart-2.6-fix-erroneous-assignation-in-if-statements.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1746871 Title: Postgresql service unit name wrongly cutted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/1746871/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1746871] Re: Postgresql service unit name wrongly cutted
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: needrestart (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1746871 Title: Postgresql service unit name wrongly cutted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/1746871/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1746871] Re: Postgresql service unit name wrongly cutted
This also affects other services containing a dot in the name, like php7.0-fpm.service, which gets truncated to "0-fpm.service" which obviously can't be found. This has been fixed in needrestart 2.7, see https://github.com/liske/needrestart/pull/19. As the fix seems trivial to me maybe this can be fixed in ubuntu Xenial version of needrestart, as I'm sure many people face this bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1746871 Title: Postgresql service unit name wrongly cutted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/1746871/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
