[Bug 1755681] Re: pstree crashes on fclose(NULL)
*** This bug is a duplicate of bug 1837444 *** https://bugs.launchpad.net/bugs/1837444 Lucas identified this beign the same as one that he works on. Marking as duplicate. ** This bug has been marked a duplicate of bug 1837444 pstree seg fault -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755681 Title: pstree crashes on fclose(NULL) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1755681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755681] Re: pstree crashes on fclose(NULL)
My reliable repro was actually a much less intensive `watch 'pstree -aup' | grep "..."` With the default watch interval of 2 seconds, I would reliably hit this 1-2 times per day with it running continuously in the background. Process churn isn't crazy, but I am regularly compiling various things. I actually debugged the issue to make sure it was consistent and not RAM failing (this is in a desktop with non-ECC RAM). I hate to say it's not critical at the risk of this ticket being closed WONT_FIX but it is not actually a critical issue. Would be nice to have fixed, even if it is just an if()-guard added to the existing version. How involved is that process? Is it something I could submit a patch for? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755681 Title: pstree crashes on fclose(NULL) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1755681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755681] Re: pstree crashes on fclose(NULL)
Note: I'm asking as a SRU [1] usually needs sort of a reproduction steps guide to verify - and since I fail to recreate ... [1]: https://wiki.ubuntu.com/StableReleaseUpdates -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755681 Title: pstree crashes on fclose(NULL) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1755681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755681] Re: pstree crashes on fclose(NULL)
The offending line you identified was not fixed as a bug fix that one could directly backport, but instead as part of [1] Instead for an SRU we would need a more surgical approach, maybe just a check to the pointer like: if (file != NULL) fclose(file); I'm not so sure about the priority of this, how regular are you hitting that on 16.04.4? I had no rapid process spawn/kill workload, but in 10/10 tries I didn't hit that. Then I ran: $ stress-ng --fork 4 --vfork 4 --exec 4 --metrics-brief But still 10/10 pstree runs worked (and that is more than 100k forks/exits per sec). OTOH the change seems trivial, never the less I'd be interested how (reliably) you hit that. [1]: https://gitlab.com/psmisc/psmisc/commit/265fa43ee48898001130b90d3656d48af5d241aa ** Tags added: server-next ** Changed in: psmisc (Ubuntu Xenial) Status: New => Confirmed ** Changed in: psmisc (Ubuntu Xenial) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755681 Title: pstree crashes on fclose(NULL) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1755681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755681] Re: pstree crashes on fclose(NULL)
I think you are right here, not sure what happened to the triager of march 14th. 23 is in Artful and Bionic already. So the question here is to backport via an SRU to Xenial ** Also affects: psmisc (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: psmisc (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755681 Title: pstree crashes on fclose(NULL) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1755681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755681] Re: pstree crashes on fclose(NULL)
After two weeks of no response, is this the wrong venue? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755681 Title: pstree crashes on fclose(NULL) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/1755681/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
