[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Merge proposal linked: https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/389234 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Description changed: [Impact] * Service is running uselessly which is consuming a few cycles/memory as well as raising general concerns e.g. on minimizing attack surface of a system. * This is also the only service in a default server install which pulls in the network-online.target, which has implications for boot ordering and speed in various configurations. * Fix by switching to socket activation [Test Case] * After installing open-iscsi (which is default installed) the service iscsid is running which is mostly useless - this is a bit critical, as we don't want to stop a running service. - so you have two cases 1. uninstall the package before upgrade; then install the new version. should be service off, socket on 2. upgrade install, should have service (still) on, socket enabled. 3. after 2. reboot should be service off, socket on * Also ensure that iscsid.service should come up as needed # should be off $ systemctl status iscsid.service iscsid.socket $ iscsiadm -m discovery -t sendtargets -p 127.0.0.1 # should be enabled now $ systemctl status iscsid.service iscsid.socket [Regression Potential] * We were discussing if we shall SRU this. First of all the change should work as in the new version, abstract sockets are not super new. * We were concerned that one would have e.g. scripts and other upper level code that does like: if service-is-not-running; then break; else do what you should do This would give up before socket-triggering it which might be too much to SRU. On a Upgrade to a newer release such minor adaptions are usual, but for SRUs? But in any config using it it will run, and as slangasek outlined " I think anyone checking for the running status of an open-iscsi service, on a system that does not have any iscsi targets configured, is writing buggy code and that should not be catered to in the face of the significant impact this bug has on all other users of Ubuntu Server." * But also we don't stop the service on upgrade (for safety of the data), so you'd have four different Bionics a) old iscsid.service runnign by default b) upgraded, but not rebooted iscsid.service still running c) upgraded, rebooted iscid.service disabled, iscsid.socket running d) new deploy after this (e.g. new cloud image) iscid.service disabled, iscsid.socket running a+b are similar as well as c+d. * If anyone strictly needs the old behavior it is a config, so one can "systemctl enable iscsid.service" and is done. * OTOH in our discussion it was agreed that the upgrade regression we fix outweighs the potential regression. [Other Info] - - * n/a + * The SRU of this change caused a regression described in bug 1802354. --- In bionic, the open-iscsi systemd unit has the following guards to keep it from running on systems with no iscsi targets configured: # Must have some pre-defined targets to login to ConditionDirectoryNotEmpty=|/etc/iscsi/nodes # or have a session to use via iscsid ConditionDirectoryNotEmpty=|/sys/class/iscsi_session However, iscsid starts from a separate unit and does not include this check. Thus, iscsid starts on every Ubuntu Server install, whether or not it has anything to do. We should replicate these unit conditionals to the iscsid unit, to ensure the daemon doesn't run (consuming memory, and slowing boot) when not needed. Related bugs: * bug 1630946: ubuntu-server depends on open-iscsi and runs iscsid + * bug 1802354: iscsid does not run if there are only initramfs initiated targets -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
This bug was fixed in the package open-iscsi - 2.0.874-5ubuntu2.2 --- open-iscsi (2.0.874-5ubuntu2.2) bionic; urgency=medium * make iscsid socket activated to only activate it as-needed (LP: #1755858) - debian/iscsid.socket: systemd socket file for iscsid - debian/open-iscsi.service: do not start or check iscsid.service - debian/rules: install and enable iscsid.socket - debian/patches/iscid-conf-use-systemd.socket-patch: default to the socket - debian/open-iscsi.postinst: + run restart logic only if service is running on upgrade + drop no more reachable upgrade path that affects iscsid + disable iscsid.service on upgrade + handle iscsid.socket to be started if the service is not running yet - debian/tests/install: fix tests to work with socket activation -- Scott Moser Fri, 07 Sep 2018 09:24:22 -0400 ** Changed in: open-iscsi (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Here is my verification of bionic proposed.
It should be considered in cooperation with open-iscsi dep8 tests
which do a iscsi root boot:
http://autopkgtest.ubuntu.com/packages/o/open-iscsi/bionic/amd64
Below is sufficient for the 'Test Case' section of the SRU Template,
it would be nice to see an actual user of open-iscsi test this.
### Setup
###
Launched a fresh bionic image of 20180927.
Notes:
* to avoid noise below I have done 'apt-get autoremove' (LP: #1721035)
* The following is 'connect-abstract-socket.py' which is used below.
#!/usr/bin/python3
from socket import socket, AF_UNIX, SOCK_STREAM
import sys
socket(AF_UNIX, SOCK_STREAM).connect(('\0' + sys.argv[1]))
print("Connected to @%s" % sys.argv[1])
### fresh boot of image.
$ cat /etc/cloud/build.info
build_name: server
serial: 20180927
$ dpkg-query --show open-iscsi
open-iscsi 2.0.874-5ubuntu2.1
$ systemctl status --no-pager --full iscsid.service iscsid.socket
open-iscsi.service
● iscsid.service - iSCSI initiator daemon (iscsid)
Loaded: loaded (/lib/systemd/system/iscsid.service; enabled; vendor preset:
enabled)
Active: active (running) since Mon 2018-10-01 19:57:30 UTC; 3min 12s ago
Docs: man:iscsid(8)
Process: 764 ExecStart=/sbin/iscsid (code=exited, status=0/SUCCESS)
Process: 728 ExecStartPre=/lib/open-iscsi/startup-checks.sh (code=exited,
status=0/SUCCESS)
Main PID: 768 (iscsid)
Tasks: 2 (limit: 2362)
CGroup: /system.slice/iscsid.service
├─767 /sbin/iscsid
└─768 /sbin/iscsid
Oct 01 19:57:30 bionic-20181001-195627 systemd[1]: Starting iSCSI initiator
daemon (iscsid)...
Oct 01 19:57:32 bionic-20181001-195627 iscsid[767]: iSCSI daemon with pid=768
started!
Oct 01 19:57:30 bionic-20181001-195627 systemd[1]: Started iSCSI initiator
daemon (iscsid).
$ systemctl status open-iscsi.service --full --no-pager
● open-iscsi.service - Login to default iSCSI targets
Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor
preset: enabled)
Active: inactive (dead)
Condition: start condition failed at Mon 2018-10-01 19:57:30 UTC; 4min 13s ago
├─ ConditionDirectoryNotEmpty=|/etc/iscsi/nodes was not met
└─ ConditionDirectoryNotEmpty=|/sys/class/iscsi_session was not met
Docs: man:iscsiadm(8)
man:iscsid(8)
### Enable proposed
$ line=$(awk '$1 == "deb" && $2 ~ /ubuntu.com/ {
printf("%s %s %s-proposed main universe\n", $1, $2, rel); exit(0) };
' "rel=$rel" /etc/apt/sources.list)
$ echo "$line" | sudo tee /etc/apt/sources.list.d/proposed.list
deb http://nova.clouds.archive.ubuntu.com/ubuntu/ bionic-proposed main universe
$ sudo apt-get update -q
$ apt-cache policy open-iscsi
open-iscsi:
Installed: 2.0.874-5ubuntu2.1
Candidate: 2.0.874-5ubuntu2.2
Version table:
2.0.874-5ubuntu2.2 500
500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-proposed/main
amd64 Packages
*** 2.0.874-5ubuntu2.1 500
500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-updates/main
amd64 Packages
100 /var/lib/dpkg/status
2.0.874-5ubuntu2 500
500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic/main amd64
Packages
### Test Case 1
### uninstall before upgrade
$ sudo apt-get --purge remove open-iscsi
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be REMOVED:
open-iscsi* ubuntu-server*
0 upgraded, 0 newly installed, 2 to remove and 51 not upgraded.
After this operation, 1461 kB disk space will be freed.
Do you want to continue? [Y/n]
(Reading database ... 59669 files and directories currently installed.)
Removing ubuntu-server (1.417) ...
Removing open-iscsi (2.0.874-5ubuntu2.1) ...
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
Processing triggers for man-db (2.8.3-2) ...
(Reading database ... 59632 files and directories currently installed.)
Purging configuration files for open-iscsi (2.0.874-5ubuntu2.1) ...
Processing triggers for ureadahead (0.100.0-20) ...
Processing triggers for systemd (237-3ubuntu10.3) ...
$ sudo apt-get install open-iscsi
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
open-iscsi
0 upgraded, 1 newly installed, 0 to remove and 51 not upgraded.
Need to get 280 kB of archives.
After this operation, 1417 kB of additional disk space will be used.
Get:1 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 op
en-iscsi amd64 2.0.874-5ubuntu2.2 [280 kB]
Fetched 280 kB in 0s (711 kB/s)
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
@Chris, For what its worth, there is a process to build maas images with -proposed enabled at https://gist.github.com/smoser/8a34b1713badb643dee3a25e5cf134b8 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
We do not usually do this type of validation as there is no Proposed pocket MAAS image or cloud image. An image would need to be build for just this package. The only alternative is to manually upgrade the images after they are applied to the nodes/pods/and instances. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
We do not typically pull from proposed. I would need to look into the process. The usual trouble is that once you turn on proposed, you On Mon, Oct 1, 2018 at 10:47 AM Dan Streetman wrote: > @cgregan are you able to verify the bionic-proposed pkg? > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1755858 > > Title: > iscsid autostarts on all servers when it has nothing to do > > To manage notifications about this bug go to: > > https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions > -- Chris Gregan Quality Assurance Manager Field Engineering/CPE cgre...@irc.canonical.com -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
@cgregan are you able to verify the bionic-proposed pkg? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Hello Steve, or anyone else affected, Accepted open-iscsi into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/open- iscsi/2.0.874-5ubuntu2.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: open-iscsi (Ubuntu Bionic) Status: Triaged => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Description changed: [Impact] * Service is running uselessly which is consuming a few cycles/memory as - well as rasising general concerns e.g. on minimizing attack surfcae of + well as raising general concerns e.g. on minimizing attack surface of a system. * This is also the only service in a default server install which pulls in the network-online.target, which has implications for boot ordering and speed in various configurations. * Fix by switching to socket activation [Test Case] * After installing open-iscsi (which is default installed) the service iscsid is running which is mostly useless -- this is a bit critical, as we don't want to stop a running service. -- so you have two cases -1. uninstall the package before upgrade; then install the new version. - should be service off, socket on -2. upgrade install, should have service (still) on, socket enabled. -3. after 2. reboot should be service off, socket on + - this is a bit critical, as we don't want to stop a running service. + - so you have two cases + 1. uninstall the package before upgrade; then install the new version. + should be service off, socket on + 2. upgrade install, should have service (still) on, socket enabled. + 3. after 2. reboot should be service off, socket on * Also ensure that iscsid.service should come up as needed -# should be off -$ systemctl status iscsid.service iscsid.socket -$ iscsiadm -m discovery -t sendtargets -p 127.0.0.1 -# should be enabled now -$ systemctl status iscsid.service iscsid.socket - + # should be off + $ systemctl status iscsid.service iscsid.socket + $ iscsiadm -m discovery -t sendtargets -p 127.0.0.1 + # should be enabled now + $ systemctl status iscsid.service iscsid.socket [Regression Potential] - * We were discussing if we shall SRU this. First of all the change should -work as in the new version, abstract sockets are not super new. + * We were discussing if we shall SRU this. First of all the change should + work as in the new version, abstract sockets are not super new. * We were concerned that one would have e.g. scripts and other upper level code that does like: if service-is-not-running; then break; else do what you should do This would give up before socket-triggering it which might be too much to SRU. On a Upgrade to a newer release such minor adaptions are usual, but for SRUs? -But in any config using it it will run, and as slangasek outlined " I -think anyone checking for the running status of an open-iscsi service, -on a system that does not have any iscsi targets configured, is writing -buggy code and that should not be catered to in the face of the -significant impact this bug has on all other users of Ubuntu Server." + But in any config using it it will run, and as slangasek outlined " I + think anyone checking for the running status of an open-iscsi service, + on a system that does not have any iscsi targets configured, is writing + buggy code and that should not be catered to in the face of the + significant impact this bug has on all other users of Ubuntu Server." * But also we don't stop the service on upgrade (for safety of the data), so you'd have four different Bionics a) old iscsid.service runnign by default b) upgraded, but not rebooted iscsid.service still running c) upgraded, rebooted iscid.service disabled, iscsid.socket running d) new deploy after this (e.g. new cloud image) iscid.service disabled, iscsid.socket running a+b are similar as well as c+d. - * If anyone strictly needs the old behavior it is a config, so one can -"systemctl enable iscsid.service" and is done. - * OTOH in our discussion it was agreed that the upgrade regression we fix -outweighs the potential regression. + * If anyone strictly needs the old behavior it is a config, so one can + "systemctl enable iscsid.service" and is done. + * OTOH in our discussion it was agreed that the upgrade regression we fix + outweighs the potential regression. [Other Info] * n/a --- In bionic, the open-iscsi systemd unit has the following guards to keep it from running on systems with no iscsi targets configured: # Must have some pre-defined targets to login to ConditionDirectoryNotEmpty=|/etc/iscsi/nodes # or have a session to use via iscsid ConditionDirectoryNotEmpty=|/sys/class/iscsi_session However, iscsid starts from a separate unit and does not include this check. Thus, iscsid starts on every Ubuntu Server install, whether or not it has anything to do. We should replicate these unit conditionals to the iscsid unit, to ensure the daemon doesn't run (consuming memory, and slowing boot) when not needed. Related bugs: * bug 1630946: ubuntu-server depends on
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
@smoser, @paelzer, your bionic upload has been sitting for ~10 days in the upload queue, and it's blocking upload for bug 1791108. Can you shake the sru trees to get that upload approved, or can you ask for it to be rejected so i can upload for the other bug? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
FYI - Smoser and I started to prep SRU work for this. But once we agree on the content I'd be really happy if someone who was affected by the upgrade issue (and therefore has a valid and "real" iscsi setup) would test from the PPA before shoving that into the SRU queue. I subscribed Chris Gregan who I was told has a reproducer being affected by this (I hope that is correct) - if so once we have a PPA up would you be able to verify it? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Description changed: [Impact] * Service is running uselessly which is consuming a few cycles/memory as well as rasising general concerns e.g. on minimizing attack surfcae of a system. - * This is also the only service in a default server install which pulls + * This is also the only service in a default server install which pulls in the network-online.target, which has implications for boot ordering and speed in various configurations. * Fix by switching to socket activation [Test Case] * After installing open-iscsi (which is default installed) the service iscsid is running which is mostly useless - * After the upgrade only the iscsid.socket should run - * Ensure that iscsid.service should come up as needed +- this is a bit critical, as we don't want to stop a running service. +- so you have two cases +1. uninstall the package before upgrade; then install the new version. + should be service off, socket on +2. upgrade install, should have service (still) on, socket enabled. +3. after 2. reboot should be service off, socket on + * Also ensure that iscsid.service should come up as needed +# should be off +$ systemctl status iscsid.service iscsid.socket +$ iscsiadm -m discovery -t sendtargets -p 127.0.0.1 +# should be enabled now +$ systemctl status iscsid.service iscsid.socket + [Regression Potential] - * I'm not sure we can/shall SRU this, but was asked to express my - thoughts in the regression potential. It is not that it would not - "work", we tested in cosmic and so far all is fine - the tools will - call the abstract socket and it will spawn. - So it is not that I see it totally "failing" - * I'd more be concerned that one would have e.g. scripts and other upper + * We were discussing if we shall SRU this. First of all the change should +work as in the new version, abstract sockets are not super new. + * We were concerned that one would have e.g. scripts and other upper level code that does like: if service-is-not-running; then break; else do what you should do This would give up before socket-triggering it which might be too much to SRU. On a Upgrade to a newer release such minor adaptions are usual, but for SRUs? +But in any config using it it will run, and as slangasek outlined " I +think anyone checking for the running status of an open-iscsi service, +on a system that does not have any iscsi targets configured, is writing +buggy code and that should not be catered to in the face of the +significant impact this bug has on all other users of Ubuntu Server." * But also we don't stop the service on upgrade (for safety of the data), so you'd have four different Bionics a) old iscsid.service runnign by default b) upgraded, but not rebooted iscsid.service still running c) upgraded, rebooted iscid.service disabled, iscsid.socket running d) new deploy after this (e.g. new cloud image) iscid.service disabled, iscsid.socket running a+b are similar as well as c+d. - * OTOH there are a few things reducing this impact, first of all this is - a config, so one can "systemctl enable iscsid.service" and will have - the old behavior - * Is this a real blocker, I'm not sure - so I documented as requested and - would want the SRU team to discuss before an upload. + * If anyone strictly needs the old behavior it is a config, so one can +"systemctl enable iscsid.service" and is done. + * OTOH in our discussion it was agreed that the upgrade regression we fix +outweighs the potential regression. [Other Info] * n/a --- In bionic, the open-iscsi systemd unit has the following guards to keep it from running on systems with no iscsi targets configured: # Must have some pre-defined targets to login to ConditionDirectoryNotEmpty=|/etc/iscsi/nodes # or have a session to use via iscsid ConditionDirectoryNotEmpty=|/sys/class/iscsi_session However, iscsid starts from a separate unit and does not include this check. Thus, iscsid starts on every Ubuntu Server install, whether or not it has anything to do. We should replicate these unit conditionals to the iscsid unit, to ensure the daemon doesn't run (consuming memory, and slowing boot) when not needed. Related bugs: * bug 1630946: ubuntu-server depends on open-iscsi and runs iscsid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
I prepared merge proposals for both xenial and bionic. Also: - tested autopkgtest on both xenial and bionic - uploaded to [my ppa](https://launchpad.net/~smoser/+archive/ubuntu/ppa) for xenial and bionic - uploaded bionic to SRU queue -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Merge proposal linked: https://code.launchpad.net/~smoser/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/354478 ** Merge proposal linked: https://code.launchpad.net/~smoser/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/354483 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
To be explicit, I don't think that the risk of regression here is such that we should not SRU this to bionic. I think anyone checking for the running status of an open-iscsi service, on a system that does not have any iscsi targets configured, is writing buggy code and that should not be catered to in the face of the significant impact this bug has on all other users of Ubuntu Server. ** Changed in: open-iscsi (Ubuntu Bionic) Assignee: Dimitri John Ledkov (xnox) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Nominated this for xenial based on bug 1651497. ** Also affects: open-iscsi (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Changed in: open-iscsi (Ubuntu Bionic) Assignee: (unassigned) => Dimitri John Ledkov (xnox) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Description changed: [Impact] - * Service is running uselessly which is consuming a few cycles/memory as -well as rasising general concerns e.g. on minimizing attack surfcae of -a system. + * Service is running uselessly which is consuming a few cycles/memory as + well as rasising general concerns e.g. on minimizing attack surfcae of + a system. - * Fix by switching to socket activation + * This is also the only service in a default server install which pulls + in the network-online.target, which has implications for boot ordering + and speed in various configurations. + + * Fix by switching to socket activation [Test Case] - * After installing open-iscsi (which is default installed) the service -iscsid is running which is mostly useless - * After the upgrade only the iscsid.socket should run - * Ensure that iscsid.service should come up as needed + * After installing open-iscsi (which is default installed) the service + iscsid is running which is mostly useless + * After the upgrade only the iscsid.socket should run + * Ensure that iscsid.service should come up as needed [Regression Potential] - * I'm not sure we can/shall SRU this, but was asked to express my -thoughts in the regression potential. It is not that it would not -"work", we tested in cosmic and so far all is fine - the tools will -call the abstract socket and it will spawn. -So it is not that I see it totally "failing" - * I'd more be concerned that one would have e.g. scripts and other upper -level code that does like: - if service-is-not-running; then break; else do what you should do -This would give up before socket-triggering it which might be too much -to SRU. On a Upgrade to a newer release such minor adaptions are usual, -but for SRUs? - * But also we don't stop the service on upgrade (for safety of the data), -so you'd have four different Bionics -a) old iscsid.service runnign by default -b) upgraded, but not rebooted iscsid.service still running -c) upgraded, rebooted iscid.service disabled, - iscsid.socket running -d) new deploy after this (e.g. new cloud image) iscid.service disabled, - iscsid.socket running -a+b are similar as well as c+d. - * OTOH there are a few things reducing this impact, first of all this is -a config, so one can "systemctl enable iscsid.service" and will have -the old behavior - * Is this a real blocker, I'm not sure - so I documented as requested and -would want the SRU team to discuss before an upload. - + * I'm not sure we can/shall SRU this, but was asked to express my + thoughts in the regression potential. It is not that it would not + "work", we tested in cosmic and so far all is fine - the tools will + call the abstract socket and it will spawn. + So it is not that I see it totally "failing" + * I'd more be concerned that one would have e.g. scripts and other upper + level code that does like: + if service-is-not-running; then break; else do what you should do + This would give up before socket-triggering it which might be too much + to SRU. On a Upgrade to a newer release such minor adaptions are usual, + but for SRUs? + * But also we don't stop the service on upgrade (for safety of the data), + so you'd have four different Bionics + a) old iscsid.service runnign by default + b) upgraded, but not rebooted iscsid.service still running + c) upgraded, rebooted iscid.service disabled, + iscsid.socket running + d) new deploy after this (e.g. new cloud image) iscid.service disabled, + iscsid.socket running + a+b are similar as well as c+d. + * OTOH there are a few things reducing this impact, first of all this is + a config, so one can "systemctl enable iscsid.service" and will have + the old behavior + * Is this a real blocker, I'm not sure - so I documented as requested and + would want the SRU team to discuss before an upload. [Other Info] - - * n/a + + * n/a --- In bionic, the open-iscsi systemd unit has the following guards to keep it from running on systems with no iscsi targets configured: # Must have some pre-defined targets to login to ConditionDirectoryNotEmpty=|/etc/iscsi/nodes # or have a session to use via iscsid ConditionDirectoryNotEmpty=|/sys/class/iscsi_session However, iscsid starts from a separate unit and does not include this check. Thus, iscsid starts on every Ubuntu Server install, whether or not it has anything to do. We should replicate these unit conditionals to the iscsid unit, to ensure the daemon doesn't run (consuming memory, and slowing boot) when not needed. Related bugs: * bug 1630946: ubuntu-server depends on open-iscsi and runs iscsid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Description changed: + [Impact] + + * Service is running uselessly which is consuming a few cycles/memory as +well as rasising general concerns e.g. on minimizing attack surfcae of +a system. + + * Fix by switching to socket activation + + [Test Case] + + * After installing open-iscsi (which is default installed) the service +iscsid is running which is mostly useless + * After the upgrade only the iscsid.socket should run + * Ensure that iscsid.service should come up as needed + + [Regression Potential] + + * I'm not sure we can/shall SRU this, but was asked to express my +thoughts in the regression potential. It is not that it would not +"work", we tested in cosmic and so far all is fine - the tools will +call the abstract socket and it will spawn. +So it is not that I see it totally "failing" + * I'd more be concerned that one would have e.g. scripts and other upper +level code that does like: + if service-is-not-running; then break; else do what you should do +This would give up before socket-triggering it which might be too much +to SRU. On a Upgrade to a newer release such minor adaptions are usual, +but for SRUs? + * But also we don't stop the service on upgrade (for safety of the data), +so you'd have four different Bionics +a) old iscsid.service runnign by default +b) upgraded, but not rebooted iscsid.service still running +c) upgraded, rebooted iscid.service disabled, + iscsid.socket running +d) new deploy after this (e.g. new cloud image) iscid.service disabled, + iscsid.socket running +a+b are similar as well as c+d. + * OTOH there are a few things reducing this impact, first of all this is +a config, so one can "systemctl enable iscsid.service" and will have +the old behavior + * Is this a real blocker, I'm not sure - so I documented as requested and +would want the SRU team to discuss before an upload. + + + [Other Info] + + * n/a + + --- + In bionic, the open-iscsi systemd unit has the following guards to keep it from running on systems with no iscsi targets configured: # Must have some pre-defined targets to login to ConditionDirectoryNotEmpty=|/etc/iscsi/nodes # or have a session to use via iscsid ConditionDirectoryNotEmpty=|/sys/class/iscsi_session However, iscsid starts from a separate unit and does not include this check. Thus, iscsid starts on every Ubuntu Server install, whether or not it has anything to do. We should replicate these unit conditionals to the iscsid unit, to ensure the daemon doesn't run (consuming memory, and slowing boot) when not needed. Related bugs: * bug 1630946: ubuntu-server depends on open-iscsi and runs iscsid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Changed in: open-iscsi (Ubuntu Bionic) Status: Won't Fix => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Done for Cosmic. Steve has mentioned he'd like to see an SRU of this to Bionic, but I think the change carries too much regression potential for an SRU. Please feel free to discuss. To make it clear I'm not working on Bionic, I'll set Won't Fix for now. ** Changed in: open-iscsi (Ubuntu Bionic) Status: Triaged => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
This bug was fixed in the package open-iscsi - 2.0.874-5ubuntu4 --- open-iscsi (2.0.874-5ubuntu4) cosmic; urgency=medium * debian/tests/install: ignore the potential stderr of the probing command that is meant to activate iscsid indirectly via the socket. open-iscsi (2.0.874-5ubuntu3) cosmic; urgency=medium * make iscsid socket activated to only activate it as-needed (LP: #1755858) - debian/iscsid.socket: systemd socket file for iscsid - debian/open-iscsi.service: do not start or check iscsid.service - debian/rules: install and enable iscsid.socket - debian/patches/iscid-conf-use-systemd.socket-patch: default to the socket - debian/open-iscsi.postinst: + run restart logic only if service is running on upgrade + drop no more reachable upgrade path that affects iscsid + disable iscsid.service on upgrade + handle iscsid.socket to be started if the service is not running yet - debian/tests/install: fix tests to work with socket activation -- Christian Ehrhardt Wed, 30 May 2018 15:42:12 +0200 ** Changed in: open-iscsi (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Ok, the forth was a charm - so on LP Infra it seems to be flaky which is a separate issue. This is the working log from the ppa: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic-ci-train-ppa-service-3279/cosmic/amd64/o/open-iscsi/20180531_060452_bd5ba@/log.gz That said the real issue is fixed in the package I will upload. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
This now worked a few times locally (4/4) but never on Infra (3/3). I first thought it would be a timeout for qemu-system-x86_64: terminating on signal 15 from pid 25607 (timeout) xkvm returned 124 in 3600s But that is only because it boots into emergency console and hangs there: You are in emergency mode. After logging in, type "journalctl -xb" to view While locally (autopkgtest in VM) it boots fine xkvm returned 0 in 200s cleaning up tgt mount tgt-boot-test-4mbUyK ok Ran 3 tests in 230.082s The other arches are good, because the cloud image based test is only run on amd64. All other tests run everywhere and are good. Here a log of one of the many good local runs: http://paste.ubuntu.com/p/cvMMb9GDTV/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
The hit in "testsuite" is more complex, as it does not reproduce for me. >From the log: == ERROR: test_tgt_boot (__main__.CloudImageTest) -- Traceback (most recent call last): File "/tmp/autopkgtest.BEvlMr/build.15A/src/debian/tests/test-open-iscsi.py", line 274, in test_tgt_boot subprocess.check_call(cmd) File "/usr/lib/python2.7/subprocess.py", line 190, in check_call raise CalledProcessError(retcode, cmd) CalledProcessError: Command '['/tmp/autopkgtest.BEvlMr/build.15A/src/debian/tests/tgt-boot-test', '-v', '--netdev=user,net=10.1.1.0/24,host=10.1.1.2,dns=10.1.1.4,dnssearch=example.com', '--disk=/tmp/tmpin5Hu3/output-disk.img,serial=output-disk', '--user-data-add=/tmp/tmpin5Hu3/user-data', '/tmp/autopkgtest.BEvlMr/build.15A/src/debian/tests/cosmic.d/disk.img', '/tmp/autopkgtest.BEvlMr/build.15A/src/debian/tests/cosmic.d/kernel', '/tmp/autopkgtest.BEvlMr/build.15A/src/debian/tests/cosmic.d/initrd']' returned non-zero exit status 124 This more seems than it might have timed out, also this is not only not reproducible (locally) but also only affecting x86_64. I'll have to wait for the LP Infra rerun on Bileto on this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
To be a bit faster (in case it is a race) than last time running with 4CPU and 2G memory this time. $ autopkgtest --apt-upgrade --shell-fail --no-built-binaries --apt-pocket=proposed=src:open-iscsi open-iscsi_2.0.874-5ubuntu3.dsc -- qemu --qemu-options='-cpu host' --cpus 4 --ram-size=2048 ~/autopkgtest-cosmic-amd64.img Ok, I can at least reproduce now ... Eventually it is easier than I thought. We have an intentional no-op (that can fail and already is on an || /bin/true). This might emit to stderr and that breaks the test. I logged in and all the status it wanted to test after this command is actually good. Now that Bileto tests work again I'll respin a fix and test on LP infra before the fix-upload to the archive. Lets see if it stumbles over more after this, to have at least only one fixup-upload. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
This worked in https://bileto.ubuntu.com/#/ticket/3268 when tested before (ppa now abandoned due to upload taking the version). I also had amd64 tests running locally (due to that the fix to the tests that I had added) But on the final migration it stumbles over it on LP Infra. So it might be a race?!? Example: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic/cosmic/amd64/o/open-iscsi/20180530_111813_16285@/log.gz I need to check what is going on there other than local. Starting a new run locally ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Changed in: open-iscsi (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Also reported to Debian and linked up their bug. It should help them just as much. And if they accept it maintenance/merges will be easier, while OTOH if they find issues we can fix them in our Delta - so either way it is good to make it known there. ** Bug watch added: Debian Bug tracker #900397 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900397 ** Also affects: open-iscsi (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900397 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
MP is reviewed and accepted, new version pushed to Cosmic as https://launchpad.net/ubuntu/+source/open-iscsi/2.0.874-5ubuntu3 I ran and adapted the tests, but lets see how migration works if there are any surprises. ** Changed in: open-iscsi (Ubuntu) Status: Triaged => Fix Committed ** Changed in: open-iscsi (Ubuntu) Assignee: Mathieu Trudel-Lapierre (cyphermox) => (unassigned) ** Changed in: open-iscsi (Ubuntu Bionic) Assignee: Mathieu Trudel-Lapierre (cyphermox) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Description changed: In bionic, the open-iscsi systemd unit has the following guards to keep it from running on systems with no iscsi targets configured: # Must have some pre-defined targets to login to ConditionDirectoryNotEmpty=|/etc/iscsi/nodes # or have a session to use via iscsid ConditionDirectoryNotEmpty=|/sys/class/iscsi_session However, iscsid starts from a separate unit and does not include this check. Thus, iscsid starts on every Ubuntu Server install, whether or not it has anything to do. We should replicate these unit conditionals to the iscsid unit, to ensure the daemon doesn't run (consuming memory, and slowing boot) when not needed. + + Related bugs: + * bug 1630946: ubuntu-server depends on open-iscsi and runs iscsid Edit ** Description changed: In bionic, the open-iscsi systemd unit has the following guards to keep it from running on systems with no iscsi targets configured: # Must have some pre-defined targets to login to ConditionDirectoryNotEmpty=|/etc/iscsi/nodes # or have a session to use via iscsid ConditionDirectoryNotEmpty=|/sys/class/iscsi_session However, iscsid starts from a separate unit and does not include this check. Thus, iscsid starts on every Ubuntu Server install, whether or not it has anything to do. We should replicate these unit conditionals to the iscsid unit, to ensure the daemon doesn't run (consuming memory, and slowing boot) when not needed. Related bugs: - * bug 1630946: ubuntu-server depends on open-iscsi and runs iscsid Edit + * bug 1630946: ubuntu-server depends on open-iscsi and runs iscsid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/346739 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Merge proposal unlinked: https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/346739 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
FYI: on the MP I'm iterating on different degrees of not-fun I have with dh_* in regard to control them to do exactly what I need for open-iscsi. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Lets get it right in Cosmic also to see what we come up with and if you then say this should be safe for an SRU I'll follow your guidance :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
On Wed, May 23, 2018 at 01:58:05PM -, Christian Ehrhardt wrote: > Fortunately we are so early in the cycle that I'd say if reviews and > tests seem good we can change it. And if on any image/maas/cloud tests > we break things we didn't expect there is time enough to revert it > before cosmic is entering any Freeze. I think we should be concerned about SRUing this change to bionic as well. iscsid.service declares Wants=network-online.target, which slows down the boot in cases where the system for whatever reason can't confirm right away that the network is up. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Fortunately we are so early in the cycle that I'd say if reviews and tests seem good we can change it. And if on any image/maas/cloud tests we break things we didn't expect there is time enough to revert it before cosmic is entering any Freeze. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
I have a test branch and build + * make iscsid socket activated to only activate it as-needed (LP: #1755858) +- debian/open-iscsi.socket: systemd socket file for iscsid +- debian/open-iscsi.service: do not start or check iscsid.service +- debian/rules: install and enable iscsid.socket +- debian/patches/iscid-conf-use-systemd.socket-patch: default to the socket Building in ppa [1] now. It is not yet up for final review, but feel free to take a look at [2] I Won't have time for it anymore for a bit, some tests on the ppa (upgrades and how they affect it as well as new installs - since it is there by default the latter meant purge+ppa+install). [1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3268 for further tests. [2]: https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/346739 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/346739 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Interesting, this worked just fine without the iscsid.conf entry as in Fedora: iscsid.startup = /bin/systemctl start iscsid.socket I need to check the code for what this is used. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Ok, this is the code path that tries to connect. It has a fallback to run this command. I think we would want anyway that this is not started in a random context, but from the socket/service. The following connect will then pick and start via the socket. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Test 1: iscsiadm -m discovery -t sendtargets -p 127.0.0.1 worked to activate it as needed Test 2: /sbin/iscsiadm -m node --loginall=automatic Not activating it, but that is fine if nothing is defined Test 3: - define something with tgt, and configure it Note: remember to load iscsi_tcp in the host if you are in a container - after that /etc/iscsi/nodes/iqn.2016-11.foo.com\:target.1.iscsi/127.0.0.1\,3260\,1/default exists Well it still counts as "no-records found" but that is fine commands are called fine And if I add a iscsid depending call is in there (added as exec pre) it works to enable it. Overall I think this could work ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Most basic tests cross check on Fedora:
First I tried a safe no-op
$ iscsiadm -m discovery -t sendtargets -p 127.0.0.1
This is working fine on fedora to activate the service
Then I tried on the fedora setup if the cmd we call would activate it.
$ /sbin/iscsiadm -m node --loginall=automatic
iscsiadm: No records found
And the service is not activated.
But that is ok, I really had no config and
/lib/systemd/system/open-iscsi.service explicitly defined RC=21 as ok for just
this reason.
If to configure something:
$ targetname="iqn.2016-11.foo.com:target.1.iscsi"
$ truncate --size 100M backingfile1
$ tgtadm --lld iscsi --op new --mode target --tid 1 -T "${targetname}"
$ tgtadm --lld iscsi --op bind --mode target --tid 1 -I ALL
$ portal="127.0.0.1:3260"
$ iscsiadm --mode discovery --type sendtargets --portal 127.0.0.1
$ iscsiadm --mode node --targetname "${targetname}" --portal 127.0.0.1:3260
--login
$ iscsiadm --mode node --targetname "${targetname}" --portal "${portal}"
--logout
This should now be usable
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1755858
Title:
iscsid autostarts on all servers when it has nothing to do
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Trying a hacky POC: 1. define iscsid.socket $ cat > /lib/systemd/system/iscsid.socket << EOF [Unit] Description=Open-iSCSI iscsid Socket Documentation=man:iscsid(8) man:iscsiadm(8) [Socket] ListenStream=@ISCSIADM_ABSTRACT_NAMESPACE [Install] WantedBy=sockets.target EOF $ systemctl enable iscsid.socket 2. remove some entries in /lib/systemd/system/open-iscsi.service - remove iscsid from Wants= - Remove the line ExecStartPre=/bin/systemctl --quiet is-active iscsid.service 3. disable and reload all files $ systemctl disable iscsid $ systemctl daemon-reload Note: we also have still /etc/init.d/iscsid, but as long as there is a .service it doesn't matter. => ok - with that on a restart it doesn't start anymore on Ubuntu Lets see if it will auto-start ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Status of a clean install in a VM and/or Container, so testable rather trivial: $ systemctl status iscsid open-iscsi ● iscsid.service - iSCSI initiator daemon (iscsid) Loaded: loaded (/lib/systemd/system/iscsid.service; enabled; vendor preset: enabled) Active: active (running) since Wed 2018-05-23 10:52:11 UTC; 7min ago Docs: man:iscsid(8) Process: 751 ExecStart=/sbin/iscsid (code=exited, status=0/SUCCESS) Process: 721 ExecStartPre=/lib/open-iscsi/startup-checks.sh (code=exited, status=0/SUCCESS) Main PID: 759 (iscsid) Tasks: 2 (limit: 548) CGroup: /system.slice/iscsid.service ├─754 /sbin/iscsid └─759 /sbin/iscsid May 23 10:52:11 b1 systemd[1]: Starting iSCSI initiator daemon (iscsid)... May 23 10:52:11 b1 systemd[1]: iscsid.service: Failed to parse PID from file /run/iscsid.pid: Invalid argument May 23 10:52:11 b1 iscsid[754]: iSCSI daemon with pid=759 started! May 23 10:52:11 b1 systemd[1]: Started iSCSI initiator daemon (iscsid). ● open-iscsi.service - Login to default iSCSI targets Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled) Active: inactive (dead) Condition: start condition failed at Wed 2018-05-23 10:52:11 UTC; 7min ago ├─ ConditionDirectoryNotEmpty=|/etc/iscsi/nodes was not met └─ ConditionDirectoryNotEmpty=|/sys/class/iscsi_session was not met Docs: man:iscsiadm(8) man:iscsid(8) It is important to note that these are not "the same" service twice. both belong to the same package: dpkg -S /lib/systemd/system/open-iscsi.service /lib/systemd/system/iscsid.service open-iscsi: /lib/systemd/system/open-iscsi.service open-iscsi: /lib/systemd/system/iscsid.service But the two are doing rather different things: open-iscsi.service: logs into iSCSI targets if some are configured (Condition stops it from doing so) - this is more a one-shot configure-devices and not a real service iscsi.service: the basic service daemone, required by the service above I think here we might learn from Fedora: Default is: [root@fedora ~]# systemctl status iscsid.socket iscsid.service ● iscsid.socket - Open-iSCSI iscsid Socket Loaded: loaded (/usr/lib/systemd/system/iscsid.socket; enabled; vendor preset: disabled) Active: active (listening) since Wed 2018-05-23 11:26:37 UTC; 9s ago Docs: man:iscsid(8) man:iscsiadm(8) Listen: @ISCSIADM_ABSTRACT_NAMESPACE (Stream) May 23 11:26:37 fedora systemd[1]: Listening on Open-iSCSI iscsid Socket. ● iscsid.service - Open-iSCSI Loaded: loaded (/usr/lib/systemd/system/iscsid.service; disabled; vendor preset: disabled) Active: inactive (dead) Docs: man:iscsid(8) man:iscsiadm(8) May 23 11:26:09 fedora systemd[1]: iscsid.service: Failed to reset devices.list: Operation not permitted May 23 11:26:09 fedora systemd[1]: Starting Open-iSCSI... And the related config in /etc/iscsid.conf says: # Use socket activation, but try to make sure the socket units are listening iscsid.startup = /bin/systemctl start iscsid.socket iscsiuio.socket (We don't have the uio, but you get the idea - initially only ensure the socket runs.) The socket then does: # systemctl cat iscsid.socket # /usr/lib/systemd/system/iscsid.socket [Unit] Description=Open-iSCSI iscsid Socket Documentation=man:iscsid(8) man:iscsiadm(8) [Socket] ListenStream=@ISCSIADM_ABSTRACT_NAMESPACE [Install] WantedBy=sockets.target The tools will reach that and activate the service: # surely fails and does nothing, but activates the service $ iscsiadm -m discovery -t st -p 1.2.3.4 Afterwards: ● iscsid.service - Open-iSCSI Loaded: loaded (/usr/lib/systemd/system/iscsid.service; disabled; vendor preset: disabled) Active: active (running) since Wed 2018-05-23 11:30:41 UTC; 7s ago So far our logic is inverse: 1. we start iscsid always 2. we pre-check if it is starte din open-iscsid ExecStartPre=/bin/systemctl --quiet is-active iscsid.service -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
** Changed in: open-iscsi (Ubuntu) Importance: Undecided => High ** Changed in: open-iscsi (Ubuntu) Status: New => Triaged ** Changed in: open-iscsi (Ubuntu) Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox) ** Also affects: open-iscsi (Ubuntu Bionic) Importance: High Assignee: Mathieu Trudel-Lapierre (cyphermox) Status: Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
