[Bug 1761372] Comment bridged from LTC Bugzilla
--- Comment From bren...@br.ibm.com 2018-04-19 11:53 EDT--- > Sure, Thanks, Have created Bug 166958 for the same, soon it will get > mirrored to Canonical. Bug 166958 is now https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1765364 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1761372 Title: backport needed for spectre/meltdown mitigation machine type qemu patches (kvm) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1761372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1761372] Comment bridged from LTC Bugzilla
--- Comment From sathe...@in.ibm.com 2018-04-19 05:39 EDT--- (In reply to comment #20) > I got in contact with mdeslaur and he confirmed there is no bug yet for > spectre/meltdown on qemu for ppc64. > > I'd ask you to: > 1. file a new bug for that as this one here is about the -sxxm machine types > 2. please list the functional changes there that add the cap-xxx options > But not the new machine types (IMHO) > Sure, Thanks, Have created Bug 166958 for the same, soon it will get mirrored to Canonical. Regards, -Satheesh > That bug would then be handled by the security Team and eventually become > part of [1] I think. > > [1]: > https://people.canonical.com/~ubuntu-security/cve/2017/CVE-2017-5715.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1761372 Title: backport needed for spectre/meltdown mitigation machine type qemu patches (kvm) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1761372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1761372] Comment bridged from LTC Bugzilla
--- Comment From sathe...@in.ibm.com 2018-04-18 07:12 EDT--- This fix needs to be considered for other LTS streams aswell like xenial, Trusty. Can we use the same bz to track there inclusion aswell? Advice otherwise, Thanks in advance. Regards, -Satheesh -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1761372 Title: backport needed for spectre/meltdown mitigation machine type qemu patches (kvm) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1761372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1761372] Comment bridged from LTC Bugzilla
--- Comment From sathe...@in.ibm.com 2018-04-09 07:10 EDT--- (In reply to comment #13) > # qemu-system-ppc64 -M ? | egrep 'bionic|2.1[12]' > pseries-2.11 pSeries Logical Partition (PAPR compliant) > pseries-2.12 pSeries Logical Partition (PAPR compliant) > pseries-2.12-sxxmpSeries Logical Partition (PAPR compliant) > pseries pSeries Logical Partition (PAPR compliant) (alias of > pseries-bionic) > pseries-bionic pSeries Logical Partition (PAPR compliant) (default) > pseries-bionic-sxxm pSeries Logical Partition (PAPR compliant) > > Both types seem to work for me. > I have no FW to check in the actual features. > > I'll drive a new general regression run over the weekend, but I'd be really > happy if one of you could test the if new type fits your needs so that I can > push it on monday (since everything else seems good). > > Still ppa: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3225 > Min Version with these changes: qemu - 1:2.11+dfsg-1ubuntu6~ppa4 ii qemu-kvm 1:2.11+dfsg-1ubuntu6~ppa4 I tested on Power8 am able to boot with pseries-bionic-sxxm fine and works as expected. kvm -M pseries-bionic-sxxm -monitor stdio -serial /dev/pts/6 -enable-kvm -nographic -vga none /home/sath/avocado-fvt-wrapper/data/avocado- vt/images/ubuntu-16.04.4-ppc64le.qcow2 -device virtio-net Regards, -Satheesh -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1761372 Title: backport needed for spectre/meltdown mitigation machine type qemu patches (kvm) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1761372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1761372] Comment bridged from LTC Bugzilla
> > > I wonder, what is the benefit of this then. > > If users need to change the machine type, then they can just as well set > the > > CFPC/SBBC/IBS caps right? > > I believe the issue is similar to what we initially hit with: > > Bug 165081 - LP1752026- Ubuntu18.04:POWER9:DD2.2: Unable to start a KVM > guest with default machine type(pseries-bionic) complaining "KVM > implementation does not support Transactional Memory, try cap-htm=off" > (kvm) > > where due to lack of "-machine pseries-*,cap-*=on/off/*" support via > libvirt we need to rely on machine type behavior to enable certain > options in the interim. > Yes exactly. And this is why I was asking for more guidance on the preferred defaults, as the addition of an extra type still needs the user to do something (e.g. selecting that type). [...] > IFF there are changes to 2.12 in the remaining upstream 2.12 or the coming > > Ubuntu 18.10 development cycle we will not try (too hard) to keep e.g. a > > Bionic pseries-2.12-sxxm in sync with that of 18.10. > > Doesn't seem likely to change at this point but that seems reasonable > either way. > Yeah, as much as upstream can't change 2.11 anymore (which is why you make it a 2.12 type) we can't change 2.12 yet (in this release). [...] > Same (=please let me know asap) is true if instead you want any of: > > pseries-2.11-sxxm > > pseries-bionic-sxxm > > Adding pseries-2.11-sxxm/pseries-bionic-sxxm gives us some flexibility > with different firmware/hardware and migration strategies so this would > be our preference. Ok, will do so. We will keep the 2.12 type as-is in code, but it might change (if it changes upstream - unlikely). While together we will try to keep the bionic types stable. > This is also in line with how things are done with > spectre-related CPU capabilities in 2.12/2.11.1 for x86 (new explicit > cpu types as opposed to changed defaults). > Yes, that is true on x86 > In terms of upstream patches that need to be backported I think we also > want "ppc/spapr-caps: Disallow setting workaround for spapr-cap-ibs". I > got a pretty clean backport on top of 2.11.1 just cherry-picking: > I already have this patch in my current build - I added it to the description here when I was dupping the other bug onto this. > > ppc/spapr-caps: Define the pseries-2.12-sxxm machine type > ppc/spapr-caps: Convert cap-ibs to custom spapr-cap > ppc/spapr-caps: Disallow setting workaround for spapr-cap-ibs > ppc/spapr-caps: Convert cap-sbbc to custom spapr-cap > ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap > ppc/spapr-caps: Add support for custom spapr_capabilities > target/ppc: Check mask when setting cap_ppc_safe_indirect_branch > That is exactly the series I already have in my ppa since yesterday ~noon > Then an ubuntu-specific pseries-2.11-sxxm patch would basically mirror > the "ppc/spapr-caps: Define the pseries-2.12-sxxm machine type" > implementation and pseries-bionic-sxxm could point to that. > Exactly my thought will do so and respin the build in the ppa. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1761372 Title: backport needed for spectre/meltdown mitigation machine type qemu patches (kvm) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1761372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1761372] Comment bridged from LTC Bugzilla
--- Comment From mdr...@us.ibm.com 2018-04-05 12:50 EDT--- (In reply to comment #9) > So all that, to provide a -sxxm type that is NOT the default (not in your > patches, so I didn't make it the default in mine). > > I wonder, what is the benefit of this then. > If users need to change the machine type, then they can just as well set the > CFPC/SBBC/IBS caps right? I believe the issue is similar to what we initially hit with: Bug 165081 - LP1752026- Ubuntu18.04:POWER9:DD2.2: Unable to start a KVM guest with default machine type(pseries-bionic) complaining "KVM implementation does not support Transactional Memory, try cap-htm=off" (kvm) where due to lack of "-machine pseries-*,cap-*=on/off/*" support via libvirt we need to rely on machine type behavior to enable certain options in the interim. > > Since we are not changing the deafault (pseries-bionic) is what we > essentially support. > We don't even have to wrap it into the 2.11 type. > > Todays machine types in Bionic: > [Upstream types] > pseries-2.10 pSeries Logical Partition (PAPR compliant) > pseries-2.11 pSeries Logical Partition (PAPR compliant) > pseries-2.12 pSeries Logical Partition (PAPR compliant) > [...] > [Ubuntu recommended types (the defaults)] > pseries pSeries Logical Partition (PAPR compliant) (alias of > pseries-bionic) > pseries-bionic pSeries Logical Partition (PAPR compliant) (default) > [...] > > Your patch will add > pseries-2.12-sxxm based on the 2.12 that was added in the stable 2.11.1 > patches. > I mentioned this before on other places. > That might be a nice simplification for users, but since 2.12 is not yet set > in stone (at least it is on -rc now) we can't (and won't) make any > guarantees about cross release migrations. > > pseries-bionic is what we can control, and the default and what we consider > that shall work across releases. > Since you provided the extra type as non-default convenience type I'll do > the same. > > IFF there are changes to 2.12 in the remaining upstream 2.12 or the coming > Ubuntu 18.10 development cycle we will not try (too hard) to keep e.g. a > Bionic pseries-2.12-sxxm in sync with that of 18.10. Doesn't seem likely to change at this point but that seems reasonable either way. > If you want any of these sxxm defaults to be the default of the default > machine type ... ARGL too much default exception. > Rephrase: > If you want the changes to the CAPs that the 2.12-sxxm type starts to be > applied to the default machine type "pseries-bionic" let me know. > > Until Bionic release we could set: > smc->default_caps.caps[SPAPR_CAP_CFPC] = SPAPR_CAP_WORKAROUND; > smc->default_caps.caps[SPAPR_CAP_SBBC] = SPAPR_CAP_WORKAROUND; > smc->default_caps.caps[SPAPR_CAP_IBS] = SPAPR_CAP_FIXED_CCD; > In the pseries-bionic type (but not after release anymore). > > Same (=please let me know asap) is true if instead you want any of: > pseries-2.11-sxxm > pseries-bionic-sxxm Adding pseries-2.11-sxxm/pseries-bionic-sxxm gives us some flexibility with different firmware/hardware and migration strategies so this would be our preference. This is also in line with how things are done with spectre-related CPU capabilities in 2.12/2.11.1 for x86 (new explicit cpu types as opposed to changed defaults). In terms of upstream patches that need to be backported I think we also want "ppc/spapr-caps: Disallow setting workaround for spapr-cap-ibs". I got a pretty clean backport on top of 2.11.1 just cherry-picking: ppc/spapr-caps: Define the pseries-2.12-sxxm machine type ppc/spapr-caps: Convert cap-ibs to custom spapr-cap ppc/spapr-caps: Disallow setting workaround for spapr-cap-ibs ppc/spapr-caps: Convert cap-sbbc to custom spapr-cap ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap ppc/spapr-caps: Add support for custom spapr_capabilities target/ppc: Check mask when setting cap_ppc_safe_indirect_branch Then an ubuntu-specific pseries-2.11-sxxm patch would basically mirror the "ppc/spapr-caps: Define the pseries-2.12-sxxm machine type" implementation and pseries-bionic-sxxm could point to that. --- Comment From mdr...@us.ibm.com 2018-04-05 12:51 EDT--- *** Bug 166063 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1761372 Title: backport needed for spectre/meltdown mitigation machine type qemu patches (kvm) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1761372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
