[Bug 1762680] Re: upgrades fail to complete

[Launchpad Bug Tracker]

This bug was fixed in the package lxd - 3.0.0-0ubuntu4

---
lxd (3.0.0-0ubuntu4) bionic; urgency=medium

  * Cherry-pick upstream fixes:
- lxc/alias: Fix example in help message
- i18n: Update translation templates
- client: Introduce LXD_SOCKET
- Makefile: Add a manifest
- containers: fix snapshot deletion
- lxc/init: Add missing --no-profiles
- i18n: Update translations
- lxc/file: Fix pull target logic
- doc: Fix example in userns-idmap
- devices: fail if Nvidia device minor is missing
- Add db.ContainersNodeList
- storage: createContainerMountpoint() fix perms
- ceph: s/0755/0711/g
- lvm: s/0755/0711/g
- storage utils: s/0755/0711/g
- zfs: s/0755/0711/g
- patches: add "storage_api_path_permissions"
- sys/fs: s/MkdirAll/Mkdir/g
- btrfs: fix permissions
- Pass a logger to raft-http
- Add new cluster.Promote function
- Add new cluster.Rebalance function
- Notify the cluster leader after a node removal, so it can rebalance
- Add integration test
- doc: Tweak backup.md
- lxd/init: Require root for interactive cluster join
- Disable flaky unit tests for now
- Log the error that made Daemon.Init() fail
- client: Expose http URL in ConnectionInfo
- lxc/query: Add support for non-JSON endpoints
- lxd/containers: Fix lxc.net check

  * Really don't restart lxd-containers on upgrades (LP: #1762680)
  * Bump standards to 4.1.4

 -- Stéphane Graber   Tue, 17 Apr 2018 13:35:28
-0400

** Changed in: lxd (Ubuntu)
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1762680] Re: upgrades fail to complete

[Stéphane Graber]

Found a way to make the restart call go away.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1762680] Re: upgrades fail to complete

[Stéphane Graber]

I'm kinda confused as to how this even makes it in considering we have:

override_dh_systemd_start:
»···echo "Not running dh_systemd_start"

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1762680] Re: upgrades fail to complete

[David Britton]

** Changed in: lxd (Ubuntu)
   Status: Incomplete => New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1762680] Re: upgrades fail to complete

[Christian Brauner]

I'm not super familiar with this but that sounds reasonable to me. The
unit shouldn't be re-triggered.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1762680] Re: upgrades fail to complete

[Dimitri John Ledkov]

# Automatically added by dh_systemd_start/11.1.6ubuntu1
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = 
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -d /run/systemd/system ]; then
systemctl --system daemon-reload >/dev/null || true
if [ -n "$2" ]; then
_dh_action=restart
else
_dh_action=start
fi
deb-systemd-invoke $_dh_action 'lxd-containers.service' 
>/dev/null || true
fi
fi

I see above in the maintainer script, thus on upgrades ( when [ -n "$2"
] is true ) a restart of lxd-containers job is attempted. Maybe we need
dh_systemd --no-restart --name lxd-containers.service or some such?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1762680] Re: upgrades fail to complete

[Stéphane Graber]

And to answer the initial question, no, we should not be using the non-
blocking systemctl calls here, that'd just paper over broken systems.

I'm not sure why lxd-containers would be re-triggered on upgrade though,
in theory lxd-containers should be kept as it is (normally running) and
the lxd unit is the one that should be brought down and back up.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1762680] Re: upgrades fail to complete

[David Britton]

** Changed in: lxd (Ubuntu)
   Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1762680] Re: upgrades fail to complete

[Christian Brauner]

The first thing we need to see is why this is blocking. Do you have any
additional logs?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762680

Title:
  upgrades fail to complete

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxd/+bug/1762680/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs