[Bug 1775043] Re: bash completion not working: uses deprecated have()
This bug was fixed in the package ufw - 0.36-0ubuntu0.18.04.1 --- ufw (0.36-0ubuntu0.18.04.1) bionic-proposed; urgency=medium * Backport to bionic addressing the following SRU bugs: - LP: #1811129 - master SRU bug - LP: #1664133 - before6.rules: echo-reply needs to be before INVALID - LP: #1719211 - improve interface name checks - LP: #1775043 - shell-completion/bash: adjust for modern bash - LP: #1204579 - support concurrent updates - LP: #1368411 - add 'prepend' command -- Jamie Strandboge Mon, 25 Mar 2019 21:14:25 + ** Changed in: ufw (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
This bug was fixed in the package ufw - 0.36-0ubuntu0.18.10.1 --- ufw (0.36-0ubuntu0.18.10.1) cosmic-proposed; urgency=medium * Backport to cosmic addressing the following SRU bugs: - LP: #1811129 - master SRU bug - LP: #1664133 - before6.rules: echo-reply needs to be before INVALID - LP: #1719211 - improve interface name checks - LP: #1775043 - shell-completion/bash: adjust for modern bash - LP: #1204579 - support concurrent updates - LP: #1368411 - add 'prepend' command -- Jamie Strandboge Mon, 25 Mar 2019 20:46:10 + ** Changed in: ufw (Ubuntu Cosmic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
Tested this is fixed in cosmic: $ apt-cache policy ufw ufw: Installed: 0.36-0ubuntu0.18.10.1 Candidate: 0.36-0ubuntu0.18.10.1 Version table: *** 0.36-0ubuntu0.18.10.1 500 500 http://us.archive.ubuntu.com/ubuntu cosmic-proposed/main amd64 Packages 500 http://us.archive.ubuntu.com/ubuntu cosmic-proposed/main i386 Packages 100 /var/lib/dpkg/status 0.35-6 500 500 http://us.archive.ubuntu.com/ubuntu cosmic/main amd64 Packages 500 http://us.archive.ubuntu.com/ubuntu cosmic/main i386 Packages ** Tags removed: verification-needed verification-needed-bionic verification-needed-cosmic ** Tags added: verification-done verification-done-bionic verification-done-cosmic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
Verified this is fixed in bionic: $ apt-cache policy ufw ufw: Installed: 0.36-0ubuntu0.18.04.1 Candidate: 0.36-0ubuntu0.18.04.1 Version table: *** 0.36-0ubuntu0.18.04.1 500 500 http://us.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages 500 http://us.archive.ubuntu.com/ubuntu bionic-proposed/main i386 Packages 100 /var/lib/dpkg/status 0.35-5 500 500 http://us.archive.ubuntu.com/ubuntu bionic/main amd64 Packages 500 http://us.archive.ubuntu.com/ubuntu bionic/main i386 Packages -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
Hello Paulo, or anyone else affected, Accepted ufw into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ufw/0.36-0ubuntu0.18.10.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: ufw (Ubuntu Cosmic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-cosmic ** Changed in: ufw (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
** Changed in: ufw (Ubuntu Bionic) Status: Triaged => In Progress ** Changed in: ufw (Ubuntu Cosmic) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
** Description changed: + [Impact] + + Tab completion is currently broken. + + [Test Case] + + $ ufw + allow delete --dry-run --help loggingreset status + appdeny enable insert reject route version + defaultdisable--forcelimit reload show + + With an unpatched ufw, tab completion only shows the files in the + current directory, which is meaningless for ufw. + + [Regression Potential] + + Risk of regression is considered very low since tab completion is + totally broken and correct functionality is easily tested. + + + = Original description = + bash completion, defined in /usr/share/bash-completion/completions/ufw, doesn't work: the completion is not dynamically loaded, because it uses deprecated helper function have(). According to /usr/share/bash-completions/bash_completion, which defines the helper functions: # Backwards compatibility for compat completions that use have(). # @deprecated should no longer be used; generally not needed with dynamically # loaded completions, and _have is suitable for runtime use. and at the end of the file: unset -f have unset have which means: function have() is not available for usage. The bash completion for ufw conditionally defines _ufw and the comspec: - have ufw && + have ufw && _ufw() ... [ "$have" ] && complete -F _ufw ufw These should be changed to: - _have ufw && + _have ufw && _ufw() ... _have ufw && complete -F _ufw ufw ProblemType: Bug DistroRelease: Ubuntu 18.04 Package: ufw 0.35-5 ProcVersionSignature: Ubuntu 4.15.0-22.24-generic 4.15.17 Uname: Linux 4.15.0-22-generic x86_64 ApportVersion: 2.20.9-0ubuntu7.1 Architecture: amd64 CurrentDesktop: XFCE Date: Mon Jun 4 14:34:11 2018 InstallationDate: Installed on 2018-04-28 (37 days ago) InstallationMedia: Xubuntu 18.04 LTS "Bionic Beaver" - Release amd64 (20180426) PackageArchitecture: all SourcePackage: ufw UpgradeStatus: No upgrade log present (probably fresh install) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
This bug was fixed in the package ufw - 0.36-1 --- ufw (0.36-1) unstable; urgency=medium * New upstream release (LP: #1782384, LP: #1664133, LP: #1509725, LP: #1695718, LP: #1719211, LP: #1775043, LP: #1204579, LP: #1652163, LP: #1377600, Closes: 686248, LP: #1368411, LP: #1586258, Closes: 909163, Closes: 884932, LP: #1558068) - drop 0002-bug849628.patch (included upstream) - drop 0003-use-default-tcp-syncookies.patch (included upstream) - drop 0004-lp1633698.patch (included upstream) * Remaining changes: - 0001-optimize-boot.patch * debian/ufw.maintscript: remove /etc/bash_completion.d/ufw on upgrade (LP: #1602834) * debian/control: remove no longer needed xs-python-version and x-python3-version fields * update debian/before6.rules.md5sum for file shipped in 0.35-6. While both before.rules and before6.rules were updated in this new upstream release, 0.35-6 mistakenly already had its own md5sum for before.rules, so we don't need to add it now. -- Jamie Strandboge Fri, 14 Dec 2018 17:50:47 + ** Changed in: ufw (Ubuntu Disco) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
This is fixed in the new 0.36 release. ** Changed in: ufw Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
** Also affects: ufw (Ubuntu Disco) Importance: Undecided Assignee: Jamie Strandboge (jdstrand) Status: Triaged ** Changed in: ufw (Ubuntu Disco) Status: Triaged => In Progress ** Changed in: ufw (Ubuntu Disco) Importance: Undecided => Medium ** Changed in: ufw (Ubuntu Cosmic) Importance: Undecided => Medium ** Changed in: ufw (Ubuntu Bionic) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
** Changed in: ufw Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
This was committed to ufw a while ago and will be in the upcoming 0.36, which I plan to SRU back to bionic. ** Changed in: ufw Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1775043] Re: bash completion not working: uses deprecated have()
Thank you for reporting this. I'll get it fixed in upstream ufw, Debian and Ubuntu 18.10. I'll then do an SRU for 18.04 LTS. ** Also affects: ufw Importance: Undecided Status: New ** Changed in: ufw Status: New => In Progress ** Changed in: ufw Assignee: (unassigned) => Jamie Strandboge (jdstrand) ** Also affects: ufw (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: ufw (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: ufw (Ubuntu Bionic) Status: New => Triaged ** Changed in: ufw (Ubuntu Cosmic) Status: New => Triaged ** Changed in: ufw (Ubuntu Bionic) Assignee: (unassigned) => Jamie Strandboge (jdstrand) ** Changed in: ufw (Ubuntu Cosmic) Assignee: (unassigned) => Jamie Strandboge (jdstrand) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1775043 Title: bash completion not working: uses deprecated have() To manage notifications about this bug go to: https://bugs.launchpad.net/ufw/+bug/1775043/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs