[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
This bug was fixed in the package apache2 - 2.4.29-1ubuntu4.5 --- apache2 (2.4.29-1ubuntu4.5) bionic; urgency=medium * d/debhelper/apache2-maintscript-helper: fix typo in apache2_switch_mpm()'s a2query call. (LP: #1782806) -- Andreas Hasenack Wed, 10 Oct 2018 15:59:25 -0300 ** Changed in: apache2 (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
I was getting this error trying to install the libapache2-mod-php7.2 on bionic using the 3.4.0 puppetlabs apache puppet module. After I added the ubuntu test repo and did an update to the latest apache2 (2.4.29), the installation via puppet was successful. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
Bionic Verification
===
First, confirming the bug:
ubuntu@bionic-apache2-1782806:~$ apt-cache policy apache2
apache2:
Installed: 2.4.29-1ubuntu4.4
Candidate: 2.4.29-1ubuntu4.4
Version table:
*** 2.4.29-1ubuntu4.4 500
500 http://br.archive.ubuntu.com/ubuntu bionic-updates/main amd64
Packages
# prep
ubuntu@bionic-apache2-1782806:~$ sudo cp
/etc/apache2/mods-available/{mpm_prefork,prefork}.conf
ubuntu@bionic-apache2-1782806:~$ sudo cp
/etc/apache2/mods-available/{mpm_prefork,prefork}.load
ubuntu@bionic-apache2-1782806:~$ sudo ln -s
/etc/apache2/mods-{available,enabled}/prefork.load
ubuntu@bionic-apache2-1782806:~$ sudo ln -s
/etc/apache2/mods-{available,enabled}/prefork.conf
# this should fail
ubuntu@bionic-apache2-1782806:~$ sudo apt install libapache2-mod-php7.2 -y
...
Creating config file /etc/php/7.2/apache2/php.ini with new version
apache2_switch_mpm prefork: No action required
dpkg: error processing package libapache2-mod-php7.2 (--configure):
installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
Errors were encountered while processing:
libapache2-mod-php7.2
E: Sub-process /usr/bin/dpkg returned an error code (1)
Bug confirmed.
Confirming fix
a) upgrading from the broken package to the fixed one
Starting with this scenario. Note how the php module package is in a failed
state:
ubuntu@bionic-apache2-1782806:~$ dpkg -l|grep apache2
ii apache22.4.29-1ubuntu4.4
ii apache2-bin2.4.29-1ubuntu4.4
ii apache2-data 2.4.29-1ubuntu4.4
ii apache2-utils 2.4.29-1ubuntu4.4
iF libapache2-mod-php7.2 7.2.10-0ubuntu0.18.04.1
ubuntu@bionic-apache2-1782806:~$ sudo apt install apache2 apache2-bin
apache2-data apache2-utils
(...)
Setting up apache2 (2.4.29-1ubuntu4.5) ...
info: Switch to mpm prefork for package libapache2-mod-php7.2
Module mpm_event disabled.
Enabling module mpm_prefork.
info: Executing deferred 'a2enmod php7.2' for package libapache2-mod-php7.2
Enabling module php7.2.
W: APT had planned for dpkg to do more than it reported back (20 vs 24).
Affected packages: libapache2-mod-php7.2:amd64
# php is now ok
ubuntu@bionic-apache2-1782806:~$ dpkg -l|grep libapache2-mod-php
ii libapache2-mod-php7.2 7.2.10-0ubuntu0.18.04.1 amd64
server-side, HTML-embedded scripting language (Apache 2 module)
# apt -f install is clean:
ubuntu@bionic-apache2-1782806:~$ sudo apt -f install
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following package was automatically installed and is no longer required:
libfreetype6
Use 'sudo apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 49 not upgraded.
b) Starting out with the condition that shows the bug, but with the fixed
package from proposed:
ubuntu@bionic-apache2-1782806:~$ apt-cache policy apache2
apache2:
Installed: 2.4.29-1ubuntu4.5
Candidate: 2.4.29-1ubuntu4.5
Version table:
*** 2.4.29-1ubuntu4.5 500
500 http://br.archive.ubuntu.com/ubuntu bionic-proposed/main amd64
Packages
# Creating the condition for the bug, as before:
ubuntu@bionic-apache2-1782806:~$ sudo cp
/etc/apache2/mods-available/{mpm_prefork,prefork}.conf
ubuntu@bionic-apache2-1782806:~$ sudo cp
/etc/apache2/mods-available/{mpm_prefork,prefork}.load
ubuntu@bionic-apache2-1782806:~$ sudo ln -s
/etc/apache2/mods-{available,enabled}/prefork.load
ubuntu@bionic-apache2-1782806:~$ sudo ln -s
/etc/apache2/mods-{available,enabled}/prefork.conf
ubuntu@bionic-apache2-1782806:~$
# installing the php module. It works this time:
ubuntu@bionic-apache2-1782806:~$ sudo apt install libapache2-mod-php7.2 -y
...
Creating config file /etc/php/7.2/cli/php.ini with new version
Setting up libapache2-mod-php7.2 (7.2.10-0ubuntu0.18.04.1) ...
Creating config file /etc/php/7.2/apache2/php.ini with new version
Module mpm_event disabled.
Enabling module mpm_prefork.
apache2_switch_mpm Switch to prefork
apache2_invoke: Enable module php7.2
ubuntu@bionic-apache2-1782806:~$
Verification succeeded.
** Tags removed: verification-needed-bionic
** Tags added: verification-done-bionic
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1782806
Title:
Typo in apache2-maintscript-helper causes MPM check to misfire
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
Bionic Verification
===
First, confirming the bug:
ubuntu@bionic-apache2-1782806:~$ apt-cache policy apache2
apache2:
Installed: 2.4.29-1ubuntu4.4
Candidate: 2.4.29-1ubuntu4.4
Version table:
*** 2.4.29-1ubuntu4.4 500
500 http://br.archive.ubuntu.com/ubuntu bionic-updates/main amd64
Packages
# prep
ubuntu@bionic-apache2-1782806:~$ sudo cp
/etc/apache2/mods-available/{mpm_prefork,prefork}.conf
ubuntu@bionic-apache2-1782806:~$ sudo cp
/etc/apache2/mods-available/{mpm_prefork,prefork}.load
ubuntu@bionic-apache2-1782806:~$ sudo ln -s
/etc/apache2/mods-{available,enabled}/prefork.load
ubuntu@bionic-apache2-1782806:~$ sudo ln -s
/etc/apache2/mods-{available,enabled}/prefork.conf
# this should fail
ubuntu@bionic-apache2-1782806:~$ sudo apt install libapache2-mod-php7.2 -y
...
Creating config file /etc/php/7.2/apache2/php.ini with new version
apache2_switch_mpm prefork: No action required
dpkg: error processing package libapache2-mod-php7.2 (--configure):
installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
Errors were encountered while processing:
libapache2-mod-php7.2
E: Sub-process /usr/bin/dpkg returned an error code (1)
Bug confirmed.
Confirming fix
a) upgrading from the broken package to the fixed one
Starting with this scenario. Note how the php module package is in a failed
state:
ubuntu@bionic-apache2-1782806:~$ dpkg -l|grep apache2
ii apache22.4.29-1ubuntu4.4
ii apache2-bin2.4.29-1ubuntu4.4
ii apache2-data 2.4.29-1ubuntu4.4
ii apache2-utils 2.4.29-1ubuntu4.4
iF libapache2-mod-php7.2 7.2.10-0ubuntu0.18.04.1
ubuntu@bionic-apache2-1782806:~$ sudo apt install apache2 apache2-bin
apache2-data apache2-utils
(...)
Setting up apache2 (2.4.29-1ubuntu4.5) ...
info: Switch to mpm prefork for package libapache2-mod-php7.2
Module mpm_event disabled.
Enabling module mpm_prefork.
info: Executing deferred 'a2enmod php7.2' for package libapache2-mod-php7.2
Enabling module php7.2.
W: APT had planned for dpkg to do more than it reported back (20 vs 24).
Affected packages: libapache2-mod-php7.2:amd64
# php is now ok
ubuntu@bionic-apache2-1782806:~$ dpkg -l|grep libapache2-mod-php
ii libapache2-mod-php7.2 7.2.10-0ubuntu0.18.04.1 amd64
server-side, HTML-embedded scripting language (Apache 2 module)
# apt -f install is clean:
ubuntu@bionic-apache2-1782806:~$ sudo apt -f install
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following package was automatically installed and is no longer required:
libfreetype6
Use 'sudo apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 49 not upgraded.
b) Starting out with the condition that shows the bug, but with the fixed
package from proposed:
ubuntu@bionic-apache2-1782806:~$ apt-cache policy apache2
apache2:
Installed: 2.4.29-1ubuntu4.5
Candidate: 2.4.29-1ubuntu4.5
Version table:
*** 2.4.29-1ubuntu4.5 500
500 http://br.archive.ubuntu.com/ubuntu bionic-proposed/main amd64
Packages
# Creating the condition for the bug, as before:
ubuntu@bionic-apache2-1782806:~$ sudo cp
/etc/apache2/mods-available/{mpm_prefork,prefork}.conf
ubuntu@bionic-apache2-1782806:~$ sudo cp
/etc/apache2/mods-available/{mpm_prefork,prefork}.load
ubuntu@bionic-apache2-1782806:~$ sudo ln -s
/etc/apache2/mods-{available,enabled}/prefork.load
ubuntu@bionic-apache2-1782806:~$ sudo ln -s
/etc/apache2/mods-{available,enabled}/prefork.conf
ubuntu@bionic-apache2-1782806:~$
# installing the php module. It works this time:
ubuntu@bionic-apache2-1782806:~$ sudo apt install libapache2-mod-php7.2 -y
...
Creating config file /etc/php/7.2/cli/php.ini with new version
Setting up libapache2-mod-php7.2 (7.2.10-0ubuntu0.18.04.1) ...
Creating config file /etc/php/7.2/apache2/php.ini with new version
Module mpm_event disabled.
Enabling module mpm_prefork.
apache2_switch_mpm Switch to prefork
apache2_invoke: Enable module php7.2
ubuntu@bionic-apache2-1782806:~$
Verification succeeded.
** Tags removed: verification-needed-bionic
** Tags added: verification-done-bionic
--
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1782806
Title:
Typo in apache2-maintscript-helper causes MPM check to misfire
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
Hello Tim, or anyone else affected, Accepted apache2 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apache2/2.4.29-1ubuntu4.5 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: apache2 (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/apache2/+git/apache2/+merge/356606 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed:
[Impact]
There are two conditions for this bug to happen, as far as I could figure out:
a) the mpm_prefork module configuration files are named just
prefork.{conf,module} instead of, or in addition to, mpm_prefork.{conf,module}
b) this renamed prefork mpm module is enabled manually instead of using
a2enmod
These conditions mean that one will have two mpm modules enabled at the
same time in /etc/apache2/mod-enabled, something that the a2enmod tool
knows how to prevent. But the symlinks can still be created manually.
+ Note that apache2 will fail to (re)start in this situation.
These were the conditions I could figure out via code inspection and
from logs from this bug and #1771934, meaning, I could reproduce the
same error, including shell code path execution.
It's quite a corner case, but it showed a real bug in the apache apache2
-maintscript-helper shell script. It seems to be triggered by a
puppetlabs module, but I didn't install or configure puppet to confirm.
One could argue it's a local configuration issue, since non-standard
tools were used, but the bug it showed in the apache script is real and
I believe it's worth fixing.
- Once the two mpm modules (event, from the default install, and preform, from
the manual symlink) are enabled at the same time, the following happens when
php is installed:
+ Once the two mpm modules (event, from the default install, and prefork, from
the manual symlink) are enabled at the same time (see testing instructions for
an example on how to do it), the following happens when php is installed:
- php's postinst runs a2query -M to check which mpm is in use
- that call returns "event", so php proceeds to switch the mpm to prefork by
calling "apache2_switch_mpm prefork"
- - due to the bug, apache2_switch_mpm() will check if "prefork" (and NOT
mpm_prefork) is already enabled. At this line, $MPM=preform, and $mpm is not
defined. So this:
+ - due to the bug, apache2_switch_mpm() will check if "prefork" (and NOT
mpm_prefork) is already enabled. In this line, $MPM=prefork, and $mpm is not
defined. So this:
a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Turns into:
+
a2query -m "prefork" > /dev/null 2>&1 || a2query_ret=$?
- because there is a /etc/apache2/mods-enabled/prefork.* symlink (manually
created), this returns 0, in which case the function determines there is
nothing to do (prefork is already enabled!) and exits 0 without actually
switching anything
- - mpm_event is still enabled, and when a2enmod is called to enable php, that
correctly complains and fails.
+ - but mpm_event is still enabled, and when a2enmod is called to enable php,
that correctly complains and fails.
With the fix, the a2query call from apache2_switch_mpm() will correctly
determine that mpm_prefork is not enabled, and perform the requested
switch.
In the end, prefork will be loaded twice, but apache handles that
gracefully and ignores the second load:
[Thu Oct 11 18:33:48.576838 2018] [so:warn] [pid 9923] AH01574: module
mpm_prefork_module is already loaded, skipping
[Test Case]
sudo apt update
sudo apt install apache2
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.conf
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.conf
Installing the php7.2 module now will fail:
sudo apt install libapache2-mod-php7.2
Creating config file /etc/php/7.2/apache2/php.ini with new version
apache2_switch_mpm prefork: No action required
dpkg: error processing package libapache2-mod-php7.2 (--configure):
installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
E: Sub-process /usr/bin/dpkg returned an error code (1)
With the package from proposed, the above will work just fine.
If a user is in the failed situation already, a dist-upgrade also fixes the
problem.
[Regression Potential]
+ One has to wonder if there are modules and helpers out there relying on this
bug, or what kind of workarounds they might have implemented already for this.
- * discussion of how regressions are most likely to manifest as a result
- of this change.
+ There is an example in the puppetlaps apache2 module where they
+ deliberately disable mpm_event while installing php:
- * It is assumed that any SRU candidate patch is well-tested before
- upload and has a low overall risk of regression, but it's important
- to make the effort to think about what ''could'' happen in the
- event of a regression.
+ https://github.com/puppetlabs/puppetlabs-
+ apache/blob/3bd70296be093a10713fd2f85676ac08d305e93f/manifests/mpm.pp#L76
- * This both shows the SRU team that the risks have been considered,
- and provides guidance to testers in
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed:
[Impact]
There are two conditions for this bug to happen, as far as I could figure out:
a) the mpm_prefork module configuration files are named just
prefork.{conf,module} instead of, or in addition to, mpm_prefork.{conf,module}
b) this renamed prefork mpm module is enabled manually instead of using
a2enmod
These conditions mean that one will have two mpm modules enabled at the
same time in /etc/apache2/mod-enabled, something that the a2enmod tool
knows how to prevent. But the symlinks can still be created manually.
+ Note that apache2 will fail to (re)start in this situation.
These were the conditions I could figure out via code inspection and
from logs from this bug and #1771934, meaning, I could reproduce the
same error, including shell code path execution.
It's quite a corner case, but it showed a real bug in the apache apache2
-maintscript-helper shell script. It seems to be triggered by a
puppetlabs module, but I didn't install or configure puppet to confirm.
One could argue it's a local configuration issue, since non-standard
tools were used, but the bug it showed in the apache script is real and
I believe it's worth fixing.
- Once the two mpm modules (event, from the default install, and preform, from
the manual symlink) are enabled at the same time, the following happens when
php is installed:
+ Once the two mpm modules (event, from the default install, and prefork, from
the manual symlink) are enabled at the same time (see testing instructions for
an example on how to do it), the following happens when php is installed:
- php's postinst runs a2query -M to check which mpm is in use
- that call returns "event", so php proceeds to switch the mpm to prefork by
calling "apache2_switch_mpm prefork"
- - due to the bug, apache2_switch_mpm() will check if "prefork" (and NOT
mpm_prefork) is already enabled. At this line, $MPM=preform, and $mpm is not
defined. So this:
+ - due to the bug, apache2_switch_mpm() will check if "prefork" (and NOT
mpm_prefork) is already enabled. In this line, $MPM=prefork, and $mpm is not
defined. So this:
a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Turns into:
+
a2query -m "prefork" > /dev/null 2>&1 || a2query_ret=$?
- because there is a /etc/apache2/mods-enabled/prefork.* symlink (manually
created), this returns 0, in which case the function determines there is
nothing to do (prefork is already enabled!) and exits 0 without actually
switching anything
- - mpm_event is still enabled, and when a2enmod is called to enable php, that
correctly complains and fails.
+ - but mpm_event is still enabled, and when a2enmod is called to enable php,
that correctly complains and fails.
With the fix, the a2query call from apache2_switch_mpm() will correctly
determine that mpm_prefork is not enabled, and perform the requested
switch.
In the end, prefork will be loaded twice, but apache handles that
gracefully and ignores the second load:
[Thu Oct 11 18:33:48.576838 2018] [so:warn] [pid 9923] AH01574: module
mpm_prefork_module is already loaded, skipping
[Test Case]
sudo apt update
sudo apt install apache2
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.conf
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.conf
Installing the php7.2 module now will fail:
sudo apt install libapache2-mod-php7.2
Creating config file /etc/php/7.2/apache2/php.ini with new version
apache2_switch_mpm prefork: No action required
dpkg: error processing package libapache2-mod-php7.2 (--configure):
installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
E: Sub-process /usr/bin/dpkg returned an error code (1)
With the package from proposed, the above will work just fine.
If a user is in the failed situation already, a dist-upgrade also fixes the
problem.
[Regression Potential]
+ One has to wonder if there are modules and helpers out there relying on this
bug, or what kind of workarounds they might have implemented already for this.
- * discussion of how regressions are most likely to manifest as a result
- of this change.
+ There is an example in the puppetlaps apache2 module where they
+ deliberately disable mpm_event while installing php:
- * It is assumed that any SRU candidate patch is well-tested before
- upload and has a low overall risk of regression, but it's important
- to make the effort to think about what ''could'' happen in the
- event of a regression.
+ https://github.com/puppetlabs/puppetlabs-
+ apache/blob/3bd70296be093a10713fd2f85676ac08d305e93f/manifests/mpm.pp#L76
- * This both shows the SRU team that the risks have been considered,
- and provides guidance to testers in
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed:
[Impact]
There are two conditions for this bug to happen, as far as I could figure out:
a) the mpm_prefork module configuration files are named just
prefork.{conf,module} instead of mpm_prefork.{conf,module}
b) this renamed prefork mpm module is enabled manually instead of using
a2enmod
These conditions mean that one will have two mpm modules enabled at the
same time in /etc/apache2/mod-enabled, something that the a2enmod tool
knows how to prevent. But the symlinks can still be created manually.
These were the conditions I could figure out via code inspection and
from logs from this bug and #1771934, meaning, I could reproduce the
same error, including shell code path execution.
It's quite a corner case, but it showed a real bug in the apache apache2
-maintscript-helper shell script. It seems to be triggered by a
puppetlabs module, but I didn't install or configure puppet to confirm.
One could argue it's a local configuration issue, since non-standard
tools were used, but the bug it showed in the apache script is real and
I believe it's worth fixing.
Once the two mpm modules (event, from the default install, and preform, from
the manual symlink) are enabled at the same time, the following happens when
php is installed:
- php's postinst runs a2query -M to check which mpm is in use
- that call returns "event", so php proceeds to switch the mpm to prefork by
calling "apache2_switch_mpm prefork"
- due to the bug, apache2_switch_mpm() will check if "prefork" (and NOT
mpm_prefork) is already enabled. At this line, $MPM=preform, and $mpm is not
defined. So this:
- a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
+ a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Turns into:
- a2query -m "prefork" > /dev/null 2>&1 || a2query_ret=$?
+ a2query -m "prefork" > /dev/null 2>&1 || a2query_ret=$?
- because there is a /etc/apache2/mods-enabled/prefork.* symlink (manually
created), this returns 0, in which case the function determines there is
nothing to do (prefork is already enabled!) and exits 0 without actually
switching anything
- mpm_event is still enabled, and when a2enmod is called to enable php, that
correctly complains and fails.
With the fix, the a2query call from apache2_switch_mpm() will correctly
determine that mpm_prefork is not enabled, and perform the requested
switch.
+
+ In the end, prefork will be loaded twice, but apache handles that
+ gracefully and ignores the second load:
+
+ [Thu Oct 11 18:33:48.576838 2018] [so:warn] [pid 9923] AH01574: module
+ mpm_prefork_module is already loaded, skipping
[Test Case]
sudo apt update
sudo apt install apache2
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.conf
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.conf
Installing the php7.2 module now will fail:
sudo apt install libapache2-mod-php7.2
Creating config file /etc/php/7.2/apache2/php.ini with new version
apache2_switch_mpm prefork: No action required
dpkg: error processing package libapache2-mod-php7.2 (--configure):
installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
E: Sub-process /usr/bin/dpkg returned an error code (1)
With the package from proposed, the above will work just fine.
If a user is in the failed situation already, a dist-upgrade also fixes the
problem.
[Regression Potential]
* discussion of how regressions are most likely to manifest as a result
of this change.
* It is assumed that any SRU candidate patch is well-tested before
upload and has a low overall risk of regression, but it's important
to make the effort to think about what ''could'' happen in the
event of a regression.
* This both shows the SRU team that the risks have been considered,
and provides guidance to testers in regression-testing the SRU.
[Other Info]
* Anything else you think is useful to include
* Anticipate questions from users, SRU, +1 maintenance, security teams and
the Technical Board
* and address these questions in advance
[Original Description]
The following line appears to have a typo:
a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
It should read:
a2query -m "mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Since $mpm is not defined. Later on there are references to enabling and
disabling "mpm_$MPM".
https://salsa.debian.org/apache-
team/apache2/blob/master/debian/debhelper/apache2-maintscript-
helper#L290
This appears to trip up the Puppet apache module since it creates a
prefork module (rather than mpm_prefork), which results in the above
query returning a positive response. This is what's happening
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed:
[Impact]
There are two conditions for this bug to happen, as far as I could figure out:
a) the mpm_prefork module configuration files are named just
prefork.{conf,module} instead of mpm_prefork.{conf,module}
b) this renamed prefork mpm module is enabled manually instead of using
a2enmod
These conditions mean that one will have two mpm modules enabled at the
same time in /etc/apache2/mod-enabled, something that the a2enmod tool
knows how to prevent. But the symlinks can still be created manually.
These were the conditions I could figure out via code inspection and
from logs from this bug and #1771934, meaning, I could reproduce the
same error, including shell code path execution.
It's quite a corner case, but it showed a real bug in the apache apache2
-maintscript-helper shell script. It seems to be triggered by a
puppetlabs module, but I didn't install or configure puppet to confirm.
One could argue it's a local configuration issue, since non-standard
tools were used, but the bug it showed in the apache script is real and
I believe it's worth fixing.
Once the two mpm modules (event, from the default install, and preform, from
the manual symlink) are enabled at the same time, the following happens when
php is installed:
- php's postinst runs a2query -M to check which mpm is in use
- that call returns "event", so php proceeds to switch the mpm to prefork by
calling "apache2_switch_mpm prefork"
- due to the bug, apache2_switch_mpm() will check if "prefork" (and NOT
mpm_prefork) is already enabled. At this line, $MPM=preform, and $mpm is not
defined. So this:
- a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
+ a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Turns into:
- a2query -m "prefork" > /dev/null 2>&1 || a2query_ret=$?
+ a2query -m "prefork" > /dev/null 2>&1 || a2query_ret=$?
- because there is a /etc/apache2/mods-enabled/prefork.* symlink (manually
created), this returns 0, in which case the function determines there is
nothing to do (prefork is already enabled!) and exits 0 without actually
switching anything
- mpm_event is still enabled, and when a2enmod is called to enable php, that
correctly complains and fails.
With the fix, the a2query call from apache2_switch_mpm() will correctly
determine that mpm_prefork is not enabled, and perform the requested
switch.
+
+ In the end, prefork will be loaded twice, but apache handles that
+ gracefully and ignores the second load:
+
+ [Thu Oct 11 18:33:48.576838 2018] [so:warn] [pid 9923] AH01574: module
+ mpm_prefork_module is already loaded, skipping
[Test Case]
sudo apt update
sudo apt install apache2
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.conf
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.conf
Installing the php7.2 module now will fail:
sudo apt install libapache2-mod-php7.2
Creating config file /etc/php/7.2/apache2/php.ini with new version
apache2_switch_mpm prefork: No action required
dpkg: error processing package libapache2-mod-php7.2 (--configure):
installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
E: Sub-process /usr/bin/dpkg returned an error code (1)
With the package from proposed, the above will work just fine.
If a user is in the failed situation already, a dist-upgrade also fixes the
problem.
[Regression Potential]
* discussion of how regressions are most likely to manifest as a result
of this change.
* It is assumed that any SRU candidate patch is well-tested before
upload and has a low overall risk of regression, but it's important
to make the effort to think about what ''could'' happen in the
event of a regression.
* This both shows the SRU team that the risks have been considered,
and provides guidance to testers in regression-testing the SRU.
[Other Info]
* Anything else you think is useful to include
* Anticipate questions from users, SRU, +1 maintenance, security teams and
the Technical Board
* and address these questions in advance
[Original Description]
The following line appears to have a typo:
a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
It should read:
a2query -m "mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Since $mpm is not defined. Later on there are references to enabling and
disabling "mpm_$MPM".
https://salsa.debian.org/apache-
team/apache2/blob/master/debian/debhelper/apache2-maintscript-
helper#L290
This appears to trip up the Puppet apache module since it creates a
prefork module (rather than mpm_prefork), which results in the above
query returning a positive response. This is what's happening
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed:
[Impact]
+ There are two conditions for this bug to happen, as far as I could figure out:
+ a) the mpm_prefork module configuration files are named just
prefork.{conf,module} instead of mpm_prefork.{conf,module}
+ b) this renamed prefork mpm module is enabled manually instead of using
a2enmod
- * An explanation of the effects of the bug on users and
+ These conditions mean that one will have two mpm modules enabled at the
+ same time in /etc/apache2/mod-enabled, something that the a2enmod tool
+ knows how to prevent. But the symlinks can still be created manually.
- * justification for backporting the fix to the stable release.
+ These were the conditions I could figure out via code inspection and
+ from logs from this bug and #1771934, meaning, I could reproduce the
+ same error, including shell code path execution.
- * In addition, it is helpful, but not required, to include an
- explanation of how the upload fixes this bug.
+ It's quite a corner case, but it showed a real bug in the apache apache2
+ -maintscript-helper shell script. It seems to be triggered by a
+ puppetlabs module, but I didn't install or configure puppet to confirm.
+
+ One could argue it's a local configuration issue, since non-standard
+ tools were used, but the bug it showed in the apache script is real and
+ I believe it's worth fixing.
+
+ Once the two mpm modules (event, from the default install, and preform, from
the manual symlink) are enabled at the same time, the following happens when
php is installed:
+ - php's postinst runs a2query -M to check which mpm is in use
+ - that call returns "event", so php proceeds to switch the mpm to prefork by
calling "apache2_switch_mpm prefork"
+ - due to the bug, apache2_switch_mpm() will check if "prefork" (and NOT
mpm_prefork) is already enabled. At this line, $MPM=preform, and $mpm is not
defined. So this:
+
+ a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
+
+ Turns into:
+ a2query -m "prefork" > /dev/null 2>&1 || a2query_ret=$?
+
+ - because there is a /etc/apache2/mods-enabled/prefork.* symlink (manually
created), this returns 0, in which case the function determines there is
nothing to do (prefork is already enabled!) and exits 0 without actually
switching anything
+ - mpm_event is still enabled, and when a2enmod is called to enable php, that
correctly complains and fails.
+
+ With the fix, the a2query call from apache2_switch_mpm() will correctly
+ determine that mpm_prefork is not enabled, and perform the requested
+ switch.
+
[Test Case]
sudo apt update
sudo apt install apache2
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.conf
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.conf
Installing the php7.2 module now will fail:
sudo apt install libapache2-mod-php7.2
Creating config file /etc/php/7.2/apache2/php.ini with new version
apache2_switch_mpm prefork: No action required
dpkg: error processing package libapache2-mod-php7.2 (--configure):
- installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
+ installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
E: Sub-process /usr/bin/dpkg returned an error code (1)
With the package from proposed, the above will work just fine.
If a user is in the failed situation already, a dist-upgrade also fixes the
problem.
[Regression Potential]
* discussion of how regressions are most likely to manifest as a result
of this change.
* It is assumed that any SRU candidate patch is well-tested before
upload and has a low overall risk of regression, but it's important
to make the effort to think about what ''could'' happen in the
event of a regression.
* This both shows the SRU team that the risks have been considered,
and provides guidance to testers in regression-testing the SRU.
[Other Info]
* Anything else you think is useful to include
* Anticipate questions from users, SRU, +1 maintenance, security teams and
the Technical Board
* and address these questions in advance
[Original Description]
The following line appears to have a typo:
a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
It should read:
a2query -m "mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Since $mpm is not defined. Later on there are references to enabling and
disabling "mpm_$MPM".
https://salsa.debian.org/apache-
team/apache2/blob/master/debian/debhelper/apache2-maintscript-
helper#L290
This appears to trip up the Puppet apache module since it creates a
prefork module (rather than mpm_prefork), which results in the above
query returning a positive response. This is what's happening in bug
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed:
[Impact]
+ There are two conditions for this bug to happen, as far as I could figure out:
+ a) the mpm_prefork module configuration files are named just
prefork.{conf,module} instead of mpm_prefork.{conf,module}
+ b) this renamed prefork mpm module is enabled manually instead of using
a2enmod
- * An explanation of the effects of the bug on users and
+ These conditions mean that one will have two mpm modules enabled at the
+ same time in /etc/apache2/mod-enabled, something that the a2enmod tool
+ knows how to prevent. But the symlinks can still be created manually.
- * justification for backporting the fix to the stable release.
+ These were the conditions I could figure out via code inspection and
+ from logs from this bug and #1771934, meaning, I could reproduce the
+ same error, including shell code path execution.
- * In addition, it is helpful, but not required, to include an
- explanation of how the upload fixes this bug.
+ It's quite a corner case, but it showed a real bug in the apache apache2
+ -maintscript-helper shell script. It seems to be triggered by a
+ puppetlabs module, but I didn't install or configure puppet to confirm.
+
+ One could argue it's a local configuration issue, since non-standard
+ tools were used, but the bug it showed in the apache script is real and
+ I believe it's worth fixing.
+
+ Once the two mpm modules (event, from the default install, and preform, from
the manual symlink) are enabled at the same time, the following happens when
php is installed:
+ - php's postinst runs a2query -M to check which mpm is in use
+ - that call returns "event", so php proceeds to switch the mpm to prefork by
calling "apache2_switch_mpm prefork"
+ - due to the bug, apache2_switch_mpm() will check if "prefork" (and NOT
mpm_prefork) is already enabled. At this line, $MPM=preform, and $mpm is not
defined. So this:
+
+ a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
+
+ Turns into:
+ a2query -m "prefork" > /dev/null 2>&1 || a2query_ret=$?
+
+ - because there is a /etc/apache2/mods-enabled/prefork.* symlink (manually
created), this returns 0, in which case the function determines there is
nothing to do (prefork is already enabled!) and exits 0 without actually
switching anything
+ - mpm_event is still enabled, and when a2enmod is called to enable php, that
correctly complains and fails.
+
+ With the fix, the a2query call from apache2_switch_mpm() will correctly
+ determine that mpm_prefork is not enabled, and perform the requested
+ switch.
+
[Test Case]
sudo apt update
sudo apt install apache2
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.conf
sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.load
sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.conf
Installing the php7.2 module now will fail:
sudo apt install libapache2-mod-php7.2
Creating config file /etc/php/7.2/apache2/php.ini with new version
apache2_switch_mpm prefork: No action required
dpkg: error processing package libapache2-mod-php7.2 (--configure):
- installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
+ installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
E: Sub-process /usr/bin/dpkg returned an error code (1)
With the package from proposed, the above will work just fine.
If a user is in the failed situation already, a dist-upgrade also fixes the
problem.
[Regression Potential]
* discussion of how regressions are most likely to manifest as a result
of this change.
* It is assumed that any SRU candidate patch is well-tested before
upload and has a low overall risk of regression, but it's important
to make the effort to think about what ''could'' happen in the
event of a regression.
* This both shows the SRU team that the risks have been considered,
and provides guidance to testers in regression-testing the SRU.
[Other Info]
* Anything else you think is useful to include
* Anticipate questions from users, SRU, +1 maintenance, security teams and
the Technical Board
* and address these questions in advance
[Original Description]
The following line appears to have a typo:
a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
It should read:
a2query -m "mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Since $mpm is not defined. Later on there are references to enabling and
disabling "mpm_$MPM".
https://salsa.debian.org/apache-
team/apache2/blob/master/debian/debhelper/apache2-maintscript-
helper#L290
This appears to trip up the Puppet apache module since it creates a
prefork module (rather than mpm_prefork), which results in the above
query returning a positive response. This is what's happening in bug
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed:
[Impact]
- * An explanation of the effects of the bug on users and
+ * An explanation of the effects of the bug on users and
- * justification for backporting the fix to the stable release.
+ * justification for backporting the fix to the stable release.
- * In addition, it is helpful, but not required, to include an
-explanation of how the upload fixes this bug.
+ * In addition, it is helpful, but not required, to include an
+ explanation of how the upload fixes this bug.
[Test Case]
- * detailed instructions how to reproduce the bug
+ sudo apt update
+ sudo apt install apache2
+ sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.conf
+ sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.load
+ sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.load
+ sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.conf
- * these should allow someone who is not familiar with the affected
-package to reproduce the bug and verify that the updated package fixes
-the problem.
+ Installing the php7.2 module now will fail:
+ sudo apt install libapache2-mod-php7.2
+
+ Creating config file /etc/php/7.2/apache2/php.ini with new version
+ apache2_switch_mpm prefork: No action required
+ dpkg: error processing package libapache2-mod-php7.2 (--configure):
+ installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
+ E: Sub-process /usr/bin/dpkg returned an error code (1)
+
+ With the package from proposed, the above will work just fine.
+ If a user is in the failed situation already, a dist-upgrade also fixes the
problem.
[Regression Potential]
- * discussion of how regressions are most likely to manifest as a result
+ * discussion of how regressions are most likely to manifest as a result
of this change.
- * It is assumed that any SRU candidate patch is well-tested before
-upload and has a low overall risk of regression, but it's important
-to make the effort to think about what ''could'' happen in the
-event of a regression.
+ * It is assumed that any SRU candidate patch is well-tested before
+ upload and has a low overall risk of regression, but it's important
+ to make the effort to think about what ''could'' happen in the
+ event of a regression.
- * This both shows the SRU team that the risks have been considered,
-and provides guidance to testers in regression-testing the SRU.
+ * This both shows the SRU team that the risks have been considered,
+ and provides guidance to testers in regression-testing the SRU.
[Other Info]
-
- * Anything else you think is useful to include
- * Anticipate questions from users, SRU, +1 maintenance, security teams and
the Technical Board
- * and address these questions in advance
+ * Anything else you think is useful to include
+ * Anticipate questions from users, SRU, +1 maintenance, security teams and
the Technical Board
+ * and address these questions in advance
[Original Description]
The following line appears to have a typo:
a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
It should read:
a2query -m "mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Since $mpm is not defined. Later on there are references to enabling and
disabling "mpm_$MPM".
https://salsa.debian.org/apache-
team/apache2/blob/master/debian/debhelper/apache2-maintscript-
helper#L290
This appears to trip up the Puppet apache module since it creates a
prefork module (rather than mpm_prefork), which results in the above
query returning a positive response. This is what's happening in bug
#1771934.
Fix is obvious and trivial so can hopefully be implemented soon. Appears
only to affect bionic since xenial had different code.
--
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1782806
Title:
Typo in apache2-maintscript-helper causes MPM check to misfire
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed:
[Impact]
- * An explanation of the effects of the bug on users and
+ * An explanation of the effects of the bug on users and
- * justification for backporting the fix to the stable release.
+ * justification for backporting the fix to the stable release.
- * In addition, it is helpful, but not required, to include an
-explanation of how the upload fixes this bug.
+ * In addition, it is helpful, but not required, to include an
+ explanation of how the upload fixes this bug.
[Test Case]
- * detailed instructions how to reproduce the bug
+ sudo apt update
+ sudo apt install apache2
+ sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.conf
+ sudo cp /etc/apache2/mods-available/{mpm_prefork,prefork}.load
+ sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.load
+ sudo ln -s /etc/apache2/mods-{available,enabled}/prefork.conf
- * these should allow someone who is not familiar with the affected
-package to reproduce the bug and verify that the updated package fixes
-the problem.
+ Installing the php7.2 module now will fail:
+ sudo apt install libapache2-mod-php7.2
+
+ Creating config file /etc/php/7.2/apache2/php.ini with new version
+ apache2_switch_mpm prefork: No action required
+ dpkg: error processing package libapache2-mod-php7.2 (--configure):
+ installed libapache2-mod-php7.2 package post-installation script subprocess
returned error exit status 1
+ E: Sub-process /usr/bin/dpkg returned an error code (1)
+
+ With the package from proposed, the above will work just fine.
+ If a user is in the failed situation already, a dist-upgrade also fixes the
problem.
[Regression Potential]
- * discussion of how regressions are most likely to manifest as a result
+ * discussion of how regressions are most likely to manifest as a result
of this change.
- * It is assumed that any SRU candidate patch is well-tested before
-upload and has a low overall risk of regression, but it's important
-to make the effort to think about what ''could'' happen in the
-event of a regression.
+ * It is assumed that any SRU candidate patch is well-tested before
+ upload and has a low overall risk of regression, but it's important
+ to make the effort to think about what ''could'' happen in the
+ event of a regression.
- * This both shows the SRU team that the risks have been considered,
-and provides guidance to testers in regression-testing the SRU.
+ * This both shows the SRU team that the risks have been considered,
+ and provides guidance to testers in regression-testing the SRU.
[Other Info]
-
- * Anything else you think is useful to include
- * Anticipate questions from users, SRU, +1 maintenance, security teams and
the Technical Board
- * and address these questions in advance
+ * Anything else you think is useful to include
+ * Anticipate questions from users, SRU, +1 maintenance, security teams and
the Technical Board
+ * and address these questions in advance
[Original Description]
The following line appears to have a typo:
a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
It should read:
a2query -m "mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$?
Since $mpm is not defined. Later on there are references to enabling and
disabling "mpm_$MPM".
https://salsa.debian.org/apache-
team/apache2/blob/master/debian/debhelper/apache2-maintscript-
helper#L290
This appears to trip up the Puppet apache module since it creates a
prefork module (rather than mpm_prefork), which results in the above
query returning a positive response. This is what's happening in bug
#1771934.
Fix is obvious and trivial so can hopefully be implemented soon. Appears
only to affect bionic since xenial had different code.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1782806
Title:
Typo in apache2-maintscript-helper causes MPM check to misfire
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed: + [Impact] + + * An explanation of the effects of the bug on users and + + * justification for backporting the fix to the stable release. + + * In addition, it is helpful, but not required, to include an +explanation of how the upload fixes this bug. + + [Test Case] + + * detailed instructions how to reproduce the bug + + * these should allow someone who is not familiar with the affected +package to reproduce the bug and verify that the updated package fixes +the problem. + + [Regression Potential] + + * discussion of how regressions are most likely to manifest as a result + of this change. + + * It is assumed that any SRU candidate patch is well-tested before +upload and has a low overall risk of regression, but it's important +to make the effort to think about what ''could'' happen in the +event of a regression. + + * This both shows the SRU team that the risks have been considered, +and provides guidance to testers in regression-testing the SRU. + + [Other Info] + + * Anything else you think is useful to include + * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board + * and address these questions in advance + + + [Original Description] + The following line appears to have a typo: a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$? It should read: a2query -m "mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$? Since $mpm is not defined. Later on there are references to enabling and disabling "mpm_$MPM". https://salsa.debian.org/apache- team/apache2/blob/master/debian/debhelper/apache2-maintscript- helper#L290 This appears to trip up the Puppet apache module since it creates a prefork module (rather than mpm_prefork), which results in the above query returning a positive response. This is what's happening in bug #1771934. Fix is obvious and trivial so can hopefully be implemented soon. Appears only to affect bionic since xenial had different code. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Description changed: + [Impact] + + * An explanation of the effects of the bug on users and + + * justification for backporting the fix to the stable release. + + * In addition, it is helpful, but not required, to include an +explanation of how the upload fixes this bug. + + [Test Case] + + * detailed instructions how to reproduce the bug + + * these should allow someone who is not familiar with the affected +package to reproduce the bug and verify that the updated package fixes +the problem. + + [Regression Potential] + + * discussion of how regressions are most likely to manifest as a result + of this change. + + * It is assumed that any SRU candidate patch is well-tested before +upload and has a low overall risk of regression, but it's important +to make the effort to think about what ''could'' happen in the +event of a regression. + + * This both shows the SRU team that the risks have been considered, +and provides guidance to testers in regression-testing the SRU. + + [Other Info] + + * Anything else you think is useful to include + * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board + * and address these questions in advance + + + [Original Description] + The following line appears to have a typo: a2query -m "$mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$? It should read: a2query -m "mpm_$MPM" > /dev/null 2>&1 || a2query_ret=$? Since $mpm is not defined. Later on there are references to enabling and disabling "mpm_$MPM". https://salsa.debian.org/apache- team/apache2/blob/master/debian/debhelper/apache2-maintscript- helper#L290 This appears to trip up the Puppet apache module since it creates a prefork module (rather than mpm_prefork), which results in the above query returning a positive response. This is what's happening in bug #1771934. Fix is obvious and trivial so can hopefully be implemented soon. Appears only to affect bionic since xenial had different code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Changed in: apache2 (Ubuntu Bionic) Assignee: (unassigned) => Andreas Hasenack (ahasenack) ** Changed in: apache2 (Ubuntu Bionic) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Changed in: apache2 (Ubuntu Bionic) Assignee: (unassigned) => Andreas Hasenack (ahasenack) ** Changed in: apache2 (Ubuntu Bionic) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: apache2 (Ubuntu Bionic) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Tags added: server-next -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Tags added: server-next -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
This is fixed in cosmic. ** Changed in: apache2 (Ubuntu) Status: In Progress => Fix Released ** Also affects: apache2 (Ubuntu Bionic) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
This is fixed in cosmic. ** Changed in: apache2 (Ubuntu) Status: In Progress => Fix Released ** Also affects: apache2 (Ubuntu Bionic) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/apache2/+git/apache2/+merge/352331 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/apache2/+git/apache2/+merge/352331 -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Changed in: apache2 (Ubuntu) Status: Triaged => In Progress ** Changed in: apache2 (Ubuntu) Assignee: (unassigned) => Andreas Hasenack (ahasenack) -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Changed in: apache2 (Ubuntu) Status: Triaged => In Progress ** Changed in: apache2 (Ubuntu) Assignee: (unassigned) => Andreas Hasenack (ahasenack) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Changed in: apache2 (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Changed in: apache2 (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Bug watch added: Debian Bug tracker #904150 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904150 ** Also affects: apache2 (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904150 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Bug watch added: Debian Bug tracker #904150 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904150 ** Also affects: apache2 (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904150 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Tags added: bitesize ** Changed in: apache2 (Ubuntu) Status: New => Triaged ** Changed in: apache2 (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to apache2 in Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1782806] Re: Typo in apache2-maintscript-helper causes MPM check to misfire
** Tags added: bitesize ** Changed in: apache2 (Ubuntu) Status: New => Triaged ** Changed in: apache2 (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1782806 Title: Typo in apache2-maintscript-helper causes MPM check to misfire To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1782806/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
