[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
** Changed in: python-phabricator (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786337 Title: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
This bug was fixed in the package python-phabricator - 0.7.0-1ubuntu0.1 --- python-phabricator (0.7.0-1ubuntu0.1) bionic; urgency=medium * Add diffusion.commit.search endpoint to interfaces.json (LP: #1786337). -- Simon Quigley Thu, 09 Aug 2018 15:03:16 -0500 ** Changed in: python-phabricator (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786337 Title: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
** Tags removed: verification-needed verification-needed-bionic ** Tags added: verification-done verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786337 Title: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
I have tested the bionic proposed update in the bionic docker container
and can confirm the fix:
root@hillValley:/# python -c 'from phabricator import Phabricator; phab =
Phabricator(host="http://127.0.0.1:9091/api/";,
token="api-nojs2ip33hmp4zn6u6cf72w7d6yh");
phab.diffusion.commit.search(constraints={"query": "b634a23c82be"})'
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 248, in
__call__
return self._request(**kwargs)
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 323, in
_request
data = self._parse_response(response)
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 333, in
_parse_response
raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-CONDUIT-CALL: Conduit API method "commit.search" does
not exist.
root@hillValley:/# python3 -c 'from phabricator import Phabricator; phab =
Phabricator(host="http://127.0.0.1:9091/api/";,
token="api-nojs2ip33hmp4zn6u6cf72w7d6yh");
phab.diffusion.commit.search(constraints={"query": "b634a23c82be"})'
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 248, in
__call__
return self._request(**kwargs)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 323, in
_request
data = self._parse_response(response)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 333, in
_parse_response
raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-CONDUIT-CALL: Conduit API method "commit.search" does
not exist.
root@hillValley:/# apt-get install -y python-phabricator/bionic-proposed
python3-phabricator/bionic-proposed
Reading package lists... Done
Building dependency tree
Reading state information... Done
Selected version '0.7.0-1ubuntu0.1' (Ubuntu:18.04/bionic-proposed [all]) for
'python-phabricator'
Selected version '0.7.0-1ubuntu0.1' (Ubuntu:18.04/bionic-proposed [all]) for
'python3-phabricator'
The following packages will be upgraded:
python-phabricator python3-phabricator
2 upgraded, 0 newly installed, 0 to remove and 13 not upgraded.
Need to get 32.8 kB of archives.
After this operation, 5120 B of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu bionic-proposed/universe amd64
python-phabricator all 0.7.0-1ubuntu0.1 [16.1 kB]
Get:2 http://archive.ubuntu.com/ubuntu bionic-proposed/universe amd64
python3-phabricator all 0.7.0-1ubuntu0.1 [16.7 kB]
Fetched 32.8 kB in 1s (22.2 kB/s)
debconf: delaying package configuration, since apt-utils is not installed
(Reading database ... 7544 files and directories currently installed.)
Preparing to unpack .../python-phabricator_0.7.0-1ubuntu0.1_all.deb ...
Unpacking python-phabricator (0.7.0-1ubuntu0.1) over (0.7.0-1) ...
Preparing to unpack .../python3-phabricator_0.7.0-1ubuntu0.1_all.deb ...
Unpacking python3-phabricator (0.7.0-1ubuntu0.1) over (0.7.0-1) ...
Setting up python-phabricator (0.7.0-1ubuntu0.1) ...
Setting up python3-phabricator (0.7.0-1ubuntu0.1) ...
root@hillValley:/# python -c 'from phabricator import Phabricator; phab =
Phabricator(host="http://127.0.0.1:9091/api/";,
token="api-nojs2ip33hmp4zn6u6cf72w7d6yh");
phab.diffusion.commit.search(constraints={"query": "b634a23c82be"})'
root@hillValley:/# python3 -c 'from phabricator import Phabricator; phab =
Phabricator(host="http://127.0.0.1:9091/api/";,
token="api-nojs2ip33hmp4zn6u6cf72w7d6yh");
phab.diffusion.commit.search(constraints={"query": "b634a23c82be"})'
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786337
Title:
diffusion.querycommits deprecated in favor of diffusion.commit.search
which support hasn't been merged for yet
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
$ python -c 'from phabricator import Phabricator; phab =
Phabricator(host="https://phab.lubuntu.me/api/";, token="API KEY");
phab.diffusion.commit.search(constraints={"query": "a34837de8224"})'
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 248, in
__call__
return self._request(**kwargs)
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 323, in
_request
data = self._parse_response(response)
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 333, in
_parse_response
raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-CONDUIT-CALL: Conduit API method "commit.search" does
not exist.
$ python3 -c 'from phabricator import Phabricator; phab =
Phabricator(host="https://phab.lubuntu.me/api/";, token="API KEY");
phab.diffusion.commit.search(constraints={"query": "a34837de8224"})'
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 248, in
__call__
return self._request(**kwargs)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 323, in
_request
data = self._parse_response(response)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 333, in
_parse_response
raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-CONDUIT-CALL: Conduit API method "commit.search" does
not exist.
$ sudo apt install python3-phabricator python-phabricator
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be upgraded:
python-phabricator python3-phabricator
2 upgraded, 0 newly installed, 0 to remove and 45 not upgraded.
Need to get 32.8 kB of archives.
After this operation, 5120 B of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu bionic-proposed/universe amd64
python-phabricator all 0.7.0-1ubuntu0.1 [16.1 kB]
Get:2 http://archive.ubuntu.com/ubuntu bionic-proposed/universe amd64
python3-phabricator all 0.7.0-1ubuntu0.1 [16.7 kB]
Fetched 32.8 kB in 1s (45.4 kB/s)
debconf: delaying package configuration, since apt-utils is not installed
(Reading database ... 23490 files and directories currently installed.)
Preparing to unpack .../python-phabricator_0.7.0-1ubuntu0.1_all.deb ...
Unpacking python-phabricator (0.7.0-1ubuntu0.1) over (0.7.0-1) ...
Preparing to unpack .../python3-phabricator_0.7.0-1ubuntu0.1_all.deb ...
Unpacking python3-phabricator (0.7.0-1ubuntu0.1) over (0.7.0-1) ...
Setting up python-phabricator (0.7.0-1ubuntu0.1) ...
Setting up python3-phabricator (0.7.0-1ubuntu0.1) ...
$ python -c 'from phabricator import Phabricator; phab =
Phabricator(host="https://phab.lubuntu.me/api/";, token="API KEY");
phab.diffusion.commit.search(constraints={"query": "a34837de8224"})'
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 248, in
__call__
return self._request(**kwargs)
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 323, in
_request
data = self._parse_response(response)
File "/usr/lib/python2.7/dist-packages/phabricator/__init__.py", line 333, in
_parse_response
raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-INVALID-AUTH: API token "API KEY" has the wrong
length. API tokens should be 32 characters long.
$ python3 -c 'from phabricator import Phabricator; phab =
Phabricator(host="https://phab.lubuntu.me/api/";, token="API KEY");
phab.diffusion.commit.search(constraints={"query": "a34837de8224"})'
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 248, in
__call__
return self._request(**kwargs)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 323, in
_request
data = self._parse_response(response)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 333, in
_parse_response
raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-INVALID-AUTH: API token "API KEY" has the wrong
length. API tokens should be 32 characters long.
$
So the initial error message clears, after which I get an error because
the string 'API KEY' in the test case is a metavariable and needs to be
replaced with some actual API key, which I assume I don't have.
It's clear that the behavior has changed, but I'm not happy to set this
as v-done just with a different error message.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786337
Title:
diffusion.querycommits deprecated in favor of diffusion.commit.search
which support hasn't been merged for yet
To manage notifications about this bug go to:
https://bugs.launc
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
Hello Simon, or anyone else affected, Accepted python-phabricator into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python- phabricator/0.7.0-1ubuntu0.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: python-phabricator (Ubuntu Bionic) Status: Confirmed => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786337 Title: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
** Changed in: python-phabricator (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786337 Title: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
** Description changed:
+ [Impact]
+
+ Without this, users of the API will eventually be unable to search
+ commits in Phabricator, something that is essential to some programs.
+
+ [Test Case]
+
+ In the Python interactive console, first import the library:
+
+ phab = Phabricator(host="https://phab.lubuntu.me/api/";, token="API KEY")
+
+ (for example)
+
+ Then, with an example commit hash, run this:
+
+ phab.diffusion.commit.search(constraints={"query": "a34837de8224"})
+
+ It should correctly return a result, rather than erroring out as shown
+ below.
+
+ [Regression Potential]
+
+ Very unlikely. If the interpretation of the JSON file somehow changes in
+ the underlying Python code, it could regress, but the more likely
+ scenario is that the API changes again in upstream Phabricator, which
+ will need another SRU to adjust.
+
+ [Original Description]
+
I'm looking to improve some Phabricator code for Lugito (Lubuntu's
Python script which acts as a hook for commits such as IRC
notifications), and I can't use diffusion.commit.search because there's
no support for it yet.
>>> phab.diffusion.commit.search(constraints={"query": "a34837de8224"})
Traceback (most recent call last):
- File "", line 1, in
- File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 248, in
__call__
- return self._request(**kwargs)
- File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 323, in
_request
- data = self._parse_response(response)
- File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 333, in
_parse_response
- raise APIError(parsed['error_code'], parsed['error_info'])
+ File "", line 1, in
+ File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 248, in
__call__
+ return self._request(**kwargs)
+ File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 323, in
_request
+ data = self._parse_response(response)
+ File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 333, in
_parse_response
+ raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-CONDUIT-CALL: Conduit API method "commit.search"
does not exist.
However, my Phabricator instance (last updated about a week ago) says
this under diffusions.querycommits:
Frozen Method: This method is frozen and will eventually be deprecated.
New code should use "diffusion.commit.search" instead.
A patch adding support for this is available upstream:
https://github.com/disqus/python-
phabricator/commit/a52c0e1357532f9ef8b26321d3728a0edead6ed4
This needs to be backported, or functionality will be lost.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786337
Title:
diffusion.querycommits deprecated in favor of diffusion.commit.search
which support hasn't been merged for yet
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
This bug was fixed in the package python-phabricator - 0.7.0-1ubuntu1 --- python-phabricator (0.7.0-1ubuntu1) cosmic; urgency=medium * Add diffusion.commit.search endpoint to interfaces.json (LP: #1786337). -- Simon Quigley Thu, 09 Aug 2018 15:03:16 -0500 ** Changed in: python-phabricator (Ubuntu Cosmic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786337 Title: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786337] Re: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
https://launchpad.net/ubuntu/+source/python-phabricator/0.7.0-1ubuntu1 ** Changed in: python-phabricator (Ubuntu Cosmic) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786337 Title: diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-phabricator/+bug/1786337/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
