[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Changed in: scite (Ubuntu Bionic) Status: Fix Released => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
This bug was fixed in the package scite - 4.0.0-1ubuntu0.1 --- scite (4.0.0-1ubuntu0.1) bionic; urgency=medium * Add patch enable_lua_to_access_dynamic_libraries.patch enabling dynamic Lua libraries in SciTE (LP: #1804865) -- Andreas Rönnquist Fri, 23 Nov 2018 20:53:03 +0100 ** Changed in: scite (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Tags removed: verification-done ** Tags added: verification-needed ** Tags removed: verification-done-bionic ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Tags removed: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
Alright, I should mention versions too: error in 4.0.0-1, and working fix in 4.0.0-1ubuntu0.1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
Alright, Installed the package from bionic-proposed in a clean virtual machine, and tested the package. The fix works. ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
It's absolutely right to verify your own changes. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
Please someone perform a SRU verification of this, so we finally can get this into Bionic. (I would do it myself if I could, but it doesn't seem right to verify my own changes). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
Looks good! The SRU description is missing the regression potential field but for a change like this, I guess that would be not very relevant anyway. Accepting. ** Changed in: scite (Ubuntu Bionic) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
Sponsored to Bionic, thank you for your contribution to Ubuntu! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Description changed: - SciTE in ubuntu 18.04 has the Lua library embedded, and compiled without - dynamic libraries enabled. This makes it impossible to load Lua modules - which is in the dynamic library on SciTE >= 4.0, when it started using - Lua 5.3. + [Impact] + + No Lua module which is in the dynamic library can be loaded by SciTE on + Linux since >=4.0 (when it started using Lua 5.3). + + [Test Case] + + First - create /usr/local/lib/lua/5.3/system and symlink a module there: + + sudo apt -y install lua-system + sudo mkdir -p /usr/local/lib/lua/5.3/system + sudo ln -s /usr/lib/x86_64-linux-gnu/lua/5.3/system/core.so /usr/local/lib/lua/5.3/system/core.so + + + Add a Lua script to the startup scripts: (Use the menu "Options" -> "Open Lua Startup Script") and add + + local system = require 'system.core' + print( "System.Gettime is ", system.gettime() ) + + which should simply print the current time using the Lua library when + starting SciTE, instead gives an error: + + error loading module 'system.core' from file '/usr/local/lib/lua/5.3/system/core.so': + dynamic libraries not enabled; check your Lua installation + >Lua: error occurred while running startup script + + + [Other] + + (Previous text): + + + SciTE in ubuntu 18.04 has the Lua library embedded, and compiled without dynamic libraries enabled. This makes it impossible to load Lua modules which is in the dynamic library on SciTE >= 4.0, when it started using Lua 5.3. On later versions (SciTE >= 4.1.0) I have built Lua without using the embedded Lua library but using Debian-packaged shared object instead, and there this isn't a problem. (I am one of the Debian maintainers of SciTE). This leaves the version in 18.04, where this still is a problem. - See upstream bug at + See upstream bug at https://sourceforge.net/p/scintilla/bugs/2058/ for a patch. Another alternative is to backport version 4.1.0 or later to Ubuntu 18.04. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
Done according to your instructions - I hope I got it right now. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Patch added: "Fix" https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+attachment/5257396/+files/scite_fix_dynamic_libraries.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
Thank you for the bug report, and apologies for the delay on this. Could you please edit the bug description to follow the SRU template? https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template As for the debdiff, please put it in a patch file and attach it to the bug report instead of pasting it into a comment. You can find the recommended versioning scheme here: https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging Unsubscribing the sponsors team, please resubscribe us when that is complete. Thank you! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Tags added: patch-accepted-upstream ** Also affects: scite (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: scite (Ubuntu Bionic) Importance: Undecided => Low ** Changed in: scite (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Changed in: scite (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
** Tags added: bionic patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
diff -Nru scite-4.0.0/debian/changelog scite-4.0.0/debian/changelog --- scite-4.0.0/debian/changelog2017-08-16 19:11:14.0 +0200 +++ scite-4.0.0/debian/changelog2018-11-23 20:53:03.0 +0100 @@ -1,3 +1,10 @@ +scite (4.0.0-1ubuntu1) bionic; urgency=medium + + * Add patch enable_lua_to_access_dynamic_libraries.patch +enabling dynamic Lua libraries in SciTE (LP: #1804865) + + -- Andreas Rönnquist Fri, 23 Nov 2018 20:53:03 +0100 + scite (4.0.0-1) unstable; urgency=medium * New upstream release diff -Nru scite-4.0.0/debian/patches/enable_lua_to_access_dynamic_libraries.patch scite-4.0.0/debian/patches/enable_lua_to_access_dynamic_libraries.patch --- scite-4.0.0/debian/patches/enable_lua_to_access_dynamic_libraries.patch 1970-01-01 01:00:00.0 +0100 +++ scite-4.0.0/debian/patches/enable_lua_to_access_dynamic_libraries.patch 2018-11-23 20:52:15.0 +0100 @@ -0,0 +1,32 @@ +Author: jj5 +Description: On Linux, enable Lua to access dynamic libraries. +Applied-Upstream: https://sourceforge.net/p/scintilla/scite/ci/2b22af2a7fbbaec530d5043523ecf8d49a6e02c9/ +Index: scite-4.0.0/scite/gtk/makefile +=== +--- scite-4.0.0.orig/scite/gtk/makefile scite-4.0.0/scite/gtk/makefile +@@ -77,7 +77,7 @@ vpath %.c $(srcdir)/../lua/src + INCLUDEDIRS=-I $(srcdir)/../../scintilla/include -I $(srcdir)/../src -I$(srcdir)/../lua/src + + .c.o: +- $(CC) $(CPPFLAGS) $(INCLUDEDIRS) $(MISLEADING) -DLUA_USE_POSIX $(CXXTFLAGS) $(CFLAGS) -c $< -o $@ ++ $(CC) $(CPPFLAGS) $(INCLUDEDIRS) $(MISLEADING) -DLUA_USE_POSIX $(LUACFLAGS) $(CXXTFLAGS) $(CFLAGS) -c $< -o $@ + + else + CXXTFLAGS+=-DNO_LUA +@@ -88,12 +88,15 @@ CXXTFLAGS:=$(CXXTFLAGS) + UNAME:=$(shell uname -s) + ifeq ($(UNAME), Linux) + LIBDL:=-ldl ++LUACFLAGS:=-DLUA_USE_DLOPEN + endif + ifneq (,$(findstring GNU,$(UNAME))) + LIBDL:=-ldl ++LUACFLAGS:=-DLUA_USE_DLOPEN + endif + ifeq ($(UNAME), Darwin) + CXXTFLAGS:=$(CXXTFLAGS) -Dunix ++LUACFLAGS:=-DLUA_USE_DLOPEN + endif + + .cxx.o: diff -Nru scite-4.0.0/debian/patches/series scite-4.0.0/debian/patches/series --- scite-4.0.0/debian/patches/series 2017-08-16 19:11:14.0 +0200 +++ scite-4.0.0/debian/patches/series 2018-11-23 20:39:40.0 +0100 @@ -1,3 +1,4 @@ hardening_flags.patch do_not_use_remote_logo.patch reproducible_build.patch +enable_lua_to_access_dynamic_libraries.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1804865] Re: Lua dynamic libraries isn't enabled
Upstream fix here: https://sourceforge.net/p/scintilla/scite/ci/2b22af2a7fbbaec530d5043523ecf8d49a6e02c9/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1804865 Title: Lua dynamic libraries isn't enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/scite/+bug/1804865/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
