[Bug 180624] Re: cheese new upstream version 0.3.0
Mantas Kriaučiūnas is also interested in preparing the new upstream release, and he provided an updated diff for 2.21.5. ** Attachment added: "cheese_2.21.5-0ubuntu1.diff.gz" http://launchpadlibrarian.net/11477374/cheese_2.21.5-0ubuntu1.diff.gz ** Summary changed: - cheese new upstream version 0.3.0 + cheese new upstream releases (2.21.5) ** Description changed: Binary package hint: cheese Changes * add a shutter sound, when taking a photo * sort the thumbnail chronologically * make the effect chooser look a bit nicer * give thumbnails a frame like in nautilus and eog. fixes bug #500819 * enable shortcuts if the mouse pointer is over the xoverlay. fixes bug #493196 * add new shortcuts o space for take a photo/start-stop recording o ctrl q for exiting o f1 for help o delete for removing a photo or video * add a gconf backend * chosen effects are stored in gconf. fixes bug #488834 * store the used webcam device in gconf. partially fixes bug #473038 * use a throbber, when the camera is loading * add drag and drop support to the iconview * vertical and horizontal flip were switched. fixes bug #479238 * many usability improvements. partially fixes bug #501337 * point to the right homepage in the about dialog * add a boilerplate for a manual in cheese. partially fixes #480628 * make video and photo button a toggle button. fixes bug #498022 * make links on about dialog clickable. fixes bug #499425 * translate menu items created by gtkuimanager, fixes bug #500821 * change the first item in menu to "Cheese" * add a "Move all to trash" option * use gtkuimanager for the menu * give the ability to record videos from the menu * provide access to the effect chooser using the menu * use radio buttons in the menu to change between photo and video mode * use HAL to detect webcams * make ximagesink an xvimagesink work for all cameras * only use raw video formats. fixes bug #502174 * use the highest resolution for each camera * add --verbose command line option, fixes bug #499399 * cheese was refactored and uses now a webcam class * removed some memory leaks * fixed many, many bugs * added/updated translations + + ... -- cheese new upstream releases (2.21.5) https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
** Also affects: cheese (Baltix) Importance: Undecided Status: New -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
FYI, cheese 2.21.5 came out. -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
Hi Steve, Updating the first patch shouldn't be too hard; you can find information about patch systems and the way patches are added / updated at: https://wiki.ubuntu.com/MOTU/School/PatchingSources https://wiki.ubuntu.com/PackagingGuide/PatchSystems There might be more complete pages for specific patch systems in: https://wiki.ubuntu.com/?action=fullsearch&context=180&value=patch&titlesearch=Titles I'd recommend you try updating the first patch which is the easiest; see my hints in comment #10: the patch used to change two words on the section line, but only one word was fixed upstream in the new upstream release, so you still need it for the other word. The way to go is to either recreate the patch manually or to force it's application (despite the patch not applying) and fix the conflicts. When you're done, just attach the updated patch and I'll help you split the other patch into smaller tasks to update it. -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
Hi Loïc, It seems there is a new version available. I have corrected everything except for the patches, which seem to be Ubuntu specific. How do you update patches? -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
** Changed in: cheese (Ubuntu) Status: In Progress => Incomplete -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
** Changed in: cheese (Ubuntu) Assignee: (unassigned) => Steve Stalcup (vorian) Status: Confirmed => In Progress -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
I've unsubscribed ubuntu-universe-sponsors based on the previous request for additional changes by a sponsor. Also, please follow the status of the cheese task in bug #149275 closely, it may be that ubuntu-main- sponsors will need to be subscribed to the revised candidate. -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
Hi Steve, Good progress in this updated interdiff; here's an updated review: I) I see you documented the removal of patches as "Removed debian/patches fixed in this release"; however, in my reading, the functionality of each patch is still missing from the new upstream release; could you explain why you think each one can be dropped with more details? For example, if you see what the fix_desktop patch fixed, perhaps you can explain why you think it can be completely dropped? I think the .desktop file still needs fixing in the new upstream release, as only part of the fix was merged. Concerning the hildon patch, could you check the debian/changelog and tell me whether you understand what it is about? If you can't find out, I shall explain it and we will document it in the patch. II) In your previous version, you dropped debian/docs, and in the new one you don't touch it at all; but upstream used to ship a TODO file and doesn't do so anymore -- does the package build if the TODO is listed in debian/docs but not present? III) Could you please revert or explain the reasons why you changed in debian/rules: --include /usr/share/gnome-pkg-tools/1/rules/gnome-get-source.mk +include /usr/share/gnome-pkg-tools/1/rules/gnome-get-source.mk and in debian/changelog: cheese (0.2.4-0ubuntu3) hardy; urgency=low - * Watch file added (LP: #180380) + * Watch file added (closes LP #180380) IV) You changed the watch file, but you didn't mention it in your new 0.3.0-0ubuntu1 changelog entry V) a) I see you fixed most of the build-deps, that's nice! However, could you please recheck the required version for libglade2-dev, libgnomeui-dev? b) Also, you added a build-dependency on libgconf2-4, I think you meant libgconf2-dev. c) The configure.ac checks as follows: gstreamer-0.10 >= $GSTREAMER_REQUIRED \ gstreamer-plugins-base-0.10 >= $GSTREAMER_REQUIRED \ please update the libgstreamer-plugins-base0.10-dev accordingly. VI) Very minor sugar spacing issues: - still adding trailing space to the debian/rules shebang -- see interdiff - "libgnomeui-dev (>=2.0)" => note missing space after >= - Homepage control field misses a trailing / - You use http://ftp.gnome.org in the watch file but http://www.gnome.org/ in the copyright; I'd suggest using ftp.g.o everywhere -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
Loïc, Thank you very much for the feedback. I hope this new revision meets the appropriate standards :) * New upstream release (LP #180624) - Added build-deps libxml-parser-perl, gnome-doc-utils, and scrollkeeper for documentation build - Added missing libglib2.0-dev (>= 2.10.0) build-dep - Added missing libgconf2-4 (>= 2.16.0) build-dep - Added missing libcairo2-dev (>= 1.2.4) build-dep - Added missing libdbus-1-dev (>= 1.0) build-dep - Added missing libhal-dev (>= 0.5.9) build-dep - Added missing libdbus-glib-1-dev (>= 0.7) build-dep - Removed debian/patches fixed in this release - Changed homepage (when referenced) to new http://www.gnome.org/projects/cheese * Bumped up Standards-Version to 3.7.3, no change needed ** Attachment added: "cheese_0.3.0-0ubuntu1.interdiff.gz" http://launchpadlibrarian.net/11198342/cheese_0.3.0-0ubuntu1.interdiff.gz -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
@Steve: in comment #5, you call interdiff twice, the first time with -p1, the second time without; this is why your interdiff is garbled. You don't need to gzip the interdiff if it's reasonably small. -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
@Steve: Some minor and less minor issues with your update: 1) you drop the hildon patch, can you explain why? 2) same question for the patch fix_desktop Even if you have a good reason to drop patches, you need to mention why in the changelog (usually the reason patches are dropped is because all the fixes they carried were merged upstream). 3) I don't understand your comment "debian/docs removed as was blank": could you clarify? I see some useful bits at the end of the upstream README which could help people setup cheese with their hardware, I think we should make sure people get the information in some way. 4) The upstream build changed a lot in 0.3.0: it wasn't autotools based in the past, which made understanding the exact build-dependencies less easy, and it seems the 0.2.4 packaging in Ubuntu was missing some build- deps; this is however relatively easy to read in the new autoconf based build, if you look at configure.ac, you should see e.g. GLIB_REQUIRED=2.10.0 and then PKG_CHECK_MODULES(CHEESE, glib-2.0 >= $GLIB_REQUIRED [...]), this means you need a libglib2.0-dev (>= 2.10.0) build-dep (this package ships glib-2.0.pc). Could you please update the build-dependencies to match the now more readable requirements in the new upstream build system? 5) This is from the extra style points department: ;) a) as an interdiff shows nicely, you added a spurious space in debian/rules b) your changelog lists multiple different things together: you mention a new upstream release on one line and then misc debian/control changes on another line, such as updating build-deps and Standards-Version; instead, it would be extra nice to list logical changes together, consider this: * New upstream release - Added build-deps on libxml-parser-perl and gnome-doc-utils for the documentation build - Added missing libglib2.0-dev (>= 2.10.0) build-dep - Dropped TODO from debian/docs as this file isn't shipped upstream anymore. * Bumped up Standards-Version to 3.7.3, no change needed. this is just a suggestion, but I'm sure you'll find it quite natural in this way! c) your changelog mentions "many new upstream changes, see upstream NEWS" but this isn't very helpful to readers; first, you don't actually install the NEWS file, second, this isn't very helpful since if people don't read about the upstream changes, they'll naturally look for the upstream changes! Anyway, the 5th point is less important, it's much more about cosmetics and style. Cheers, -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
** Attachment added: "cheese_0.3.0-0ubuntu1.debdiff" http://launchpadlibrarian.net/11187375/cheese_0.3.0-0ubuntu1.debdiff -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
Loïc, Started over from the beginning, [EMAIL PROTECTED]:~/cheese-^$ interdiff -z -p1 cheese_0.2.4-0ubuntu3.diff.gz cheese_0.3.0-0ubuntu1.diff.gz > check.interdiff [EMAIL PROTECTED]:~/cheese-^$ interdiff -z cheese_0.2.4-0ubuntu3.diff.gz cheese_0.3.0-0ubuntu1.diff.gz | gzip --best -c - > cheese_0.3.0-0ubuntu1.interdiff.gz [EMAIL PROTECTED]:~/cheese-^$ combinediff -z cheese_0.3.0-0ubuntu1.interdiff.gz cheese_0.2.4-0ubuntu3.diff.gz > test.diff [EMAIL PROTECTED]:~/cheese-^$ interdiff -z test.diff cheese_0.3.0-0ubuntu1.diff.gz [EMAIL PROTECTED]:~//cheese-^$ resulting in the attached interdiff & debdiff ** Attachment added: "cheese_0.3.0-0ubuntu1.interdiff.gz" http://launchpadlibrarian.net/11187370/cheese_0.3.0-0ubuntu1.interdiff.gz -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
Hello Loïc, here you go. ** Attachment added: "cheese_0.3.0-0ubuntu1.interdiff" http://launchpadlibrarian.net/11185310/cheese_0.3.0-0ubuntu1.interdiff -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
** Attachment removed: "cheese_0.3.0-0ubuntu1.interdiff.gz" http://launchpadlibrarian.net/11167796/cheese_0.3.0-0ubuntu1.interdiff.gz -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
@Steve: your interdiff looks huge and is hard to read, all files are removed and then readded -- did you pass -p1? Could you please update your interdiff with "interdiff -z -p1 old- version.diff.gz new-version.diff.gz > new-version.interdiff"? Or you can "debdiff | filterdiff -i '*/debian/*'" etc. -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
Loïc: can you take a look at this one? -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
** Tags added: upgrade -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 180624] Re: cheese new upstream version 0.3.0
** Attachment added: "cheese_0.3.0-0ubuntu1.interdiff.gz" http://launchpadlibrarian.net/11167796/cheese_0.3.0-0ubuntu1.interdiff.gz ** Changed in: cheese (Ubuntu) Status: New => Confirmed -- cheese new upstream version 0.3.0 https://bugs.launchpad.net/bugs/180624 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
