[Bug 1816650] Re: 4.19+ (and possibly -stable trees?) need a fix from upstream
** Also affects: lldpd (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: lldpd (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: lldpd (Ubuntu) Status: New => Fix Released ** Changed in: lldpd (Ubuntu Bionic) Assignee: (unassigned) => Nish Aravamudan (nacc) ** Changed in: lldpd (Ubuntu Cosmic) Assignee: (unassigned) => Nish Aravamudan (nacc) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1816650 Title: 4.19+ (and possibly -stable trees?) need a fix from upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lldpd/+bug/1816650/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1816650] Re: 4.19+ (and possibly -stable trees?) need a fix from upstream
This bug was fixed in the package lldpd - 0.9.9-1ubuntu0.1 --- lldpd (0.9.9-1ubuntu0.1) bionic; urgency=medium * debian/patches/0002-remove-specific-handling-for-bond.patch: Remove specific handling for bonds. Thanks to Vincent Bernat . Closes LP: #1816650. -- Nishanth Aravamudan Wed, 20 Feb 2019 14:24:36 -0600 ** Changed in: lldpd (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1816650 Title: 4.19+ (and possibly -stable trees?) need a fix from upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lldpd/+bug/1816650/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1816650] Re: 4.19+ (and possibly -stable trees?) need a fix from upstream
Thank you for the verification! I have released this to bionic-updates just now. Could you or someone else perform the same validation on a 18.10 system? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1816650 Title: 4.19+ (and possibly -stable trees?) need a fix from upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lldpd/+bug/1816650/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1816650] Re: 4.19+ (and possibly -stable trees?) need a fix from upstream
** Description changed: + [Impact] + + lldpctl indicates duplicate LLDP records. + + [Test Case] + + On a system with a bonded link, issue: + + # lldpctl | grep PortDescr + + and it will indicate duplicate records. + + After applying the fix, issue the same command and duplicates will be + elided. + + [Regression Potential] + + The above issue is only seen on kernels newer than 4.19 (so 19.04+, + which implies 18.04.3's kernel). However, the bond-specific code in + lldpctl is only needed on kernels <= 2.6.27 per upstream, which is older + than any kernel in any supported Ubuntu. This fix allows future-proofs + lldpctl for the eventual HWE impact. + + [Original Description] + So I think this commit: https://github.com/torvalds/linux/commit/6a9e461f6fe4434e6172304b69774daff9a3ac4c has been backported to some -stable trees. This makes lldpd < 1.0.3 duplicate entries. I think given both -stable trees in existing Ubuntu and the HWE stack in 18.04 (even if only 18.04.3), we should backport https://github.com/vincentbernat/lldpd/pull/307/commits/0638075c721323aa6aeab9c6ab282861f53c9f2f to the source package in 18.04+. ** Changed in: lldpd (Ubuntu Cosmic) Status: New => Won't Fix ** Changed in: lldpd (Ubuntu Cosmic) Status: Won't Fix => In Progress ** Changed in: lldpd (Ubuntu Bionic) Status: New => In Progress ** Description changed: [Impact] - lldpctl indicates duplicate LLDP records. + lldpctl indicates duplicate LLDP records. While the above issue is only + seen on kernels newer than 4.19 (so 19.04+, which implies 18.04.3's + kernel), this patch has been backported to the -stable tree. [Test Case] On a system with a bonded link, issue: # lldpctl | grep PortDescr and it will indicate duplicate records. After applying the fix, issue the same command and duplicates will be elided. [Regression Potential] - The above issue is only seen on kernels newer than 4.19 (so 19.04+, - which implies 18.04.3's kernel). However, the bond-specific code in - lldpctl is only needed on kernels <= 2.6.27 per upstream, which is older - than any kernel in any supported Ubuntu. This fix allows future-proofs - lldpctl for the eventual HWE impact. + However, the bond-specific code in lldpctl is only needed on kernels <= + 2.6.27 per upstream, which is older than any kernel in any supported + Ubuntu. This fix allows future-proofs lldpctl for the eventual HWE + impact. [Original Description] So I think this commit: https://github.com/torvalds/linux/commit/6a9e461f6fe4434e6172304b69774daff9a3ac4c has been backported to some -stable trees. This makes lldpd < 1.0.3 duplicate entries. I think given both -stable trees in existing Ubuntu and the HWE stack in 18.04 (even if only 18.04.3), we should backport https://github.com/vincentbernat/lldpd/pull/307/commits/0638075c721323aa6aeab9c6ab282861f53c9f2f to the source package in 18.04+. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1816650 Title: 4.19+ (and possibly -stable trees?) need a fix from upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lldpd/+bug/1816650/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1816650] Re: 4.19+ (and possibly -stable trees?) need a fix from upstream
Hello Nish, or anyone else affected, Accepted lldpd into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lldpd/1.0.1-1ubuntu0.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: lldpd (Ubuntu Cosmic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-cosmic ** Changed in: lldpd (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1816650 Title: 4.19+ (and possibly -stable trees?) need a fix from upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lldpd/+bug/1816650/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1816650] Re: 4.19+ (and possibly -stable trees?) need a fix from upstream
Before: # lldpctl | grep PortDescr PortDescr:et-0/0/23:0 PortDescr:et-0/0/23:0 PortDescr:et-0/0/23:0 PortDescr:et-0/0/23:0 After: # lldpctl | grep PortDescr PortDescr:et-0/0/23:0 PortDescr:et-0/0/23:0 Using: 0.9.9-1ubuntu0.1 on 18.04 ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1816650 Title: 4.19+ (and possibly -stable trees?) need a fix from upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lldpd/+bug/1816650/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1816650] Re: 4.19+ (and possibly -stable trees?) need a fix from upstream
The version of lldpd in the proposed pocket of Cosmic that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion. ** Tags removed: verification-needed-cosmic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1816650 Title: 4.19+ (and possibly -stable trees?) need a fix from upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lldpd/+bug/1816650/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs