[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
This bug was fixed in the package openrazer - 2.5.0+dfsg-1ubuntu2
---
openrazer (2.5.0+dfsg-1ubuntu2) eoan; urgency=medium
* Make drivers return -ENODEV for kernels without RAW HID and USB
support such as s390x (LP: #1830055)
- this is a more generic solution to making this driver build for
all kernels/architectures without the need of special arch
specific packaging build exceptions.
* Apply upstream fixes that address issues found with static analysis
of the driver:
- 39fc3b34c6fc ("razercore: remove redundant check on retval")
- 33afc37782b9 ("razerkraken_driver: set the device->serial
string correctly")
- 279c86ea75f1 ("razermousemat_driver: remove redundant check on
retval")
-- Colin Ian King Fri, 21 Jun 2019 18:32:11
+0100
** Changed in: openrazer (Ubuntu)
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1830055
Title:
openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
New Source package in: https://kernel.ubuntu.com/~cking/lp-1830055/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
Need another upload to disable s390x build completely. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
** Attachment added: "debdiff with fix" https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+attachment/5269163/+files/openrazer_2.5.0+dfsg-1_2.5.0+dfsg-1ubuntu1.diff.gz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
Source package in https://kernel.ubuntu.com/~cking/lp-1830055/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
Probably best to just disable s390 dkms builds as this will never support HID interfaces. Also disallows user from attempting to load a module that will fail to load. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
So, on 5.0 kernels the build does not fail because modpost is more relaxed and will throw warnings on undefined symbols, whereas with 5.2 modpost throws an error. Interesting fact is that modprobing the razercore on a 5.0 s390 kernel will fail with: [ 2553.134689] razercore: Unknown symbol hid_unregister_driver (err -2) [ 2553.134703] razercore: Unknown symbol hid_hw_start (err -2) [ 2553.134725] razercore: Unknown symbol __hid_register_driver (err -2) [ 2553.134748] razercore: Unknown symbol hid_hw_stop (err -2) [ 2553.134782] razercore: Unknown symbol usb_control_msg (err -2) [ 2553.134804] razercore: Unknown symbol usb_disable_autosuspend (err -2) [ 2553.134820] razercore: Unknown symbol hid_open_report (err -2) And on 5.2 it just won't build because of modpost being more proactive at checking this. I think the modpost should be relaxed so at least it will build on 5.2. It may not load with our kernel, but I guess if somebody wants it they need to have their own kernel with the hid support for s390x (which probably does not exist). Alternatively we could disable the build for s390x. I'd prefer to relax odpost as we leave room for a user to at least use their own kernel that may support this driver. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
This is failing because HID functionality is not built into the s390x kernel: CC [M] /var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore_driver.o LD [M] /var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore.o Building modules, stage 2. MODPOST 6 modules ERROR: "hid_open_report" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermug.ko] undefined! ERROR: "usb_disable_autosuspend" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermug.ko] undefined! ERROR: "usb_control_msg" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermug.ko] undefined! ERROR: "hid_hw_stop" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermug.ko] undefined! ERROR: "__hid_register_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermug.ko] undefined! ERROR: "hid_hw_start" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermug.ko] undefined! ERROR: "hid_unregister_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermug.ko] undefined! ERROR: "hid_open_report" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermousemat.ko] undefined! ERROR: "usb_disable_autosuspend" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermousemat.ko] undefined! ERROR: "usb_control_msg" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermousemat.ko] undefined! ERROR: "hid_hw_stop" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermousemat.ko] undefined! ERROR: "__hid_register_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermousemat.ko] undefined! ERROR: "hid_hw_start" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermousemat.ko] undefined! ERROR: "hid_unregister_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermousemat.ko] undefined! ERROR: "hid_open_report" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermouse.ko] undefined! ERROR: "usb_control_msg" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermouse.ko] undefined! ERROR: "hid_hw_stop" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermouse.ko] undefined! ERROR: "__hid_register_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermouse.ko] undefined! ERROR: "hid_hw_start" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermouse.ko] undefined! ERROR: "hid_unregister_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razermouse.ko] undefined! ERROR: "hid_open_report" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkraken.ko] undefined! ERROR: "usb_disable_autosuspend" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkraken.ko] undefined! ERROR: "usb_control_msg" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkraken.ko] undefined! ERROR: "hid_hw_stop" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkraken.ko] undefined! ERROR: "__hid_register_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkraken.ko] undefined! ERROR: "hid_hw_start" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkraken.ko] undefined! ERROR: "hid_unregister_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkraken.ko] undefined! ERROR: "hid_open_report" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkbd.ko] undefined! ERROR: "usb_disable_autosuspend" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkbd.ko] undefined! ERROR: "usb_control_msg" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkbd.ko] undefined! ERROR: "hid_hw_stop" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkbd.ko] undefined! ERROR: "__hid_register_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkbd.ko] undefined! ERROR: "hid_hw_start" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkbd.ko] undefined! ERROR: "hid_unregister_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razerkbd.ko] undefined! ERROR: "hid_open_report" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore.ko] undefined! ERROR: "usb_disable_autosuspend" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore.ko] undefined! ERROR: "usb_control_msg" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore.ko] undefined! ERROR: "hid_hw_stop" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore.ko] undefined! ERROR: "__hid_register_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore.ko] undefined! ERROR: "hid_hw_start" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore.ko] undefined! ERROR: "hid_unregister_driver" [/var/lib/dkms/openrazer-driver/2.5.0/build/driver/razercore.ko] undefined! make[2]: *** [scripts/Makefile.modpost:91: __modpost] Error 1 make[1]: *** [Makefile:1629: modules] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-5.2.0-3-generic' make: *** [Makefile:25: driver] Error 2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0
[Bug 1830055] Re: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1
** Changed in: openrazer (Ubuntu) Assignee: (unassigned) => Colin Ian King (colin-king) ** Changed in: openrazer (Ubuntu) Importance: Undecided => Medium ** Changed in: openrazer (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830055 Title: openrazer 2.5.0+dfsg-1 ADT test failure with linux 5.2.0-0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openrazer/+bug/1830055/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
