[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-12-09 Thread Corey Bryant
This bug was fixed in the package horizon - 3:13.0.2-0ubuntu2~cloud0
---

 horizon (3:13.0.2-0ubuntu2~cloud0) xenial-queens; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (3:13.0.2-0ubuntu2) bionic; urgency=medium
 .
   * d/p/lp1840465.patch: Fix failing to list security groups
 with no rules (LP: #1840465).


** Changed in: cloud-archive/queens
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-12-09 Thread Corey Bryant
This bug was fixed in the package horizon - 3:14.0.3-0ubuntu1~cloud1
---

 horizon (3:14.0.3-0ubuntu1~cloud1) bionic-rocky; urgency=medium
 .
   * d/p/lp1840465.patch: Fix failing to list security groups
 with no rules (LP: #1840465).


** Changed in: cloud-archive/rocky
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-12-09 Thread Corey Bryant
This bug was fixed in the package horizon - 3:15.1.0-0ubuntu1.2~cloud0
---

 horizon (3:15.1.0-0ubuntu1.2~cloud0) bionic-stein; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (3:15.1.0-0ubuntu1.2) disco; urgency=medium
 .
   * d/p/lp1840465.patch: Fix failing to list security groups
 with no rules (LP: #1840465).


** Changed in: cloud-archive/stein
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-12-09 Thread Edward Hope-Morley
** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-12-03 Thread Hemanth Nakkina
The test case mentioned in the bug description have been verified on
bionic-stein

** Tags removed: verification-stein-needed
** Tags added: verification-stein-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-12-02 Thread Launchpad Bug Tracker
This bug was fixed in the package horizon - 3:13.0.2-0ubuntu2

---
horizon (3:13.0.2-0ubuntu2) bionic; urgency=medium

  * d/p/lp1840465.patch: Fix failing to list security groups
with no rules (LP: #1840465).

 -- Rodrigo Barbieri   Fri, 18 Oct 2019
20:27:28 +

** Changed in: horizon (Ubuntu Bionic)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-12-02 Thread Launchpad Bug Tracker
This bug was fixed in the package horizon - 3:15.1.0-0ubuntu1.2

---
horizon (3:15.1.0-0ubuntu1.2) disco; urgency=medium

  * d/p/lp1840465.patch: Fix failing to list security groups
with no rules (LP: #1840465).

 -- Rodrigo Barbieri   Fri, 18 Oct 2019
19:13:41 +

** Changed in: horizon (Ubuntu Disco)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-11-28 Thread Rodrigo Barbieri
verified on disco-stein

** Tags removed: verification-needed-disco
** Tags added: verification-done-disco

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-11-27 Thread Rodrigo Barbieri
verified on bionic-queens

** Tags removed: verification-needed-bionic verification-queens-needed
** Tags added: verification-done-bionic verification-queens-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-11-21 Thread Łukasz Zemczak
Hello Tobias, or anyone else affected,

Accepted horizon into bionic-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/horizon/3:13.0.2-0ubuntu2 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: horizon (Ubuntu Bionic)
   Status: In Progress => Fix Committed

** Tags added: verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-11-21 Thread Łukasz Zemczak
Hello Tobias, or anyone else affected,

Accepted horizon into disco-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/horizon/3:15.1.0-0ubuntu1.2 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-disco to verification-done-disco. If it does not fix
the bug for you, please add a comment stating that, and change the tag
to verification-failed-disco. In either case, without details of your
testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: horizon (Ubuntu Disco)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-disco

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-11-14 Thread Rodrigo Barbieri
Since the system behaves as expected with the updated package installed,
passing the test case, I will mark it as verified.

** Tags removed: verification-rocky-needed
** Tags added: verification-rocky-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-11-13 Thread Rodrigo Barbieri
I tried to reproduce again in a different deployment unsuccessfully. I
don't know how (and if) it differs from the previous instance I was able
to reproduce it.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-11-12 Thread Rodrigo Barbieri
While performing validation, I was unable to reproduce the issue in
bionic-rocky deployment. Inspecting the code, the fix was not present. I
added logging, and confirmed that neutron is now including the key
"security_group_rules" in the response, therefore the error is no longer
triggered. I added logging to confirm that it was indeed the case, and
got:

[Tue Nov 12 22:32:51.766942 2019] [wsgi:error] [pid 26153:tid
139930429884160] [remote 10.5.0.43:40358] sg: {'id': '40ca8baa-
a3a5-412d-b955-7f9fb3e86e26', 'name': 'test3', 'tenant_id':
'a3ef2c1a2a8e4b628f592e0f87ef3c11', 'description': '',
'security_group_rules': [], 'tags': [], 'created_at':
'2019-11-12T22:11:56Z', 'updated_at': '2019-11-12T22:12:03Z',
'revision_number': 3, 'project_id': 'a3ef2c1a2a8e4b628f592e0f87ef3c11'}

I also re-tested this with a limited user account, same results.

I proceeded to upgrade the package, confirmed the code has been changed
and includes that fix. Ran the test case and saw that it does not cause
any problems. Added additional logging to confirm the new condition (the
fix) is not invoked as it is not necessary and indeed it was not being
invoked.

I briefly checked neutron, python-neutronclient and horizon code, but I
haven't been able to track down the change that caused the key
'security_group_rules' to no longer be missing.

I proceeded to reproduce the problem in xenial-queens to re-confirm the
test case, and I couldn't.

Therefore my conclusion is that the test case needs to be improved, as
it seems to be missing details that are required to reproduce the
problem.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-22 Thread Akihiro Motoki
** Tags removed: rocky-backport-potential stein-backport-potential

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-21 Thread Corey Bryant
** Changed in: horizon (Ubuntu Eoan)
   Status: In Progress => Fix Released

** Also affects: cloud-archive
   Importance: Undecided
   Status: New

** Also affects: cloud-archive/train
   Importance: Undecided
   Status: New

** Also affects: cloud-archive/rocky
   Importance: Undecided
   Status: New

** Also affects: cloud-archive/queens
   Importance: Undecided
   Status: New

** Also affects: cloud-archive/stein
   Importance: Undecided
   Status: New

** Changed in: cloud-archive/queens
   Importance: Undecided => Medium

** Changed in: cloud-archive/queens
   Status: New => Triaged

** Changed in: cloud-archive/rocky
   Importance: Undecided => Medium

** Changed in: cloud-archive/rocky
   Status: New => Triaged

** Changed in: cloud-archive/stein
   Importance: Undecided => Medium

** Changed in: cloud-archive/stein
   Status: New => Triaged

** Changed in: cloud-archive/train
   Status: New => Fix Released

** Changed in: cloud-archive/train
   Importance: Undecided => Medium

** Changed in: horizon (Ubuntu Eoan)
   Importance: Undecided => Medium

** Changed in: horizon (Ubuntu Disco)
   Importance: Undecided => Medium

** Changed in: horizon (Ubuntu Bionic)
   Importance: Undecided => Medium

** Changed in: horizon (Ubuntu)
   Importance: Undecided => Medium

** Changed in: horizon (Ubuntu)
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-21 Thread Rodrigo Barbieri
** Tags added: sts-sru-needed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-19 Thread Rodrigo Barbieri
** Changed in: horizon (Ubuntu Bionic)
   Status: New => In Progress

** Changed in: horizon (Ubuntu Disco)
   Status: New => In Progress

** Changed in: horizon (Ubuntu Eoan)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-19 Thread Rodrigo Barbieri
Attached debdiffs for disco, cosmic and bionic.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-19 Thread Rodrigo Barbieri
** Patch added: "lp1840465_bionic.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/horizon/+bug/1840465/+attachment/5298453/+files/lp1840465_bionic.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-19 Thread Rodrigo Barbieri
** Patch added: "lp1840465_cosmic.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/horizon/+bug/1840465/+attachment/5298452/+files/lp1840465_cosmic.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-19 Thread Rodrigo Barbieri
** Description changed:

  Horizon 14.0.2 (rocky)
  If a security group without any rules exists the listing of security groups 
fails with a KeyError.
  
  Traceback (most recent call last):
-   File 
"/usr/share/openstack-dashboard/openstack_dashboard/api/rest/utils.py", line 
127, in _wrapped
- data = function(self, request, *args, **kw)
-   File 
"/usr/share/openstack-dashboard/openstack_dashboard/api/rest/network.py", line 
44, in get
- security_groups = api.neutron.security_group_list(request)
-   File "/usr/lib/python2.7/site-packages/horizon/utils/memoized.py", line 95, 
in wrapped
- value = cache[key] = func(*args, **kwargs)
-   File "/usr/share/openstack-dashboard/openstack_dashboard/api/neutron.py", 
line 1641, in security_group_list
- return SecurityGroupManager(request).list(**params)
-   File "/usr/share/openstack-dashboard/openstack_dashboard/api/neutron.py", 
line 372, in list
- return self._list(**params)
-   File "/usr/share/openstack-dashboard/openstack_dashboard/api/neutron.py", 
line 359, in _list
- return [SecurityGroup(sg) for sg in secgroups.get('security_groups')]
-   File "/usr/share/openstack-dashboard/openstack_dashboard/api/neutron.py", 
line 240, in __init__
- for rule in sg['security_group_rules']]
+   File 
"/usr/share/openstack-dashboard/openstack_dashboard/api/rest/utils.py", line 
127, in _wrapped
+ data = function(self, request, *args, **kw)
+   File 
"/usr/share/openstack-dashboard/openstack_dashboard/api/rest/network.py", line 
44, in get
+ security_groups = api.neutron.security_group_list(request)
+   File "/usr/lib/python2.7/site-packages/horizon/utils/memoized.py", line 95, 
in wrapped
+ value = cache[key] = func(*args, **kwargs)
+   File "/usr/share/openstack-dashboard/openstack_dashboard/api/neutron.py", 
line 1641, in security_group_list
+ return SecurityGroupManager(request).list(**params)
+   File "/usr/share/openstack-dashboard/openstack_dashboard/api/neutron.py", 
line 372, in list
+ return self._list(**params)
+   File "/usr/share/openstack-dashboard/openstack_dashboard/api/neutron.py", 
line 359, in _list
+ return [SecurityGroup(sg) for sg in secgroups.get('security_groups')]
+   File "/usr/share/openstack-dashboard/openstack_dashboard/api/neutron.py", 
line 240, in __init__
+ for rule in sg['security_group_rules']]
  KeyError: 'security_group_rules'
+ 
+ ===
+ 
+ [Impact]
+ 
+ By default, new security groups created through horizon or CLI include 2
+ default security rules. Upon managing those rules and removing them (to
+ perhaps add others or limit traffic completely), the security group page
+ errors out and prevents listing of *all* security groups if the empty
+ security group is within the list to be displayed. Therefore, not only
+ is the empty security group affected, but all others as well, as they
+ cannot be listed. The root cause of the bug is that the payload does not
+ include the expected key "security_group_rules" for that security group
+ when there are no rules.
+ 
+ A fix has been implemented for Train (from master), Stein, Rocky and
+ Queens releases and should be backported so the issue is addressed on
+ previous those releases. The fix prevents the crash by ensuring the key
+ "security_group_rules" is present with an empty list in case it was not
+ included in the payload.
+ 
+ [Test Case]
+ 
+ 1. Reproducing the issue
+ 
+ 1a. Go to the Security Group section at Project > Network > Security Groups
+ 1b. Create a security group
+ 1c. Click the Manage Rules button for that security group you just created
+ 1d. Delete the two default rules
+ 1e. Go back to the Security Group section at Project > Network > Security 
Groups
+ 1f. Security groups are no longer being listed and there will be an error 
popup: "Error: Unable to retrieve security groups.".
+ 
+ 2. Install the package with the fixed code
+ 
+ 3. Confirm bug has been fixed
+ 
+ 3a. Repeat step 1a, you will notice that now security groups can be
+ listed, including the empty one you had previously created
+ 
+ 3b. Repeat steps 1b through 1e, the newly created and emptied security
+ group can also be listed along the others.
+ 
+ [Regression Potential]
+ 
+ Given the following indicators:
+ 
+ a. Upstream CI passed, for all releases the fix is being backported.
+ b. The small scope of the problem: a key error prevents the page from being 
rendered. The fix is to make sure the key is always present, since it is always 
expected.
+ c. The fix is very simple, and during tests we can see that the other pages 
handle an empty list properly as the value for the "security_group_rules".
+ 
+ We can safely say there the regression potential is negligible.

** Description changed:

  Horizon 14.0.2 (rocky)
  If a security group without any rules exists the listing of security groups 
fails with a KeyError.
  
  Traceback (most recent call last):
    File 

[Bug 1840465] Re: [SRU] Fails to list security groups if one or more exists without rules

2019-10-19 Thread Rodrigo Barbieri
** Summary changed:

- Fails to list security groups if one or more exists without rules
+ [SRU] Fails to list security groups if one or more exists without rules

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1840465

Title:
  [SRU] Fails to list security groups if one or more exists without
  rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1840465/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs