[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
this problem still exists in 20.04 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
19.10 is EOL, unsubscribed sponsors and removed the series. Please resubscribe ~ubuntu-sponsors if a patch is still needed. ** No longer affects: grub2 (Ubuntu Eoan) ** No longer affects: grubzfs-testsuite (Ubuntu Eoan) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
@jibel, any chance of an SRU for this? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
@finley, this is a different issue. It'll be easier to track in a separate report. Could you file on please? Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
On Ubuntu 19.10, with ZFS root and zfs-auto-snapshot, /etc/grub.d/10_linux_zfs was scanning every single snapshot whenever update-grub was invoked. This is a simple patch that just exits the get_dataset_info() function if the dataset is a snapshot. I could be missing something, but I don't expect we want to be finding kernel & initrd images on snapshots under normal circumstances. ** Patch added: "Simple four line patch I created that solved my issue" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5323115/+files/grub-common-2.04-1ubuntu12.1.dont_scan_snapshots-brianfinley.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
I know it works. jpb propossed the first patch, I tested (#22) But I'm waiting for is an "official" fix :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
> What is needed for a fix for 19.10? The patch to 10_linux_zfs from "grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff" seems to be working fine on 19.10. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
What is needed for a fix for 19.10? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
** Patch removed: "grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5308462/+files/grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff ** Patch added: "grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5308634/+files/grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
** Patch removed: "grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5308448/+files/grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff ** Patch added: "grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5308462/+files/grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
debdiff to backport the fixes from focal to eoan ** Patch added: "grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5308448/+files/grub2_2.04-1ubuntu12.1_1ubuntu12.2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
This bug was fixed in the package grubzfs-testsuite - 0.4.6 --- grubzfs-testsuite (0.4.6) focal; urgency=medium [ Jean-Baptiste Lallement ] [ Didier Roche ] * Test cases for: - Handle the case where grub-probe returns several devices for a single pool (LP: #1848856). - Do not crash on invalid fstab and report the invalid entry. (LP: #1849347) - When a pool fails to import, catch and display the error message and continue with other pools. Import all the pools in readonly mode so we can import other pools with unsupported features (LP: #1848399) -- Jean-Baptiste Lallement Mon, 18 Nov 2019 11:38:20 +0100 ** Changed in: grubzfs-testsuite (Ubuntu Focal) Status: Triaged => Fix Released ** Changed in: grub2 (Ubuntu Focal) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
This bug was fixed in the package grub2 - 2.04-1ubuntu14 --- grub2 (2.04-1ubuntu14) focal; urgency=medium * debian/patches/ubuntu-zfs-enhance-support.patch: - Handle the case where grub-probe returns several devices for a single pool (LP: #1848856). Thanks jpb for the report and the proposed patch. - Add savedefault to non-recovery entries (LP: #1850202). Thanks Deltik for the patch. - Do not crash on invalid fstab and report the invalid entry. (LP: #1849347) Thanks Deltik for the patch. - When a pool fails to import, catch and display the error message and continue with other pools. Import all the pools in readonly mode so we can import other pools with unsupported features (LP: #1848399) Thanks satmandu for the investigation and the proposed patch -- Jean-Baptiste Lallement Mon, 18 Nov 2019 11:22:43 +0100 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
I also tested the fix propossed by jpb in #21 and can confirm that it worked for me as well. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
** Description changed: - At the end of the upgrade from 19.04 to 19.10, the post process of the - update-grub reports: + [Description] + When a pool is created on several devices like cache and log on separate devices, mirror or raidz. When grub-probe queries the target to report the device attached to the boot directory, it reports all the devices that make the pool, one by line. The result is an error in 10_linux_zfs that generates an invalid grub configuration file. Only the case 1 pool = 1 device was considered + + [Test Case] + 1. Create a mirrored pool + $ zpool create mirror /dev/Xda1 /dev/Xda2 + + 2. run update-grub + + Expected result: + grub configuration is generated successfully. + + Actual result: + The generated grub configuration file is incomplete and its syntax is invalid + + [Regression Potential] + Low. The patch takes the first device returned by grub-probe which is the first device of data of the mirror. + + [Original Description] + At the end of the upgrade from 19.04 to 19.10, the post process of the update-grub reports: Syntax error at line 185 Syntax errors are detected in generated GRUB config file. Ensure that there are no errors in /etc/default/grub and /etc/grub.d/* files or please file a bug report with /boot/grub/grub.cfg.new file attached. run-parts: /etc/kernel/postinst.d/zz-update-grub exited with return code 1 dpkg: error processing package linux-image-5.3.0-18-generic (--configure): - installed linux-image-5.3.0-18-generic package post-installation script subprocess returned error exit status 1 + installed linux-image-5.3.0-18-generic package post-installation script subprocess returned error exit status 1 Errors were encountered while processing: - friendly-recovery - grub-efi-amd64 - grub-efi - grub-efi-amd64-signed - shim-signed - linux-image-5.3.0-18-generic + friendly-recovery + grub-efi-amd64 + grub-efi + grub-efi-amd64-signed + shim-signed + linux-image-5.3.0-18-generic The system used https://github.com/zfsonlinux/zfs/wiki/Ubuntu-18.04 -Root-on-ZFS to add zfs on root to a 19.04 system. The syntax error in grub.cfg.new is an extra } on line 185. However, comparing the grub.cfg.new to the previously generated grub.cfg under 19.04, there is a significant quantity of configuration missing. Manually running update-grub generates the same error. /etc/default/grub is the only file changed from default installation to include zswap. This file was not changed prior to upgrade. The error is reported during the processing of /etc/grub.d/10_linux_zfs which is dated October 11. I attempted the upgrade on 10/18 and have done multiple updates to get the latest kernel and remove old kernels prior to the upgrade. So, I believe the problem is with one of the upgrade modules. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: zfs on root fails with grub syntax error with multidisks pools
** Summary changed: - zfs on root fails with grub syntax error with multidisk pools + zfs on root fails with grub syntax error with multidisks pools -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: zfs on root fails with grub syntax error with multidisks pools To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
