[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-05-12 Thread Chris Hofstaedtler
On e7b1483ab857862aeee144eb9029611af834c65d (tag: Ubuntu-5.4.0-30.34), I
had to revert 77d5805eafdb5c42bdfe78f058ad9c40ee1278b4 "scsi: lpfc: Fix
broken Credit Recovery after driver load" to make our lpfc 8Gb cards
work again.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-04-16 Thread Launchpad Bug Tracker
This bug was fixed in the package linux - 5.4.0-24.28

---
linux (5.4.0-24.28) focal; urgency=medium

  * focal/linux: 5.4.0-24.28 -proposed tracker (LP: #1871939)

  * getitimer returns it_value=0 erroneously (LP: #1349028)
- [Config] CONTEXT_TRACKING_FORCE policy should be unset

  * 12d1:1038 Dual-Role OTG device on non-HNP port - unable to enumerate USB
device on port 1 (LP: #1047527)
- [Config] USB_OTG_FSM policy not needed

  * Add DCPD backlight support for HP CML system (LP: #1871589)
- SAUCE: drm/i915: Force DPCD backlight mode for HP CML 2020 system

  * Backlight brightness cannot be adjusted using keys (LP: #1860303)
- SAUCE drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible
  13t-aw100

  * CVE-2020-11494
- slcan: Don't transmit uninitialized stack data in padding

  * Ubuntu Kernel Support for OpenPOWER NV Secure & Trusted Boot (LP: #1866909)
- powerpc: Detect the secure boot mode of the system
- powerpc/ima: Add support to initialize ima policy rules
- powerpc: Detect the trusted boot state of the system
- powerpc/ima: Define trusted boot policy
- ima: Make process_buffer_measurement() generic
- certs: Add wrapper function to check blacklisted binary hash
- ima: Check against blacklisted hashes for files with modsig
- powerpc/ima: Update ima arch policy to check for blacklist
- powerpc/ima: Indicate kernel modules appended signatures are enforced
- powerpc/powernv: Add OPAL API interface to access secure variable
- powerpc: expose secure variables to userspace via sysfs
- x86/efi: move common keyring handler functions to new file
- powerpc: Load firmware trusted keys/hashes into kernel keyring
- x86/efi: remove unused variables

  * [roce-0227]sync mainline kernel 5.6rc3  roce patchset into ubuntu HWE kernel
branch (LP: #1864950)
- RDMA/hns: Cleanups of magic numbers
- RDMA/hns: Optimize eqe buffer allocation flow
- RDMA/hns: Add the workqueue framework for flush cqe handler
- RDMA/hns: Delayed flush cqe process with workqueue
- RDMA/hns: fix spelling mistake: "attatch" -> "attach"
- RDMA/hns: Initialize all fields of doorbells to zero
- RDMA/hns: Treat revision HIP08_A as a special case
- RDMA/hns: Use flush framework for the case in aeq
- RDMA/hns: Stop doorbell update while qp state error
- RDMA/hns: Optimize qp destroy flow
- RDMA/hns: Optimize qp context create and destroy flow
- RDMA/hns: Optimize qp number assign flow
- RDMA/hns: Optimize qp buffer allocation flow
- RDMA/hns: Optimize qp param setup flow
- RDMA/hns: Optimize kernel qp wrid allocation flow
- RDMA/hns: Optimize qp doorbell allocation flow
- RDMA/hns: Check if depth of qp is 0 before configure

  * [hns3-0316]sync mainline kernel 5.6rc4  hns3 patchset into ubuntu HWE kernel
branch (LP: #1867586)
- net: hns3: modify an unsuitable print when setting unknown duplex to fibre
- net: hns3: add enabled TC numbers and DWRR weight info in debugfs
- net: hns3: add support for dump MAC ID and loopback status in debugfs
- net: hns3: add missing help info for QS shaper in debugfs
- net: hns3: fix some mixed type assignment
- net: hns3: rename macro HCLGE_MAX_NCL_CONFIG_LENGTH
- net: hns3: remove an unnecessary resetting check in
  hclge_handle_hw_ras_error()
- net: hns3: delete some reduandant code
- net: hns3: add a check before PF inform VF to reset
- net: hns3: print out status register when VF receives unknown source
  interrupt
- net: hns3: print out command code when dump fails in debugfs
- net: hns3: synchronize some print relating to reset issue
- net: hns3: delete unnecessary logs after kzalloc fails

  * [SRU][F/U/OEM-5.6] UBUNTU: SAUCE: Fix amdgpu hang during acpi event
(LP: #1871316)
- SAUCE: drm/amdgpu: Fix oops when pp_funcs is unset in ACPI event

  * alsa: make the dmic detection align to the mainline kernel-5.6
(LP: #1871284)
- ALSA: hda: add Intel DSP configuration / probe code
- ALSA: hda: fix intel DSP config
- ALSA: hda: Allow non-Intel device probe gracefully
- ALSA: hda: More constifications
- ALSA: hda: Rename back to dmic_detect option
- [Config] SND_INTEL_DSP_CONFIG=m

  * add_key05 from ubuntu_ltp_syscalls failed (LP: #1869644)
- KEYS: reaching the keys quotas correctly

  * Fix authentication fail on Realtek WiFi 8723de (LP: #1871300)
- SAUCE: rtw88: No retry and report for auth and assoc
- SAUCE: rtw88: fix rate for a while after being connected
- SAUCE: rtw88: Move driver IQK to set channel before association for 11N 
chip

  * Add Mute LED support for an HP laptop (LP: #1871090)
- ALSA: hda/realtek: Enable mute LED on an HP system

  * dscr_sysfs_test / futex_bench / tm-unavailable  in powerpc from
ubuntu_kernel_selftests timeout on PowerPC nodes with B-5.3 (LP: #1864642)
- Revert "UBUNTU: SAUCE:

Re: [Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-04-03 Thread Jeff Lane
Oh thanks!

I got some guidance from the kernel team that everything was mostly
ok, but I needed to update the commits so the cherry pick showed the
source it came from since it was not mainline.  I had started working
on updating all the commits, but, let me check what you've just
provided and I may not need to update anything (or update far less).
They did say that it shouldnt' be an issue getting these all in.  So
I'll try to get that pushed again this afternoon or tomorrow.

On Fri, Apr 3, 2020 at 1:36 PM Vignesh Gunasekaran
<1855...@bugs.launchpad.net> wrote:
>
> Hi Jeff,
>
> I went back to check if those patches in comment #5 are pulled from the
> MKP tree into the Mainline tree and I noticed that those are landed now.
>
> The SHA IDs of those commits in the Mainline kernel are as follows,
>
> df3fe76658ed scsi: lpfc: add RDF registration and Link Integrity FPIN logging
> 73ec6d2748dc scsi: fc: Update Descriptor definition and add RDF and Link 
> Integrity FPINs
> 145e5a8a5cbd scsi: lpfc: Copyright updates for 12.6.0.4 patches
> ad6203f97526 scsi: lpfc: Update lpfc version to 12.6.0.4
> f6770e7d2329 scsi: lpfc: Clean up hba max_lun_queue_depth checks
> 6cde2e3e2813 scsi: lpfc: Remove handler for obsolete ELS - Read Port Status 
> (RPS)
> 4cb9e1ddaa14 scsi: lpfc: Fix coverity errors in fmdi attribute handling
> a99c80742af4 scsi: lpfc: Fix compiler warning on frame size
> 821bc882acca scsi: lpfc: Fix release of hwq to clear the eq relationship
> 792f3b90be2a scsi: lpfc: Fix registration of ELS type support in fdmi
> 835214f5d5f5 scsi: lpfc: Fix broken Credit Recovery after driver load
> 0ab384a49c54 scsi: lpfc: Fix lpfc_io_buf resource leak in 
> lpfc_get_scsi_buf_s4 error path
>
> Could you pass on this info to your kernel team? So that all lpfc
> patches can be accepted.
>
> Thanks
> Vignesh
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1855303
>
> Title:
>   Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5
>
> Status in linux package in Ubuntu:
>   In Progress
> Status in linux source package in Focal:
>   In Progress
>
> Bug description:
>   [IMPACT]
>
>   This is related to bug
>   https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856340
>
>   This is a significant number of updates by Broadcom to the lpfc driver
>   that didn't make 5.4 in time.  As 20.04 is an LTS release with
>   expected hardware support for 5 years, we need to ensure as much
>   hardware support lands as possible to support server vendors over the
>   next couple years.
>
>   Broadcom has updated the lpfc driver to version 12.6.0.4 in 5.5.  The
>   version in focal is 12.2.0.3 and missing several bug fixes and
>   hardware support additions.
>
>   Please update the driver in focal appropriately.
>
>   [FIXES]
>   eede4970fb6c29f2056d7d016a3764c90e9d8a65 scsi: lpfc: size cpu map by
>   last cpu id set
>   4583a4f66b323c6e4d774be2649e83a4e7c7b78c scsi: lpfc: use hdwq assigned
>   cpu for allocation
>   3b294c0fb910dc91250abab574e85c9c1957c795 scsi: lpfc: Update lpfc version
>   to 12.6.0.2
>   542ddc9b346984cb5bbc2a923d3f3f27ae961ffa scsi: lpfc: revise nvme max
>   queues to be hdwq count
>   bc227dde0d8b687aa525d01b0df5556d4d37eca3 scsi: lpfc: Initialize cpu_map
>   for not present cpus
>   d480e57809a04a3b9e755c0bdd43e10a9f12 scsi: lpfc: fix inlining of
>   lpfc_sli4_cleanup_poll_list()
>   6c6d59e0fe5b86cf273d6d744a6a9768c4ecc756 scsi: lpfc: fix: Coverity:
>   lpfc_cmpl_els_rsp(): Null pointer dereferences
>   6f23f8c5c9f1be4eb17c035129c80e49000c18a7 scsi: lpfc: fix: Coverity:
>   lpfc_get_scsi_buf_s3(): Null pointer dereferences
>   61951a6d3153b4482404b739be921a7459f8dc12 scsi: lpfc: Fix
>   lpfc_cpumask_of_node_init()
>   eea2d396aa57acb3607f79ef04c08c2c5166f3fa scsi: lpfc: Fix a kernel
>   warning triggered by lpfc_sli4_enable_intr()
>   765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
>   warning triggered by lpfc_get_sgl_per_hdwq()
>   aff6ab9e7221c1b5d15418419b9797e5badd4aec scsi: lpfc: Update lpfc version
>   to 12.6.0.1
>   171f6c41949f6e9d5e09dcac842a10bf8dda8dcc scsi: lpfc: Add enablement of
>   multiple adapter dumps
>   dcaa213679387e95a315dca05c57dbb15273703c scsi: lpfc: Change default IRQ
>   model on AMD architectures
>   93a4d6f40198dffcca35d9a928c409f9290f1fe0 scsi: lpfc: Add registration
>   for CPU Offline/Online events
>   b9da814cd5f5bb93041a6e4dbc9c5149713186ff scsi: lpfc: Clarify FAWNN error
>   message
>   69641627c653464db46f3e3d8c438349be055670 scsi: lpfc: Sync with FC-NVMe-2
>   SLER change to require Conf with SLER
>   dda5bdf074da3782ff9e785ee50cd2a3f214d498 scsi: lpfc: Fix dynamic fw log
>   enablement check
>   2332e6e475b016e2026763f51333f84e2e6c57a3 scsi: lpfc: Fix unexpected
>   error messages during RSCN handling
>   6c1e803eac846f886cd35131e6516fc51a8414b9 scsi: lpfc: Fix kernel crash at
>   lpfc_nvme_info_show during remote port bounce
>   6bfb1620829825c01e1dcdd63b6a77

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-04-03 Thread Vignesh Gunasekaran
Hi Jeff,

I went back to check if those patches in comment #5 are pulled from the
MKP tree into the Mainline tree and I noticed that those are landed now.

The SHA IDs of those commits in the Mainline kernel are as follows,

df3fe76658ed scsi: lpfc: add RDF registration and Link Integrity FPIN logging
73ec6d2748dc scsi: fc: Update Descriptor definition and add RDF and Link 
Integrity FPINs
145e5a8a5cbd scsi: lpfc: Copyright updates for 12.6.0.4 patches
ad6203f97526 scsi: lpfc: Update lpfc version to 12.6.0.4
f6770e7d2329 scsi: lpfc: Clean up hba max_lun_queue_depth checks
6cde2e3e2813 scsi: lpfc: Remove handler for obsolete ELS - Read Port Status 
(RPS)
4cb9e1ddaa14 scsi: lpfc: Fix coverity errors in fmdi attribute handling
a99c80742af4 scsi: lpfc: Fix compiler warning on frame size
821bc882acca scsi: lpfc: Fix release of hwq to clear the eq relationship
792f3b90be2a scsi: lpfc: Fix registration of ELS type support in fdmi
835214f5d5f5 scsi: lpfc: Fix broken Credit Recovery after driver load
0ab384a49c54 scsi: lpfc: Fix lpfc_io_buf resource leak in lpfc_get_scsi_buf_s4 
error path

Could you pass on this info to your kernel team? So that all lpfc
patches can be accepted.

Thanks
Vignesh

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-04-02 Thread Jeff Lane
** Description changed:

  [IMPACT]
  
  This is related to bug
  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856340
  
  both patch sets are needed to make up
  This is a massive number of updates by Broadcom to the lpfc driver that 
didn't make 5.4 in time.  As 20.04 is an LTS release with expected hardware 
support for 5 years, we need to ensure as much hardware support lands as 
possible to support server vendors over the next couple years.
  
  Broadcom has updated the lpfc driver to version 12.6.0.2 in 5.5.  The
  version in focal is 12.2.0.3 and missing several bug fixes and hardware
  support additions.
  
  Please update the driver in focal appropriately.
  
  [FIXES]
  eede4970fb6c29f2056d7d016a3764c90e9d8a65 scsi: lpfc: size cpu map by
  last cpu id set
  4583a4f66b323c6e4d774be2649e83a4e7c7b78c scsi: lpfc: use hdwq assigned
  cpu for allocation
  3b294c0fb910dc91250abab574e85c9c1957c795 scsi: lpfc: Update lpfc version
  to 12.6.0.2
  542ddc9b346984cb5bbc2a923d3f3f27ae961ffa scsi: lpfc: revise nvme max
  queues to be hdwq count
  bc227dde0d8b687aa525d01b0df5556d4d37eca3 scsi: lpfc: Initialize cpu_map
  for not present cpus
  d480e57809a04a3b9e755c0bdd43e10a9f12 scsi: lpfc: fix inlining of
  lpfc_sli4_cleanup_poll_list()
  6c6d59e0fe5b86cf273d6d744a6a9768c4ecc756 scsi: lpfc: fix: Coverity:
  lpfc_cmpl_els_rsp(): Null pointer dereferences
  6f23f8c5c9f1be4eb17c035129c80e49000c18a7 scsi: lpfc: fix: Coverity:
  lpfc_get_scsi_buf_s3(): Null pointer dereferences
  61951a6d3153b4482404b739be921a7459f8dc12 scsi: lpfc: Fix
  lpfc_cpumask_of_node_init()
  eea2d396aa57acb3607f79ef04c08c2c5166f3fa scsi: lpfc: Fix a kernel
  warning triggered by lpfc_sli4_enable_intr()
  765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
  warning triggered by lpfc_get_sgl_per_hdwq()
  aff6ab9e7221c1b5d15418419b9797e5badd4aec scsi: lpfc: Update lpfc version
  to 12.6.0.1
  171f6c41949f6e9d5e09dcac842a10bf8dda8dcc scsi: lpfc: Add enablement of
  multiple adapter dumps
  dcaa213679387e95a315dca05c57dbb15273703c scsi: lpfc: Change default IRQ
  model on AMD architectures
  93a4d6f40198dffcca35d9a928c409f9290f1fe0 scsi: lpfc: Add registration
  for CPU Offline/Online events
  b9da814cd5f5bb93041a6e4dbc9c5149713186ff scsi: lpfc: Clarify FAWNN error
  message
  69641627c653464db46f3e3d8c438349be055670 scsi: lpfc: Sync with FC-NVMe-2
  SLER change to require Conf with SLER
  dda5bdf074da3782ff9e785ee50cd2a3f214d498 scsi: lpfc: Fix dynamic fw log
  enablement check
  2332e6e475b016e2026763f51333f84e2e6c57a3 scsi: lpfc: Fix unexpected
  error messages during RSCN handling
  6c1e803eac846f886cd35131e6516fc51a8414b9 scsi: lpfc: Fix kernel crash at
  lpfc_nvme_info_show during remote port bounce
  6bfb1620829825c01e1dcdd63b6a7700352babd9 scsi: lpfc: Fix configuration
  of BB credit recovery in service parameters
  7cfd5639d99bec0d27af089d0c8c114330e43a72 scsi: lpfc: Fix duplicate
  unreg_rpi error in port offline flow
  7b10db555257d1248398643a23e10cf36b50d516 scsi: lpfc: Make
  lpfc_debugfs_ras_log_data static
  c3e5aac3e2f501ad4fcb03fed0e32a6f009faea2 scsi: lpfc: Fix NULL check
  before mempool_destroy is not needed
  5792a0e81678da41f05bb724ebd20f134604fa15 scsi: lpfc: fix spelling error
  in MAGIC_NUMER_xxx
  9e2edb41c3d4cab6da0eedcc07ae04758af62ab8 scsi: lpfc: fix build error of
  lpfc_debugfs.c for vfree/vmalloc
  5314995e370e46ac12d12378544ad4575b6f6672 scsi: lpfc: lpfc_nvmet: Fix Use
  plain integer as NULL pointer
  2c7fb469024f0da98f4d078fcf570786ec87c384 scsi: lpfc: lpfc_attr: Fix Use
  plain integer as NULL pointer
  74acec655f560ef721c1e191732af2bcb094b537 scsi: lpfc: Update lpfc version
  to 12.6.0.0
  b4b3417cf6c8051f9f210cd694e6342fb008795c scsi: lpfc: Add additional
  discovery log messages
  83c6cb1ae8be6948b5fa43b2450a176dba80688b scsi: lpfc: Add FC-AL support
  to lpe32000 models
  e7d8595272553c27846946601b72e4c581f9712a scsi: lpfc: Add FA-WWN Async
  Event reporting
  b1dfa5411ea440f7a5bd65176259ffb3bfbdecf0 scsi: lpfc: Add log macros to
  allow print by serverity or verbosity setting
  95bfc6d8ad86a76c89f62bb466f740b0fc05a667 scsi: lpfc: Make FW logging
  dynamically configurable
  8156d378c4cbf8ca19df5d8f0c610ce6923b61e2 scsi: lpfc: Revise interrupt
  coalescing for missing scenarios
  ea85a20cd54f3b09880f6c08994b059f0d114a11 scsi: lpfc: Remove lock
  contention target write path
  22770cbabf6bb77a397d9f11d41f97667dd0caa2 scsi: lpfc: Slight fast-path
  performance optimizations
  f84f8f93f01feb64fdda8dd6c72d1b7dc24ad11d scsi: lpfc: fix coverity error
  of dereference after null check
  91a52b617cdb8bf6d298892101c061d438b84a19 scsi: lpfc: Fix hardlockup in
  lpfc_abort_handler
  324e1c402069e8d277d2a2b18ce40bde1265b96a scsi: lpfc: Fix bad ndlp ptr in
  xri aborted handling
  feff8b3d84d3d9570f893b4d83e5eab6693d6a52 scsi: lpfc: Fix SLI3 hba in
  loop mode not discovering devices
  27f3efd637ce4859a44a7ca730c72392b4111c26 scsi: lpfc: Fix lockdep errors
  in sli_ringtx_put
  0a5ce731977da

Re: [Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-30 Thread Jeff Lane
On Mon, Mar 23, 2020 at 6:41 AM Vignesh Gunasekaran
<1855...@bugs.launchpad.net> wrote:
>
> >So I appreciate the patch set you've provided, but due to the number of 
> >patches, what I need to do is >cherry-pick them from mainline and push a 
> >branch with cherry picks rather than 70+ patches that need to be 
> >>reviewed/applied by the kernel team.
> >
> >And because I can't find these in mainline at all (I've just checked all the 
> >proposed commit ids against the >most recent updates to mainline) I can't 
> >cherry pick these. Do you know when they'll be accepted upstream?
> >
> >I also checked against Linus tree and cant find those commit IDs there 
> >either.
>
> Jeff,
>
> All of those 72 patches are already accepted by the Kernel community and
> most of them are already pulled into linus.git except for the ones you
> listed. But, the ones you have listed are present in mkp/scsi.git.

So as I mentioned in my reply to Laurie just now, I've built some
kernels freshly over the weekend and uploaded them.

However, I do have to tell you that I'm pretty sure they won't accept
packages from mkp/scsi.git, the general rule of thumb is that they're
only accepted into the Ubuntu kernel once they're accepted into the
Mainline kernel.
However, I'll submit them anyway and see what happens.

I still am not sure if they'll accept at all given that several do
touch common code rather than being driver specific, but we'll see how
everything lands.

>
> Even when I was creating a patchset I went by searching those commit
> IDs, but couldn't find them either in linus.git or mkp/scsi.git. I guess
> those commit IDs were from local git. So, I found the equivalent commit
> IDs for those patches in mkp/scsi.git and cherry-picked them.
>
> Ultimately, all 72 patches are already cherry-picked from either
> linus.git or mkp/scsi.git. The patchset has the cherry-pick reference in
> it.
>
>
> I verified the patchset applies cleanly on the focal tree using:
>
> #git am //*.patch
>
> I thought executing this command is all you have to do it from your end.

I needed to cherry pick each (or at least I was able to add what I
needed via 'git am') and add a signed-off line with my name and add a
bug link to the commit message for each patch.  The tree I built just
now has all that, so it's good now.

> Regarding comment 6:
>
> >Additionally, this one does not cleanly apply when cherry-picked:
> >765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
> >warning triggered by lpfc_get_sgl_per_hdwq()
>
> This commit is already pulled into the focal tree from upstream.

Weird, I tried searching out tree for both that commit ID and by text
searching the subject and didn't find it... oh well, I've limited the
test kernels to just the 72 patches you provided in your tarball.
Thanks for that tarball and sorry for any confusion on my end (this
isn't something I routinely do, so I'm a bit cobwebby when I have to
do these).




--
Jeff Lane
Engineering Manager
IHV/OEM Alliances and Server Certification

"Entropy isn't what it used to be."

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-30 Thread Jeff Lane
Hi Laurie,

Yes, here:
https://people.canonical.com/~jlane/lpfc-kernels/

Just uploaded fresh builds this morning after fixing a couple things.

Thanks, and I hope you are all doing well and staying healthy as well.

Jeff

On Mon, Mar 30, 2020 at 11:06 AM laurie barry  wrote:
>
> Jeff - is there a date by when we'll see a kernel we can run through our
> test group?
>
> thank you and be well
> Laurie
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1855303
>
> Title:
>   Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5
>
> Status in linux package in Ubuntu:
>   In Progress
> Status in linux source package in Focal:
>   In Progress
>
> Bug description:
>   [IMPACT]
>
>   This is related to bug
>   https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856340
>
>   both patch sets are needed to make up
>   This is a massive number of updates by Broadcom to the lpfc driver that 
> didn't make 5.4 in time.  As 20.04 is an LTS release with expected hardware 
> support for 5 years, we need to ensure as much hardware support lands as 
> possible to support server vendors over the next couple years.
>
>   Broadcom has updated the lpfc driver to version 12.6.0.2 in 5.5.  The
>   version in focal is 12.2.0.3 and missing several bug fixes and
>   hardware support additions.
>
>   Please update the driver in focal appropriately.
>
>   [FIXES]
>   eede4970fb6c29f2056d7d016a3764c90e9d8a65 scsi: lpfc: size cpu map by
>   last cpu id set
>   4583a4f66b323c6e4d774be2649e83a4e7c7b78c scsi: lpfc: use hdwq assigned
>   cpu for allocation
>   3b294c0fb910dc91250abab574e85c9c1957c795 scsi: lpfc: Update lpfc version
>   to 12.6.0.2
>   542ddc9b346984cb5bbc2a923d3f3f27ae961ffa scsi: lpfc: revise nvme max
>   queues to be hdwq count
>   bc227dde0d8b687aa525d01b0df5556d4d37eca3 scsi: lpfc: Initialize cpu_map
>   for not present cpus
>   d480e57809a04a3b9e755c0bdd43e10a9f12 scsi: lpfc: fix inlining of
>   lpfc_sli4_cleanup_poll_list()
>   6c6d59e0fe5b86cf273d6d744a6a9768c4ecc756 scsi: lpfc: fix: Coverity:
>   lpfc_cmpl_els_rsp(): Null pointer dereferences
>   6f23f8c5c9f1be4eb17c035129c80e49000c18a7 scsi: lpfc: fix: Coverity:
>   lpfc_get_scsi_buf_s3(): Null pointer dereferences
>   61951a6d3153b4482404b739be921a7459f8dc12 scsi: lpfc: Fix
>   lpfc_cpumask_of_node_init()
>   eea2d396aa57acb3607f79ef04c08c2c5166f3fa scsi: lpfc: Fix a kernel
>   warning triggered by lpfc_sli4_enable_intr()
>   765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
>   warning triggered by lpfc_get_sgl_per_hdwq()
>   aff6ab9e7221c1b5d15418419b9797e5badd4aec scsi: lpfc: Update lpfc version
>   to 12.6.0.1
>   171f6c41949f6e9d5e09dcac842a10bf8dda8dcc scsi: lpfc: Add enablement of
>   multiple adapter dumps
>   dcaa213679387e95a315dca05c57dbb15273703c scsi: lpfc: Change default IRQ
>   model on AMD architectures
>   93a4d6f40198dffcca35d9a928c409f9290f1fe0 scsi: lpfc: Add registration
>   for CPU Offline/Online events
>   b9da814cd5f5bb93041a6e4dbc9c5149713186ff scsi: lpfc: Clarify FAWNN error
>   message
>   69641627c653464db46f3e3d8c438349be055670 scsi: lpfc: Sync with FC-NVMe-2
>   SLER change to require Conf with SLER
>   dda5bdf074da3782ff9e785ee50cd2a3f214d498 scsi: lpfc: Fix dynamic fw log
>   enablement check
>   2332e6e475b016e2026763f51333f84e2e6c57a3 scsi: lpfc: Fix unexpected
>   error messages during RSCN handling
>   6c1e803eac846f886cd35131e6516fc51a8414b9 scsi: lpfc: Fix kernel crash at
>   lpfc_nvme_info_show during remote port bounce
>   6bfb1620829825c01e1dcdd63b6a7700352babd9 scsi: lpfc: Fix configuration
>   of BB credit recovery in service parameters
>   7cfd5639d99bec0d27af089d0c8c114330e43a72 scsi: lpfc: Fix duplicate
>   unreg_rpi error in port offline flow
>   7b10db555257d1248398643a23e10cf36b50d516 scsi: lpfc: Make
>   lpfc_debugfs_ras_log_data static
>   c3e5aac3e2f501ad4fcb03fed0e32a6f009faea2 scsi: lpfc: Fix NULL check
>   before mempool_destroy is not needed
>   5792a0e81678da41f05bb724ebd20f134604fa15 scsi: lpfc: fix spelling error
>   in MAGIC_NUMER_xxx
>   9e2edb41c3d4cab6da0eedcc07ae04758af62ab8 scsi: lpfc: fix build error of
>   lpfc_debugfs.c for vfree/vmalloc
>   5314995e370e46ac12d12378544ad4575b6f6672 scsi: lpfc: lpfc_nvmet: Fix Use
>   plain integer as NULL pointer
>   2c7fb469024f0da98f4d078fcf570786ec87c384 scsi: lpfc: lpfc_attr: Fix Use
>   plain integer as NULL pointer
>   74acec655f560ef721c1e191732af2bcb094b537 scsi: lpfc: Update lpfc version
>   to 12.6.0.0
>   b4b3417cf6c8051f9f210cd694e6342fb008795c scsi: lpfc: Add additional
>   discovery log messages
>   83c6cb1ae8be6948b5fa43b2450a176dba80688b scsi: lpfc: Add FC-AL support
>   to lpe32000 models
>   e7d8595272553c27846946601b72e4c581f9712a scsi: lpfc: Add FA-WWN Async
>   Event reporting
>   b1dfa5411ea440f7a5bd65176259ffb3bfbdecf0 scsi: lpfc: Add log macros to
>   allow print by serverity or verbosity setting
>   95bfc6d8ad86a76c89f62bb466f740b0fc05a

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-30 Thread laurie barry
Jeff - is there a date by when we'll see a kernel we can run through our
test group?

thank you and be well
Laurie

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-23 Thread Vignesh Gunasekaran
>So I appreciate the patch set you've provided, but due to the number of 
>patches, what I need to do is >cherry-pick them from mainline and push a 
>branch with cherry picks rather than 70+ patches that need to be 
>>reviewed/applied by the kernel team.
>
>And because I can't find these in mainline at all (I've just checked all the 
>proposed commit ids against the >most recent updates to mainline) I can't 
>cherry pick these. Do you know when they'll be accepted upstream?
>
>I also checked against Linus tree and cant find those commit IDs there either.

Jeff,

All of those 72 patches are already accepted by the Kernel community and
most of them are already pulled into linus.git except for the ones you
listed. But, the ones you have listed are present in mkp/scsi.git.

Even when I was creating a patchset I went by searching those commit
IDs, but couldn't find them either in linus.git or mkp/scsi.git. I guess
those commit IDs were from local git. So, I found the equivalent commit
IDs for those patches in mkp/scsi.git and cherry-picked them.

Ultimately, all 72 patches are already cherry-picked from either
linus.git or mkp/scsi.git. The patchset has the cherry-pick reference in
it.


I verified the patchset applies cleanly on the focal tree using:

#git am //*.patch

I thought executing this command is all you have to do it from your end.


Regarding comment 6:

>Additionally, this one does not cleanly apply when cherry-picked:
>765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
>warning triggered by lpfc_get_sgl_per_hdwq()

This commit is already pulled into the focal tree from upstream.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-21 Thread Jeff Lane
Additionally, this one did not cleanly apply:
Additionally, this one does not cleanly apply when cherry-picked:
765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
warning triggered by lpfc_get_sgl_per_hdwq()

bladernr@galactica:~/development/kernels-ubuntu/focal$ cherrypick 
765ab6cdac3b681952da0e22184bf6cf1ae41cf8
error: could not apply 765ab6cdac3b... scsi: lpfc: Fix a kernel warning 
triggered by lpfc_get_sgl_per_hdwq()
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'
bladernr@galactica:~/development/kernels-ubuntu/focal$ git diff
diff --cc drivers/scsi/lpfc/lpfc_sli.c
index e660ee98ad8b,613fbf4a7da9..
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@@ -20687,7 -20668,7 +20687,11 @@@ lpfc_get_sgl_per_hdwq(struct lpfc_hba *
/* allocate more */
spin_unlock_irqrestore(&hdwq->hdwq_lock, iflags);
tmp = kmalloc_node(sizeof(*tmp), GFP_ATOMIC,
++<<< HEAD
 + cpu_to_node(hdwq->io_wq->chann));
++===
+  cpu_to_node(raw_smp_processor_id()));
++>>> 765ab6cdac3b... scsi: lpfc: Fix a kernel warning triggered by 
lpfc_get_sgl_per_hdwq()
if (!tmp) {
lpfc_printf_log(phba, KERN_INFO, LOG_SLI,
"8353 error kmalloc memory for HDWQ "
@@@ -20830,7 -20811,7 +20834,11 @@@ lpfc_get_cmd_rsp_buf_per_hdwq(struct lp
/* allocate more */
spin_unlock_irqrestore(&hdwq->hdwq_lock, iflags);
tmp = kmalloc_node(sizeof(*tmp), GFP_ATOMIC,
++<<< HEAD
 + cpu_to_node(hdwq->io_wq->chann));
++===
+  cpu_to_node(raw_smp_processor_id()));
++>>> 765ab6cdac3b... scsi: lpfc: Fix a kernel warning triggered by 
lpfc_get_sgl_per_hdwq()
if (!tmp) {
lpfc_printf_log(phba, KERN_INFO, LOG_SLI,
"8355 error kmalloc memory for HDWQ "

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-21 Thread Jeff Lane
Hi Vignesh,

As I've been working on this and I just noticed that several of these
patches do not exist in the upstream kernel:

89cc9dba63c91a6c796dc46342c1d57c82c9b0cd
scsi: lpfc: Fix lpfc_io_buf resource leak in lpfc_get_scsi_buf_s4 error path
   

692fc8380ca0f9185e75e01a74357d2cf3083743
   
scsi: lpfc: Fix broken Credit Recovery after driver load

0f74f70cb674e3b8712e896863ad85db4d193d46
   
scsi: lpfc: Fix registration of ELS type support in fdmi

01034e708a353fed29963d084c35d58785a317a6
   
scsi: lpfc: Fix release of hwq to clear the eq relationship

3cd50eac891db354e945bf9898726e163a19560e
   
scsi: lpfc: Fix compiler warning on frame size

3ad04f4f0ad75ad4e7d886133f673d9fe20aa9c4
   
scsi: lpfc: Fix coverity errors in fmdi attribute handling

8d9fae72109e9921f52be342007b4c78490ea4fe
   
scsi: lpfc: Remove handler for obsolete ELS - Read Port Status (RPS)

20d674a4bf64acf54eadc7215ea32b88a3a7687e
   
scsi: lpfc: Clean up hba max_lun_queue_depth checks

35817310d9e05e666dbd242750008dad33ed8992
   
scsi: lpfc: Update lpfc version to 12.6.0.4

fd6cc30f341fea14bac45bf1c5c9d10702c18a9d
   
scsi: lpfc: Copyright updates for 12.6.0.4 patches

73ec6d2748dc35db2b32cf3c182a27c4a0837b9b
   
scsi: fc: Update Descriptor definition and add RDF and Link Integrity FPINs

df3fe76658ed47617741819a501e2bd2ae446962 
scsi: lpfc: add RDF registration and Link Integrity FPIN logging

So I appreciate the patch set you've provided, but due to the number of
patches, what I need to do is cherry-pick them from mainline and push a
branch with cherry picks rather than 70+ patches that need to be
reviewed/applied by the kernel team.

And because I can't find these in mainline at all (I've just checked all
the proposed commit ids against the most recent updates to mainline) I
can't cherry pick these.  Do you know when they'll be accepted upstream?

I also checked against Linus tree and cant find those commit IDs there
either.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-20 Thread Jeff Lane
** Description changed:

  [IMPACT]
+ 
+ This is related to bug
+ https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856340
+ 
+ both patch sets are needed to make up
  This is a massive number of updates by Broadcom to the lpfc driver that 
didn't make 5.4 in time.  As 20.04 is an LTS release with expected hardware 
support for 5 years, we need to ensure as much hardware support lands as 
possible to support server vendors over the next couple years.
  
  Broadcom has updated the lpfc driver to version 12.6.0.2 in 5.5.  The
  version in focal is 12.2.0.3 and missing several bug fixes and hardware
  support additions.
  
  Please update the driver in focal appropriately.
  
  [FIXES]
  eede4970fb6c29f2056d7d016a3764c90e9d8a65 scsi: lpfc: size cpu map by
  last cpu id set
  4583a4f66b323c6e4d774be2649e83a4e7c7b78c scsi: lpfc: use hdwq assigned
  cpu for allocation
  3b294c0fb910dc91250abab574e85c9c1957c795 scsi: lpfc: Update lpfc version
  to 12.6.0.2
  542ddc9b346984cb5bbc2a923d3f3f27ae961ffa scsi: lpfc: revise nvme max
  queues to be hdwq count
  bc227dde0d8b687aa525d01b0df5556d4d37eca3 scsi: lpfc: Initialize cpu_map
  for not present cpus
  d480e57809a04a3b9e755c0bdd43e10a9f12 scsi: lpfc: fix inlining of
  lpfc_sli4_cleanup_poll_list()
  6c6d59e0fe5b86cf273d6d744a6a9768c4ecc756 scsi: lpfc: fix: Coverity:
  lpfc_cmpl_els_rsp(): Null pointer dereferences
  6f23f8c5c9f1be4eb17c035129c80e49000c18a7 scsi: lpfc: fix: Coverity:
  lpfc_get_scsi_buf_s3(): Null pointer dereferences
  61951a6d3153b4482404b739be921a7459f8dc12 scsi: lpfc: Fix
  lpfc_cpumask_of_node_init()
  eea2d396aa57acb3607f79ef04c08c2c5166f3fa scsi: lpfc: Fix a kernel
  warning triggered by lpfc_sli4_enable_intr()
  765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
  warning triggered by lpfc_get_sgl_per_hdwq()
  aff6ab9e7221c1b5d15418419b9797e5badd4aec scsi: lpfc: Update lpfc version
  to 12.6.0.1
  171f6c41949f6e9d5e09dcac842a10bf8dda8dcc scsi: lpfc: Add enablement of
  multiple adapter dumps
  dcaa213679387e95a315dca05c57dbb15273703c scsi: lpfc: Change default IRQ
  model on AMD architectures
  93a4d6f40198dffcca35d9a928c409f9290f1fe0 scsi: lpfc: Add registration
  for CPU Offline/Online events
  b9da814cd5f5bb93041a6e4dbc9c5149713186ff scsi: lpfc: Clarify FAWNN error
  message
  69641627c653464db46f3e3d8c438349be055670 scsi: lpfc: Sync with FC-NVMe-2
  SLER change to require Conf with SLER
  dda5bdf074da3782ff9e785ee50cd2a3f214d498 scsi: lpfc: Fix dynamic fw log
  enablement check
  2332e6e475b016e2026763f51333f84e2e6c57a3 scsi: lpfc: Fix unexpected
  error messages during RSCN handling
  6c1e803eac846f886cd35131e6516fc51a8414b9 scsi: lpfc: Fix kernel crash at
  lpfc_nvme_info_show during remote port bounce
  6bfb1620829825c01e1dcdd63b6a7700352babd9 scsi: lpfc: Fix configuration
  of BB credit recovery in service parameters
  7cfd5639d99bec0d27af089d0c8c114330e43a72 scsi: lpfc: Fix duplicate
  unreg_rpi error in port offline flow
  7b10db555257d1248398643a23e10cf36b50d516 scsi: lpfc: Make
  lpfc_debugfs_ras_log_data static
  c3e5aac3e2f501ad4fcb03fed0e32a6f009faea2 scsi: lpfc: Fix NULL check
  before mempool_destroy is not needed
  5792a0e81678da41f05bb724ebd20f134604fa15 scsi: lpfc: fix spelling error
  in MAGIC_NUMER_xxx
  9e2edb41c3d4cab6da0eedcc07ae04758af62ab8 scsi: lpfc: fix build error of
  lpfc_debugfs.c for vfree/vmalloc
  5314995e370e46ac12d12378544ad4575b6f6672 scsi: lpfc: lpfc_nvmet: Fix Use
  plain integer as NULL pointer
  2c7fb469024f0da98f4d078fcf570786ec87c384 scsi: lpfc: lpfc_attr: Fix Use
  plain integer as NULL pointer
  74acec655f560ef721c1e191732af2bcb094b537 scsi: lpfc: Update lpfc version
  to 12.6.0.0
  b4b3417cf6c8051f9f210cd694e6342fb008795c scsi: lpfc: Add additional
  discovery log messages
  83c6cb1ae8be6948b5fa43b2450a176dba80688b scsi: lpfc: Add FC-AL support
  to lpe32000 models
  e7d8595272553c27846946601b72e4c581f9712a scsi: lpfc: Add FA-WWN Async
  Event reporting
  b1dfa5411ea440f7a5bd65176259ffb3bfbdecf0 scsi: lpfc: Add log macros to
  allow print by serverity or verbosity setting
  95bfc6d8ad86a76c89f62bb466f740b0fc05a667 scsi: lpfc: Make FW logging
  dynamically configurable
  8156d378c4cbf8ca19df5d8f0c610ce6923b61e2 scsi: lpfc: Revise interrupt
  coalescing for missing scenarios
  ea85a20cd54f3b09880f6c08994b059f0d114a11 scsi: lpfc: Remove lock
  contention target write path
  22770cbabf6bb77a397d9f11d41f97667dd0caa2 scsi: lpfc: Slight fast-path
  performance optimizations
  f84f8f93f01feb64fdda8dd6c72d1b7dc24ad11d scsi: lpfc: fix coverity error
  of dereference after null check
  91a52b617cdb8bf6d298892101c061d438b84a19 scsi: lpfc: Fix hardlockup in
  lpfc_abort_handler
  324e1c402069e8d277d2a2b18ce40bde1265b96a scsi: lpfc: Fix bad ndlp ptr in
  xri aborted handling
  feff8b3d84d3d9570f893b4d83e5eab6693d6a52 scsi: lpfc: Fix SLI3 hba in
  loop mode not discovering devices
  27f3efd637ce4859a44a7ca730c72392b4111c26 scsi: lpfc: Fix lockdep errors
  in sli_ringtx_put
  0a5ce731977da

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-11 Thread Vignesh Gunasekaran
Hi Jeff,

Here is the patchset of lpfc that is required for focal. Some of the
patches mentioned in this bug are already present in the focal tree and
the remainings are part of this patchset. The patches were cut against
the main focal tree.

Regards
Vignesh 

** Attachment added: "lpfc_12.6.0.4_for_focal.tar.gz"
   
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+attachment/5335995/+files/lpfc_12.6.0.4_for_focal.tar.gz

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-03-03 Thread Jeff Lane
** Description changed:

- This is a massive number of updates by Broadcom to the lpfc driver that
- didn't make 5.4 in time.  As 20.04 is an LTS release with expected
- hardware support for 5 years, we need to ensure as much hardware support
- lands as possible to support server vendors over the next couple years.
+ [IMPACT]
+ This is a massive number of updates by Broadcom to the lpfc driver that 
didn't make 5.4 in time.  As 20.04 is an LTS release with expected hardware 
support for 5 years, we need to ensure as much hardware support lands as 
possible to support server vendors over the next couple years.
  
  Broadcom has updated the lpfc driver to version 12.6.0.2 in 5.5.  The
  version in focal is 12.2.0.3 and missing several bug fixes and hardware
- support additions.  Given the number of patches missing in Focal, and
- that they all apply to a single driver, it may be easiest to just pick
- the version in 5.5 fully, rather than apply so many patches to the 5.4
- tree, but that's just a suggestion.
+ support additions.
  
  Please update the driver in focal appropriately.
  
+ [FIXES]
  eede4970fb6c29f2056d7d016a3764c90e9d8a65 scsi: lpfc: size cpu map by
  last cpu id set
  4583a4f66b323c6e4d774be2649e83a4e7c7b78c scsi: lpfc: use hdwq assigned
  cpu for allocation
  3b294c0fb910dc91250abab574e85c9c1957c795 scsi: lpfc: Update lpfc version
  to 12.6.0.2
  542ddc9b346984cb5bbc2a923d3f3f27ae961ffa scsi: lpfc: revise nvme max
  queues to be hdwq count
  bc227dde0d8b687aa525d01b0df5556d4d37eca3 scsi: lpfc: Initialize cpu_map
  for not present cpus
  d480e57809a04a3b9e755c0bdd43e10a9f12 scsi: lpfc: fix inlining of
  lpfc_sli4_cleanup_poll_list()
  6c6d59e0fe5b86cf273d6d744a6a9768c4ecc756 scsi: lpfc: fix: Coverity:
  lpfc_cmpl_els_rsp(): Null pointer dereferences
  6f23f8c5c9f1be4eb17c035129c80e49000c18a7 scsi: lpfc: fix: Coverity:
  lpfc_get_scsi_buf_s3(): Null pointer dereferences
  61951a6d3153b4482404b739be921a7459f8dc12 scsi: lpfc: Fix
  lpfc_cpumask_of_node_init()
  eea2d396aa57acb3607f79ef04c08c2c5166f3fa scsi: lpfc: Fix a kernel
  warning triggered by lpfc_sli4_enable_intr()
  765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
  warning triggered by lpfc_get_sgl_per_hdwq()
  aff6ab9e7221c1b5d15418419b9797e5badd4aec scsi: lpfc: Update lpfc version
  to 12.6.0.1
  171f6c41949f6e9d5e09dcac842a10bf8dda8dcc scsi: lpfc: Add enablement of
  multiple adapter dumps
  dcaa213679387e95a315dca05c57dbb15273703c scsi: lpfc: Change default IRQ
  model on AMD architectures
  93a4d6f40198dffcca35d9a928c409f9290f1fe0 scsi: lpfc: Add registration
  for CPU Offline/Online events
  b9da814cd5f5bb93041a6e4dbc9c5149713186ff scsi: lpfc: Clarify FAWNN error
  message
  69641627c653464db46f3e3d8c438349be055670 scsi: lpfc: Sync with FC-NVMe-2
  SLER change to require Conf with SLER
  dda5bdf074da3782ff9e785ee50cd2a3f214d498 scsi: lpfc: Fix dynamic fw log
  enablement check
  2332e6e475b016e2026763f51333f84e2e6c57a3 scsi: lpfc: Fix unexpected
  error messages during RSCN handling
  6c1e803eac846f886cd35131e6516fc51a8414b9 scsi: lpfc: Fix kernel crash at
  lpfc_nvme_info_show during remote port bounce
  6bfb1620829825c01e1dcdd63b6a7700352babd9 scsi: lpfc: Fix configuration
  of BB credit recovery in service parameters
  7cfd5639d99bec0d27af089d0c8c114330e43a72 scsi: lpfc: Fix duplicate
  unreg_rpi error in port offline flow
  7b10db555257d1248398643a23e10cf36b50d516 scsi: lpfc: Make
  lpfc_debugfs_ras_log_data static
  c3e5aac3e2f501ad4fcb03fed0e32a6f009faea2 scsi: lpfc: Fix NULL check
  before mempool_destroy is not needed
  5792a0e81678da41f05bb724ebd20f134604fa15 scsi: lpfc: fix spelling error
  in MAGIC_NUMER_xxx
  9e2edb41c3d4cab6da0eedcc07ae04758af62ab8 scsi: lpfc: fix build error of
  lpfc_debugfs.c for vfree/vmalloc
  5314995e370e46ac12d12378544ad4575b6f6672 scsi: lpfc: lpfc_nvmet: Fix Use
  plain integer as NULL pointer
  2c7fb469024f0da98f4d078fcf570786ec87c384 scsi: lpfc: lpfc_attr: Fix Use
  plain integer as NULL pointer
  74acec655f560ef721c1e191732af2bcb094b537 scsi: lpfc: Update lpfc version
  to 12.6.0.0
  b4b3417cf6c8051f9f210cd694e6342fb008795c scsi: lpfc: Add additional
  discovery log messages
  83c6cb1ae8be6948b5fa43b2450a176dba80688b scsi: lpfc: Add FC-AL support
  to lpe32000 models
  e7d8595272553c27846946601b72e4c581f9712a scsi: lpfc: Add FA-WWN Async
  Event reporting
  b1dfa5411ea440f7a5bd65176259ffb3bfbdecf0 scsi: lpfc: Add log macros to
  allow print by serverity or verbosity setting
  95bfc6d8ad86a76c89f62bb466f740b0fc05a667 scsi: lpfc: Make FW logging
  dynamically configurable
  8156d378c4cbf8ca19df5d8f0c610ce6923b61e2 scsi: lpfc: Revise interrupt
  coalescing for missing scenarios
  ea85a20cd54f3b09880f6c08994b059f0d114a11 scsi: lpfc: Remove lock
  contention target write path
  22770cbabf6bb77a397d9f11d41f97667dd0caa2 scsi: lpfc: Slight fast-path
  performance optimizations
  f84f8f93f01feb64fdda8dd6c72d1b7dc24ad11d scsi: lpfc: fix coverity error
  of dereference after null 

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2020-02-24 Thread laurie barry
Jeff,

I just realized I updated the wrong bug...here's the list of additional
patches we'll need to include to update 20.04 to the latest upstream for
lpfc.  There's one additional kernel patch we need you to include below
please.

thx
Laurie


Here is the list of additional patch commit ids that would be used to update 
from 12.6.0.2 (end of list in 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303) to 12.6.0.3 and 
12.6.0.4 and to add FPIN/mpio support:
scsi: lpfc: Fix incomplete NVME discovery when target
commit 3ec5ec408ca633e17d3483e8b806c9fa447e19cc

scsi: lpfc: Fix: Rework setting of fdmi symbolic node name registration
commit d4e9ddd5ae8f26c521692283c7cbedc7e9881529

scsi: lpfc: Fix missing check for CSF in Write Object Mbox Rsp
commit a0c94c5ef874b214305cca965acc7edc27bb69a6

scsi: lpfc: Fix Fabric hostname registration if system hostname changes
commit 3712967ea7f2d3793ae2a39e9eae2df111d770b5

scsi: lpfc: Fix ras_log via debugfs
commit 25d4132f95c25e6f78a94666a1e067291272888a

scsi: lpfc: Fix disablement of FC-AL on lpe35000 models
commit 265fb8efca11eee1ffe8edd2bc0a9fbf31b6b84e

scsi: lpfc: Fix unmap of dpp bars affecting next driver load
commit b88d705fa037b222ecdd5de867132ae25403fe48

scsi: lpfc: Fix MDS Latency Diagnostics Err-drop rates
commit 78a7872570fbeed44e7362354619b403c6e6de1e

scsi: lpfc: Fix improper flag check for IO type
commit f44ccecf36581a2030313e979127013f9d455d3a

scsi: lpfc: Update lpfc version to 12.6.0.3
commit e627554eedcfac83bb2ba073adf711a13049273a



scsi: lpfc: Fix RQ buffer leakage when no IOCBs available
commit9c75a0dee87b2bad80d381ad9fa8ef90847d3a1d

scsi: lpfc: Fix lpfc_io_buf resource leak in lpfc_get_scsi_buf_s4 error path
commit89cc9dba63c91a6c796dc46342c1d57c82c9b0cd

scsi: lpfc: Fix broken Credit Recovery after driver load
commit692fc8380ca0f9185e75e01a74357d2cf3083743

scsi: lpfc: Fix registration of ELS type support in fdmi
commit0f74f70cb674e3b8712e896863ad85db4d193d46

scsi: lpfc: Fix release of hwq to clear the eq relationship
commit01034e708a353fed29963d084c35d58785a317a6

scsi: lpfc: Fix compiler warning on frame size
commit3cd50eac891db354e945bf9898726e163a19560e

scsi: lpfc: Fix coverity errors in fmdi attribute handling
commit3ad04f4f0ad75ad4e7d886133f673d9fe20aa9c4

scsi: lpfc: Remove handler for obsolete ELS - Read Port Status (RPS)
commit8d9fae72109e9921f52be342007b4c78490ea4fe

scsi: lpfc: Clean up hba max_lun_queue_depth checks
commit20d674a4bf64acf54eadc7215ea32b88a3a7687e

scsi: lpfc: Update lpfc version to 12.6.0.4
commit35817310d9e05e666dbd242750008dad33ed8992

scsi: lpfc: Copyright updates for 12.6.0.4 patches
commitfd6cc30f341fea14bac45bf1c5c9d10702c18a9d

---

This one--> scsi: fc: Update Descriptor definition and add RDF and Link 
Integrity FPINs
commit73ec6d2748dc35db2b32cf3c182a27c4a0837b9b

scsi: lpfc: add RDF registration and Link Integrity FPIN logging
commitdf3fe76658ed47617741819a501e2bd2ae446962

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1855303

Title:
  Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855303/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1855303] Re: Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

2019-12-20 Thread Jeff Lane
** Summary changed:

- Update Broadcom Emulex lpfc driver in Ubuntu 20.0.4 to 12.6.0.x
+ Update Broadcom Emulex lpfc driver in 5.4 to 12.6.0.x from 5.5

** Description changed:

- Jeff,
+ This is a massive number of updates by Broadcom to the lpfc driver that
+ didn't make 5.4 in time.  As 20.04 is an LTS release with expected
+ hardware support for 5 years, we need to ensure as much hardware support
+ lands as possible to support server vendors over the next couple years.
  
- Here's the list of committed patches on top of your current git tree
- that we require for lpfc.  Please let me know what other information you
- require.  I'm working with James Smart to obtain the list of additional
- patch kernel dependencies needed and will file a separate launchpad bug
- for that.
+ Broadcom has updated the lpfc driver to version 12.6.0.2 in 5.5.  The
+ version in focal is 12.2.0.3 and missing several bug fixes and hardware
+ support additions.  Given the number of patches missing in Focal, and
+ that they all apply to a single driver, it may be easiest to just pick
+ the version in 5.5 fully, rather than apply so many patches to the 5.4
+ tree, but that's just a suggestion.
  
- ---
- 
- Dick Kennedy
- Wed, Dec 4, 9:23 AM (1 day ago)
- to me
- 
- They can skip all the ones that say Merge, they should know that anyway. 
- I went all the way back to 12.2.0.3 so that they can see where their tree 
stopped.
+ Please update the driver in focal appropriately.
  
  eede4970fb6c29f2056d7d016a3764c90e9d8a65 scsi: lpfc: size cpu map by
  last cpu id set
  4583a4f66b323c6e4d774be2649e83a4e7c7b78c scsi: lpfc: use hdwq assigned
  cpu for allocation
  3b294c0fb910dc91250abab574e85c9c1957c795 scsi: lpfc: Update lpfc version
  to 12.6.0.2
  542ddc9b346984cb5bbc2a923d3f3f27ae961ffa scsi: lpfc: revise nvme max
  queues to be hdwq count
  bc227dde0d8b687aa525d01b0df5556d4d37eca3 scsi: lpfc: Initialize cpu_map
  for not present cpus
  d480e57809a04a3b9e755c0bdd43e10a9f12 scsi: lpfc: fix inlining of
  lpfc_sli4_cleanup_poll_list()
  6c6d59e0fe5b86cf273d6d744a6a9768c4ecc756 scsi: lpfc: fix: Coverity:
  lpfc_cmpl_els_rsp(): Null pointer dereferences
  6f23f8c5c9f1be4eb17c035129c80e49000c18a7 scsi: lpfc: fix: Coverity:
  lpfc_get_scsi_buf_s3(): Null pointer dereferences
  61951a6d3153b4482404b739be921a7459f8dc12 scsi: lpfc: Fix
  lpfc_cpumask_of_node_init()
  eea2d396aa57acb3607f79ef04c08c2c5166f3fa scsi: lpfc: Fix a kernel
  warning triggered by lpfc_sli4_enable_intr()
  765ab6cdac3b681952da0e22184bf6cf1ae41cf8 scsi: lpfc: Fix a kernel
  warning triggered by lpfc_get_sgl_per_hdwq()
  aff6ab9e7221c1b5d15418419b9797e5badd4aec scsi: lpfc: Update lpfc version
  to 12.6.0.1
  171f6c41949f6e9d5e09dcac842a10bf8dda8dcc scsi: lpfc: Add enablement of
  multiple adapter dumps
  dcaa213679387e95a315dca05c57dbb15273703c scsi: lpfc: Change default IRQ
  model on AMD architectures
  93a4d6f40198dffcca35d9a928c409f9290f1fe0 scsi: lpfc: Add registration
  for CPU Offline/Online events
  b9da814cd5f5bb93041a6e4dbc9c5149713186ff scsi: lpfc: Clarify FAWNN error
  message
  69641627c653464db46f3e3d8c438349be055670 scsi: lpfc: Sync with FC-NVMe-2
  SLER change to require Conf with SLER
  dda5bdf074da3782ff9e785ee50cd2a3f214d498 scsi: lpfc: Fix dynamic fw log
  enablement check
  2332e6e475b016e2026763f51333f84e2e6c57a3 scsi: lpfc: Fix unexpected
  error messages during RSCN handling
  6c1e803eac846f886cd35131e6516fc51a8414b9 scsi: lpfc: Fix kernel crash at
  lpfc_nvme_info_show during remote port bounce
  6bfb1620829825c01e1dcdd63b6a7700352babd9 scsi: lpfc: Fix configuration
  of BB credit recovery in service parameters
  7cfd5639d99bec0d27af089d0c8c114330e43a72 scsi: lpfc: Fix duplicate
  unreg_rpi error in port offline flow
  7b10db555257d1248398643a23e10cf36b50d516 scsi: lpfc: Make
  lpfc_debugfs_ras_log_data static
  c3e5aac3e2f501ad4fcb03fed0e32a6f009faea2 scsi: lpfc: Fix NULL check
  before mempool_destroy is not needed
  5792a0e81678da41f05bb724ebd20f134604fa15 scsi: lpfc: fix spelling error
  in MAGIC_NUMER_xxx
  9e2edb41c3d4cab6da0eedcc07ae04758af62ab8 scsi: lpfc: fix build error of
  lpfc_debugfs.c for vfree/vmalloc
  5314995e370e46ac12d12378544ad4575b6f6672 scsi: lpfc: lpfc_nvmet: Fix Use
  plain integer as NULL pointer
  2c7fb469024f0da98f4d078fcf570786ec87c384 scsi: lpfc: lpfc_attr: Fix Use
  plain integer as NULL pointer
  74acec655f560ef721c1e191732af2bcb094b537 scsi: lpfc: Update lpfc version
  to 12.6.0.0
  b4b3417cf6c8051f9f210cd694e6342fb008795c scsi: lpfc: Add additional
  discovery log messages
  83c6cb1ae8be6948b5fa43b2450a176dba80688b scsi: lpfc: Add FC-AL support
  to lpe32000 models
  e7d8595272553c27846946601b72e4c581f9712a scsi: lpfc: Add FA-WWN Async
  Event reporting
  b1dfa5411ea440f7a5bd65176259ffb3bfbdecf0 scsi: lpfc: Add log macros to
  allow print by serverity or verbosity setting
  95bfc6d8ad86a76c89f62bb466f740b0fc05a667 scsi: lpfc: Make FW logging
  dynamically configurable
  8156d378c4cbf8ca19