[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
What I'm saying is there is not a documented "Test Case" in the bug report which is an important part of the SRU process. Please add one so that we can review this SRU. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
Brian, the testcase is to backup some TB of data, and try to read them, the index should not be corrupted. This is why I'm asking upstream to test the package once its in proposed pocket, because I lack the data to test it properly ** Description changed: [ Impact ] * Data is corrupted on some specific conditions [ Regression Potential ] * Really low, the package has an autopkgtestsuite that runs thousand of tests, and the fix is since one year part of upstream code + + [ Test Case ] + * Backup some TB of data, and try to read the index, it should be not corrupted [ Other info ] Per the "important notes" section of the borg docs: https://borgbackup.readthedocs.io/en/stable/changes.html "Pre-1.1.11 potential index corruption / data loss issue A bug was discovered in our hashtable code, see issue #4829. The code is used for the client-side chunks cache and the server-side repo index. Although borg uses the hashtables very heavily, the index corruption did not happen too frequently, because it needed specific conditions to happen. Data loss required even more specific conditions, so it should be rare (and also detectable via borg check). [..]" Theoretically affects all Ubuntu releases before 20.04 (focal.) I know this is a universe package, but if anyone was up for an SRU that would be fantastic.. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
I added the testcase to the bug -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
Given this is a *known data corrupting bug* declared by upstream, it would seem really odd to hold up the release for bionic and focal, where the solution is just an upgrade to the upstream version containing the fix! (I can possibly see the argument for being more careful with cherrypicked patches.) Unless upstream has published a detailed test case there may not be one accessible to us. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
I've gone through the upstream bug https://github.com/borgbackup/borg/issues/4829 and not found any data which could be used as a test case. While the description of the bug there is quite detailed, I think one would have to be incredibly familiar with borg internals & code to create a reproducer. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
It looks like this has been noticed on the borgbackup GitHub, resulting in https://github.com/ThomasWaldmann/borg/commit/aa3938a7a53c29d35df8567f4ebba4c2c76e7342 . As it's just a test, this might be a sensible thing to cherry-pick? It'd turn the test case from “back up lots of data, and hope you hit the edge case” to “the tests, run as a part of the build, complete without errors”. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
Hello, yes, I requested that test and I will cherry-pick. I tried right now a build with that added test in my ppa (but no fix) and it failed https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/costamagnagianfranco-ppa/+build/20359561 the very same build (so no patch for the corruption issue) was good without the added test https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/costamagnagianfranco-ppa/+build/20359652 Now, I tested the fixed package with that added testcase and it was good. https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+build/20359659 So, reuploading in unapproved queue with the added testcase looks really useful. If the build is good, we can assume the runtime is good too, since the code triggered is exactly the same. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
and reuploaded! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
Unfortunately upgrading from 1.1.11 to 1.1.14 requires xxhash being installed on the system, because I removed the embedded version being used in borgbackup -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
SRU review There's something wrong going on here, but I'm not sure exactly what you intend so I'm not sure what to suggest. The upload in the Bionic queue is 1.1.14-2ubuntu1.20.04.1 but Bionic is 18.04. Focal is on 1.1.11-5 which is lower than the Bionic upload, so that can't work. Please could you clarify exactly what versions you're trying to put where, and which are intended to be cherry-picks and which are intended to be new upstream versions? The Bionic queue upload seems to suggest that it's both a new upstream version and a cherry-pick, which is why I'm confused. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
Hello Brian, I'll ask upstream to test it once the new version is in proposed pocket. Is it ok for you? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
I uploaded 1.1.15 which contains the upstream fix and new regression test for this particular bug. If it builds, we can assume we are fine -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
xenial 16.04: upgrade from the current 1.0.12 to 1.0.13-0ubuntu1.16.04.1 (a.k.a. stock 1.0.13 + this fix cherry-picked from 1.0 maint branch) bionic 18.04: upgrade to 1.1.14-2ubuntu18.04.1 (sorry, just the versioning in changelog was wrong!) focal 20.04: upgrade to 1.1.14-2ubuntu20.04.1 I fixed the changelog, changed from 20 to 18 and reuploaded to bionic (and uploaded the focal version too) ** Changed in: borgbackup (Ubuntu Focal) Status: Fix Released => Confirmed ** Changed in: borgbackup (Ubuntu Focal) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11
It looks like there may be a test case in the upstream bug but it'd be helpful if one was added to the Launchpad one. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/borgbackup/+bug/1877844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
