[Bug 1888715] Re: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg()
The fix was already released as part of 4.4.0-190.220 for the upstream stable update from bug #1892822. ** Changed in: linux (Ubuntu Xenial) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888715 Title: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1888715/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888715] Re: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg()
** Also affects: linux (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888715 Title: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1888715/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888715] Re: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg()
FYI: the fix is in the upstream linux-4.4.y branch now: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.4.233=c514bb4147e2c667cf82f9aa7689cf442078c13f -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888715 Title: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1888715/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888715] Re: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg()
https://lore.kernel.org/netdev/20200728015505.37830-1-de...@microsoft.com/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888715 Title: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1888715/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888715] Re: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg()
rcu_access_pointer(sk->sk_filter) is basically the same as sk->sk_filter. If sk->sk_filter is true, the change makes no difference. If sk->sk_filter is false, the change also drops a UDP packet with incorrect UDP checksum by "goto csum_error;". Without the change, the packet is dropped in udp_recvmsg(); with the change, the packet is dropped earlier. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888715 Title: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1888715/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888715] Re: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg()
Hello Dexuan, wonderful, thanks; Eric's proposed patch confuses me on one point: - if (rcu_access_pointer(sk->sk_filter) && - udp_lib_checksum_complete(skb)) + if (udp_lib_checksum_complete(skb)) goto csum_error; Do you know why the rcu_access_pointer() call has been removed? Thanks ** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888715 Title: UDP data corruption caused by buggy udp_recvmsg() -> skb_copy_and_csum_datagram_msg() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1888715/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
