[Bug 1890341] Re: Intermittent autopkgtest failure with testStdinPipe (s390x)
Released as 5.4.0 and 4.7.0 Updating Debian soon. ** Changed in: phpmyadmin-sql-parser Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890341 Title: Intermittent autopkgtest failure with testStdinPipe (s390x) To manage notifications about this bug go to: https://bugs.launchpad.net/phpmyadmin-sql-parser/+bug/1890341/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890341] Re: Intermittent autopkgtest failure with testStdinPipe (s390x)
This bug was fixed in the package phpmyadmin-sql-parser - 4.6.1-2ubuntu1 --- phpmyadmin-sql-parser (4.6.1-2ubuntu1) groovy; urgency=medium * d/p/use-stream-select-instead-of-non-blocking-stdin.patch: Fix FTBFS and autopkgtest failure due to non-determinism when using non-blocking stdin to read inputs. The fix is to use the well-known idiom of "select + a timeout" instead. (LP: #1890341) -- Sergio Durigan Junior Wed, 26 Aug 2020 19:47:54 -0400 ** Changed in: phpmyadmin-sql-parser (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890341 Title: Intermittent autopkgtest failure with testStdinPipe (s390x) To manage notifications about this bug go to: https://bugs.launchpad.net/phpmyadmin-sql-parser/+bug/1890341/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890341] Re: Intermittent autopkgtest failure with testStdinPipe (s390x)
Thanks Sergio for providing the patch, and William for accepting it upstream. I just uploaded the debdiff Sergio proposed with a small change, in the patch a Description was missing in the headers so I copied and pasted the content of the commit message accepted upstream. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890341 Title: Intermittent autopkgtest failure with testStdinPipe (s390x) To manage notifications about this bug go to: https://bugs.launchpad.net/phpmyadmin-sql-parser/+bug/1890341/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890341] Re: Intermittent autopkgtest failure with testStdinPipe (s390x)
Thank you for your precious help ! Merged, waiting for next 4.x or 5.x release. ** Changed in: phpmyadmin-sql-parser Assignee: (unassigned) => William Desportes (williamdes) ** Changed in: phpmyadmin-sql-parser (Ubuntu) Assignee: (unassigned) => William Desportes (williamdes) ** Changed in: phpmyadmin-sql-parser Status: New => Fix Committed ** Changed in: phpmyadmin-sql-parser (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890341 Title: Intermittent autopkgtest failure with testStdinPipe (s390x) To manage notifications about this bug go to: https://bugs.launchpad.net/phpmyadmin-sql-parser/+bug/1890341/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890341] Re: Intermittent autopkgtest failure with testStdinPipe (s390x)
The attachment "fix-ftbfs-autopkgtest-non-blocking-stdin.patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890341 Title: Intermittent autopkgtest failure with testStdinPipe (s390x) To manage notifications about this bug go to: https://bugs.launchpad.net/phpmyadmin-sql-parser/+bug/1890341/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1890341] Re: Intermittent autopkgtest failure with testStdinPipe (s390x)
I investigated this problem and came up with a solution which I think is sensible. I submitted the fix as a pull-request to upstream, which can be seen here: https://github.com/phpmyadmin/sql-parser/pull/312 I was not able to pinpoint the exact reason this problem manifests itself only on s390x, but in theory it could also happen in other architectures, because it's an issue with the way the code deals with reading input from stdin while marking it as non-blocking as well. The approach I decided to take was to rewrite the function that reads input and use stream_select (which is just a wrapper for select(2)) but keep stdin as blocking. Then, with the help of select's timeout mechanism, we're still able to not block while reading input. At the time of this writing, upstream, hasn't had the chance to review the approach yet. However, because of the upcoming feature freeze, I think it's OK for us to go ahead and apply this patch to unblock phpmyadmin-sql-parser and other packages in the proposed queue. I'm attaching a debdiff with the proposed fix. There's also a PPA with the build here: https://launchpad.net/~sergiodj/+archive/ubuntu/phpmyadmin-sql-parser- ftbfs Last, but not least, I ran autopkgtest and everything passes. ** Patch added: "fix-ftbfs-autopkgtest-non-blocking-stdin.patch" https://bugs.launchpad.net/phpmyadmin-sql-parser/+bug/1890341/+attachment/5404959/+files/fix-ftbfs-autopkgtest-non-blocking-stdin.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1890341 Title: Intermittent autopkgtest failure with testStdinPipe (s390x) To manage notifications about this bug go to: https://bugs.launchpad.net/phpmyadmin-sql-parser/+bug/1890341/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
