Launchpad has imported 23 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=1680527.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.
On 2020-12-03T16:18:39+00:00 Sebastien Bacher wrote:
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:83.0)
Gecko/20100101 Firefox/83.0
Steps to reproduce:
The bug was reported against the snap on
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1903805
' Thunderbird snap keeps asking to be the default email client '
The issue is similar to firefox bug 512305 , the approach for writing to
~/.local/share/applications directly isn't going to work for confined
applications
Actual results:
Thunderbird changes the default mimetype association in its private snap
directory
Expected results:
The default is changed in the real user directory. Calling xdg-settings
is proxyed to snapd and leads to the correct result
Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1903805/comments/2
On 2020-12-03T16:22:03+00:00 Sebastien Bacher wrote:
Created attachment 9191065
thunderbird-xdg-settings.patch
The attached patch is similar to what firefox has been doing in
https://hg.mozilla.org/releases/mozilla-release/rev/74e95f9fb43e (the
snap env detection has been updated to be similar to what firefox is
currently doing which is a bit different from what first landed)
Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1903805/comments/3
On 2020-12-05T23:02:13+00:00 Rob Lemley wrote:
It looks reasonable enough and applied cleanly to current Daily code. I
started up a try (Daily version) build with it applied. Any chance of
getting a proper patch with the a checkin comment and author information
included?
Try build: https://treeherder.mozilla.org/jobs?repo=try-comm-
central=FlDpf85IR6C3AvUa4Cl4UQ.0=8c6b6907e248c88ad5f0bcb3001d5d6c882a2d0c
Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1903805/comments/4
On 2020-12-08T10:07:20+00:00 Sebastien Bacher wrote:
Thanks for the review, I'll update the patch in the next days as
requested, I just need to figure out the proper mercurial workflow
Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1903805/comments/5
On 2020-12-08T20:58:40+00:00 Mkmelin+mozilla wrote:
Please see https://developer.thunderbird.net/thunderbird-
development/fixing-a-bug
For patches, it's what `hg export` gives you, not `hg diff` (and do set
your name/addr up in hg)
Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1903805/comments/6
On 2020-12-09T19:58:58+00:00 Sebastien Bacher wrote:
Created attachment 9192263
Use xdg-settings in the snap to set default
Thanks for the pointer, I had read that documentation but got lost in
the queues details. I've screwed my checkout but I'm adding one with the
author/description at least, if that's not enough to commit let me know
and I will try to do again a proper checkout to have the right commit id
reference
Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1903805/comments/7
On 2020-12-10T00:11:37+00:00 Rob Lemley wrote:
I built a Snap package with this applied (Thunderbird Daily) and it
didn't work. I'll try applying it to 78.6 tomorrow and see if it fares
better. (Using Ubuntu's snap sources and a build I ran on try-c-c.)
xdg-settings reports that Thunderbird is the default mail client, but I
keep getting the popup when I start it. I checked for the SNAP_NAME
environment variable on the process and it is set to "thunderbird".
Test system is Ubuntu LTS (20.04.1).
Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1903805/comments/8
On 2020-12-10T12:07:04+00:00 Mkmelin+mozilla wrote:
Comment on attachment 9192263
Use xdg-settings in the snap to set default
Review of attachment 9192263:
-
::: mail/components/shell/nsGNOMEShellService.cpp
@@ +241,5 @@
> + }
> + if (strcmp(output, "thunderbird.desktop\n") == 0) {
> + g_free(output);
> + return true;
> + }
This part doesn't seem to follow what firefox currently has..?
Reply at:
