[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
This bug was fixed in the package opengcs - 0.3.4+dfsg2-0ubuntu3.18.04.1 --- opengcs (0.3.4+dfsg2-0ubuntu3.18.04.1) bionic; urgency=medium * d/p/0002-Simplify-ticks.patch: simplify ticks using a constant. This change follows what was done by runc upstream maintainers (LP: #1912691). -- Lucas Kanashiro Mon, 22 Mar 2021 12:00:41 -0300 ** Changed in: opengcs (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
This bug was fixed in the package opengcs - 0.3.4+dfsg2-0ubuntu3.20.04.1 --- opengcs (0.3.4+dfsg2-0ubuntu3.20.04.1) focal; urgency=medium * d/p/0002-Simplify-ticks.patch: simplify ticks using a constant. This change follows what was done by runc upstream maintainers (LP: #1912691). -- Lucas Kanashiro Mon, 22 Mar 2021 12:02:47 -0300 ** Changed in: opengcs (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
This bug was fixed in the package opengcs - 0.3.4+dfsg2-0ubuntu4.1 --- opengcs (0.3.4+dfsg2-0ubuntu4.1) groovy; urgency=medium * d/p/0002-Simplify-ticks.patch: simplify ticks using a constant. This change follows what was done by runc upstream maintainers (LP: #1912691). -- Lucas Kanashiro Mon, 22 Mar 2021 12:04:30 -0300 ** Changed in: opengcs (Ubuntu Groovy) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
The test plan says the upstream test suite should be executed to catch any regression. This was done during the package build process and it succeeded. Therefore, I am considering the validation as done for this SRU. ** Tags removed: verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy ** Tags added: verification-done verification-done-bionic verification-done-focal verification-done-groovy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
Hello Lucas, or anyone else affected, Accepted opengcs into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/opengcs/0.3.4+dfsg2-0ubuntu4.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-groovy. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: opengcs (Ubuntu Groovy) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-groovy ** Changed in: opengcs (Ubuntu Focal) Status: New => Fix Committed ** Tags added: verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
SRU +1 for opengcs as currently in Bionic, Focal and Groovy Unapproved. I prefer to accept all related packages together to avoid confusion, so I intend to accept these together with containerd and docker.io when they are ready (currently waiting on feedback from my review at https://bugs.launchpad.net/ubuntu/+source/docker.io/+bug/1919322/comments/15). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
Thanks for the review Sergio! I am going to fix my email address in the groovy package and upload all of them. Also fix/improve the bug description. ** Description changed: [Impact] Due to our current policy we keep updating the container stack in all supported releases with new upstream versions. runc is part of this stack, and currently versions of opengcs in Bionic, Focal and Groovy do not support runc / 1.0.0 ~ rc93-0ubuntu1. opengcs tries to make use of system.GetClockTicks which would require a dependency on cgo. runc upstream decided to stop using it here: https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817 In Hirsute, a similar approach was implemented in opengcs to allow runc migration. Now, in order to unblock the runc SRUs we need to backport the Hirsute patch. [Test Plan] - The upstream test suite seems to be enough to caught any potential issue + The upstream test suite seems to be enough to catch any potential issue in this case. [Where problems could occur] - We are replacing a system call which would require cgo with a constant. - According to this comment this is safe enough: + We are replacing a system call which would require cgo with a known + constant to avoid this dependency. This approach was adopted by runc + upstream maintainers, and according to this comment this is safe enough: https://github.com/containerd/cgroups/pull/12#issuecomment-311322400 But the scenario where someone compile its own kernel and change the value of this constant will be inconsistent. However, this is not a big deal IMO, someone changing its own kernel needs to handle the consequences. [Original Message] opencgs test is failing and blocking runc/1.0.0~rc92-0ubuntu1 from migrating to hirsute: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac /autopkgtest- hirsute/hirsute/amd64/o/opengcs/20210118_162901_84e57@/log.gz This is the important bits: # vendor/github.com/docker/containerd/sys src/vendor/github.com/docker/containerd/sys/proc.go:17:34: undefined: system.GetClockTicks The new runc version does not provide GetClockTicks anymore: https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817 We should do the same in opengcs. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
Thanks, Lucas. I reviewed the patches and they look fine. A very small nit: you're using your @debian.org email in the Groovy changelog. Other than that, all 3 patches LGTM. I did build all 3 packages in a local sbuild, and the builds succeeded. A few comments about the SRU template: - In the "Test Plan" section, s/caught/catch/. - In the "Where problems could occur" section, this sentence seems strange: "We are replacing a system call which would require cgo with a constant." Just pointing it out in case you want to clarify it. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
** Attachment added: "debdiff-bionic" https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+attachment/5479208/+files/debdiff-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
** Attachment added: "debdiff-focal" https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+attachment/5479207/+files/debdiff-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
** Attachment added: "debdiff-groovy" https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+attachment/5479206/+files/debdiff-groovy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
I prepared packages for Bionic, Focal and Groovy here in this PPA: https://launchpad.net/~lucaskanashiro/+archive/ubuntu/opengcs autopkgtest is passing in all of them. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1912691] Re: [SRU] Support runc/1.0.0~rc93-0ubuntu1
** Description changed: + [Impact] + + Due to our current policy we keep updating the container stack in all + supported releases with new upstream versions. runc is part of this + stack, and currently versions of opengcs in Bionic, Focal and Groovy do + not support runc / 1.0.0 ~ rc93-0ubuntu1. + + opengcs tries to make use of system.GetClockTicks which would require a + dependency on cgo. runc upstream decided to stop using it here: + + https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817 + + In Hirsute, a similar approach was implemented in opengcs to allow runc + migration. Now, in order to unblock the runc SRUs we need to backport + the Hirsute patch. + + [Test Plan] + + The upstream test suite seems to be enough to caught any potential issue + in this case. + + [Where problems could occur] + + We are replacing a system call which would require cgo with a constant. + According to this comment this is safe enough: + + https://github.com/containerd/cgroups/pull/12#issuecomment-311322400 + + But the scenario where someone compile its own kernel and change the + value of this constant will be inconsistent. However, this is not a big + deal IMO, someone changing its own kernel needs to handle the + consequences. + + [Original Message] + opencgs test is failing and blocking runc/1.0.0~rc92-0ubuntu1 from migrating to hirsute: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac /autopkgtest- hirsute/hirsute/amd64/o/opengcs/20210118_162901_84e57@/log.gz This is the important bits: # vendor/github.com/docker/containerd/sys src/vendor/github.com/docker/containerd/sys/proc.go:17:34: undefined: system.GetClockTicks The new runc version does not provide GetClockTicks anymore: https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817 We should do the same in opengcs. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1912691 Title: [SRU] Support runc/1.0.0~rc93-0ubuntu1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
