Public bug reported:

I think that in the error message of getlock method are swapped got and
wanted lock types.

if (scope != reslock.scope) {
        t_context("requested lockscope not satisfied!  got %s, wanted %s",
                  scope == ne_lockscope_exclusive ? "exclusive" : "shared",
                  reslock.scope == ne_lockscope_exclusive ? 
                  "exclusive" : "shared");
        ne_unlock(i_session, &reslock);
        return FAIL;
    }    

I'd patch it as follows:

line 86 -- t_context("requested lockscope not satisfied!  got %s, wanted
%s",

line 86 ++ t_context("requested lockscope not satisfied!  wanted %s, got
%s",

** Affects: litmus (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "A patch fixing the reported problem."
   
https://bugs.launchpad.net/bugs/1915018/+attachment/5461260/+files/locks.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1915018

Title:
  Misleading error message in lock tests

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/litmus/+bug/1915018/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to