[Bug 1927980] Re: smartd-runner bug causes loss of email recipients
Thank you for your reply. Unfortunately I cannot help you with salsa; I don't manage the system. I know you can ask for help on the #salsa channel (OFTC IRC network); maybe someone there will be able to help you with the user creation. Once you are able to login you should also be able to create the Merge Request. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1927980 Title: smartd-runner bug causes loss of email recipients To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1927980/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1927980] Re: smartd-runner bug causes loss of email recipients
** Changed in: smartmontools (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1927980 Title: smartd-runner bug causes loss of email recipients To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1927980/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1927980] Re: smartd-runner bug causes loss of email recipients
> Also, if you have the time, it would be good if you could also open a Merge > Request against the Debian smartmontools project on salsa: > > https://salsa.debian.org/debian/smartmontools I'd love to, but how? What do you suggest? -- salsa won't let me create a merge request, presumably because I am not logged in. -- salsa won't let me log in using my longstanding oft-used github credentials. -- it also won't let me log in with username (JohnDenker) and password; it says: Your account is pending approval from your GitLab administrator and hence blocked. Please contact your GitLab administrator if you think this is an error. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1927980 Title: smartd-runner bug causes loss of email recipients To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1927980/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1927980] Re: smartd-runner bug causes loss of email recipients
I tried investigating this bug a bit more with Athos' help. First, I cannot easily reproduce it because smartd doesn't even start when running on virtualized environments, and I don't feel like using my own host machine to test the problem. Then, I noticed that there is a bug filed upstream which looked very similar to this one: https://www.smartmontools.org/ticket/1454 It *may* be related, but it doesn't seem to directly impact this one (keep reading). After looking at the flow of execution, it was clear that: - smartd will call /usr/share/smartmontools/smartd_warning.sh after having set a bunch of environment variables that affect the execution of the script. For our purposes, the only variables we will need to manually set are SMARTD_ADDRESS and SMARTD_MAILER. - Because SMARTD_MAILER will be set to /usr/share/smartmontools/smartd- runner, this is the script that will be executed afterwards. After looking at what "smartd-runner" does (it invokes every executable under /etc/smartmontools/run.d/), and after verifying that the only thing under /etc/smartmontools/run.d/ is a very simple script called "10mail" (which just invokes the "mail" command with some arguments), it's clear that we can try to reproduce this bug by hand. By the way, here is the smartd function that is responsible for putting the arguments together and actually invoking the smartd_warning.sh script: https://www.smartmontools.org/browser/tags/RELEASE_7_1/smartmontools/smartd.cpp#L1084 In a nutshell, what the function seems to do is: To reproduce the bug, we can: $ lxc launch images:ubuntu/focal smartmontools-focal $ lxc shell smartmontools-focal # apt update && apt install -y smartmontools bsd-mailx # adduser test # SMARTD_ADDRESS="root test" SMARTD_MAILER=/usr/share/smartmontools/smartd-runner /usr/share/smartmontools/smartd_warning.sh # mail root ... verify that there's an email from smartd_warning ... # su - test $ mail No mail for test I verified that the reporter's patch seems to fix the problem. @John, I noticed that you opened a bug against Debian, which is good. However, there is already a bug opened about this problem: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661485 Could you please close your bug and comment on that other bug to let them know that you're also affected? Also, if you have the time, it would be good if you could also open a Merge Request against the Debian smartmontools project on salsa: https://salsa.debian.org/debian/smartmontools Thanks a lot. ** Bug watch added: www.smartmontools.org/ #1454 https://www.smartmontools.org/ticket/1454 ** Changed in: smartmontools (Ubuntu) Status: New => Triaged ** Changed in: smartmontools (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1927980 Title: smartd-runner bug causes loss of email recipients To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1927980/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1927980] Re: smartd-runner bug causes loss of email recipients
** Bug watch added: Debian Bug tracker #661485 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661485 ** Also affects: smartmontools (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661485 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1927980 Title: smartd-runner bug causes loss of email recipients To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1927980/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1927980] Re: smartd-runner bug causes loss of email recipients
Pushed upstream, as requested, just now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1927980 Title: smartd-runner bug causes loss of email recipients To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1927980/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1927980] Re: smartd-runner bug causes loss of email recipients
Thank you for taking the time to report this bug and helping to make Ubuntu better. This bug is present in Debian as well and Ubuntu currently does not make any changes to the Debian package. Therefore, this bug would be best fixed directly in Debian, and then Ubuntu will pick up the fix automatically. Once it is fixed in the development release we can consider a SRU: https://wiki.ubuntu.com/StableReleaseUpdates Would you mind filing a bug with Debian please? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1927980 Title: smartd-runner bug causes loss of email recipients To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1927980/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1927980] Re: smartd-runner bug causes loss of email recipients
The attachment "smartd-runner.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1927980 Title: smartd-runner bug causes loss of email recipients To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1927980/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
