[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
This bug was fixed in the package golang-github-docker-go-connections - 0.4.0-2ubuntu0.21.04.1 --- golang-github-docker-go-connections (0.4.0-2ubuntu0.21.04.1) hirsute; urgency=medium * Fix FTBFS which is blocking runc migration (LP: #1930891). - d/p/0001-Skip-tests-which-use-expired-certificate.patch: backport patch written by the Debian maintainer to skip tests which relies on expired certificates. -- Lucas Kanashiro Fri, 04 Jun 2021 10:29:13 -0300 ** Changed in: golang-github-docker-go-connections (Ubuntu Hirsute) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
The regressions are gone and now this is ready to land. The Test Plan section indicates this would need to build in Hirsute and here you go: https://launchpad.net/ubuntu/+source/golang-github-docker-go- connections/0.4.0-2ubuntu0.21.04.1/+build/21685532 ** Tags removed: verification-needed verification-needed-hirsute ** Tags added: verification-done verification-done-hirsute -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
Sorry, the debdiff above is incorrect. The golang-github-containers- image package in hirsute was uploaded disabling LTO here: https://bugs.launchpad.net/ubuntu/bionic/+source/golang-github- containers-image/+bug/1938908/comments/28 Once this is accepted, we will be able to land this update which is also blocking the container stack SRU one more time. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
This is hitting us again while backporting the container stack: https://bugs.launchpad.net/ubuntu/bionic/+source/golang-github- containers-image/+bug/1938908 I'll disable LTO to make it build fine on the failing architectures. Debdiff attached. ** Patch added: "golang-github-docker-go-connections.debdiff" https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+attachment/5533314/+files/golang-github-docker-go-connections.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
The package is FTBFS on non-amd64 architectures (64-bits only) due to LTO. I could disable LTO in d/rules as well but since the runc SRU was unblocked (already landed) I am not sure if this is still an update we want to land. WDYT? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
Hello Lucas, or anyone else affected, Accepted golang-github-docker-go-connections into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-github-docker-go- connections/0.4.0-2ubuntu0.21.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: golang-github-docker-go-connections (Ubuntu Hirsute) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-hirsute -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
@Brian to be honest I also do not know how to mock the date in those tests. I tried some options that I found on some forums but none of them worked out. Upstream is still unresponsive and those same tests are also failing in their master branch. If you think this is not a suitable SRU I'd ask you to ignore those tests for now and unblock the runc SRU, that's my main goal here. ** Changed in: golang-github-docker-go-connections (Ubuntu Hirsute) Status: Incomplete => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
I'm not familiar with go but is there anything like datefudge (which was used in an SRU of gnutls28) or faketime that can be used to set the date to one that is before the date on which the certificate expired? I think it'd be better if we didn't skip tests which then might allow the package to regress. ** Changed in: golang-github-docker-go-connections (Ubuntu Hirsute) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
After further discussion within the team we decided that using ubuntu0.21.04.1 is the best option here. There is the unlikely but possible case where -3 is removed from impish-proposed and Impish gets released with -2. ** Attachment added: "debdiff3" https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+attachment/5502484/+files/debdiff3 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
Thanks for taking another look on this Utkarsh! We append ubuntu0.XX.YY.1 to the version string when we have the same version in 2 releases but in this case this version was released only in Hirsute, Impish was not released yet :) I'll be uploading the last debdiff I attached. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
Either way, +1 for the patch; go, go, go! \o/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
There you go, the attached debdiff has some DEP-3 headers in the added patch. ** Attachment added: "debdiff2" https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+attachment/5502460/+files/debdiff2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
Hey, how about we use 0.4.0-2ubuntu0.21.04.1 as the version number? impish (-release) has the same version atm; I now -3 is in -pocket but still, always helpful to use 0.21.04.X, I believe. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
I tried to just import the patch added by the Debian maintainer with no changes but I think it is better to add some DEP-3 headers as you mentioned. Checking the upstream bug tracker I noticed I filed this very same bug some months ago :) but no replies so far: https://github.com/docker/go-connections/issues/83 ** Also affects: golang-github-docker-go-connections (Ubuntu Hirsute) Importance: Undecided Status: New ** Changed in: golang-github-docker-go-connections (Ubuntu) Status: New => Fix Released ** Changed in: golang-github-docker-go-connections (Ubuntu Hirsute) Status: New => In Progress ** Bug watch added: github.com/docker/go-connections/issues #83 https://github.com/docker/go-connections/issues/83 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
This looks good! I'm wondering if that's worth raising an issue upstream? If there is already, probably, add this to the patch header. Except for the DEP3 thingy, it looks good! \o/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration
The attached debdiff adds the patch to skip the tests as mentioned in the description and fixes the FTBFS. ** Attachment added: "debdiff" https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+attachment/5502458/+files/debdiff ** Description changed: + [Impact] + + This FTBFS is avoiding runc users to get an important update (LP + #1927219). Moreover, the fix adopted by the Debian maintainer is minimal + and very simple. + + [Test Plan] + + Check if the package is building fine in Hirsute. + + [Where problems could occur] + + TBH I can't foresee any problem at all, no feature code is touched and + just a couple of tests are skippped. In case something bad happens will + be when running TLS related tests. + + [Original message] + golang-github-docker-go-connections is FTBFS in Hirsute because a couple of tests rely on an expired certificate. This failure is blocking the runc migration. The Debian maintainer fixed it in the next revision but it did not make into Hirsute. The simple fix is to backport this patch as-is to Hirsute to also skip those tests there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
