[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
** Changed in: ubuntu-z-systems Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
This bug was fixed in the package linux - 5.4.0-88.99 --- linux (5.4.0-88.99) focal; urgency=medium * focal/linux: 5.4.0-88.99 -proposed tracker (LP: #1944747) * Packaging resync (LP: #1786013) - debian/dkms-versions -- update from kernel-versions (main/2021.09.06) * please drop virtualbox-guest-dkms virtualbox-guest-source (LP: #1933248) - Revert "UBUNTU: [Config] Disable virtualbox dkms build" linux (5.4.0-87.98) focal; urgency=medium * please drop virtualbox-guest-dkms virtualbox-guest-source (LP: #1933248) - [Config] Disable virtualbox dkms build * Packaging resync (LP: #1786013) - debian/dkms-versions -- update from kernel-versions (main/2021.09.06) * LRMv5: switch primary version handling to kernel-versions data set (LP: #1928921) - [Packaging] switch to kernel-versions * disable “CONFIG_HISI_DMA” config for ubuntu version (LP: #1936771) - Disable CONFIG_HISI_DMA - [Config] Record hisi_dma no longer built for arm64 * memory leaking when removing a profile (LP: #1939915) - apparmor: Fix memory leak of profile proxy * CryptoExpress EP11 cards are going offline (LP: #1939618) - s390/zcrypt: Support for CCA protected key block version 2 - s390: Replace zero-length array with flexible-array member - s390/zcrypt: Use scnprintf() for avoiding potential buffer overflow - s390/zcrypt: replace snprintf/sprintf with scnprintf - s390/ap: Remove ap device suspend and resume callbacks - s390/zcrypt: use fallthrough; - s390/zcrypt: use kvmalloc instead of kmalloc for 256k alloc - s390/ap: remove power management code from ap bus and drivers - s390/ap: introduce new ap function ap_get_qdev() - s390/zcrypt: use kzalloc - s390/zcrypt: fix smatch warnings - s390/zcrypt: code beautification and struct field renames - s390/zcrypt: split ioctl function into smaller code units - s390/ap: rename and clarify ap state machine related stuff - s390/zcrypt: provide cex4 cca sysfs attributes for cex3 - s390/ap: rework crypto config info and default domain code - s390/zcrypt: simplify cca_findcard2 loop code - s390/zcrypt: remove set_fs() invocation in zcrypt device driver - s390/ap: remove unnecessary spin_lock_init() - s390/zcrypt: Support for CCA APKA master keys - s390/zcrypt: introduce msg tracking in zcrypt functions - s390/ap: split ap queue state machine state from device state - s390/ap: add error response code field for ap queue devices - s390/ap: add card/queue deconfig state - s390/sclp: Add support for SCLP AP adapter config/deconfig - s390/ap: Support AP card SCLP config and deconfig operations - s390/ap/zcrypt: revisit ap and zcrypt error handling - s390/zcrypt: move ap_msg param one level up the call chain - s390/zcrypt: Introduce Failure Injection feature - s390/zcrypt: fix wrong format specifications - s390/ap: fix ap devices reference counting - s390/zcrypt: return EIO when msg retry limit reached - s390/zcrypt: fix zcard and zqueue hot-unplug memleak - s390/ap: Fix hanging ioctl caused by wrong msg counter * memfd from ubuntu_kernel_selftests failed to build on B-5.4 (LP: #1926142) - SAUCE: selftests/memfd: fix build when F_SEAL_FUTURE_WRITE is not defined * [SRU] Ice driver causes the kernel to crash with Ubuntu 20.04.2 with ethtool specific register commands (LP: #1939855) - ice: Fix bad register reads * ubunut_kernel_selftests: memory-hotplug: avoid spamming logs with dump_page() (LP: #1941829) - selftests: memory-hotplug: avoid spamming logs with dump_page(), ratio limit hot-remove error test * e1000e blocks the boot process when it tried to write checksum to its NVM (LP: #1936998) - e1000e: Do not take care about recovery NVM checksum * Focal update: v5.4.140 upstream stable release (LP: #1941798) - Revert "ACPICA: Fix memory leak caused by _CID repair function" - ALSA: seq: Fix racy deletion of subscriber - arm64: dts: ls1028a: fix node name for the sysclk - ARM: imx: add missing iounmap() - ARM: imx: add missing clk_disable_unprepare() - ARM: dts: imx6qdl-sr-som: Increase the PHY reset duration to 10ms - ARM: dts: colibri-imx6ull: limit SDIO clock to 25MHz - ARM: imx: fix missing 3rd argument in macro imx_mmdc_perf_init - ARM: dts: imx: Swap M53Menlo pinctrl_power_button/pinctrl_power_out pins - arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode - ALSA: usb-audio: fix incorrect clock source setting - clk: stm32f4: fix post divisor setup for I2S/SAI PLLs - ARM: dts: am437x-l4: fix typo in can@0 node - omap5-board-common: remove not physically existing vdds_1v8_main fixed- regulator - spi: imx: mx51-ecspi: Reinstate low-speed CONFIGREG delay - spi: imx: mx51-ecspi: Fix low-speed CONFIGREG delay calculation - scsi: sr: Return correct event when media event code is
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
Thx Harald for the verification (adjusting the tags accordingly ...) ** Changed in: linux (Ubuntu) Status: Fix Committed => Fix Released ** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed- focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
** Also affects: linux (Ubuntu Impish) Importance: Undecided Assignee: Canonical Kernel Team (canonical-kernel-team) Status: Fix Committed ** Also affects: linux (Ubuntu Hirsute) Importance: Undecided Status: New ** No longer affects: linux (Ubuntu Hirsute) ** No longer affects: linux (Ubuntu Impish) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
** Changed in: linux (Ubuntu) Status: In Progress => Fix Committed ** Changed in: ubuntu-z-systems Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
** Changed in: linux (Ubuntu Focal) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
** Also affects: linux (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Focal) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
Pull request submitted to kernel team's mailing list: https://lists.ubuntu.com/archives/kernel-team/2021-August/thread.html#123711 changing status to 'In Progress'. ** Changed in: linux (Ubuntu) Status: Triaged => In Progress ** Changed in: ubuntu-z-systems Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
** Description changed:
+ SRU Justification:
+
+ [Impact]
+
+ * With current focal kernels IBM Z CryptoExpress adapters in EP11 mode
+ go offline in case of unknown error indications from the hardware.
+
+ * This does not only lead to a software fallback, but can also lead to errors
and crashes,
+ if certain crypto operations are currently ongoing.
+
+ * A rework of the AP bus and zcrypt device driver, as it was done in
+ 5.11, fixes the situation.
+
+ * From the below range of commits, the last 1/3 are the ones that fix the
issue mentioned here
+ and the others are pre-requisites to get the relevant ones applied.
+
+ * In theory the patch set could have been made smaller,
+ but with the cost that the code would be a mix between old and new, with
maybe some new code snippets,
+ hence it would divert from what's upstream accepted (in 5.11 and above),
the risk would increase,
+ increased effort to maintain and less test coverage.
+
+ [Fix]
+
+ * The SRU request was created as pull request,
+ so please pull f904c400c9c4^..f6d9ab1de03a (means starting at f904c400c9c4
{incl.} to head/f6d9ab1de03a {incl.})
+ from here: https://code.launchpad.net/~fheimes/+git/lp1939618
+
+ [Test Case]
+
+ * An Ubuntu Server 20.04 on IBM Z or LinuxONE installation is required,
+ with ideally three attached CryptoExpress adapters running in CCA, EP11 and
accelerator mode.
+
+ * Run stress test on these three CryptoExpress adapters.
+
+ * IBM has such stress tests and ran these based on a patched Ubuntu 20.04
kernel.
+ The tests come with a specially focus on error path tests,
+ since this patch set mainly focuses on doing a better error patch handling.
+
+ * Note: A a new config option for the zcrypt driver was introduced
+ that enables the possibility to inject erroneous messages.
+
+ * An application exists that generates such messages and thus tests
+ these error paths.
+
+ * Canonical's focus will mainly be on regression testing.
+
+ [Regression Potential]
+
+ * Like with all modification there is a certain risk of regressions,
+ especially with bigger patch sets.
+
+ * But the modifications here are limited to the s390x platform,
+ and there again largely to the s390x hardware crypto stack and driver
+ (CryptoExpress adapter) which is optional hardware.
+ (See the diff stat in the comment below.)
+
+ * The crypto-specific tools (located at the s390-tools package) may no longer
work with this patched driver.
+ But this got tested by IBM with the result that the changes are fully
backward compatible.
+ The 'older' s390 tools package (from focal) can just not show and control
the new (config state) feature,
+ but the functionality covered by the older s390 tools package is utterly
covered by this patch set.
+
+ * The core of this patch set went into the 5.11 kernel upstream,
+ hence is in hirsute (and has also been picked by other distros).
+
+ * Since this patch set is a rework of the AP bus and zcrypt driver code,
+ it may now show new errors that were never thrown before, like for or
example memory leaks.
+ However, this is not unique to this patch set, it the same for upstream,
Hirsute and Impish (and other distros).
+
+ * The patches are all upstream and all needed upstream commits could just be
cherry-picked,
+ hence no modifications were needed.
+
+ * So the commits were not only tested by IBM upfront,
+ but a patched focal master-next kernel is also available as PPA (see
comment below) for further testing.
+
+ * This patch set was also tested on 5.11, where two issues were found
+ that are already part of this set.
+
+ [Other]
+
+ * I iterated through all commits and found that that the latest ones got
upstream with 5.13,
+ hence Impish includes all commits needed and is not affected!
+
+ * Looks like all commits, expect three, are even upstream with 5.11,
+ but the missing three came in on top via upstream stable,
+ hence Hirsute master-next includes all commits needed too and is also not
affected!
+
+ * But non of the commits could be found in current Focal master-next (aot:
5.4.0-84),
+ the first commits from this set started to land with 5.7,
+ hence this SRU request is for focal only.
+ __
+
Here is the backport against current git for ubuntu 20.04.
It is a zip file with a patches subdir and all the patches in there together
with a series file. So just unpack it and apply with quilt.
** Changed in: linux (Ubuntu)
Status: Incomplete => Triaged
** Changed in: ubuntu-z-systems
Status: Incomplete => Triaged
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1939618
Title:
CryptoExpress EP11 cards are going offline
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
The patched focal master-next kernel sources are available as PR from here: https://code.launchpad.net/~fheimes/+git/lp1939618 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
diff stat graph that provides an indication where the changes mainly are: arch/s390/appldata/appldata_os.c | 2 +- arch/s390/include/asm/sclp.h | 2 + arch/s390/include/uapi/asm/zcrypt.h| 140 +++--- drivers/s390/block/dasd_diag.c | 2 +- drivers/s390/block/dasd_eckd.h | 2 +- drivers/s390/char/Makefile | 2 + drivers/s390/char/raw3270.h| 2 +- drivers/s390/char/sclp.h | 2 +- drivers/s390/char/sclp_ap.c| 63 +++ drivers/s390/char/sclp_pci.c | 2 +- drivers/s390/cio/idset.c | 2 +- drivers/s390/crypto/ap_bus.c | 974 +++- drivers/s390/crypto/ap_bus.h | 139 +++-- drivers/s390/crypto/ap_card.c | 98 ++-- drivers/s390/crypto/ap_debug.h | 8 + drivers/s390/crypto/ap_queue.c | 513 +++ drivers/s390/crypto/pkey_api.c | 20 +- drivers/s390/crypto/zcrypt_api.c | 574 ++--- drivers/s390/crypto/zcrypt_api.h | 49 +- drivers/s390/crypto/zcrypt_card.c | 30 +- drivers/s390/crypto/zcrypt_ccamisc.c | 320 ++-- drivers/s390/crypto/zcrypt_ccamisc.h | 32 +- drivers/s390/crypto/zcrypt_cex2a.c | 8 +- drivers/s390/crypto/zcrypt_cex2c.c | 164 +- drivers/s390/crypto/zcrypt_cex4.c | 197 drivers/s390/crypto/zcrypt_debug.h | 8 + drivers/s390/crypto/zcrypt_ep11misc.c | 41 +- drivers/s390/crypto/zcrypt_error.h | 92 ++-- drivers/s390/crypto/zcrypt_msgtype50.c | 179 +++ drivers/s390/crypto/zcrypt_msgtype6.c | 374 +++--- drivers/s390/crypto/zcrypt_msgtype6.h | 8 +- drivers/s390/crypto/zcrypt_queue.c | 26 +- -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
A patched kernel (based on 5.4.0-84, current focal master-next) got built and is available for further testing here: https://launchpad.net/~fheimes/+archive/ubuntu/lp1939618 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: CryptoExpress EP11 cards are going offline
** Summary changed: - EP11 cards going offline => Fix backport to U20.04LTS + CryptoExpress EP11 cards are going offline -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: CryptoExpress EP11 cards are going offline To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
