[Bug 1939618] Re: EP11 cards going offline => Fix backport to U20.04LTS
Hi Harald, well, I hope it's not too much effort, since: - you already have a proper sequence (it's more or less your series file in your zip) (however, if this list could be minimized to the bare minimum, that would be highly desired) - then I guess you remember which of the exported commits you had to touch and modify; these are the ones that need the additional 'backported' and 'Signed-off-by' lines - then just attach these official backport files and the sequence (The cherry-picked lines do not need to be added manually, since git will do that for us, once we'll process the sequence...) We will also need to add a "SRU justification" (like you can see in the bug description of this bug LP#1925452) - but once there, I can create a draft, but may ask you to help on some details (like how this can be tested, regression risk, etc.) ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: EP11 cards going offline => Fix backport to U20.04LTS To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: EP11 cards going offline => Fix backport to U20.04LTS
Sorry for coming back to this with a little delay, due to the 21.10 FF
and the 20.04.3 RCs ...
I'm not sure if I understood you correctly.
Does that mean that the commits 27c4f6738bdc to 91ffc519c199 from comment #5
all needed to be touched and are backports?
And that the remaining ones are all just plain exports - w/o any modification,
hence can simply be cherry-picked?
This distinction is very crucial and need to be added to each of the
commits, so that the entire provenance of the commit/patch is traceable.
So in other words all commits that had to be touches ('backported') need to
have lines like this:
"
(backported from commit 5620ae29f1eabe655f44335231b580a78c8364ea)
Signed-off-by: First-Name Last-Name
"
(like described here: https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat
this is not unique to the Canonical kernel team procedure, but a kind of a
de-facto standard ...)
Here is an example LP bug with backports attached:
https://bugs.launchpad.net/bugs/1925452
Generally the others would need lines like this:
"
(cherry picked from commit d4e0018e3e4dd685af25d300fd26a0d5a984482e)
Signed-off-by: First-Name Last-Name
"
But the 'cherry-picked' lines do not need to be added manually, since
git helps on doing this.
(If you grep for 'backport' or 'cherry-picked' though the list of
patches in your zip file I get no hits.)
---
So what we need is:
1) separate 'backport' files of the modified commits only,
that have a 'backported' AND an additional 'Signed-off-by' line included by
the backporter
(no files are needed for commits that can just be cherry picked)
2) a list / sequence of the backport files AND cherry pick commits,
that allows to get the entire set of needed commits/patches (cherry-picks
and backports)
applied to the Ubuntu focal master-next git tree
[git://kernel.ubuntu.com/ubuntu/ubuntu-focal --branch master-next
--single-branch]
(we need to be able to re-run and re-apply this again)
The rest can( and is) usually done by us - means reapplying them,
pushing then to a remote git branch on Launchpad and finally sending a
pull request (incl. cover letter) to the Canonical kernel teams mailing
list.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1939618
Title:
EP11 cards going offline => Fix backport to U20.04LTS
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: EP11 cards going offline => Fix backport to U20.04LTS
** Changed in: ubuntu-z-systems Status: Triaged => Incomplete ** Changed in: linux (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: EP11 cards going offline => Fix backport to U20.04LTS To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: EP11 cards going offline => Fix backport to U20.04LTS
As Frank mentioned, the patches cannot be accepted in that form. There is no information where these came from and what was changed in the backport. This is a series of 33 commits, it's enormous. Are these all fixes? Looks like not because only two patches have stable tags, +three patches have Fixes tag. What's with the rest? Are they going to stable trees? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: EP11 cards going offline => Fix backport to U20.04LTS To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: EP11 cards going offline => Fix backport to U20.04LTS
Well, this is a patch set of 34 commits, which is significant, and looks to me that they cover much more than just fixing "EP11 cards going offline", rather than bringing the entire driver to the latest level. The usual way is to pick the minimal set of patches that fix a particular issue and get these SRUed. And btw. this is a relatively unusual way of sharing patches or backports -- if about a handful of patches (or two) are needed, we would do cherry-picks or apply selective backport patch-files. In case of more patches the usual way is a branch with a pull-request. But the patches seem to apply cleanly to the current focal master-next tree and touch s390x specific files only (either in /arch/s390/ or in /drivers/s390/). Please notice that hirsute's 5.11 kernel would need to be on the same level, to avoid any potential regressions on upgrades. I'll bring this to the kernel teams attention and we'll discuss if this is doable as SRU. ** Changed in: ubuntu-z-systems Status: New => Triaged ** Changed in: linux (Ubuntu) Assignee: Skipper Bug Screeners (skipper-screen-team) => Canonical Kernel Team (canonical-kernel-team) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: EP11 cards going offline => Fix backport to U20.04LTS To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1939618] Re: EP11 cards going offline => Fix backport to U20.04LTS
** Also affects: ubuntu-z-systems Importance: Undecided Status: New ** Changed in: ubuntu-z-systems Importance: Undecided => High ** Changed in: ubuntu-z-systems Assignee: (unassigned) => Skipper Bug Screeners (skipper-screen-team) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939618 Title: EP11 cards going offline => Fix backport to U20.04LTS To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1939618/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
