[Bug 1940465] Re: redshift/1.12-4.2 FTBFS in Impish
This bug was fixed in the package redshift - 1.12-4.2ubuntu1 --- redshift (1.12-4.2ubuntu1) impish; urgency=medium * d/rules: pass --without-systemduserunitdir to configure to avoid the creation/installation of systemd service files (LP: #1940465). -- Lucas Kanashiro Thu, 19 Aug 2021 11:43:47 -0300 ** Changed in: redshift (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940465 Title: redshift/1.12-4.2 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1940465] Re: redshift/1.12-4.2 FTBFS in Impish
Great! Thanks again :) Package uploaded. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940465 Title: redshift/1.12-4.2 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1940465] Re: redshift/1.12-4.2 FTBFS in Impish
Thanks for the follow up, Lucas. This looks good! The "--without- systemduserunitdir" line is indented with spaces instead of TABs, but we already discussed it and I know you will fix the problem, so: LGTM, +1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940465 Title: redshift/1.12-4.2 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1940465] Re: redshift/1.12-4.2 FTBFS in Impish
Thanks for the investigation Sergio! I agree with your solution, I did not check the upstream Makefile :) I attached a new debdiff with your solution. ** Attachment added: "debdiff2" https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+attachment/5519111/+files/debdiff2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940465 Title: redshift/1.12-4.2 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1940465] Re: redshift/1.12-4.2 FTBFS in Impish
Thanks for the investigation and the patch, Lucas. Ugh, this one is kind of messy :-/. I'm not a fan of using d/not- installed; I think it tends to hide problems that can prove to be important. I spent some time trying to figure out why this change works on Debian but not on Ubuntu. When I compared Debian's build logs against Ubuntu's, I noticed this difference: Debian: checking Directory to install systemd user unit files... Package systemd was not found in the pkg-config search path. Ubuntu: checking Directory to install systemd user unit files... /usr/lib/systemd/user Upon investigating a bit more, I noticed that Debian's systemd doesn't seem to ship with a pkg-config, whereas it does in Ubuntu. So, I looked into redshift's configure.ac and found this: # Check for systemd PKG_PROG_PKG_CONFIG AC_MSG_CHECKING([Directory to install systemd user unit files]) AC_ARG_WITH([systemduserunitdir], [AS_HELP_STRING([--with-systemduserunitdir=], [Directory for systemd user unit files])], [], [with_systemduserunitdir=$($PKG_CONFIG --variable=systemduserunitdir systemd)]) AS_IF([test -n "$with_systemduserunitdir" -a "x$with_systemduserunitdir" != xno], [ AC_SUBST([systemduserunitdir], [$with_systemduserunitdir]) AC_MSG_RESULT([$systemduserunitdir]) enable_systemd=yes ], [ AC_MSG_RESULT([not enabled]) enable_systemd=no ]) AM_CONDITIONAL([ENABLE_SYSTEMD], [test "x$enable_systemd" != xno]) You can see that there is an "else" branch (on AC_ARG_WITH) which accounts for disabling systemd support. That's good. I was also able to verify that Makefile.am takes ENABLE_SYSTEMD into account. Having said all that, I think a better approach to this bug would be: --- debian/rules.old2021-08-18 16:43:05.739938897 -0400 +++ debian/rules2021-08-18 16:41:49.973477436 -0400 @@ -12,6 +12,9 @@ override_dh_auto_configure: intltoolize --force dh_auto_configure -- \ +# Disable the creation/installation of systemd service files. +# See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892275 + --without-systemduserunitdir \ --enable-randr --enable-vidmode \ --enable-geoclue2 --disable-geoclue \ --enable-ubuntu --enable-apparmor WDYT? ** Bug watch added: Debian Bug tracker #892275 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892275 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940465 Title: redshift/1.12-4.2 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1940465] Re: redshift/1.12-4.2 FTBFS in Impish
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940465 Title: redshift/1.12-4.2 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1940465] Re: redshift/1.12-4.2 FTBFS in Impish
This is not an issue in Debian (the package built fine in all architectures). Also, the DDs preparing the last two NMUs did not commit the changes into the git repository, so I did not forward those changes. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940465 Title: redshift/1.12-4.2 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1940465] Re: redshift/1.12-4.2 FTBFS in Impish
I implemented the proposed solution and it indeed fixes the FTBFS. The debdiff is attached and here is a PPA where it built in all supported architectures: https://launchpad.net/~lucaskanashiro/+archive/ubuntu/testing ** Attachment added: "debdiff" https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+attachment/5518825/+files/debdiff ** Description changed: redshift/1.12-4.2 failed to build because the systemd unit files were dropped in the last Debian upload but they are still inside debian/tmp build directory. See the logs below: https://launchpadlibrarian.net/554163390/buildlog_ubuntu-impish- amd64.redshift_1.12-4.2_BUILDING.txt.gz - I simple fix would be to list those files in debian/not-installed to + A simple fix would be to list those files in debian/not-installed to avoid dh_missing complaining about that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940465 Title: redshift/1.12-4.2 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/redshift/+bug/1940465/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
