[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
** Changed in: glibc (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
** Merge proposal unlinked: https://code.launchpad.net/~chacman/ubuntu/+source/systemd/+git/systemd/+merge/410695 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
** Merge proposal linked: https://code.launchpad.net/~chacman/ubuntu/+source/systemd/+git/systemd/+merge/410695 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
This bug was fixed in the package systemd - 248.3-1ubuntu7 --- systemd (248.3-1ubuntu7) impish; urgency=medium * d/tests/tests-in-lxd: suppress the cgroups v2 warning on stderr from lxd/lxc even more comprehensively until the snapd change required to do it nicely gets into a release. -- Michael Hudson-Doyle Wed, 01 Sep 2021 19:21:58 +1200 ** Changed in: systemd (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
Merged upstream and staged in: https://git.launchpad.net/~ubuntu-core- dev/ubuntu/+source/systemd/log/?h=ubuntu-impish ** Changed in: systemd (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
We do now have an upstream patch/PR: https://github.com/systemd/systemd/pull/20705 It's not much different from what was already landed in the systemd package (skipping the test in this scenario). So we should probably only stage it for the next systemd upload, after it was merged upstream. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
** Also affects: glibc via https://github.com/systemd/systemd/issues/20593 Importance: Unknown Status: Unknown ** Project changed: glibc => systemd -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
Unfortunately, it doesn't seem to be the same bug, but might be similar.
I can still reporduce the issue with the upstream daily-build.
I can reproduce it on an Ubuntu Impish host (kernel 5.11.0-31-generic, systemd
248.3-1ubuntu3), running an Ubuntu Impish container (kernel 5.11.0-31-generic,
systemd 249.743.g8fd4d27f3c+21.10.20210909132725 – daily upstream build from
[ppa:ubuntu-support-team/systemd](https://launchpad.net/~ubuntu-support-team/+archive/ubuntu/systemd))
– or basically any container that uses the unified cgroups hierarchy (like
Fedora 34, as mentioned before).
Interestingly, in other places that try to read `memory.current`
(cgtop.c/cgroup.c) there is a fallback to `memory.usage_in_bytes` if the
system does not detect an all unified hierarchy. But those seem to be
mutually exclusive:
On a host using the **hybrid** hierarchy I can only see `memory.usage_in_bytes`
(same goes for hybrid container on hybrid host):
```
$ find /sys/fs/cgroup/ -wholename *system.slice/memory.current
$ find /sys/fs/cgroup/ -wholename *system.slice/memory.usage_in_bytes
/sys/fs/cgroup/memory/system.slice/memory.usage_in_bytes
```
=> Tests are skipped ("test-oomd-util: cgroups are not running in unified mode,
skipping tests.")
On a host using the **unified** hierarchy I can only see `memory.current` (same
goes for unified container on unified host and hybrid container on unified
host):
```
$ find /sys/fs/cgroup/ -wholename *system.slice/memory.current
/sys/fs/cgroup/system.slice/memory.current
$ find /sys/fs/cgroup/ -wholename *system.slice/memory.usage_in_bytes
```
=> Tests pass as expected.
BUT: Inside a **unified** container on a **hybrid** host, I can see neither:
```
$ find /sys/fs/cgroup/ -wholename *system.slice/memory.current
$ find /sys/fs/cgroup/ -wholename *system.slice/memory.usage_in_bytes
```
=> This is a problem. The test fails, because it cannot access `memory.current`
but is not skiped either.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942113
Title:
systemd unit test regression in autopkgtest (oomd-utils)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1942113/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
Sigh yes it does look like you found amd fixed the same bug. Oh well at least I learnt some things yesterday. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
Just a suggestion, before opening an upstream bug, y'all might want to test with the latest upstream code, as I think this is fixed already? You can use this ppa to test with the latest upstream (daily) code if it makes things easier for you: https://launchpad.net/~ubuntu-support-team/+archive/ubuntu/systemd If I've misunderstood the bug and this isn't fixed upstream yet, I apologize and please ignore the noise :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
So it turns out that if you have security.nesting=true set on the container, then the systemd in proposed manages to set up a unified hierarchy and the test fails. This is the difference between the production test runs and mine. I filed a bug upstream https://github.com/systemd/systemd/issues/20593 I'm not sure I want to argue for a hint for this, because the systemd tests are failing for other reasons when triggered by other packages. It's probably better to upload a systemd that skips the failing test case. ** Bug watch added: github.com/systemd/systemd/issues #20593 https://github.com/systemd/systemd/issues/20593 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
Hmm something is off here: I'm pretty sure containers inherit their cgroups mode from the host, so the default hierarchy changing in the systemd in the archive shouldn't affect anything. I can reproduce the failure of this report by adding systemd.unified_cgroup_hierarchy=1 to the kernel command line of the container host, but then the test also fails with the systemd from the release pocket (and surely we aren't running our armhf autopkgtest container hosts with unified cgroups?). So I'm still pretty confused but think I support hinting past this failure... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
So yes, that is what matters. When a system is booted with systemd 248.3-1ubuntu3, it sets up the cgroups in "hybrid" mode. systemd 248.3-1ubuntu5 defaults to "unified" mode but simply upgrading the package does not redo this setup -- the system remains in hybrid mode. The test cases that are failing on the autopkgtest runners only run if the system is is in unified mode, so the only case where they run is if systemd was installed before the reboot. OK, so that's settled and I think we can conclude that this is not a regression. So the next question is why do they fail? Well I assume they are not compatible in some way with the focal GA kernel but I haven't proven this yet... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
The difference I can see between the passing and failing run is that in the failing run, systemd and glibc are upgraded before the "rebooting testbed after setup commands that affected boot" and in the passing run they are upgraded after that step. That doesn't make a lot of sense but maybe the test depends on some boot time actions that the newer libc/systemd are not doing correctly? The fact that this doesn't reproduce outside the autopkgtest infrastructure makes me less worried about the consequences of hinting past this but also having systemd hinted is not a great place to be. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942113] Re: systemd unit test regression in autopkgtest (oomd-utils)
Funny thing, though : https://autopkgtest.ubuntu.com/results/autopkgtest- impish/impish/arm64/s/systemd/20210830_074606_ed6ee@/log.gz -> tests triggered by the systemd upload. The mentioned test passed. Even though the libc version *is the same* (2.34-0ubuntu1 has been pulled to satisfy dependencies). ** Also affects: glibc (Ubuntu) Importance: Undecided Status: New ** Tags added: update-excuse -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942113 Title: systemd unit test regression in autopkgtest (oomd-utils) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1942113/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
