[Bug 1967425] Re: Backport golang 1.16 to Bionic
** Changed in: golang-1.16 (Ubuntu Bionic) Status: New => In Progress ** Changed in: golang-1.16 (Ubuntu Bionic) Assignee: (unassigned) => Lucas Kanashiro (lucaskanashiro) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967425 Title: Backport golang 1.16 to Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-1.16/+bug/1967425/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967425] Re: Backport golang 1.16 to Bionic
Thanks for the review Bryce. I added some more bits to the changelog to make it more clear about the needed changes. I also updated the bug description with your suggestions. The package was already uploaded. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967425 Title: Backport golang 1.16 to Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-1.16/+bug/1967425/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967425] Re: Backport golang 1.16 to Bionic
** Description changed:
[Impact]
To enable packages that are backported wholesale to all releases of
Ubuntu (i.e. runc and docker.io) to stop depending on what is now a
fairly ancient version of Go (some of them require at least Go 1.16), we
are going to upload 1.16 to bionic (this version is in focal already).
This is an unusual "SRU" but the plan has been concocted with the
approval of the Ubuntu security team (who I will ask to comment here to
confirm their acceptance of the plan).
[Test Plan]
A smoke test, like this:
$ apt install golang-1.16-go
$ PATH=/usr/lib/go-1.16/bin:$PATH
$ go version
< check it's 1.16 >
$ cat > trivial.go
package main
func main() {}
$ go run trivial.go
$ cat > trivialcgo.go
package main
import "C"
func main() {}
$ go run trivialcgo.go
- Then we should verify that runc from Jammy builds with the golang-1.16
- in proposed, take the runc package, edit this line in debian/rules:
+ Then we should verify that runc/1.1.0-0ubuntu1~20.04.1 from Focal (in
+ unapproved queue at the moment) builds in Bionic with the golang-1.16 in
+ proposed, take the runc package (https://github.com/tianon/debian-
+ runc/tree/focal), add the following line to debian/rules:
- export PATH:=/usr/lib/go-1.16/bin:${PATH}
+ +export GO111MODULE := off
+ +export GOCACHE := $(CURDIR)/.cache
- to reference go-1.16 instead, edit the build-dependencies, and upload
- that to a PPA that has proposed enabled and check it builds everywhere.
+ Also add a new changelog entry with something like this:
+
+ $ dch -v 1.1.0-0ubuntu1~18.04.1 -D bionic -b "Backport to Bionic."
+
+ and upload that to a PPA that has bionic-proposed enabled and check it
+ builds everywhere.
[Where problems could occur]
It's a new package so should not impact any existing behavior. I'm not
at all proposing to update the default version of Go in a stable
release.
** Description changed:
[Impact]
To enable packages that are backported wholesale to all releases of
Ubuntu (i.e. runc and docker.io) to stop depending on what is now a
fairly ancient version of Go (some of them require at least Go 1.16), we
are going to upload 1.16 to bionic (this version is in focal already).
This is an unusual "SRU" but the plan has been concocted with the
approval of the Ubuntu security team (who I will ask to comment here to
confirm their acceptance of the plan).
[Test Plan]
A smoke test, like this:
$ apt install golang-1.16-go
$ PATH=/usr/lib/go-1.16/bin:$PATH
$ go version
< check it's 1.16 >
$ cat > trivial.go
package main
func main() {}
$ go run trivial.go
$ cat > trivialcgo.go
package main
import "C"
func main() {}
$ go run trivialcgo.go
Then we should verify that runc/1.1.0-0ubuntu1~20.04.1 from Focal (in
unapproved queue at the moment) builds in Bionic with the golang-1.16 in
proposed, take the runc package (https://github.com/tianon/debian-
runc/tree/focal), add the following line to debian/rules:
+export GO111MODULE := off
+export GOCACHE := $(CURDIR)/.cache
Also add a new changelog entry with something like this:
$ dch -v 1.1.0-0ubuntu1~18.04.1 -D bionic -b "Backport to Bionic."
and upload that to a PPA that has bionic-proposed enabled and check it
builds everywhere.
[Where problems could occur]
It's a new package so should not impact any existing behavior. I'm not
at all proposing to update the default version of Go in a stable
- release.
+ release. FWIW golang-1.16 is already co-installable with other golang
+ versions in other releases.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1967425
Title:
Backport golang 1.16 to Bionic
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-1.16/+bug/1967425/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967425] Re: Backport golang 1.16 to Bionic
Hi Lucas, The changelog entry is a bit terse, but comment #1 gives a perfect explanation of the Breaks change and in better detail than could be done in a changelog entry. I wondered if the debhelper-compat -> debhelper change could take more explanation, but it seems obvious enough. Is the reason for making it >= 11 rather than = 11 because we have debhelper 13 in bionic-backports? Anyway, the packaging changes LGTM, +1. For the SRU text, it might be helpful to express the runc rebuild in a cut-and-paste style as you did for the main test case. For the [where problems might occur], you could further point out that golang-1.13 and golang-1.16 are already co-installable without conflict on focal and impish. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967425 Title: Backport golang 1.16 to Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-1.16/+bug/1967425/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967425] Re: Backport golang 1.16 to Bionic
The attached debdiff backport golang-1.16/1.16.2-0ubuntu1~20.04 from Focal to Bionic. ** Attachment added: "debdiff" https://bugs.launchpad.net/ubuntu/+source/golang-1.16/+bug/1967425/+attachment/5575870/+files/debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967425 Title: Backport golang 1.16 to Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-1.16/+bug/1967425/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967425] Re: Backport golang 1.16 to Bionic
golang-1.16-go from Focal has Breaks: dh-golang (<< 1.43~) which is
unsatisfiable in Bionic, where we have dh-golang/1.34.2. This made runc
version 1.1.0-0ubuntu1 FTBFS with golang 1.16.
According to the discussion on the commit message
(https://salsa.debian.org/go-
team/compiler/golang/-/commit/daea28cbf7eb6397e7), version 1.40 of dh-
golang is actually needed. After checking the diff between version
1.34.2 and 1.40, I noticed that the main changes needed are:
* Set GO111MODULE to off
* Set GOCACHE directory
After applying those changes directly to runc, it built with golang 1.16
and dh-golang 1.34.2. This might help others trying to make some package
build with golang 1.16 in bionic once it lands.
So the required changes to backport golang-1.16/1.16.2-0ubuntu1~20.04
from Focal to Bionic are:
* Downgrade debhelper compatibility level to 11. Compat 12 is not available in
Bionic.
* Remove Breaks: dh-golang (<< 1.43~) from d/control{,.in}.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1967425
Title:
Backport golang 1.16 to Bionic
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-1.16/+bug/1967425/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967425] Re: Backport golang 1.16 to Bionic
** Also affects: golang-1.16 (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: golang-1.16 (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967425 Title: Backport golang 1.16 to Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-1.16/+bug/1967425/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
