[Bug 1968607] Re: screen became locked during release upgrade
To workaround (using loginctl) see this post: https://askubuntu.com/a/921726 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
This bug was fixed in the package ubuntu-release-upgrader - 1:20.04.38 --- ubuntu-release-upgrader (1:20.04.38) focal; urgency=medium * do-release-upgrade: Preserve env vars needed for screen lock prevention (LP: #1968607). * Run pre-build.sh: updating translations. * Manually run utils/update_mirrors.py to update mirrors. -- Nick Rosbrook Thu, 14 Apr 2022 13:21:35 -0400 ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
This bug was fixed in the package ubuntu-release-upgrader - 1:21.10.9 --- ubuntu-release-upgrader (1:21.10.9) impish; urgency=medium * do-release-upgrade: Preserve env vars needed for screen lock prevention (LP: #1968607). * Run pre-build.sh: updating mirrors, demotions, and translations. -- Nick Rosbrook Thu, 14 Apr 2022 12:56:05 -0400 ** Changed in: ubuntu-release-upgrader (Ubuntu Impish) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
I tested ubuntu-release-upgrader 1:20.04.38 from focal-proposed using the test plan above, and verified the fix works as expected. ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal ** Description changed: [Impact] This bug prevents the screen lock inhibitor logic when the Gtk3 or KDE frontends are used for release upgrades. This leaves users at risk of encountering an issue where the lock screen cannot be unlocked, if it was locked during upgrade. This is needed in the stable releases because it affects upgrades to jammy. [Test Plan] - To reproduce on impish, do the following: + To reproduce on impish or focal, do the following: * For ease of testing, set your screen lock timeout to 1 minute. * Start an upgrade to jammy using the Gtk3 frontend: - $ do-release-upgrade -d -f DistUpgradeViewGtk3 + $ do-release-upgrade -d -f DistUpgradeViewGtk3 * Click the 'Upgrade' button when the release notes are displayed. When - prompted, click 'Start Upgrade'. Observe that there is no information message - indicating the screen lock has been disabled (nor is there a message - indicating that we failed to disable the screen lock). + prompted, click 'Start Upgrade'. Observe that there is no information message + indicating the screen lock has been disabled (nor is there a message + indicating that we failed to disable the screen lock). * Idle long enough to allow the screen lock to kick in. Note: dbus-monitor "interface=org.freedesktop.ScreenSaver" can also be used to monitor any attempts to disable the screen lock. [Where problems could occur] This patch introduces new environment variables to the upgrade that were not previously set when the KDE or Gtk3 frontends were used. Regressions could occur if any existing code (besides the screen lock inhibitor code) had different behavior based on these variables. [Original Description] I was upgrading from Ubuntu 21.10 to Ubuntu 22.04 this morning when my lock screen became enabled. My screen is set to blank after 5 minutes. Looking at the main release upgrade log file I noticed the following: 2022-04-11 06:55:10,389 INFO release-upgrader version '22.04.7' started ... 2022-04-11 06:58:10,297 DEBUG inhibit screensaver Then in /var/log/auth.log I found: Apr 11 07:06:24 godspeed gdm-password]: gkr-pam: unlocked login keyring I don't recall when I last responded to a dialog from ubuntu-release- upgrader but I would guess it was around here: 2022-04-11 06:56:18,259 DEBUG About to apply the following changes So that would only be a couple of minutes of inactivity before the screensaver was inhibited, so I don't think it worked. Additionally, I never saw a message about the screen lock being disabled. ProblemType: Bug DistroRelease: Ubuntu 22.04 Package: ubuntu-release-upgrader-core 1:22.04.8 ProcVersionSignature: Ubuntu 5.15.0-25.25-generic 5.15.30 Uname: Linux 5.15.0-25-generic x86_64 ApportVersion: 2.20.11-0ubuntu80 Architecture: amd64 CasperMD5CheckResult: pass CrashDB: ubuntu CurrentDesktop: ubuntu:GNOME Date: Mon Apr 11 11:07:56 2022 InstallationDate: Installed on 2022-01-07 (94 days ago) InstallationMedia: Ubuntu 21.10 "Impish Indri" - Release amd64 (20211012) PackageArchitecture: all SourcePackage: ubuntu-release-upgrader Symptom: ubuntu-release-upgrader UpgradeStatus: Upgraded to jammy on 2022-04-11 (0 days ago) VarLogDistupgradeTermlog: -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
Hello Brian, or anyone else affected, Accepted ubuntu-release-upgrader into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:20.04.38 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Status: Triaged => Fix Committed ** Tags added: verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
I tested ubuntu-release-upgrader 1:21.10.9 from impish-proposed using the test plan above, and verified the fix works as expected. ** Tags removed: verification-needed-impish ** Tags added: verification-done-impish -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
Hello Brian, or anyone else affected, Accepted ubuntu-release-upgrader into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:21.10.9 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-impish. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: ubuntu-release-upgrader (Ubuntu Impish) Status: Triaged => Fix Committed ** Tags added: verification-needed verification-needed-impish -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
** Merge proposal linked: https://code.launchpad.net/~enr0n/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/419493 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
** Merge proposal linked: https://code.launchpad.net/~enr0n/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/419492 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
** Description changed: + [Impact] + + This bug prevents the screen lock inhibitor logic when the Gtk3 or KDE + frontends are used for release upgrades. This leaves users at risk of + encountering an issue where the lock screen cannot be unlocked, if it was + locked during upgrade. + + This is needed in the stable releases because it affects upgrades to + jammy. + + [Test Plan] + + To reproduce on impish, do the following: + + * For ease of testing, set your screen lock timeout to 1 minute. + * Start an upgrade to jammy using the Gtk3 frontend: + + $ do-release-upgrade -d -f DistUpgradeViewGtk3 + + * Click the 'Upgrade' button when the release notes are displayed. When + prompted, click 'Start Upgrade'. Observe that there is no information message + indicating the screen lock has been disabled (nor is there a message + indicating that we failed to disable the screen lock). + * Idle long enough to allow the screen lock to kick in. + + Note: dbus-monitor "interface=org.freedesktop.ScreenSaver" can also be used to + monitor any attempts to disable the screen lock. + + [Where problems could occur] + + This patch introduces new environment variables to the upgrade that were not + previously set when the KDE or Gtk3 frontends were used. Regressions could + occur if any existing code (besides the screen lock inhibitor code) had + different behavior based on these variables. + + [Original Description] + I was upgrading from Ubuntu 21.10 to Ubuntu 22.04 this morning when my lock screen became enabled. My screen is set to blank after 5 minutes. Looking at the main release upgrade log file I noticed the following: 2022-04-11 06:55:10,389 INFO release-upgrader version '22.04.7' started ... 2022-04-11 06:58:10,297 DEBUG inhibit screensaver Then in /var/log/auth.log I found: Apr 11 07:06:24 godspeed gdm-password]: gkr-pam: unlocked login keyring I don't recall when I last responded to a dialog from ubuntu-release- upgrader but I would guess it was around here: 2022-04-11 06:56:18,259 DEBUG About to apply the following changes So that would only be a couple of minutes of inactivity before the screensaver was inhibited, so I don't think it worked. Additionally, I never saw a message about the screen lock being disabled. ProblemType: Bug DistroRelease: Ubuntu 22.04 Package: ubuntu-release-upgrader-core 1:22.04.8 ProcVersionSignature: Ubuntu 5.15.0-25.25-generic 5.15.30 Uname: Linux 5.15.0-25-generic x86_64 ApportVersion: 2.20.11-0ubuntu80 Architecture: amd64 CasperMD5CheckResult: pass CrashDB: ubuntu CurrentDesktop: ubuntu:GNOME Date: Mon Apr 11 11:07:56 2022 InstallationDate: Installed on 2022-01-07 (94 days ago) InstallationMedia: Ubuntu 21.10 "Impish Indri" - Release amd64 (20211012) PackageArchitecture: all SourcePackage: ubuntu-release-upgrader Symptom: ubuntu-release-upgrader UpgradeStatus: Upgraded to jammy on 2022-04-11 (0 days ago) VarLogDistupgradeTermlog: -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
This bug was fixed in the package ubuntu-release-upgrader - 1:22.04.9 --- ubuntu-release-upgrader (1:22.04.9) jammy; urgency=medium [ Nick Rosbrook ] * do-release-upgrade: Preserve env vars needed for screen lock prevention (LP: #1968607). * DistUpgrade/DistUpgradeController.py: Do not make UI dialog calls while EUID != 0. [ Brian Murray ] * Run pre-build.sh: updating mirrors, demotions, and translations. -- Brian Murray Wed, 13 Apr 2022 14:30:37 -0700 ** Changed in: ubuntu-release-upgrader (Ubuntu Jammy) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
** Merge proposal linked: https://code.launchpad.net/~enr0n/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/419415 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
** Merge proposal linked: https://code.launchpad.net/~enr0n/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/419332 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
Per a conversation with Nick this will need to be fixed in `do-release- upgrade` which is shipped with the version of ubuntu-release-upgrader for the release from which you are upgrading and not in the dist- upgrader tarball. Subsequently, I'm opening tasks for Impish and Jammy as well. ** Changed in: ubuntu-release-upgrader (Ubuntu) Status: New => Triaged ** Changed in: ubuntu-release-upgrader (Ubuntu) Importance: Undecided => Critical ** Also affects: ubuntu-release-upgrader (Ubuntu Impish) Importance: Undecided Status: New ** Also affects: ubuntu-release-upgrader (Ubuntu Jammy) Importance: Critical Status: Triaged ** Also affects: ubuntu-release-upgrader (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: ubuntu-release-upgrader (Ubuntu Impish) Status: New => Triaged ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Status: New => Triaged ** Tags added: fr-2244 ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Importance: Undecided => Critical ** Changed in: ubuntu-release-upgrader (Ubuntu Impish) Importance: Undecided => Critical ** Changed in: ubuntu-release-upgrader (Ubuntu Jammy) Milestone: None => ubuntu-22.04 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968607] Re: screen became locked during release upgrade
I have tested this with both the DistUpgradeViewGtk3 and DistUpgradeViewText frontends. Using Gtk3, the screen lock prevention code fails, and no failure is reported in the logs. Using the text frontend, the screen lock prevention code works as expected. I believe the issue is that for the Gtk3 and KDE frontends, the dist- upgrade script is not invoked in a way that preserves the user's environment variables [1], namely `DBUS_SESSION_BUS_ADDRESS` etc. So, the DBus call fails and the failure is not reported because `XDG_SESSION_TYPE` is not set either [2]. [1] https://git.launchpad.net/ubuntu-release-upgrader/tree/do-release-upgrade#n221 [2] https://git.launchpad.net/ubuntu-release-upgrader/tree/DistUpgrade/DistUpgradeController.py#n2079 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968607 Title: screen became locked during release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1968607/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
