[Bug 1968636] Re: cryptroot-unlock doesn't work at all when terminal width is below 51
This bug was fixed in the package cryptsetup - 2:2.7.0-1ubuntu6 --- cryptsetup (2:2.7.0-1ubuntu6) oracular; urgency=medium [ Adam Vodopjan ] * Fix cryptroot-unlock behavior on narrow terminals (LP: #1968636) -- Dan Bungert Tue, 11 Jun 2024 13:19:25 -0600 ** Changed in: cryptsetup (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968636 Title: cryptroot-unlock doesn't work at all when terminal width is below 51 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1968636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968636] Re: cryptroot-unlock doesn't work at all when terminal width is below 51
Hi Adam, Thanks for the patch. I appreciate your detailed analysis of the problem and sharing the path you took to arrive at the solution. I also appreciate that while solving this problem you're fixing other bugs and making the ubuntu delta to the debian version of the package smaller. I will be uploading this to Ubuntu Oracular shortly. If you'd like to see this in a LTS, the next step would be to https://wiki.ubuntu.com/StableReleaseUpdates ** Changed in: cryptsetup (Ubuntu) Status: Confirmed => Fix Committed ** Changed in: cryptsetup (Ubuntu) Assignee: Dan Bungert (dbungert) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968636 Title: cryptroot-unlock doesn't work at all when terminal width is below 51 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1968636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968636] Re: cryptroot-unlock doesn't work at all when terminal width is below 51
** Changed in: cryptsetup (Ubuntu) Assignee: (unassigned) => Dan Bungert (dbungert) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968636 Title: cryptroot-unlock doesn't work at all when terminal width is below 51 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1968636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968636] Re: cryptroot-unlock doesn't work at all when terminal width is below 51
** Merge proposal linked: https://code.launchpad.net/~grozzly/ubuntu/+source/cryptsetup/+git/cryptsetup/+merge/466145 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968636 Title: cryptroot-unlock doesn't work at all when terminal width is below 51 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1968636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968636] Re: cryptroot-unlock doesn't work at all when terminal width is below 51
After looking deeper into the repo history, I see the questionable implementation of pgrep_exe() was introduced by this patch https://bugs.launchpad.net/ubuntu/+source/busybox/+bug/1651818/comments/11 in attempt to adopt the debian code to the ubuntu environment. Aside for other things, it ignores the fact the first line in "ps" output is the header. It was enough to replace .. ps -eo pid= | while read pid; do with .. ps | sed 1d | while read pid _; do and pgrep_exe() would just work. This way terminal width does not affect the ps output in any way. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968636 Title: cryptroot-unlock doesn't work at all when terminal width is below 51 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1968636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1968636] Re: cryptroot-unlock doesn't work at all when terminal width is below 51
Commenting on #2: When building busybox, there is a number of config switches. For your binary to support "ps -w" you need this in the config: - CONFIG_DESKTOP is not set - CONFIG_FEATURE_PS_WIDE=y On my 22.04 systems I've got 2 busybox binaries: /usr/bin/busybox (2.1M) from busybox-static package and /usr/lib/initramfs-tools/bin/busybox (311K) from busybox-initramfs package. The former was built using debian/config/pkg/static from the source package (CONFIG_DESKTOP=y), it does not support "ps -w". The latter was built with debian/config/pkg/initramfs from the source package (no CONFIG_DESKTOP, CONFIG_FEATURE_PS_WIDE=y), it supports "ps -w" and, evidently, it is the one that gets packaged into initramfs. If your non-desktop busybox was built without CONFIG_FEATURE_PS_WIDE=y, there should be no problem described in this bug report. In the case, terminal width would be assumed 79 [1] To make it work no matter if "ps -w" is supported or not, there are two options, both based on [2] 1. "ps https://git.launchpad.net/ubuntu/+source/busybox/tree/procps/ps.c?h=applied/ubuntu/jammy#n650 [2] https://git.launchpad.net/ubuntu/+source/busybox/tree/libbb/xfuncs.c?h=applied/ubuntu/jammy#n292 [3] https://git.launchpad.net/ubuntu/+source/busybox/tree/libbb/xfuncs.c?h=applied/ubuntu/jammy#n235 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1968636 Title: cryptroot-unlock doesn't work at all when terminal width is below 51 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1968636/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
