[Bug 2058401] Re: Enable automated tests
This bug was fixed in the package freerdp3 - 3.5.1+dfsg1-5 --- freerdp3 (3.5.1+dfsg1-5) unstable; urgency=medium * Add patch to skip a test that fails on 32-bit arm (Closes: #1071949) -- Jeremy Bícha Tue, 28 May 2024 12:40:03 -0400 ** Changed in: freerdp3 (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
I worked around the exported symbols issue by doing the build twice. ** Changed in: freerdp3 (Ubuntu) Status: In Progress => Fix Committed ** Changed in: freerdp3 (Ubuntu) Assignee: Nathan Teodosio (nteodosio) => (unassigned) ** Also affects: freerdp3 (Ubuntu Noble) Importance: Undecided Status: New ** Changed in: freerdp3 (Ubuntu Noble) Status: New => Triaged ** Changed in: freerdp3 (Ubuntu Noble) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
I am handling this via Debian and the changes will be synced to Oracular soon. Therefore, I am unsubscribing ubuntu-sponsors. Feel free to resubscribe if you have something else that needs to be sponsored. I pushed the autopkgtests there but I needed to add a commit to fix some issues seen there: https://salsa.debian.org/debian-remote-team/freerdp3/-/commit/f814cdf193 I opened a merge request to get some more feedback from an upstream developer about why enabling build tests lead to a major increase in exported symbols: https://salsa.debian.org/debian-remote-team/freerdp3/-/merge_requests/4 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
The test also ran fine in the "real thing": https://autopkgtest.ubuntu.com/results/autopkgtest-noble-nteodosio- rebuilds/noble/amd64/f/freerdp3/20240411_104943_f59b7@/log.gz. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
I tried this with 'autopkgtest -B . -- schroot noble-amd64' and the autopkgtest succeeded. ** Patch added: "freerdp.v2.diff" https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+attachment/5763646/+files/freerdp.v2.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
Thanks for the review. I'm then unsubscribing ubuntu-sponsors and will subscribe again when I have a new patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
+1 for enabling build-time testing, but that does not make an autopkgtest. Autopkgtests should test the package as installed in an Ubuntu system; rebuilding the package (you have Restrictions: build-needed) and re- running the upstream test suite in the build tree adds nothing to the tests run at build time. Moreover you have extra build-deps installed this way, which make the autopkgtest result even less reliable. It is fine to run the upstream test suite as an autopkgtest, but only if you can can make it use the software installed from the .deb package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
OK, we don't care about Armhf on Noble so I'm subscribing ubuntu- sponsors again. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
Nathan, I am removing ubuntu-sponsors from this bug as per your request to hold off. Please, subscribe it back to this bug once you believe it is ready. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
The attachment "freerdp3.diff" seems to be a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
Actually please hold that for a moment, I had forgotten to enable other architectures in the PPA and a test is failing in Armhf. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
The following debdiff enables the build tests and runs them as autopkgtests, which as per [1] run successfully. [1] https://autopkgtest.ubuntu.com/results/autopkgtest-noble-nteodosio- rebuilds/noble/amd64/f/freerdp3/20240326_213622_91f66@/log.gz ** Patch added: "freerdp3.diff" https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+attachment/5759843/+files/freerdp3.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058401] Re: Enable automated tests
** Changed in: freerdp3 (Ubuntu) Assignee: (unassigned) => Nathan Teodosio (nteodosio) ** Changed in: freerdp3 (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058401 Title: Enable automated tests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp3/+bug/2058401/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
