[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
** Description changed: [Impact] If you have Source Code enabled, and you change the pockets configuration to "all pockets", it will add -backports without source code. The Source Code flag will still be set in the UI, but after a reload, you can see it is in a mixed state. This is more notable now, because this splits up the deb822 paragraph into two: One for the deb, and one for deb-src, whereas it should remain one. [Test plan] 1. Turn on source code, save and refresh sources, close app - 2. Turn "recommended updates" to "all updates", observe that -backports got added with deb-src, to the existing paragraph. + 2. Start again, observe the flag is on. + 3. Turn "recommended updates" to "all updates", observe that -backports got added with deb-src, to the existing paragraph. + 4. Restart the app and observe that the flag is still on. [Where problems could occur] This incurs a performance regression, as we need to check the state of the source code flag after reloading sources. That said, this is of course necessary for the source code flag to be correct after reloading modified sources (it gets reset to False when reloading). And since we run in a dbus service, we may just be reloading without having made the changes ourselves, so we can't just cache the old value and restore it. That said, software-properties already times out on my oracular system. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
The software-properties-qt regressions are still the bugs in autopkgtest by having a separate software-properties-qt package in the release pocket, which wrongly gets triggered and then fails to download, this package will be superseded again by this -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
Accepting, but my request to amend the Test Plan from comment 2 still stands, and needs adjusting (and SRU verification accordingly) prior to SRU release. ** Changed in: software-properties (Ubuntu Noble) Status: Incomplete => Fix Committed ** Tags added: verification-needed verification-needed-noble -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
This is missing the previous changelog entry, but also should just be squashed together. I pinged juliank and jamespage in #ubuntu-devel. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
@racb It's fine to replace the other software-properties upload, there's no value in releasing it on its own since it just merges software- properties-qt back into the main package from the temporary once-off we did to unblock the image building. No point pushing updated software-properties-* to everyone that contain exactly the same code they already have installed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
FTR, I reviewed tree 826c52fe8492f91fa5766921cf6b1e88fc94d4d6 so if nothing relevant is changed I can accept a tree identical to that when unblocked. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
> ...you can see it is in a mixed state For the Test Plan, given that the justification for the SRU is the behaviour of the Source Code flag in the UI, this must be tested. Otherwise it'd be sufficient for some mistake to result in the SRU being "verified" when the actual problem we're trying to fix isn't confirmed fixed. Please add to the Test Plan to ensure that the flag in the UI reports correctly after a reload. Unless I've misunderstood? > * Reload the source code state when reloading sources.list (LP: #2069433) I won't block on this but for next time I suggest writing changelogs in SRUs from the perspective of the user. The SRU justification is that the UI is being fixed and/or we want to avoid splitting the deb822 paragraph into two, but neither of these can be inferred from this message. It would be nice to provide the user with this information so that they can decide if/when they want to receive the update (for users who care by using apt-listchanges, etc). How you fixed it is IMHO secondary (but can still be mentioned if you wish). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
Ah accepting this is blocked on a previous SRU in bug 2061214. Even if the autopkgtests failures are OK to ignore there, it looks like it's not been verified so I cannot release it regardless. ** Also affects: software-properties (Ubuntu Noble) Importance: Undecided Status: New ** Changed in: software-properties (Ubuntu Noble) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled
This bug was fixed in the package software-properties - 0.99.50 --- software-properties (0.99.50) oracular; urgency=medium * Reload the source code state when reloading sources.list (LP: #2069433) -- Julian Andres Klode Fri, 14 Jun 2024 17:02:16 +0200 ** Changed in: software-properties (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069433 Title: Enabling new pockets does not enable deb-src for them, even if source code is enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
