[Bug 2070081] Re: paraview 5.12.1+dfsg-3 FTBFS on Oracular
Something else I forgot to ask/mention: does the package also FTBFS on Debian? If yes, then it's worth considering forwarding the delta to them as well. Also, I might be wrong here but I believe you don't have to manually set the compiler flags like that anymore. This used to be the case a long time ago when debhelper's cmake module couldn't handle the flags very well, but nowadays things should just work. Might be worth giving it a try. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2070081 Title: paraview 5.12.1+dfsg-3 FTBFS on Oracular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/paraview/+bug/2070081/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2070081] Re: paraview 5.12.1+dfsg-3 FTBFS on Oracular
Thanks for the patch, Zixing Liu. I'd like to ask you adjust a few things before we proceed with the upload: 1) Since you're adding a delta, you also need to run update-maintainer in order to have the Maintainer field set to Ubuntu Developers instead of the regular Debian maintainer. 2) You're also reorganizing the definitions of the compiler flags. Could you please mention this in the changelog entry? 3) While the CMAKE_BUILD_TYPE change looks sensible to me, it would be great if you could provide a PPA where the modified package builds properly. I will remove ubuntu-sponsors from the notification list for now. Please re-add it when the package is ready to be reviewed again. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2070081 Title: paraview 5.12.1+dfsg-3 FTBFS on Oracular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/paraview/+bug/2070081/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2070081] Re: paraview 5.12.1+dfsg-3 FTBFS on Oracular
The attachment "paraview-5.12.1+dfsg-3ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2070081 Title: paraview 5.12.1+dfsg-3 FTBFS on Oracular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/paraview/+bug/2070081/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2070081] Re: paraview 5.12.1+dfsg-3 FTBFS on Oracular
** Patch added: "paraview-5.12.1+dfsg-3ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/paraview/+bug/2070081/+attachment/5791265/+files/paraview-5.12.1+dfsg-3ubuntu1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2070081 Title: paraview 5.12.1+dfsg-3 FTBFS on Oracular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/paraview/+bug/2070081/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
