[Bug 234566] Re: [Hardy] Segfault of Terminator when no $DISPLAY is set
** Changed in: terminator (Ubuntu) Status: Fix Committed = Fix Released -- [Hardy] Segfault of Terminator when no $DISPLAY is set https://bugs.launchpad.net/bugs/234566 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234566] Re: [Hardy] Segfault of Terminator when no $DISPLAY is set
thanks sh, I have pushed a fix to this in trunk rev 292 you might want to confirm the fix by pulling trunk @@ -1460,7 +1458,12 @@ command.append (options.command) if (options.execute): command = options.execute - + + if gtk.gdk.display_get_default() == None: +print sys.stderr, _(You need to run terminator in an X environment. \ +Make sure DISPLAY is properly set) +sys.exit(1) + term = Terminator (options.profile, command, options.fullscreen, options.maximise, options.borderless) gtk.main () ** Changed in: terminator (Ubuntu) Assignee: (unassigned) = chantra (chantra) Status: New = Fix Committed -- [Hardy] Segfault of Terminator when no $DISPLAY is set https://bugs.launchpad.net/bugs/234566 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234566] Re: [Hardy] Segfault of Terminator when no $DISPLAY is set
Thx, I wonder if it's not better, to do this in the very beginning of terminator startup, so there is no need to do all checks and go further..until we see that it's no X environment ;) I proposed r291 (from my dev branch) to terminator trunk...it's a simple os.environ check if $DISPLAY is set... NEvertheless...I'll check trunk now :) Good work btw.. Regards, \sh -- [Hardy] Segfault of Terminator when no $DISPLAY is set https://bugs.launchpad.net/bugs/234566 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234566] Re: [Hardy] Segfault of Terminator when no $DISPLAY is set
yep, but I believe the help should be accessible through ssh too :) And I don't believe DISPLAY is platform independant thus checking if gdk return None is more portable -- [Hardy] Segfault of Terminator when no $DISPLAY is set https://bugs.launchpad.net/bugs/234566 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234566] Re: [Hardy] Segfault of Terminator when no $DISPLAY is set
Hey, well, MAC os has it ;) But windows won't... So, ok..agreed...the gdk check is more sane ;) \sh -- [Hardy] Segfault of Terminator when no $DISPLAY is set https://bugs.launchpad.net/bugs/234566 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
