[Bug 243156] Re: bibtex autokey no longer ignores uncapitalized title words
** Changed in: emacs-snapshot (Ubuntu) Status: New = Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/243156 Title: bibtex autokey no longer ignores uncapitalized title words To manage notifications about this bug go to: https://bugs.launchpad.net/emacs/+bug/243156/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 243156] Re: bibtex autokey no longer ignores uncapitalized title words
I forwarded this bug to the Emacs maintainers. I'm also attaching an updated patch for emacs-snapshot 1:20090207 ** Bug watch added: emacsbugs.donarmstrong.com/ #2385 http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2385 ** Also affects: emacs via http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2385 Importance: Unknown Status: Unknown ** Attachment added: Updated patch for 23.0.90.1 http://launchpadlibrarian.net/22880851/bibtex-snapshot-el.patch -- bibtex autokey no longer ignores uncapitalized title words https://bugs.launchpad.net/bugs/243156 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 243156] Re: bibtex autokey no longer ignores uncapitalized title words
Upstream accepted and committed the patch. I'm not sure if the Launchpad tracker for Emacs upstream bugs works yet, so noting it here. -- bibtex autokey no longer ignores uncapitalized title words https://bugs.launchpad.net/bugs/243156 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 243156] Re: bibtex autokey no longer ignores uncapitalized title words
Reproed and fix confirmed on emacs-snapshot 1:20081013-1. The patch needed some minor editing before it would apply (a comment in the second hunk just before the actual diff had been reformatted with `quotes'). ** Also affects: emacs-snapshot (Ubuntu) Importance: Undecided Status: New -- bibtex autokey no longer ignores uncapitalized title words https://bugs.launchpad.net/bugs/243156 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 243156] Re: bibtex autokey no longer ignores uncapitalized title words
The patch needed some minor editing before it would apply (a comment in the second hunk just before the actual diff had been reformatted with `quotes'). Third hunk, actually. ;; Ignore words matched by one of the elements of - ;; bibtex-autokey-titleword-ignore + ;; `bibtex-autokey-titleword-ignore' -- bibtex autokey no longer ignores uncapitalized title words https://bugs.launchpad.net/bugs/243156 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 243156] Re: bibtex autokey no longer ignores uncapitalized title words
It seems that the function bibtex-autokey-get-title sets (case-fold- search t) right at the beginning, so its attempts at finding lowercase words is doomed to fail. Arguably [[:upper:]] and [[:lower:]] should actually work regardless of the value of the variable case-fold-search, so perhaps that should be fixed rather than this individual symptom. Incidentally, the code to loop over each individual element of the list in turn seems rather inefficient; wouldn't it be better to concatenate all elements of the list to a single big \\|-separated regex, and perform a single string-match? ** Changed in: emacs22 (Ubuntu) Status: New = Confirmed -- bibtex autokey no longer ignores uncapitalized title words https://bugs.launchpad.net/bugs/243156 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 243156] Re: bibtex autokey no longer ignores uncapitalized title words
In the meantime, here is a simple patch which appears to fix the problem for me, on Emacs 22.2. I would appreciate it if somebody with a recent emacs-snapshot could take the time to verify that this problem still exists there (looking at CVS sources on Savannah, it ought to) and that this patch fixes it. If so, I can take care of bringing this to the attention of the Emacs maintainers. The change to do a single regex match is not strictly necessary, but should hopefully improve scalability for long lists of ignore words, and might improve performance if the regex engine manages to do a good job with optimizing the generated expression. The local case-fold-search nil and the reintroduction of [:lower:] in the final regex are the real meat of this patch. Repro steps in some more detail: 1. Create a file /tmp/nst.bib and paste in the example entry from the problem report 2 In that buffer, press C-c C-c 3. Observe the suggested title in the minibuffer. (Press C-g to discard it and quit.) What should have happened and what does happen as in the original report. ** Attachment added: Patch for Emacs 22.2 bibtex.el http://launchpadlibrarian.net/21594845/bibtex-el.patch -- bibtex autokey no longer ignores uncapitalized title words https://bugs.launchpad.net/bugs/243156 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 243156] Re: bibtex autokey no longer ignores uncapitalized title words
And it somehow uses ALL of the lower-case words rather than just the first letter. Im not a regexp genious, but I couldn't find a solution other than listing all prepositions and conjunctions -- bibtex autokey no longer ignores uncapitalized title words https://bugs.launchpad.net/bugs/243156 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
