[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
Bug 280265 is not really a duplicate, but since that touches the same panel it should probably be fixed at the same time. Will update title to reflect that. The Passwords with Certificates (TLS) config panel not only inverts the labels/fileselectors, it also inverts the password fields when it saves them. Reproduction: Create a VPN in Passwords with Certificates (TLS) mode : User name: foo Password: foo CA Certificate: ca.crt User Certificate: user.crt Certificate password: bar Private Key: user.key Click Validate, close the panel Reedit that connection, the panel now reads: User name: foo Password: bar CA Certificate: ca.crt User Certificate: user.crt Certificate password: foo Private Key: user.key (NB: if you validate it again without changing anything and reopen it, it's back to what you originally typed :) ** Summary changed: - nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode + nm-openvpn Passwords with Certificate (TLS) panel has wrong labels and inverts passwords -- nm-openvpn Passwords with Certificate (TLS) panel has wrong labels and inverts passwords https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openvpn in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
Bug 280265 is not really a duplicate, but since that touches the same panel it should probably be fixed at the same time. Will update title to reflect that. The Passwords with Certificates (TLS) config panel not only inverts the labels/fileselectors, it also inverts the password fields when it saves them. Reproduction: Create a VPN in Passwords with Certificates (TLS) mode : User name: foo Password: foo CA Certificate: ca.crt User Certificate: user.crt Certificate password: bar Private Key: user.key Click Validate, close the panel Reedit that connection, the panel now reads: User name: foo Password: bar CA Certificate: ca.crt User Certificate: user.crt Certificate password: foo Private Key: user.key (NB: if you validate it again without changing anything and reopen it, it's back to what you originally typed :) ** Summary changed: - nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode + nm-openvpn Passwords with Certificate (TLS) panel has wrong labels and inverts passwords -- nm-openvpn Passwords with Certificate (TLS) panel has wrong labels and inverts passwords https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
James: You will have to validate the Certificate (TLS) configuration, then when back to the list of VPNs you select and edit it, then switch to Password with certificate(TLS). Without any file selected, you can still easily see that the label and the file selector are mismatched in the Password with certificate(TLS) panel by looking at the title of the fileselector dialog window : the one on the right of the User Certificate label shows Please choose a CA Certificate and the one on the right of the CA Certificate label shows Please choose a user certificate. The patch switches the ID of the two fileselectors widgets in the glade file so that their position in the panel are inversed. The rest of the code accesses the fileselectors by their IDs so it doesn't need to be changed. I've tested that it results in an openvpn command line that reflects correctly what's on the configuration panel. -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
Hi Thierry, Thanks for working on this. I tried your recipe to reproduce and it didn't really work for me, all the certificates I had chosen disappeared as I changed the type, so I couldn't really see what the problem was. Do I need to use real certificates rather than empty files? Does your patch just change the glade file so that the labels refer to a different widget, and as the code shows and hides the widget the labels are also shown? Thanks, James -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openvpn in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
Hi Thierry, Thanks for working on this. I tried your recipe to reproduce and it didn't really work for me, all the certificates I had chosen disappeared as I changed the type, so I couldn't really see what the problem was. Do I need to use real certificates rather than empty files? Does your patch just change the glade file so that the labels refer to a different widget, and as the code shows and hides the widget the labels are also shown? Thanks, James -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
0.7~~svn20080928t225540-0ubuntu1 revamped that panel. The issue still exists, the patch needs adaptation. Reproduction: Create a new VPN. Select authentication type Certificate (TLS). Select : User Certificate: user.crt Certificate password: (empty) CA Certificate: ca.crt Private key: user.key Switch to authentication type Password with certificate(TLS). You now get: User name: (current user name) Password: (empty) CA Certificate: user.crt User Certificate: ca.crt Certificate password: (empty) Private Key: user.key Since a password box now appears just below User certificate, inverting labels is confusing (the password box applies the user certificate, not the CA one). The proposed patch is to inverse file selectors rather than labels, resulting in : User name: (current user name) Password: (empty) CA Certificate: ca.crt User Certificate: user.crt Certificate password: (empty) Private Key: user.key which is correct. -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openvpn in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
Proposed fix -- network-manager-openvpn (0.7~~svn20080928t225540-0ubuntu2) intrepid; urgency=low * debian/patches/07_fileselectors_order.diff: Fix ordering of certificate file selectors in the Passwords with certificates case (LP: #275608) -- Thierry Carrez [EMAIL PROTECTED] Mon, 06 Oct 2008 11:38:50 +0200 ** Attachment added: fileselectors_order.debdiff http://launchpadlibrarian.net/18251884/fileselectors_order.debdiff ** Changed in: network-manager-openvpn (Ubuntu) Status: Triaged = Confirmed -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openvpn in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
0.7~~svn20080928t225540-0ubuntu1 revamped that panel. The issue still exists, the patch needs adaptation. Reproduction: Create a new VPN. Select authentication type Certificate (TLS). Select : User Certificate: user.crt Certificate password: (empty) CA Certificate: ca.crt Private key: user.key Switch to authentication type Password with certificate(TLS). You now get: User name: (current user name) Password: (empty) CA Certificate: user.crt User Certificate: ca.crt Certificate password: (empty) Private Key: user.key Since a password box now appears just below User certificate, inverting labels is confusing (the password box applies the user certificate, not the CA one). The proposed patch is to inverse file selectors rather than labels, resulting in : User name: (current user name) Password: (empty) CA Certificate: ca.crt User Certificate: user.crt Certificate password: (empty) Private Key: user.key which is correct. -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
Proposed fix -- network-manager-openvpn (0.7~~svn20080928t225540-0ubuntu2) intrepid; urgency=low * debian/patches/07_fileselectors_order.diff: Fix ordering of certificate file selectors in the Passwords with certificates case (LP: #275608) -- Thierry Carrez [EMAIL PROTECTED] Mon, 06 Oct 2008 11:38:50 +0200 ** Attachment added: fileselectors_order.debdiff http://launchpadlibrarian.net/18251884/fileselectors_order.debdiff ** Changed in: network-manager-openvpn (Ubuntu) Status: Triaged = Confirmed -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
Slightly-modified patch from the one Christoph Höger posted at: http://mail.gnome.org/archives/networkmanager-list/2008-September/msg00287.html Patch will need some refresh before being able to apply to pending release. ** Attachment added: order.patch http://launchpadlibrarian.net/18134120/order.patch ** Changed in: network-manager-openvpn (Ubuntu) Importance: High = Medium Status: Confirmed = Triaged -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openvpn in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 275608] Re: nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode
Slightly-modified patch from the one Christoph Höger posted at: http://mail.gnome.org/archives/networkmanager-list/2008-September/msg00287.html Patch will need some refresh before being able to apply to pending release. ** Attachment added: order.patch http://launchpadlibrarian.net/18134120/order.patch ** Changed in: network-manager-openvpn (Ubuntu) Importance: High = Medium Status: Confirmed = Triaged -- nm-openvpn swaps ca-cert and user-cert labels when using Passwords with Certificate (TLS) mode https://bugs.launchpad.net/bugs/275608 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
